On Wed 06 Jan 2016 at 14:21:36 -0700, Zan Lynx wrote:
> On 01/06/2016 12:19 PM, Rhialto wrote:
> > So keeping every step of the way in the StringView realm is definitely
> > better. Whether the actual string storage is safe in the long term, I
> > didn't look at, but presumably it is or more things
On 01/06/2016 12:19 PM, Rhialto wrote:
> So keeping every step of the way in the StringView realm is definitely
> better. Whether the actual string storage is safe in the long term, I
> didn't look at, but presumably it is or more things would go wrong
> (probably).
Whereas I believe the opposite:
On Wed 06 Jan 2016 at 14:04:10 +0100, Detlef Graef wrote:
> Is this fix ok?
Disclaimer: I don't know the innards of Pan and I hardly ever use C++,
but it looks like an improvement to me.
Before, prefs_string is a StringView, which would be converted to a
temporary std::string (when returning from
