[Openvpn-devel] [S] Change in openvpn[master]: io_work: convert shift argument to uintptr_t

2024-10-14 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/759?usp=email ) Change subject: io_work: convert shift argument to uintptr_t ..

[Openvpn-devel] [PATCH v4] io_work: pass event_arg object to event handler in case of socket event

2024-10-14 Thread Frank Lichtenheld
From: Antonio Quartulli In order to allow the code to work with multiple listening sockets it is essential to allow the generic multi_io event handler to distinguish between the various socket objects. This can be achieved by passing an event_arg object that contains a pointer to the link_socket

[Openvpn-devel] [PATCH v4] io_work: convert shift argument to uintptr_t

2024-10-14 Thread Frank Lichtenheld
From: Antonio Quartulli Instead of passing the shift argument as pointer, pass directly its integer value. This will allow the code to distinguish a shift value from a real object pointer, like we already do in multi_tcp_process_io(). This change will allow us later to pass an event_arg object a

[Openvpn-devel] [PATCH v4] event/multi: add event_arg object to make event handling more generic

2024-10-14 Thread Frank Lichtenheld
From: Antonio Quartulli In order to prepare the event handling code to deal with multiple listening sockets, we have to make sure that it is possible to distinguish which of these sockets have been poked by an incoming connection request. To achieve that, this patch changes the object being pass

[Openvpn-devel] [M] Change in openvpn[master]: pass link_socket object to i/o functions

2024-10-14 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/758?usp=email ) Change subject: pass link_socket object to i/o functions .. P

[Openvpn-devel] [PATCH v4] pass link_socket object to i/o functions

2024-10-14 Thread Frank Lichtenheld
From: Antonio Quartulli In order to prepare the code to work with distinct sockets, it is essential that i/o functions do not operate on any hard-coded socket object (i.e. c->c2.link_socket). This patch changes all the low-level i/o functionis to work with a socket specified as argument rather t

[Openvpn-devel] [PATCH v4] event/multi: add event_arg object to make event handling more generic

2024-10-14 Thread Frank Lichtenheld
From: Antonio Quartulli In order to prepare the event handling code to deal with multiple listening sockets, we have to make sure that it is possible to distinguish which of these sockets have been poked by an incoming connection request. To achieve that, this patch changes the object being pass