[Openvpn-devel] [L] Change in openvpn[master]: allow tcp/udp server to listen on multiple ports at the same time

2024-10-11 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/434?usp=email ) Change subject: allow tcp/udp server to listen on multiple ports at the same time .

[Openvpn-devel] [M] Change in openvpn[master]: event/multi: add event_arg object to make event handling more generic

2024-10-11 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/757?usp=email ) Change subject: event/multi: add event_arg object to make event handling more generic

[Openvpn-devel] [M] Change in openvpn[master]: event/multi: add event_arg object to make event handling more generic

2024-10-11 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/757?usp=email ) Change subject: event/multi: add event_arg object to make event handling more generic

[Openvpn-devel] [S] Change in openvpn[master]: io_work: pass event_arg object to event handler in case of socket event

2024-10-11 Thread its_Giaan (Code Review)
Attention is currently required from: its_Giaan, plaisthos. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/760?usp=email to look at the new patch set (#4). The change is no longer submittable: checks~ChecksSubmit

[Openvpn-devel] [M] Change in openvpn[master]: event/multi: add event_arg object to make event handling more generic

2024-10-11 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/757?usp=email to look at the new patch set (#4). The following approvals got outdated and w

[Openvpn-devel] [S] Change in openvpn[master]: io_work: convert shift argument to uintptr_t

2024-10-11 Thread its_Giaan (Code Review)
Attention is currently required from: its_Giaan, plaisthos. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/759?usp=email to look at the new patch set (#4). The change is no longer submittable: checks~ChecksSubmit

[Openvpn-devel] [M] Change in openvpn[master]: pass link_socket object to i/o functions

2024-10-11 Thread its_Giaan (Code Review)
Attention is currently required from: its_Giaan, plaisthos. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/758?usp=email to look at the new patch set (#4). The change is no longer submittable: checks~ChecksSubmit

[Openvpn-devel] [S] Change in openvpn[master]: io_work: pass event_arg object to event handler in case of socket event

2024-10-11 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/760?usp=email ) Change subject: io_work: pass event_arg object to event handler in case of socket event ...

[Openvpn-devel] [PATCH v3] io_work: convert shift argument to uintptr_t

2024-10-11 Thread Frank Lichtenheld
From: Antonio Quartulli Instead of passing the shift argument as pointer, pass directly its integer value. This will allow the code to distinguish a shift value from a real object pointer, like we already do in multi_tcp_process_io(). This change will allow us later to pass an event_arg object a

[Openvpn-devel] [M] Change in openvpn[master]: pass link_socket object to i/o functions

2024-10-11 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/758?usp=email ) Change subject: pass link_socket object to i/o functions ...