Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/754?usp=email
to review the following change.
Change subject: Ensure that the AF_UNIX socket pair has at least 65k of buffer
space
Attention is currently required from: cron2, flichtenheld, plaisthos.
mrbff has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/677?usp=email )
Change subject: route: copied 'gateway_needed' logic from add_route_ipv6 to
add_route
.
Attention is currently required from: flichtenheld, mrbff, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/677?usp=email
to look at the new patch set (#10).
Change subject: route: copied 'gateway_needed' logi
Attention is currently required from: flichtenheld, mrbff, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/677?usp=email )
Change subject: route: copied 'gateway_needed' logic from add_route_ipv6 to
add_route
.
Attention is currently required from: cron2, flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/753?usp=email )
Change subject: Refactor methods to use the actual state of tun rather the
options struct
Attention is currently required from: its_Giaan, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/524?usp=email )
Change subject: Route: add support for user defined routing table
..
Thanks for the review. Indent fixed, that was a that sneaked in.
Patch has been applied to the master branch.
commit b322690394b75a9d4987d4b27107ccb01bbcd90e
Author: Gert Doering
Date: Wed Sep 18 18:29:17 2024 +0200
make t_server_null 'server alive?' check more robust
Acked-by: Fr
On Wed, Sep 18, 2024 at 06:29:17PM +0200, Gert Doering wrote:
> - use "$RUN_SUDO kill -0 $pid" to test if a given process is running, not
> "ps -p $pid" - the latter will not work if security.bsd.see_other_uids=0
> is set
>
> - produce proper error messages if pid files can not be found or are
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/748?usp=email )
Change subject: Change dev null to be a driver type instead of a special mode
of tun/tap
.
