[Openvpn-devel] [M] Change in openvpn[master]: Static-challenge concatenation option

2024-07-10 Thread cron2 (Code Review)
Attention is currently required from: plaisthos, selvanair. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/665?usp=email ) Change subject: Static-challenge concatenation option .. Patch Set 3

[Openvpn-devel] [M] Change in openvpn[master]: Static-challenge concatenation option

2024-07-10 Thread selvanair (Code Review)
Attention is currently required from: plaisthos. selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/665?usp=email ) Change subject: Static-challenge concatenation option .. Patch Set 3: (1 c

Re: [Openvpn-devel] [PATCH v2] configure: Switch to C11 by default

2024-07-10 Thread Gert Doering
Hi, On Wed, Jul 10, 2024 at 06:03:06PM +0200, Frank Lichtenheld wrote: > Mostly so we can use anonymous structs without jumping through > hoops or relying on unofficial support. > > Change-Id: I72934e747d1ad68a7e3675afbeb1b63df7941186 > Signed-off-by: Frank Lichtenheld > Acked-by: Arne Schwabe

[Openvpn-devel] [XS] Change in openvpn[master]: Avoid SIGUSR1 to SIGHUP when the configuration is read from stdin

2024-07-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/533?usp=email ) Change subject: Avoid SIGUSR1 to SIGHUP when the configuration is read from stdin ...

[Openvpn-devel] [PATCH v2] configure: Switch to C11 by default

2024-07-10 Thread Frank Lichtenheld
Mostly so we can use anonymous structs without jumping through hoops or relying on unofficial support. Change-Id: I72934e747d1ad68a7e3675afbeb1b63df7941186 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one developer. I re

[Openvpn-devel] [S] Change in openvpn[master]: Remove check for anonymous unions from configure and cmake config

2024-07-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/588?usp=email ) Change subject: Remove check for anonymous unions from configure and cmake config ...

[Openvpn-devel] [PATCH v3] Remove check for anonymous unions from configure and cmake config

2024-07-10 Thread Frank Lichtenheld
From: Arne Schwabe Anonymous unions/structs are technically a custom GNU C99 feature but was already widely supported by other compilers. With C11 this feature has become a standard feature so all compilers nowadays support it. Change-Id: I1ef5f6f21f0135a628a63553c39515fa4549ce87 Signed-off-by:

[Openvpn-devel] [M] Change in openvpn[master]: Ensures all params are ready before invoking dco_set_peer()

2024-07-10 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/587?usp=email ) Change subject: Ensures all params are ready before invoking dco_set_peer() ...

[Openvpn-devel] [M] Change in openvpn[master]: Ensures all params are ready before invoking dco_set_peer()

2024-07-10 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/587?usp=email to look at the new patch set (#2). The following approvals got outdated and were rem

Re: [Openvpn-devel] [PATCH v4] Allow trailing \r and \n in control channel message

2024-07-10 Thread Frank Lichtenheld
On Wed, Jul 10, 2024 at 04:06:23PM +0200, Frank Lichtenheld wrote: > From: Arne Schwabe > > Writing a reason from a script will easily end up adding extra \r\n characters > at the end of the reason. Our current code pushes this to the peer. So be more > liberal in accepting these message. > > Cl

[Openvpn-devel] [PATCH v4] Allow trailing \r and \n in control channel message

2024-07-10 Thread Frank Lichtenheld
From: Arne Schwabe Writing a reason from a script will easily end up adding extra \r\n characters at the end of the reason. Our current code pushes this to the peer. So be more liberal in accepting these message. Closes openvpn/openvpn#568 Change-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e Si

[Openvpn-devel] [M] Change in openvpn[master]: Allow trailing \r and \n in control channel message

2024-07-10 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/672?usp=email ) Change subject: Allow trailing \r and \n in control channel message ...

[Openvpn-devel] [S] Change in openvpn[master]: configure: Review use of standard AC macros

2024-07-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/674?usp=email to review the following change. Change subject: configure: Review use of standard AC macros

[Openvpn-devel] [S] Change in openvpn[master]: configure: Allow to detect git checkout if .git is not a directory

2024-07-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/675?usp=email to review the following change. Change subject: configure: Allow to detect git checkout if .git is not a directory

[Openvpn-devel] [M] Change in openvpn[master]: Allow trailing \r and \n in control channel message

2024-07-10 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/672?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Co

[Openvpn-devel] IRC community meeting summary

2024-07-10 Thread Johan Draaisma
Meeting summary for 10 July 2024: * *Updated: forums topics* /novaflash got access just last week, will look into the forums situation and set up a new PoC server./ * *Updated: OpenVPN community meetup 2024* /Determined that venue will be atSteamWork?

[Openvpn-devel] [M] Change in openvpn[master]: Static-challenge concatenation option

2024-07-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, selvanair. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/665?usp=email ) Change subject: Static-challenge concatenation option .. Patc