[Openvpn-devel] [S] Change in openvpn[master]: tun.c: don't attempt to delete DNS and WINS servers if they're not set

2023-12-14 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/482?usp=email to review the following change. Change subject: tun.c: don't attempt to delete DNS and WINS serv

[Openvpn-devel] [PATCH v6] Implement the --tls-export-cert feature

2023-12-14 Thread Frank Lichtenheld
From: Arne Schwabe This is a re-implementation of the --tls-export-cert feature. This was necessary to due to missing approval to re-license the old (now removed) code. The re-implementation is based on the following description of the feature provided by David: Add an option to export certifi

[Openvpn-devel] [PATCH v2] tests: disable automake serial_tests

2023-12-14 Thread Frank Lichtenheld
Serial mode is the old one and offers much less options for running the tests. Generally our tests seem to work fine with the newer parallel mode. The only reason we stuck with serial_tests seems to be that we didn't like that it doesn't output the test output by default. We could fix that with a c

[Openvpn-devel] [M] Change in openvpn[master]: tests: fork default automake test-driver

2023-12-14 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/478?usp=email to look at the new patch set (#3). Change subject: tests: fork default automake test-driver ..

[Openvpn-devel] [M] Change in openvpn[master]: tests: fork default automake test-driver

2023-12-14 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/478?usp=email ) Change subject: tests: fork default automake test-driver .. Patch Set 2: