Re: [opensource-dev] Review Request: VWR-20801 Implement SOCKS 5 Proxy for the viewer

2011-03-29 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/232/#review519 --- Excellent! Except for a handful of minor typos, I've no problem wi

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-29 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/242/#review521 --- Ship it! Looks good. - Merov On March 28, 2011, 6:22 p.m., Sto

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-29 Thread Merov Linden
> On March 29, 2011, 6:02 p.m., Merov Linden wrote: > > Looks good. BTW, what's the JIRA for this patch? - Merov --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/

Re: [opensource-dev] Review Request: STORM-954 corrected patch

2011-03-31 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/194/#review526 --- +1 on this patch modulo the code convention fix I mention here und

Re: [opensource-dev] Review Request: STORM-954 corrected patch

2011-03-31 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/194/#review528 --- Ship it! Thanks Twisted for taking my comment into account in ht

Re: [opensource-dev] Review Request: STORM-1122 Linux viewer sucks up file descriptors, stops loading content and crashes

2011-04-03 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/245/#review538 --- I'm thinking the fix should go deeper and, possibly, get rid of g

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-03 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review539 --- Boroondas comments should be addressed, especially the one here un

[opensource-dev] Review Request: STORM-610 : Changes to Environment Editor: water color change is not saved

2011-04-06 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/254/ --- Review request for Viewer. Summary --- This is a rework of Vadim's ori

[opensource-dev] Review Request: KDU Improvements: Compress j2c with precincts

2011-04-07 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/256/ --- Review request for Viewer. Summary --- This patch adds code to j2c to:

Re: [opensource-dev] Review Request: partial fix for STORM-948: [crashhunters] meta-issue for bad_alloc exceptions

2011-04-21 Thread Merov Linden
> On March 25, 2011, 6:20 p.m., Merov Linden wrote: > > indra/newview/llappviewer.cpp, lines 1417-1420 > > <http://codereview.secondlife.com/r/218/diff/1/?file=1306#file1306line1417> > > > > Aren't we in danger of immediate crash when called? If so, what

Re: [opensource-dev] Review Request: STORM-1093 "Dock" icon is still shown after a side panel has been docked with Ctrl+Shift+W

2011-04-28 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/276/#review662 --- Ship it! Looks correct. Definitely needs a PO build to confirm it

Re: [opensource-dev] Review Request: OPEN-61 Adding locations that VC redistributable package installs files.

2011-04-28 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/259/#review663 --- Ship it! Looks good. I'll run that through a test TC build before

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

2011-04-28 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/#review664 --- Ship it! Looks to me all previous comments have been taken into a

Re: [opensource-dev] Review Request: Improvements in configuration time by eliminating redundant unpacking when reconfiguring

2011-05-10 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/293/#review692 --- Ship it! Looks good. - Merov On May 3, 2011, 6:34 p.m., Brad K

<    1   2