[opensource-dev] Review Request: VWR-20962 CTRL-\ Last chatter

2010-12-13 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/16/ --- Review request for Viewer. Summary --- You have to push CTRL-\(there is

[opensource-dev] Review Request: Settings.xml: redundant entries and unnecessary tag

2010-12-14 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/18/ --- Review request for Viewer. Summary --- I wrote two programs that use se

Re: [opensource-dev] Review Request: Settings.xml: redundant entries and unnecessary tag

2010-12-16 Thread Jonathan Yap
hat it should be an unsigned integer, depending on what units are being used (i.e. a limit of 3.25 makes sense if you are using kb/sec). - Jonathan On 2010-12-14 12:39:34, Jonathan Yap wrote: > > --- > This is an automatica

Re: [opensource-dev] Review Request: VWR-20962 CTRL-\ Last chatter

2010-12-22 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/16/ --- (Updated 2010-12-22 11:18:28.916125) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: VWR-20962 CTRL-\ Last chatter

2010-12-22 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/16/ --- (Updated 2010-12-22 11:18:45.942539) Review request for Viewer. Summary --

Re: [opensource-dev] Review Request: STORM-785 CTRL-\ Last chatter

2010-12-22 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/16/ --- (Updated 2010-12-22 11:21:04.403780) Review request for Viewer. Summary (u

Re: [opensource-dev] Review Request: VWR-24100 Settings.xml: redundant entries and unnecessary tag

2010-12-23 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/18/ --- (Updated 2010-12-23 12:12:39.928040) Review request for Viewer. Summary (u

[opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

2010-12-23 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/65/ --- Review request for Viewer. Summary --- This change enables the "+" menu

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

2010-12-24 Thread Jonathan Yap
iew.secondlife.com/r/65/#review85 --- On 2010-12-23 13:25:31, Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

2010-12-24 Thread Jonathan Yap
23 13:25:31, Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/65/ > --- > > (Updated 201

[opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express

2010-12-29 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/68/ --- Review request for Viewer. Summary --- Environment: Windows, VS 2005 Ex

Re: [opensource-dev] Review Request: VWR-24100 Settings.xml: redundant entries and unnecessary tag

2011-01-04 Thread Jonathan Yap
ated e-mail. To reply, visit: http://codereview.secondlife.com/r/18/#review32 ------- On Dec. 23, 2010, 12:12 p.m., Jonathan Yap wrote: > > --- > This is an automaticall

[opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-05 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/71/ --- Review request for Viewer. Summary --- The "/me" in the lsl code below

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-06 Thread Jonathan Yap
il. To reply, visit: http://codereview.secondlife.com/r/71/#review114 ------- On Jan. 5, 2011, 6:14 p.m., Jonathan Yap wrote: > > --- > This is an automatica

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-06 Thread Jonathan Yap
g just /me work. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/71/#review120 --- On Jan. 5, 2011, 6:14 p.m., Jon

Re: [opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express

2011-01-06 Thread Jonathan Yap
e.com/r/68/#review111 --- On Dec. 29, 2010, 3:42 p.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

[opensource-dev] Review Request: STORM-830 Volume slider isn't properly remembered if set to zero

2011-01-06 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/72/ --- Review request for Viewer. Summary --- There is an edge case in setMast

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-06 Thread Jonathan Yap
/kick etc" without at that point > > checking > > for one specific case (missing possibly many other variations). > > > > Jonathan Yap wrote: > If it was me writing the original code I would not have made it > case-sensitive, but as this is a bug fix and not a new featu

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-07 Thread Jonathan Yap
Messages from objects would be treated as if /me had been sent. I don't think this is what is desired. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/71/#review132

Re: [opensource-dev] Review Request: STORM-830 Volume slider isn't properly remembered if set to zero

2011-01-10 Thread Jonathan Yap
automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/72/#review128 --- On Jan. 6, 2011, 2:37 p.m., Jonathan Yap wrote: > > --- > This is an automatical

[opensource-dev] Review Request: Storm-844 "More" should be "Less" when Media Control is open

2011-01-12 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/78/ --- Review request for Viewer. Summary --- "More" should be "Less" when Med

Re: [opensource-dev] Review Request: Storm-844 "More" should be "Less" when Media Control is open

2011-01-13 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/78/#review148 --- On Jan. 12, 2011, 6:02 a.m., Jonathan Yap wrote: > > ---

Re: [opensource-dev] Review Request: Storm-844 "More" should be "Less" when Media Control is open

2011-01-16 Thread Jonathan Yap
s that something down in the control code is wrong. > > Jonathan Yap wrote: > I did a test with the floater preview UI (one of the few places that > label is not the same as label_selected. There is a >> button there that > does change to << when pressed. > >

Re: [opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express

2011-01-17 Thread Jonathan Yap
r/68/#review175 --- On Dec. 29, 2010, 3:42 p.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://cod

Re: [opensource-dev] Review Request: Provide define LL_MSVC10 to customize Visual Studio 10 code submissions.

2011-01-25 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/121/#review249 --- 1) You should fill in the Bugs field with a Jira number. 2) Since

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/#review265 --- autobuild/common.py

Re: [opensource-dev] Review Request: VWR-24667; Copy3rdPartyLibs.cmake needs to account for Visual Studio 10 and Visual Studio 10 Express.

2011-01-30 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/131/#review282 --- indra/cmake/Copy3rdPartyLibs.cmake

[opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

2011-02-05 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ --- Review request for Viewer. Summary --- This is a request for help. I

Re: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

2011-02-05 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ --- (Updated Feb. 5, 2011, 3:08 p.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

2011-02-06 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ --- (Updated Feb. 6, 2011, 12:54 a.m.) Review request for Viewer. Changes ---

[opensource-dev] Review Request: STORM-974 UI button alignment issues in Landmark panel, About Land window, and Hardware Settings window

2011-02-07 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/142/ --- Review request for Viewer. Summary --- Please see the jira for the ref

Re: [opensource-dev] Review Request: STORM-974 UI button alignment issues in Landmark panel, About Land window, and Hardware Settings window

2011-02-08 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/142/ --- (Updated Feb. 8, 2011, 5:22 a.m.) Review request for Viewer. Changes

[opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used

2011-02-08 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/ --- Review request for Viewer. Summary --- llmediaplugintest shows up to b

Re: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

2011-02-15 Thread Jonathan Yap
is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/#review362 --- On Feb. 6, 2011, 12:54 a.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

2011-02-15 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ --- (Updated Feb. 15, 2011, 10:04 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used

2011-02-16 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/ --- (Updated Feb. 16, 2011, 11:32 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used

2011-02-16 Thread Jonathan Yap
ce. - Jonathan ------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/#review347 --- On Feb. 16, 2011, 11:32 a.m., Jonathan Yap wrote: &

Re: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used

2011-02-16 Thread Jonathan Yap
round a bit. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/#review368 --- On Feb. 16, 2011, 11:32

Re: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

2011-02-18 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ --- (Updated Feb. 18, 2011, 7:11 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

2011-02-18 Thread Jonathan Yap
the diffs. They are corrupted and I don't know how to fix them. - Jonathan On Feb. 18, 2011, 7:11 a.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.sec

[opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

2011-03-10 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/ --- Review request for Viewer. Summary --- Add optional range ring to the

Re: [opensource-dev] Review Request: STORM-971 'Stop Tracking' menu item is still enabled in Mini-map floater after you stopped tracking in Nearby mini-map

2011-03-10 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/133/#review442 --- indra/newview/llnetmap.cpp

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

2011-03-12 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/ --- (Updated March 12, 2011, 7:51 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

2011-03-12 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/ --- (Updated March 12, 2011, 7:52 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

2011-03-12 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/ --- (Updated March 12, 2011, 8 a.m.) Review request for Viewer. Changes -

Re: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

2011-03-12 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ --- (Updated March 12, 2011, 4:33 p.m.) Review request for Viewer. Summary --

Re: [opensource-dev] Review Request: STORM-1025 Chat preferences > font size should increase size of input text as well

2011-03-12 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ --- (Updated March 12, 2011, 4:42 p.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

2011-03-17 Thread Jonathan Yap
changed the mystery constant 20.0 to CHAT_NORMAL_RADIUS. Struggling with the diff hence that part is not updated. - Jonathan On March 12, 2011, 8 a.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail.

[opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

2011-03-23 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/229/ --- Review request for Viewer. Summary --- 1) Change Voice Enabled to Spea

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

2011-03-24 Thread Jonathan Yap
-- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/229/#review496 ------- On March 23, 2011, 6:06 p.m., Jonathan Yap wrote: > > --

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

2011-03-24 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/229/ --- (Updated March 24, 2011, 9:10 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

2011-03-24 Thread Jonathan Yap
off the speak button hint. That line was there when I incorrectly though the speak button might be on at viewer startup. I could not get the diff to update so am commenting in here. - Jonathan On March 24, 2011, 9:10 a.m., Jonathan Yap wrote

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

2011-03-24 Thread Jonathan Yap
> On March 24, 2011, 11:04 a.m., Jonathan Yap wrote: > > I deleted the line in the mouse-up speak button code that turns off the > > speak button hint. That line was there when I incorrectly though the speak > > button might be on at viewer startup. I could not get the d

[opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-03-30 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/ --- Review request for Viewer. Summary --- Chat preferences > font size s

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-03-30 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/ --- (Updated March 30, 2011, 5:43 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-04 Thread Jonathan Yap
, I guess the idea is that you > > put new members below it, not above. > > > > Also, should this be initialized to null here ... This was fixed as well. - Jonathan --- This is an automatically generated e-mail

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-04 Thread Jonathan Yap
e and that change was in the last PO test build. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review539 --- On Ma

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/ --- (Updated April 13, 2011, 6:40 a.m.) Review request for Viewer. Summary --

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Jonathan Yap
nt when the MM sent this back. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review589 --- On April 13, 2011, 6:40 a.m.

[opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-13 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/ --- Review request for Viewer. Summary --- The results of using the World

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/ --- (Updated April 13, 2011, 12:32 p.m.) Review request for Viewer. Changes -

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Jonathan Yap
; > > CS: extra spaces near parenthesis Done. - Jonathan ------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review591 ---

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Jonathan Yap
om/r/244/#review596 ------- On April 13, 2011, 12:32 p.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondli

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Jonathan Yap
> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llbottomtray.cpp, lines 560-561 > > <http://codereview.secondlife.com/r/244/diff/3/?file=1450#file1450line560> > > > > Any reason not to move this to LLNearbyChatBar::post

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-15 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/ --- (Updated April 15, 2011, 11:33 a.m.) Review request for Viewer. Changes -

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-15 Thread Jonathan Yap
inside the "for" clause to limit its > > scope. Changed. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/#review598 --------

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-15 Thread Jonathan Yap
//codereview.secondlife.com/r/262/#review595 --- On April 15, 2011, 11:33 a.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To r

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-15 Thread Jonathan Yap
on? > > It's not like we have to keep any internal state or something. > > Jonathan Yap wrote: > Moved to inside of routine. > > Boroondas Gupte wrote: > That's a good idea, too, but not what I meant. I was wondering why you > are using a class (or s

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-16 Thread Jonathan Yap
on? > > It's not like we have to keep any internal state or something. > > Jonathan Yap wrote: > Moved to inside of routine. > > Boroondas Gupte wrote: > That's a good idea, too, but not what I meant. I was wondering why you > are using a class (or s

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-16 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/ --- (Updated April 16, 2011, 6:24 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-16 Thread Jonathan Yap
Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/#review629 --- On April 16, 2011, 6:24 a.m., Jonath

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-16 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/ --- (Updated April 16, 2011, 1:52 p.m.) Review request for Viewer. Changes --

[opensource-dev] Review Request: STORM-956 Ability to mute dialogs by muting object (or object owner)

2011-04-20 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/275/ --- Review request for Viewer. Summary --- >From the jira Description: Gri

Re: [opensource-dev] Review Request: STORM-859 : winres.h isn't present within VC++ Express includes. Must be manually copied from win7 sdk example code.

2011-05-16 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/304/#review698 --- indra/newview/skins/default/xui/en/notifications.xml

[opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

2011-06-02 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/317/ --- Review request for Viewer. Summary --- As a Content Creator, I have to

[opensource-dev] Review Request: VWR-25896 [Regression] Bulk uploads do not adhere to default permissions

2011-06-05 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/323/ --- Review request for Viewer. Summary --- Something in the big mesh branc

Re: [opensource-dev] Review Request: VWR-25896 [Regression] Bulk uploads do not adhere to default permissions

2011-06-05 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/323/ --- (Updated June 5, 2011, 8:11 a.m.) Review request for Viewer. Summary

Re: [opensource-dev] Review Request: VWR-25896 [Regression] Bulk uploads do not adhere to default permissions

2011-06-05 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/323/#review720 ------- On June 5, 2011, 8:11 a.m., Jonathan Yap wrote: > >

[opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

2011-06-07 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/326/ --- Review request for Viewer. Summary --- 1. Launch viewer, change langua

[opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-09 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/ --- Review request for Viewer. Summary --- This is a patch by ArminWeather

[opensource-dev] Review Request: STORM-787 Mute Gestures Button

2011-06-12 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/336/ --- Review request for Viewer. Summary --- Added a checkbox control in Pre

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

2011-06-15 Thread Jonathan Yap
/codereview.secondlife.com/r/326/#review751 ------- On June 7, 2011, 2:32 p.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To re

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

2011-06-15 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/326/ --- (Updated June 15, 2011, 10:04 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

2011-06-15 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/326/ --- (Updated June 15, 2011, 12:50 p.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-1320 Create a 3p-libndofdev-linux repo based on version 0.3 of Jan Ciger's linux libndofdev.

2011-06-16 Thread Jonathan Yap
> On June 16, 2011, 4:59 p.m., Boroondas Gupte wrote: > > libndofdev/CMakeLists.txt, lines 27-30 > > > > > > Might be worth mentioning the non-linux libndofdev (and where to find > > it) in the error message. On windo

[opensource-dev] Review Request: STORM-1392 Add Nearby Voice to the Communicate menu

2011-06-18 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/346/ --- Review request for Viewer. Summary --- Add Nearby Voice to the Communi

Re: [opensource-dev] Review Request: STORM-1392 Add Nearby Voice to the Communicate menu

2011-06-18 Thread Jonathan Yap
generated e-mail. To reply, visit: http://codereview.secondlife.com/r/346/#review771 ------- On June 18, 2011, 4:12 a.m., Jonathan Yap wrote: > > --- > This is an automa

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-24 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/ --- (Updated June 24, 2011, 4:45 a.m.) Review request for Viewer. Summary ---

[opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

2011-06-29 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/ --- Review request for Viewer. Summary --- Add a feature on the "Wearing T

Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

2011-06-29 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/ --- (Updated June 29, 2011, 12:14 p.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

2011-06-30 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/ --- (Updated June 30, 2011, 1:27 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: Change pre-login viewer display URL to prepare for new community information display

2011-07-18 Thread Jonathan Yap
> On July 16, 2011, 6:48 a.m., Thickbrick Sleaford wrote: > > indra/newview/app_settings/settings.xml, line 4875 > > > > > > Setting the default value to something other than an empty string would > > override the se

Re: [opensource-dev] Review Request: (STORM-1221) [HARD CODED] ALL LANGS Several strings are untranslated under Group Profile Land/Assets (French viewer)

2011-07-19 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/400/#review889 --- indra/newview/lldateutil.cpp

Re: [opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

2011-08-03 Thread Jonathan Yap
variable. If you can think of a better way please let me know. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/317/#review895 ---

Re: [opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

2011-08-03 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/317/ --- (Updated Aug. 3, 2011, 11:21 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

2011-08-14 Thread Jonathan Yap
> > short comment explaining the semantics of this variable. > > Jonathan Yap wrote: > Comment added. Robin Cornelius suggested using a global variable. If > you can think of a better way please let me know. > > Boroondas Gupte wrote: > A static class m

Re: [opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

2011-08-14 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/317/ --- (Updated Aug. 14, 2011, 9:07 a.m.) Review request for Viewer. Changes ---

[opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

2011-08-22 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/ --- Review request for Viewer. Summary --- Add a block button to popups fr

Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

2011-08-23 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/ --- (Updated Aug. 23, 2011, 4:07 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

2011-08-23 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/ --- (Updated Aug. 23, 2011, 1:41 p.m.) Review request for Viewer. Summary ---

  1   2   >