[opensource-dev] Review Request: quote all COPY_IF_DIFFERENT argument variables (fixes OPEN-36: error "COPY_IF_DIFFERENT Macro invoked with incorrect arguments" due to insufficient quoting)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/182/ --- Review request for Viewer. Summary --- Searched all uses of the copy_i

Re: [opensource-dev] Review Request: quote all COPY_IF_DIFFERENT argument variables (fixes OPEN-36: error "COPY_IF_DIFFERENT Macro invoked with incorrect arguments" due to insufficient quoting)

ttp://codereview.secondlife.com/r/182/#comment310> For me, this change here is sufficient for getting the expected result when performing the repro in OPEN-36. Throwing in the other changes for consistency. - Boroondas On March 7, 2011, 4:44 p.m., Boroondas Gupte

[opensource-dev] STORM-1038 & VWR-24337 (was: PO Test build (222938))

On 03/08/2011 06:14 AM, Philippe (Merov) Bossut wrote: > * STORM-1038 : Viewer crash in texture cache pruning on startup Might be a duplicate of VWR-24337 , the fix of which has a "Ship it!" for over one month n

Re: [opensource-dev] Review Request: quote all COPY_IF_DIFFERENT argument variables (fixes OPEN-36: error "COPY_IF_DIFFERENT Macro invoked with incorrect arguments" due to insufficient quoting)

ation. See my comment at https://jira.secondlife.com/browse/OPEN-36?focusedCommentId=247669&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-247669 - Boroondas On March 7, 2011, 4:44 p.m., Boroondas Gu

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/#review444 --- Good idea. Off course, the two main rules of optimization are: 1.

[opensource-dev] iterators, finding extrema with for-loops (was: Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.)

On 03/11/2011 05:43 PM, Ricky wrote: > As to the variables that are initialized with high numbers, there has > to be a better way: if these were standard for-loops, I would just > initialize the first value with the first item in the list, and then > start the loop at the second value, if any. How

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

> On March 12, 2011, 7:16 a.m., Oz Linden wrote: > > indra/llcharacter/llbvhloader.cpp, line 1199 > > > > > > I think it would be clearer to either add a new constant > > POSITION_MOTION_THRESHOLD_SQUARED or to write

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/#review453 --- Thanks for the changes. Some more comments from me: indra/newvie

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

> On March 13, 2011, 5:34 a.m., Boroondas Gupte wrote: > > indra/newview/llselectmgr.cpp, lines 6596-6599 > > <http://codereview.secondlife.com/r/199/diff/1-2/?file=1189#file1189line6596> > > > > Notwithstanding the comment above this code, I don'

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

> On March 13, 2011, 5:34 a.m., Boroondas Gupte wrote: > > indra/llmath/tests/llbbox_test.cpp, line 37 > > <http://codereview.secondlife.com/r/199/diff/2/?file=1243#file1243line37> > > > > While we're changing this anyway, braces around the assigned

Re: [opensource-dev] Review Request: a try fix and debug code for STORM-973:[crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/202/#review464 --- Just making sure I understood this: Are the changes indra/newvie

Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/#review465 --- Apart from the bugfix (calling hideExpandText before evaluating (

Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/#review470 --- You're welcome, and thank you, too. :-) indra/newview/llexpandab

Re: [opensource-dev] Review Request: OPEN-45: Correctly include the pass-through options when displaying the configure and build commands

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/213/#review471 --- Ship it! This change looks correct and well done. (Didn't test it

Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/#review484 --- Ship it! No further objections. Great work! - Boroondas On Mar

Re: [opensource-dev] Review Request: more fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/222/#review491 --- While we can view the diff on bitbucket, please upload it here, to

Re: [opensource-dev] Review Request: STORM-323: redundant popups

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/230/#review495 --- Ship it! Looks good. Not your fault, but I can't resist to menti

Re: [opensource-dev] Doxygen Updated / Fixed on dimentox.com

On 03/26/2011 12:26 PM, WolfPup Lowenhar wrote: > > I just tried going to the site and it is only partially there. I only > get the different selections at the top and when I try to go to any > page besides the main I get a 404 error. > Indeed, Namespaces

Re: [opensource-dev] [JIRA] Projects and Components, my.secondlife.com

On 03/26/2011 03:28 PM, Opensource Obscure wrote: > Many issues about Profiles, Picks, Privacy Notes and related > features are currently filed in JIRA under the VWR Project. > This prevents them to add "my.secondlife.com" as Component; > the whole situation seems a bit confused to me. If such issu

Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/231/#review506 --- Ah, a good issue to tackle! Thanks for looking into it. indra/ne

Re: [opensource-dev] Doxygen questions

On 03/27/2011 05:16 AM, Brandon Husbands wrote: > Alright Caller and call graph are making this take days. I threw 8 > cpus at it with 4 gigs of ram. and it still is taking over 2 days. > Are caller graphs and call graphs needed? Needed? No. (Without the graphs, direct callers and callies will stil

Re: [opensource-dev] Linux build without the pausing behaviour

On 03/28/2011 04:41 PM, Mike Chase wrote: > Is there a Linux build of V2 of any version that doesnt exhibit the > annoying multi-second pauses that freeze the UI? I find myself without > any useable V2 viewer at present. I've tried 2.5.2 and 2.6.3 and both > still have this issue. I guess you'

Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played

> On March 26, 2011, 8:55 a.m., Boroondas Gupte wrote: > > indra/newview/llgesturemgr.cpp, lines 763-764 > > <http://codereview.secondlife.com/r/231/diff/1/?file=1327#file1327line763> > > > > s/is/if/ > > Seth ProductEngine wrote: > Chang

Re: [opensource-dev] jira labels

Hi OO, I hope you don't mind me taking this to the list, as it might be of general interest. On 03/29/2011 09:42 AM, Opensource Obscure wrote: > Hello Boroondas, > I see you removed 3 labels from > https://jira.secondlife.com/browse/VWR-15259 while > adding "needs-design". > > Not a problem, but

Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/231/#review518 --- Ship it! Should be fine then, as far as I can tell. - Boroondas

Re: [opensource-dev] Mac/Linux testers needed for Open-52 (Superfluous source files)

On 03/30/2011 08:43 PM, Jonathan Welch wrote: > [...] I would like you to try deleting > the .cpp (and associated .h) files listed in Open-52 > and report back in a > comment if any files in that list are needed. > > You will have to update cmakelists.tx

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review523 --- indra/llui/lllineeditor.h

[opensource-dev] Review Request: STORM-1121: make llimage_libtest build on Linux

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/247/ --- Review request for Viewer. Summary --- Posting Merov's fix to demonstr

Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/231/#review531 --- I'm a bit worried about the loop-nesting. E.g. indra/newview/llg

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/#review544 --- indra/newview/llselectmgr.cpp

[opensource-dev] Review trouble (was: Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.)

On 04/05/2011 01:49 AM, Ricky wrote: > ok, this is getting annoying. Any idea why I am having issues posting > to the review? Mayhaps you added comments to code-lines but didn't save them? Also, comments with overlapping code-line ranges (e.g. one comment about lines 1-7 and one about lines 3-9 of

Re: [opensource-dev] UI produces just grey boxes

On 04/05/2011 07:46 AM, Glimmering Sands wrote: > Please see the attached screen shots to > understand what I mean. These look like your build is failing to load the images included in the viewer's Artwork from disk. I guess images received from the network or retrieved from the cache work (There's

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

On 04/05/2011 02:20 AM, Ricky wrote: > Consider the following replacement for the section under consideration: > --- > } > // factor the distance into the displacement vector. This will get us > // equally visible movements for both close and far away selections. > F32 min_dist = sqrt(fsqrtf(min_di

Re: [opensource-dev] Review Request: STORM-1121: make llimage_libtest build on Linux

condlife.com/r/247/#review560 --- On March 31, 2011, 1:07 a.m., Boroondas Gupte wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://coder

Re: [opensource-dev] Review Request: Change to description for ShowNetStatus in debbug settings.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/251/#review565 --- indra/newview/app_settings/settings.xml

Re: [opensource-dev] UI produces just grey boxes

On 04/06/2011 04:57 AM, Glimmering Sands wrote: > Thank you, I will try from a freshly made account. The hint that it > is possibly the artwork bundle will hopefully help much. Note that since the move to mercurial, the artwork is included in the source tree (most of it in indra/newview/skins/*/te

Re: [opensource-dev] Review Request: OPEN-57: Allow override of the autobuild platform for configuration testing

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/253/#review568 --- Ship it! Looks good - Boroondas On April 6, 2011, 3:32 a.m., O

[opensource-dev] How to handle JsonCpp's headers on STANDALONE?

Hi all As you might have noticed, the prebuilt package for JsonCpp has changed its path for headers to be included by applications from *include/jsoncpp/* to *include/json/* some time ago. (Probably to better match the upstream directory name

[opensource-dev] Review Request: OPEN-54: Making CMake variable name for JsonCpp include dir(s) consistent

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/257/ --- Review request for Viewer. Summary --- Chose the singular form as that

Re: [opensource-dev] Review Request: fix for ECC-49 / storm-1147: Other avatar's loose clothing\ flared cuffs look like they are tight\got no flare in v.2.4.0 and higher

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/260/#review579 --- Don't forget to credit the Residents providing the fix in doc/cont

Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/252/#review567 --- I guess there is no real reason why there's a space before some se

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/255/#review580 --- indra/llimage/llimagedimensionsinfo.h

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

> On April 8, 2011, 4:51 p.m., Boroondas Gupte wrote: > > indra/llimage/llimagedimensionsinfo.cpp, line 147 > > <http://codereview.secondlife.com/r/255/diff/2/?file=1426#file1426line147> > > > > ... until here. (Assuming it's the same 8.) Might be w

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review589 --- Ship it! Looks good. Some minor stuff still: indra/newview/llv

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/#review595 --- indra/newview/llfloaterworldmap.cpp

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/265/#review602 --- Ship it! Already giving a 'Ship it', as all my comments below add

Re: [opensource-dev] Widespread, Reproducible Profile Total Data Loss - Tolerated for multiple releases, why?

On 04/15/2011 03:11 PM, Arrehn Oberlander wrote: > [...] editing profile data using the web profile interface can result > in whatever section of data that you edited being completely erased, > wiped out, 8-24hrs later. [...] > Apparently this is a widely known problem. When I started asking > arou

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/265/#review621 --- Ship it! indra/newview/skins/default/xui/en/panel_people.xml

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

> On April 13, 2011, 2:31 p.m., Boroondas Gupte wrote: > > indra/newview/llfloaterworldmap.cpp, lines 99-101 > > <http://codereview.secondlife.com/r/262/diff/1/?file=1462#file1462line99> > > > > Why do you make this a functor rather than a plain normal functi

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

> On April 13, 2011, 2:31 p.m., Boroondas Gupte wrote: > > indra/newview/llfloaterworldmap.cpp, lines 99-101 > > <http://codereview.secondlife.com/r/262/diff/1/?file=1462#file1462line99> > > > > Why do you make this a functor rather than a plain normal functi

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/#review626 --- I tried to compile with your change on Linux (g++ 4.4.5) indra/n

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

> On April 13, 2011, 2:31 p.m., Boroondas Gupte wrote: > > indra/newview/llfloaterworldmap.cpp, lines 99-101 > > <http://codereview.secondlife.com/r/262/diff/1/?file=1462#file1462line99> > > > > Why do you make this a functor rather than a plain normal functi

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/#review629 --- indra/newview/llfloaterworldmap.cpp

Re: [opensource-dev] autobuild with VS2005

Linux-based dev here, so be aware my answer is based on hear-say, not own experience. On 04/18/2011 02:05 PM, Marine Kelley wrote: > - Tried to run autobuild as "autobuild build -c Release", only to get > an error saying that it does not find VS2010 (of course, it is not > installed). I also had t

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/#review632 --- Ship it! One last (literally) tiny thing: indra/newview/llfloat

Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played

> On April 1, 2011, 4:22 a.m., Boroondas Gupte wrote: > > indra/newview/llgesturemgr.h, lines 168-170 > > <http://codereview.secondlife.com/r/231/diff/3/?file=1373#file1373line168> > > > > Shouldn't this be a (non-static) method of LLMulitGesture taking

[opensource-dev] Higher contrast for build result pages. (was: New Build Result Pages)

* Higher contrast and some minor layout fixes for Second Life Viewer build result pages (K) 2011 Boroondas Gupte All rites reversed -- re-use what you like Roughly based on and meant for use in combination with http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/cg_vi

Re: [opensource-dev] Higher contrast for build result pages.

On 04/23/2011 01:43 AM, CG Linden wrote: > Try this on for size: > http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/viewer-pre-release/rev/227447/index.html > > On Fri, Apr 22, 2011 at 11:14 AM, CG Linden > wrote: > > Thanks, I'll incorporate it. > Lo

Re: [opensource-dev] Higher contrast for build result pages.

On 04/24/2011 03:52 AM, Chuck Baggett wrote: > Is the link > http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/viewer-pre-release/rev/227447/index.html > is supposed to go to a page that shows good contrast? It's supposed to show at least /better/ contrast than http://automated-builds

[opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/277/ --- Review request for Viewer. Summary --- Just looked at Vadim's fix for

Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

tp://codereview.secondlife.com/r/277/#review647 --- On April 25, 2011, 5:09 a.m., Boroondas Gupte wrote: > > --- > This is an automatically generated e-mail. T

Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/277/ --- (Updated April 25, 2011, 4:40 p.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: CHOP-629 symbol information for llcommon.dll is missing both in the debugger and in crash reports

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/281/#review653 --- indra/llcommon/CMakeLists.txt

Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/278/#review654 --- indra/llvfs/llvfs.cpp

Re: [opensource-dev] Review Request: VWR-25610 LLControlGroup::loadFromFile makes unnecessary copies of large LLSD objects

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/280/#review655 --- Ship it! The nice thing about this change is that is has to be co

Re: [opensource-dev] Review Request: CHOP-629 symbol information for llcommon.dll is missing both in the debugger and in crash reports

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/281/#review657 --- Ship it! >The /DEBUG linker flag doesn't really apply for sta

Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

> On April 27, 2011, 3:30 a.m., Boroondas Gupte wrote: > > indra/llvfs/llvfs.cpp, lines 1716-1717 > > <http://codereview.secondlife.com/r/278/diff/1/?file=1511#file1511line1716> > > > > When index_size == 0, wouldn't it be more appropriate to skip

Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/278/#review661 --- Ship it! Ready to rock! - Boroondas On April 26, 2011, 5:31 p.

[opensource-dev] Review Request: VWR-25654: fix memory leak in LLTranslate::getTranslateUrl

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/282/ --- Review request for Viewer. Summary --- curl_escape() returns a pointer

Re: [opensource-dev] Review Request: CHOP-624 header dependency improvements for build time speedup

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/297/#review676 --- This change is identical to the one under review at https://coder

Re: [opensource-dev] Review Request: CHOP-624 header dependency improvements for build time speedup

> On May 4, 2011, 11:58 a.m., Boroondas Gupte wrote: > > This change is identical to the one under review at > > https://codereview.secondlife.com/r/289 > > > > Did you upload the wrong diff file to one of the review requests? > > Brad Kittenbrink wrote: >

Re: [opensource-dev] What's the autobuild equivalent to "develop.py clean"?

On 05/05/2011 05:37 PM, Ardy Lay wrote: > On 5/5/2011 10:23 AM, Tonya Souther wrote: >> I can't seem to find a way to clean the tree and start a build from >> scratch. I'm chasing a link error where it's complaining about symbols >> that exist elsewhere, and want to make sure that a clean build has

[opensource-dev] Configurations for non-LL developers (was: Meet lots of link errors when linking secondlife-bin)

On 05/06/2011 06:07 AM, xinyi chen wrote: > I tried many times to compile -Release / Debug / RelWithDebInfo and > attach /GS+ or /GS- You'll probably want ReleaseOS, DebugOS or RelWithDebInfoOS instead of the configurations mentioned above. See https://wiki.secondlife.com/wiki/Build_Viewer_With_Aut

Re: [opensource-dev] Review Request: CHOP-624 header dependency improvements for build time speedup

> On May 6, 2011, 3:19 a.m., Boroondas Gupte wrote: > > No further objections, thus giving my "Ship it". Though, as I know near > > nothing about the precompiled header technique and just trust you on the > > assertion that these changes are ok if everything sti

Re: [opensource-dev] Review Request: CHOP-624 header dependency improvements for build time speedup

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/289/#review682 --- Ship it! No further objections, thus giving my "Ship it". Though,

Re: [opensource-dev] Review Request: CHOP-624 header dependency improvements for build time speedup

> On May 6, 2011, 3:19 a.m., Boroondas Gupte wrote: > > indra/newview/llviewerwindow.cpp, line 248 > > <http://codereview.secondlife.com/r/289/diff/2/?file=1687#file1687line248> > > > > Just to make sure, as 'static' is that silly C++ keyword

Re: [opensource-dev] Review Request: Cleaning up testing cmake macros to prepare for refactoring them to improve build time.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/301/#review688 --- Review Board can't apply your patch. Please upload a diff file tha

Re: [opensource-dev] Review Request: CHOP-658 moving panels and floaters into a new static library project viewer_components/viewerui

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/302/#review689 --- Review Board can only partially apply your patch. Please upload a

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/#review694 --- doc/contributions.txt

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/#review696 --- Ship it! indra/llui/llnotifications.cpp

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/#review697 --- Ship it! Yay, 4 RB revisions for a one-liner :-P - Boroondas O

Re: [opensource-dev] Review Request: STORM-859 : winres.h isn't present within VC++ Express includes. Must be manually copied from win7 sdk example code.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/304/#review699 --- Ship it! Am I reading this comment right, that ... indra/newvie

[opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/307/ --- Review request for Viewer. Summary --- Some trickery needed to make th

Re: [opensource-dev] Review Request: Update autobuilds default VC version to 2010

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/305/#review701 --- autobuild/autobuild_tool_source_environment.py

Re: [opensource-dev] Review Request: Update autobuilds default VC version to 2010

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/305/#review703 --- Ship it! This change looks good. It should be investigated wheth

Re: [opensource-dev] Review Request: VWR-25654: fix memory leak in LLTranslate::getTranslateUrl

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/282/ --- (Updated May 17, 2011, 9:18 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: Convert autobuild library builds to use msbuild.exe instead of devenv.com.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/312/#review704 --- autobuild/autobuild_tool_source_environment.py

Re: [opensource-dev] Review Request: Convert autobuild library builds to use msbuild.exe instead of devenv.com.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/312/#review705 --- autobuild/autobuild_tool_source_environment.py

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/307/ --- (Updated May 18, 2011, 1:13 p.m.) Review request for Viewer. Changes

Re: [opensource-dev] 2.6.6 source?

On 05/20/2011 05:38 PM, Lance Corrimal wrote: > Has anyone seen the 2.6.6 sources? bitbucket hasn't got them... Both, viewer-development and viewer-beta have a 2.6.6-beta1 tag. I don't know whether that's also the code of the release. v

Re: [opensource-dev] tcmalloc

On 05/20/2011 10:20 PM, Kiptic ‌ wrote: > However, I was wondering more about any other useful -D options that > might be lurking in there. Is there a list somewhere? After configuring, try cmake -L build-*/ or, if you also want the help strings cmake -LH build-*/ by default, so-called

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

1, 1:13 p.m., Boroondas Gupte wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/307/ > --- > >

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/307/ --- (Updated May 24, 2011, 3:41 p.m.) Review request for Viewer. Changes

Re: [opensource-dev] 3D soound

On 05/24/2011 07:42 PM, Lee ponzu wrote: > I saw this cool demo of 3D sound. This is totally different from the > SL Voice technology, and I think it would compliment it perfectly. > > Take a look... > > http://www.google.com/search?sourceid=chrome&ie=UTF-8&q=princeton+3D+sound >

[opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/313/ --- Review request for Viewer. Summary --- Context: We are currently using

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

> On May 24, 2011, 3:32 p.m., Boroondas Gupte wrote: > > indra/llvfs/lldiriterator.cpp, lines 140-144 > > <http://codereview.secondlife.com/r/307/diff/2/?file=2546#file2546line140> > > > > Meh, my backwards-compatibility approach does not work: The existanc

Re: [opensource-dev] Dumbly stuck on storm-899

On 05/26/2011 03:22 PM, Jonathan Welch wrote: > I tried to fix Storm-899 this morning and feel that it is pretty close > to being fixed, but I have gotten hung up on a dumb error. If anyone > would care to point out how to fix it I would appreciate a chance to > improve my c++ skills (and yes, I h

[opensource-dev] in-viewer translation: API vs. freestanding page, Google Translate Element (was: in-viewer translation is dead soon.)

On 05/28/2011 03:32 PM, Daniel wrote: > Note that Google is not closing off all translation services. They > are moving to using the Translate Element within web pages ( > http://translate.google.com/translate_tools ). I assume the reason is > a freestanding translator page does not bring in any

[opensource-dev] in-viewer translation: alternative services, usage statistics (was: in-viewer translation is dead soon.)

On 05/28/2011 02:00 AM, Philippe (Merov) Bossut wrote: > It shouldn't be too hard to substitute with another service. Someone > has an alternative service to propose? As Daniel has pointed out , we have to be careful to not

[opensource-dev] new subtasks added to STORM-312 (was: 3D connexion devices on linux)

On 06/04/2011 10:37 AM, Francesco "Sythos" wrote: > We cannot ask to the world to patch the kernel for SL, not all have > enough skills, and all other device and programs work fine. Imho the > right way to work is fix the SL side, without introduce risk and > collateral effect putting hands on kern

<    1   2   3   4   5   >