[opensource-dev] [META][WEB] Registering a SL Review Board account: Jira email address vs. mailing list address (was: Re: Review Request: Restructure loops that use breaks without need (reviewboard te

2010-12-02 Thread Boroondas Gupte
Thu, 02 Dec 2010 11:40:12 -0000 > From: Boroondas Gupte <*[The address I use for jira* (different from > the one I use for the mailing list and not intended for public > visibility)*]*> > To: Boroondas Gupte <*[...]*>, Oz Linden , Viewer > > > &g

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

2010-12-02 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/2/#review10 --- indra/newview/llappviewer.cpp

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

2010-12-02 Thread Boroondas Gupte
> On 2010-12-02 04:52:10, Boroondas Gupte wrote: > > EDITED TO ADD: (apparently Review Board can't handle comments on comments on lines (sic!) and new comments on lines at the same time) "The Review-Board diff view conveniently highlights them in red, so they are hard to

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

2010-12-02 Thread Boroondas Gupte
> On 2010-12-02 04:52:10, Boroondas Gupte wrote: > > > > Boroondas Gupte wrote: > EDITED TO ADD: (apparently Review Board can't handle comments on comments > on lines (sic!) and new comments on lines at the same time) > "The Review-Board diff view c

Re: [opensource-dev] ReviewBoard email to this list?

2010-12-02 Thread Boroondas Gupte
On 12/02/2010 02:52 PM, Oz Linden (Scott Lawrence) wrote: > Note that these emails are easy to set up filters for - not only will > all of them have 'Review Request' in the Subject lines, there are also > a couple of custom headers in each message that make them easy to > recognize. On 12/02/2010 0

Re: [opensource-dev] nametag opacity

2010-12-03 Thread Boroondas Gupte
On 12/03/2010 05:36 AM, Chuck Baggett wrote: > Are the nametags fixed at 100 per cent opaque or are they of variable > opacity? > > By nametags I mean avatar names and group titles. The opacity is variable, but the control for the setting isn't obvious, as it's labeled "bubble chat opacity", altho

Re: [opensource-dev] nametag opacity

2010-12-03 Thread Boroondas Gupte
On 12/03/2010 12:28 PM, Boroondas Gupte wrote: > Since the recent preferences overhaul (see STORM-31 > <https://jira.secondlife.com/browse/STORM-31> and in particular > STORM-573 <https://jira.secondlife.com/browse/STORM-573>) err, STORM-583 <https://jira.secondlife.co

Re: [opensource-dev] Review Request: STORM-524 : Refresh L$ balance

2010-12-09 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/6/#review19 --- Ship it! Didn't test, but code looks good. indra/newview/llstatusb

Re: [opensource-dev] Linux 64bit and gstreamer

2010-12-11 Thread Boroondas Gupte
Hi Mike, On 12/10/2010 06:51 PM, Mike Chase wrote: > Can someone point me to a summary of 64bit support for Linux > for that series of viewers? I know in the past I was able to run a > 32bit version but with no streaming media. See the forum thread Linux 64 bits and medias

Re: [opensource-dev] Review Request: Settings.xml: redundant entries and unnecessary tag

2010-12-16 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/18/#review29 --- Ship it! looks good - Boroondas On 2010-12-14 12:39:34, Jonathan

Re: [opensource-dev] Review Request: Crash in LLRemoteParcelInfoProcessor::processParcelInfoReply()

2010-12-16 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/24/#review30 --- indra/newview/llremoteparcelrequest.cpp

Re: [opensource-dev] Review Request: scripts/install.py --uninstall does not always remove symbolic links.

2010-12-16 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/29/#review33 --- Ship it! Your explanation is consistent with python's documentation

Re: [opensource-dev] VWR-24172 (tab key not working)

2010-12-18 Thread Boroondas Gupte
On 12/18/2010 04:55 PM, Trilo Byte wrote: > [...] tab key stopped working to jump between fields (in the build window, > debugged settings window, etc). [...] anybody else experiencing this? Yes, me. Boroondas ___ Policies and (un)subscribe information

Re: [opensource-dev] Review Request: VWR-24247: develop.py configure still searches for the wrong header file when checking for Tut

2010-12-19 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/39/#review49 --- indra/cmake/FindTut.cmake

Re: [opensource-dev] Review Request: VWR-24247: develop.py configure still searches for the wrong header file when checking for Tut

2010-12-19 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/39/#review51 --- Ship it! Ah, I wasn't aware gcc ignores INCLUDE. In that case, the

Re: [opensource-dev] Review Request: VWR-24254: Add support for using ld.gold on linux.

2010-12-19 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/48/#review52 --- indra/cmake/LLCommon.cmake

Re: [opensource-dev] Review Request: VWR-10579: Fix NDOF.cmake to do the right thing on standalone.

2010-12-19 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/45/#review53 --- I'd prefer the following behavior: Let the user specify whether to u

Re: [opensource-dev] Review Request: SNOW-240: Fix libjson naming madness, for standalone.

2010-12-19 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/47/#review54 --- Ship it! Looks good. Like this, it should continue working even if

Re: [opensource-dev] Review Request: SNOW-240: Fix libjson naming madness, for standalone.

2010-12-19 Thread Boroondas Gupte
> On 2010-12-19 12:48:35, Boroondas Gupte wrote: > > Looks good. > > > > Like this, it should continue working even if a system-wide installed > > libjson uses the compiler-version-specific filename, like the gentoo ebuild > > from Techwolf's portage ove

[opensource-dev] Indicating privacy implications of preference settings (was: STORM-34 Test Binaries)

2010-12-28 Thread Boroondas Gupte
On 12/28/2010 09:40 PM, Celierra Darling wrote: > It seems a little unclear to try to communicate "this can have privacy > implications" by putting the setting on the privacy tab. It might be > better to write the setting label so it's more explicit (i.e. > something like "Show my favorites to any

Re: [opensource-dev] Review Request: Reenable the LLMatrix3::orthogonalize test in llmath/tests/m3math_test.cpp

2010-12-28 Thread Boroondas Gupte
> On 2010-12-28 10:10:54, Aleric Inglewood wrote: > > I think this line should be deleted, not commented out. If there still is a > > reason to think that it might need to be uncommented later than apparently > > we aren't sure the test really works, in which case I think it should be > > skip

Re: [opensource-dev] Review Request: Constraints in XUI files don't match the constraints imposed elsewhere in the viewer/server code.

2010-12-29 Thread Boroondas Gupte
> On 2010-12-24 11:06:43, Vadim ProductEngine wrote: > > How do you know the server constraints? Signpost already answered a similar question on jira: https://jira.secondlife.com/browse/VWR-24197?focusedCommentId=228070&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comme

Re: [opensource-dev] Tab button no longer works

2010-12-30 Thread Boroondas Gupte
On 12/30/2010 04:54 AM, tinselsilv...@frontiernet.net wrote: > My tab button has not worked in the last two Dev versions 217861 & 217920. > Did I miss a post or Jira regarding this issue? STORM-823 > The lack of a tab button makes building and telepo

[opensource-dev] FMOD or not (was: Debian Squeeze compiling)

2010-12-30 Thread Boroondas Gupte
On 12/29/2010 04:21 PM, Duncan Bradders wrote: > Hello, I'm trying to compile the latest viewer development on my > distro, the envoronment it's the same for other viewers and usually I > can compile TPV V1 viewers. > > dbradd...@casa:~/Src/viewer-development/indra$ ./develop.py > --type=Release co

Re: [opensource-dev] Very Strange occurrence...

2011-01-04 Thread Boroondas Gupte
On 01/04/2011 07:07 AM, Anya Kanevsky wrote: > Ponzu, I'm understandably very interested in finding out which xml > files ... Thanks! > Getting IMs from people telling me to lay off other people I don't > know and have never talked to is getting kind of old. > [...] > > 2010/12/31 Ponzu mailto:lee

Re: [opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

2011-01-06 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/70/#review115 --- "View Diff" doesn't display anything and with "Download Diff", I ge

Re: [opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

2011-01-06 Thread Boroondas Gupte
> On Jan. 6, 2011, 4:01 a.m., Boroondas Gupte wrote: > > "View Diff" doesn't display anything and with "Download Diff", I get a > > patch file that doesn't change anything: It removes some lines and adds > > back the exact same lines, with th

Re: [opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

2011-01-07 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/70/#review131 --- Still CRLFs in indra/newview/skins/default/xui/en/floater_web_conte

Re: [opensource-dev] Review Request: Storm-844 "More" should be "Less" when Media Control is open

2011-01-12 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/78/#review143 --- doc/contributions.txt

Re: [opensource-dev] Clarification on contributions.txt

2011-01-13 Thread Boroondas Gupte
[Sent from wrong address, so once again for the list. Sorry Oz for the duplicate message.] On 01/13/2011 06:05 PM, Oz Linden (Scott Lawrence) wrote: > On 2011-01-13 11:37, Jonathan Welch wrote: >> Hi Oz, >> >> I updated two wiki entries dealing with adding to contributions.txt >> and would appreci

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-14 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/#review152 --- scripts/install.py

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-14 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/#review153 --- indra/llcharacter/llanimationstates.cpp

Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory

2011-01-14 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/#review154 --- Ship it! Looks good. Files should only be removed when they actual

Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: remove: Attempting to remove filename: /ramdisk/imprudence/cache/textures/*/*.texture

2011-01-14 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/84/#review155 --- indra/newview/lltexturecache.cpp

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-14 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/90/#review161 --- Ship it! Correct. - Boroondas On Jan. 14, 2011, 1:02 p.m., Aler

Re: [opensource-dev] Review Request: VWR-24366: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON

2011-01-14 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/95/#review162 --- Ship it! Looks sane and your explanation makes sense. - Boroondas

Re: [opensource-dev] Link times

2011-01-14 Thread Boroondas Gupte
On 01/14/2011 06:04 PM, Jonathan Welch wrote: > I just did a quick study on link times for various viewers on my 2Gb XP system > > Viewer 1st link 2nd link > CV 1.220:53 0:24 > SG 1.5 3:30 2:07 > V2.5 6:18 6:01 The long time for 2.5 be due to VWR-24366

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-15 Thread Boroondas Gupte
> On Jan. 14, 2011, 1:16 p.m., Boroondas Gupte wrote: > > scripts/install.py, line 598 > > <http://codereview.secondlife.com/r/80/diff/1/?file=388#file388line598> > > > > Does to_install need filtering at all? (Can it contain > > non-installables?)

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-15 Thread Boroondas Gupte
> On Jan. 14, 2011, 1:16 p.m., Boroondas Gupte wrote: > > scripts/install.py, lines 592-594 > > <http://codereview.secondlife.com/r/80/diff/1/?file=388#file388line592> > > > > This can be written more pythonesque as > > > > (t

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-16 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/#review167 --- Ship it! scripts/install.py

Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory

2011-01-16 Thread Boroondas Gupte
> On Jan. 14, 2011, 1:47 p.m., Boroondas Gupte wrote: > > indra/newview/llappviewer.cpp, lines 3091-3094 > > <http://codereview.secondlife.com/r/83/diff/1/?file=402#file402line3091> > > > > what's the reason for moving the LL_INFOS around? > > Al

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-17 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/#review173 --- Ship it! - Boroondas On Jan. 17, 2011, 5:24 a.m., Aleric Inglewo

[opensource-dev] Review Request: VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2

2011-01-17 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/97/ --- Review request for Viewer. Summary --- Only use QUIET in pkg_check_modu

[opensource-dev] Review Request: make PREHASH variables char const* const

2011-01-18 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/ --- Review request for Viewer. Summary --- For the reason for this change,

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-19 Thread Boroondas Gupte
> On Jan. 18, 2011, 12:09 p.m., Merov Linden wrote: > > indra/newview/lltexturecache.cpp, line 1595 > > > > > > validate_idx being used in a test later, it's not just for > > (validate_idx == 0) that the behavior will b

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-19 Thread Boroondas Gupte
> On Jan. 19, 2011, 2:44 p.m., Boroondas Gupte wrote: > > > validate_idx being used in a test later, it's not just for (validate_idx > > > == 0) > > > that the behavior will be different. I need to understand better what > > > that idx >

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-19 Thread Boroondas Gupte
> On Jan. 19, 2011, 2:44 p.m., Boroondas Gupte wrote: > > indra/newview/lltexturecache.cpp, line 1595 > > <http://codereview.secondlife.com/r/90/diff/1/?file=413#file413line1595> > > > > Old code: > > validate_idx will now be in [1,256]. (one higher

[opensource-dev] Motto & Goals (was: STORM-243 - simulator version notifications)

2011-01-20 Thread Boroondas Gupte
On 01/19/2011 09:20 AM, Stickman wrote: > Is there a mission statement, a motto, a creed, or a list of goals > somewhere? "Fast, Easy and Fun", wasn't it? Or has that motto, too, already been antiquated? A list of long term goals (besides what is dictated by server side changes anyway) would intere

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-01-20 Thread Boroondas Gupte
ty' embarrashments :p > > Because I don't know how to quote code in a comment, I'll answer in a 'review'. See below. - Boroondas --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review196

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-01-20 Thread Boroondas Gupte
l-pointer-exception would have shown up. - Boroondas On Jan. 18, 2011, 7:29 a.m., Boroondas Gupte wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-01-20 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/ --- (Updated Jan. 20, 2011, 2:57 p.m.) Review request for Viewer and Seth Produ

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/#review229 --- indra/newview/llbottomtray.h

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/#review230 --- Looks like RB ate some of my comments in the review above. (Maybe

Re: [opensource-dev] Review Request: VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2

2011-01-21 Thread Boroondas Gupte
o reply, visit: http://codereview.secondlife.com/r/97/#review227 --- On Jan. 17, 2011, 10:03 a.m., Boroondas Gupte wrote: > > --- > This is an automatically generated e-

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Boroondas Gupte
> On Jan. 21, 2011, 3:44 a.m., Boroondas Gupte wrote: > > indra/newview/llspeakbutton.cpp, lines 67-70 > > <http://codereview.secondlife.com/r/113/diff/1/?file=619#file619line67> > > > > Please don't remove the single empty line between the end of on

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-01-22 Thread Boroondas Gupte
- Boroondas On Jan. 20, 2011, 2:57 p.m., Boroondas Gupte wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/100/ > -

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-01-22 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/ --- (Updated Jan. 22, 2011, 7:40 a.m.) Review request for Viewer and Seth Produ

Re: [opensource-dev] Review Request: VWR-24612 lscript_compile warnings treated as errors -- workaround

2011-01-25 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/122/#review251 --- I'm not a Windows person, but ... indra/llcommon/llpreprocessor.

Re: [opensource-dev] Review Request: VWR-24612 lscript_compile warnings treated as errors -- workaround

2011-01-25 Thread Boroondas Gupte
> On Jan. 25, 2011, 11:30 a.m., Boroondas Gupte wrote: > > indra/llcommon/llpreprocessor.h, lines 164-167 > > <http://codereview.secondlife.com/r/122/diff/1/?file=635#file635line164> > > > > Isn't the 'pop' sufficient for restoring the pre

Re: [opensource-dev] Review Request: Use consistent path for all *.py scripts

2011-01-29 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/129/#review276 --- Ship it! Covers all occurrences of the variant with env, so shoul

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-29 Thread Boroondas Gupte
> On Jan. 28, 2011, 2:46 p.m., Alain Linden wrote: > > autobuild/common.py, line 415 > > > > > > ...and test for None here. Good idea. This would avoid bugs that could occur e.g. when the string is changed and not spel

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-29 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/#review280 --- autobuild/common.py

[opensource-dev] Python 2.5 implementations that come without ElementTree? (was: attempting to compile a viewer)

2011-01-30 Thread Boroondas Gupte
Hi Andro On 01/30/2011 10:35 AM, Andromeda Quonset wrote: > CMake Error at cmake/Prebuilt.cmake:39 (message): > Failed to download or unpack prebuilt 'ogg-vorbis'. Process returned 1. > > [...] > > I have gane back through the archives for this list, and I've found a > few other instances of th

Re: [opensource-dev] "Nearby" people tab

2011-02-01 Thread Boroondas Gupte
Hi Dave On 02/01/2011 01:57 AM, Dave Booth wrote: > On 1/31/2011 07:52, Oz Linden (Scott Lawrence) wrote: >> It would be interesting to see what was in the log file for the period >> of time that the window was not properly filled in. > I intend to capture some more specific data in the next few

Re: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

2011-02-04 Thread Boroondas Gupte
> On Feb. 2, 2011, 6:30 p.m., Merov Linden wrote: > > indra/llmessage/llpumpio.cpp, line 359 > > > > > > An example where the use of operator() is particularly unsightly... > > Aleric Inglewood wrote: > And rightfull

Re: [opensource-dev] streaming media on 64bit?

2011-02-05 Thread Boroondas Gupte
Hi Marc On 02/05/2011 05:03 AM, Marc Adored wrote: > I am on 64bit ubuntu and noticed that media on a prim works now even > though I am using a 32bit viewer. I am assuming this is because it is > a SLPlugin and not part of the viewer? That's not the reason: The SLPlugin binary, while a separate pr

[opensource-dev] Copying GStreamer from a 32bit system to a 64bit one (was: streaming media on 64bit?)

2011-02-05 Thread Boroondas Gupte
On 02/05/2011 04:15 PM, Marc Adored wrote: > (:5205): GStreamer-WARNING **: Failed to load plugin > '/usr/lib32/gstreamer-0.10/libgstspc.so': libopenspc.so.0: cannot open > shared object file: No such file or directory > > [...] > > I have copied the gstreamer-0.10 from my wifes 32bit ubuntu to > /

Re: [opensource-dev] Friends Permissions

2011-02-06 Thread Boroondas Gupte
On 02/06/2011 02:55 PM, Trilo Byte wrote: > [...] permissions the people on my friends list have (see me online, locate > me on the map, move my objects, etc), but I can't figure out how to change > those settings. It used to be on the Notes & Privacy tab of the Profile, but > the web profile d

Re: [opensource-dev] Review Request: VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2

2011-02-07 Thread Boroondas Gupte
> On Jan. 20, 2011, 11:33 p.m., Merov Linden wrote: > > I'm advising the MM to merge in a test repo and do a full TC cycle on all > > platforms before merging though... > > Boroondas Gupte wrote: > As far as I can see indra/cmake/FindLLQtWebkit.cmake only

[opensource-dev] autobuild on Linux 64-bit standalone: setup & configuring issues (was: Using 'autobuild' to build the viewer)

2011-02-07 Thread Boroondas Gupte
Ok, I've finally taken some time to test autobuild, too. On 01/28/2011 12:41 AM, Oz Linden (Scott Lawrence) wrote: > > To begin experimenting with this new way of doing things, you'll need > to check out autobuild itself (it's written in python, and is open > source) from: > > https://bitbucke

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-02-07 Thread Boroondas Gupte
-- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review321 --- On Jan. 22, 2011, 7:40 a.m., Boroondas Gupte wrote: > > ---

Re: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used

2011-02-08 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/144/#review347 --- > If there is some better way to more exactly target these two ite

Re: [opensource-dev] Test build

2011-02-09 Thread Boroondas Gupte
Downloaded the Linux build. On 02/08/2011 09:15 PM, Philippe (Merov) Bossut wrote: > - STORM-955 : Massively duplicated objects Tested that with the long command line Aleric gave on RB. Much less multiple occurrences than in build 219680. Remaining multiple ones are: 2 COLLAPSED_BY_USER

Re: [opensource-dev] Review Request: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON

2011-02-10 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/147/#review350 --- A good change to avoid heisenbugs. indra/cmake/GoogleMock.cmake

[opensource-dev] Review Request: OPEN-29: Error out if lldir_.h is included when building for a different platform.

2011-02-11 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/148/ --- Review request for Viewer. Summary --- Rather than relying on (probabl

Re: [opensource-dev] Review Request: OPEN-29: Error out if lldir_.h is included when building for a different platform.

2011-02-11 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/148/ --- (Updated Feb. 11, 2011, 6:07 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: open-2 (improved progress messages during dependency checks) and open-31 (more standardized short form option switches)

2011-02-13 Thread Boroondas Gupte
On 02/12/2011 10:13 PM, Oz Linden wrote: > (there is a failure displaying the diff for autobuild.configfile.py because > it is a one word change of the logging level for a log message added by one > of my other changes that has not yet been applied to the trunk) You should be able use the 'Parent

Re: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used

2011-02-16 Thread Boroondas Gupte
> On Feb. 8, 2011, 10:41 a.m., Boroondas Gupte wrote: > > > If there is some better way to more exactly target these two items please > > > point it out. > > > > You should be able to get the same effect when wrapping the only place > > where this fil

Re: [opensource-dev] Review Request: STORM-977 llmediaplugintest shows up even though -DLL_TESTS:BOOL=OFF has been used

2011-02-16 Thread Boroondas Gupte
> On Feb. 8, 2011, 10:41 a.m., Boroondas Gupte wrote: > > > If there is some better way to more exactly target these two items please > > > point it out. > > > > You should be able to get the same effect when wrapping the only place > > where this fil

Re: [opensource-dev] Review Request: When a bake texture upload fails, retry instead of giving up.

2011-02-17 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/152/#review375 --- indra/newview/lltexlayer.h

Re: [opensource-dev] Hacking up to Visual Studio 2010 ...

2011-02-18 Thread Boroondas Gupte
On 02/18/2011 01:56 AM, Oz Linden (Scott Lawrence) wrote: > [...] > Then check out: > > https://bitbucket.org/oz_linden/viewer-autobuild2010 > > cd into the top level of that directory, and run: > > autobuild configure -c OpenSourceRelWithDebInfo > > autobuild configure -c OpenSourceRel

[opensource-dev] Linux build error: missing binary operator before token "(" (was: Hacking up to Visual Studio 2010 ...)

2011-02-18 Thread Boroondas Gupte
On 02/18/2011 01:56 AM, Oz Linden (Scott Lawrence) wrote: > [...] > > Then check out: > > https://bitbucket.org/oz_linden/viewer-autobuild2010 > > cd into the top level of that directory, and run: > > autobuild configure -c OpenSourceRelWithDebInfo > > autobuild configure -c OpenSourceR

Re: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

2011-02-18 Thread Boroondas Gupte
> On Feb. 18, 2011, 7:16 a.m., Jonathan Yap wrote: > > My internet connection went dead while in the middle of updating the diffs. > > They are corrupted and I don't know how to fix them. Have you tried uploading them again? That won't remove the bogus intermediary revision, but if we know ab

Re: [opensource-dev] Linux build error: missing binary operator before token "("

2011-02-19 Thread Boroondas Gupte
On 02/19/2011 08:30 PM, Nicky D. wrote: >> [...] >> [19:13:30]: [LogScan] /usr/include/bits/huge_val.h:30:20: error: missing >> binary operator before token "(" >> [...] > Tried it today, getting that too. Huge slew of errors. > > Even though this looks intimidating, the reason is really simple. >

Re: [opensource-dev] Is 'STANDALONE' confusing?

2011-02-21 Thread Boroondas Gupte
On 02/21/2011 03:28 PM, Oz Linden (Scott Lawrence) wrote: > If we are going to change it, the replacement term should, in addition > to being more accurately descriptive of what it does, be an affirmative > term - don't suggest any 'NO_*" replacements. Would it be acceptable to invert the settin

Re: [opensource-dev] Is 'STANDALONE' confusing?

2011-02-21 Thread Boroondas Gupte
On 02/21/2011 04:41 PM, Aleric Inglewood wrote: > A LOT worse, but still better than 'standalone' would be USE_SYSTEM_LIBS. Why would you consider USE_SYSTEM_LIBS worse than other suggestions? Cheers, Boroondas ___ Policies and (un)subscribe information

Re: [opensource-dev] Is 'STANDALONE' confusing?

2011-02-23 Thread Boroondas Gupte
On 02/23/2011 10:57 AM, leliel wrote: > On Tue, Feb 22, 2011 at 6:56 PM, Oz Linden (Scott Lawrence) > wrote: >> The real distinction, I think, is whether or not you are using >> _installed_ libraries. Normally, the viewer build has only minimal >> reliance on the libs that are installed on the sy

Re: [opensource-dev] Review Request: VWR-24333: Hardening against use of getLindenUserDir() before logging in.

2011-02-26 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/91/#review386 --- indra/llvfs/lldir.cpp

[opensource-dev] Review Request: on-line fix for OPEN-39: (standalone) bitpack_test.o: No such file or directory

2011-02-26 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/168/ --- Review request for Viewer and Aleric Inglewood. Summary --- On standal

Re: [opensource-dev] Review Request: STORM-1001: Viewer needlessly hits the "ObjectMedia" cap with thousands of requests

2011-02-26 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/162/#review387 --- indra/llprimitive/lltextureentry.cpp

Re: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone

2011-02-26 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review388 --- Can you give some instructions on how to do a standalone build wit

Re: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone

2011-02-27 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review391 --- Ship it! Ah, with that, configuration succeeds and GLH_INCLUDE_DI

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-02-27 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/153/#review392 --- Ship it! indra/llcommon/llavatarname.cpp

Re: [opensource-dev] Review Request: VWR-24889: When a bake texture upload fails, retry instead of giving up.

2011-03-01 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/152/#review397 --- indra/newview/lltexlayer.h

Re: [opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs

2011-03-01 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/169/#review398 --- indra/llui/lltextbase.cpp

Re: [opensource-dev] Review Request: one-line fix for OPEN-39: (standalone) bitpack_test.o: No such file or directory

2011-03-02 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/168/ --- (Updated March 2, 2011, 5:32 a.m.) Review request for Viewer and Aleric Ing

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-03-04 Thread Boroondas Gupte
indra/llcommon/llavatarname.cpp <http://codereview.secondlife.com/r/153/#comment306> Nitpicking now, but it should be "i.e.", not "ie". Also, the defaulted display name is NOT the same as the user name. (Mine would be "Boroondas Gupte" and "boroondas.gupte&q

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-03-04 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/153/#review422 --- Ship it! Perfect :-) - Boroondas On March 4, 2011, 5:11 a.m.,

Re: [opensource-dev] Review Request: Implementation of new testing hooks to enable the creation of a headless viewer for testing.

2011-03-07 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/181/#review426 --- Any chance this big change could be split into several smaller (ho

Re: [opensource-dev] Review Request: make PREHASH variables char const* const (fixes VWR-24487: llurlentry_stub.cpp:196: error: deprecated conversion from string constant to 'char*')

2011-03-07 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/ --- (Updated March 7, 2011, 3:51 p.m.) Review request for Viewer and Seth Produ

  1   2   3   4   5   >