[opensource-dev] Code review request: STORM-121 (Cleanup of Voice Client shutdown)

2010-09-14 Thread Aimee Linden
Hi, Would someone mind code-reviewing this change ... http://bitbucket.org/aimee_linden/viewer-development-fixes/changeset/836266aa8302 Just some simple reduction of duplicated code to ensure things get cleaned up properly when the voice client shuts down. Aimee. _

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

2010-09-07 Thread Aimee Linden
that worked > > -- > From: "Ardy Lay" > Sent: Tuesday, September 07, 2010 4:18 PM > To: > Subject: Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions > icons in the friends list) > >> The provided bu

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

2010-09-07 Thread Alexandrea Fride
llkdu.dll problem hapend to me to, replace the dll from the officialy viewer 2.1 or devenlopbuild that worked -- From: "Ardy Lay" Sent: Tuesday, September 07, 2010 4:18 PM To: Subject: Re: [opensource-dev] Code Review Request:

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

2010-09-07 Thread Ardy Lay
On 9/6/2010 11:53 AM, Aimee Linden wrote: > Hi, > > Could I get some eyes on a fix for > http://jira.secondlife.com/browse/VWR-21253 ... > > http://bitbucket.org/aimee_linden/viewer-development-tweaks/changeset/fb38222f1b08 > > A test build containing this is available here ... > > http://automa

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

2010-09-07 Thread Boroondas Gupte
During testing, I made some interesting observations that I wanted to comment about, but JIRA is read-only at the moment, so I'll just paste it here: Tested, works as expected with the following exceptions: Revoking "See my online status" permission automatically also re

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

2010-09-07 Thread Aimee Linden
> On 09/06/2010 07:37 PM, Marine Kelley wrote: >> >> Err... color me stupid but... how does one show the friends list in this >> style on viewer 2 ? I can detach tabs from the sidebar, but I cannot find a >> way to show the permissions matrix. It would be so handy ! On 6 Sep 2010, at 21:23, Bor

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

2010-09-06 Thread Marine Kelley
On 6 September 2010 22:23, Boroondas Gupte wrote: > I guess you refer to the screenshot attached to the jira issue? Note the > date when that one was added, Oct. 15, 20*09*. Also note the artwork and > color scheme. I guess that was from an early development version of Viewer 2 > that already had

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

2010-09-06 Thread Boroondas Gupte
On 09/06/2010 07:37 PM, Marine Kelley wrote: > Err... color me stupid but... how does one show the friends list in > this style on viewer 2 ? I can detach tabs from the sidebar, but I > cannot find a way to show the permissions matrix. It would be so handy ! > [...] > > On 6 September 2010 18:53,

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

2010-09-06 Thread Alexandrea Fride
Works fine on windows to however icons dont fit with viewer 2 style :) if not mistaken those are the icons from viewer 1 (and prefered if the icons where a bit smaller in weight & height and more easly to define what is what) @Kelley that was probly a alpha viewer 2 release since if you look at

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

2010-09-06 Thread leliel
On Mon, Sep 6, 2010 at 10:37 AM, Marine Kelley wrote: > Err... color me stupid but... how does one show the friends list in this > style on viewer 2 ? I can detach tabs from the sidebar, but I cannot find a > way to show the permissions matrix. It would be so handy ! Hover the mouse over their na

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

2010-09-06 Thread Marine Kelley
Err... color me stupid but... how does one show the friends list in this style on viewer 2 ? I can detach tabs from the sidebar, but I cannot find a way to show the permissions matrix. It would be so handy ! Thanks, Marine On 6 September 2010 18:53, Aimee Linden wrote: > Hi, > > Could I get so

[opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

2010-09-06 Thread Aimee Linden
Hi, Could I get some eyes on a fix for http://jira.secondlife.com/browse/VWR-21253 ... http://bitbucket.org/aimee_linden/viewer-development-tweaks/changeset/fb38222f1b08 A test build containing this is available here ... http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/aimee_vie

[opensource-dev] code review request

2010-09-03 Thread Kent Quirk (Q Linden)
Hi, all, getting back into it a little during recovery. Can I please get a review and perhaps pull for: http://jira.secondlife.com/browse/VWR-20945 Code is here: Fix is in https://bitbucket.org/kentquirk/vwr-20945 changeset 123b6d316c16 This issue is important to our release team. Thanks!

Re: [opensource-dev] Code review request: VWR-22454 (Teleporting multiple friends)

2010-09-01 Thread Tofu Linden
Looks shippable. I assume it works. Ideally the (nice) video-repro would be text-ized so it doesn't have to be decoded by QA in real time. :) +1 Aimee Linden wrote: > Hi, > > Could I get some eyes on a fix for VWR-22454 (Teleporting multiple friends) > please? > > > http://bitbucket.org/aim

[opensource-dev] Code review request: VWR-22454 (Teleporting multiple friends)

2010-09-01 Thread Aimee Linden
Hi, Could I get some eyes on a fix for VWR-22454 (Teleporting multiple friends) please? http://bitbucket.org/aimee_linden/viewer-development-import/changeset/18f8e079a1de Aimee. ___ Policies and (un)subscribe information available here: http://wiki.