Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

> On June 25, 2011, 8:30 a.m., Tankmaster Finesmith wrote: > > When I applied this latest patch to firestorm, which is based off of LL > > 2.5.2, I kept getting timed out when TPing from a mainland area and a DD of > > 256 to other regions. I tried multiple times TPing from the area around >

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

> On June 25, 2011, 8:30 a.m., Tankmaster Finesmith wrote: > > When I applied this latest patch to firestorm, which is based off of LL > > 2.5.2, I kept getting timed out when TPing from a mainland area and a DD of > > 256 to other regions. I tried multiple times TPing from the area around >

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

> On June 25, 2011, 8:30 a.m., Tankmaster Finesmith wrote: > > When I applied this latest patch to firestorm, which is based off of LL > > 2.5.2, I kept getting timed out when TPing from a mainland area and a DD of > > 256 to other regions. I tried multiple times TPing from the area around >

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

I agree very much about extensive testing of changes in key-functionality like voice. Lots of teleporting is the right thing to do for this patch (see the jira for more a more detailed list of things that I think need to be adressed). About Inventory failures and being disconnected from the sim,

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/#review819 --- When I applied this latest patch to firestorm, which is based off

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/#review815 --- Ship it! No major objections now, thanks. - Vadim On June 24,

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/#review814 --- indra/newview/llvoicevivox.h

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/ --- (Updated June 24, 2011, 4:45 a.m.) Review request for Viewer. Summary ---

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/#review813 --- I pushed a new version of the patch to https://bitbucket.org/Armin

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

> On June 20, 2011, 9:49 a.m., Vadim ProductEngine wrote: > > indra/newview/llvoicevivox.cpp, line 557 > > > > > > Inconsistent spacing around "if" conditions. > > > > Please use "if (cond)" with no extra or m

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

> On June 20, 2011, 9:49 a.m., Vadim ProductEngine wrote: > > indra/newview/llvoicevivox.cpp, lines 4485-4488 > > > > > > What if region caps never arrive? > > The string may grow infinitely. > > > > Also

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

> On June 20, 2011, 9:49 a.m., Vadim ProductEngine wrote: > > indra/newview/llvoicevivox.cpp, lines 4485-4488 > > > > > > What if region caps never arrive? > > The string may grow infinitely. > > > > Also

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

> On June 20, 2011, 9:49 a.m., Vadim ProductEngine wrote: > > indra/newview/llvoicevivox.cpp, lines 4485-4488 > > > > > > What if region caps never arrive? > > The string may grow infinitely. > > > > Also

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

> On June 9, 2011, 1:48 p.m., Altair Memo wrote: > > indra/newview/llvoicevivox.cpp, line 785 > > > > > > not sure is a nice choice remove the warn, a resident lose the only way > > to know if all work fine I'll add

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/#review778 --- Seems to work for me, although I'd appreciate if you used a more

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/#review738 --- indra/newview/llvoicevivox.h

[opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/ --- Review request for Viewer. Summary --- This is a patch by ArminWeather