Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-21 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/90/#review241 --- Ship it! Ok, I read the code in more details and I'm indeed convin

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-19 Thread Cron Stardust
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/90/#review204 --- Ship it! Thanks for the clarification! Looks good to me. - Cron

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-19 Thread Aleric Inglewood
> On Jan. 18, 2011, 12:09 p.m., Merov Linden wrote: > > indra/newview/lltexturecache.cpp, line 1595 > > > > > > validate_idx being used in a test later, it's not just for > > (validate_idx == 0) that the behavior will b

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-19 Thread Boroondas Gupte
> On Jan. 19, 2011, 2:44 p.m., Boroondas Gupte wrote: > > indra/newview/lltexturecache.cpp, line 1595 > > > > > > Old code: > > validate_idx will now be in [1,256]. (one higher than before) > > > > New code:

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-19 Thread Boroondas Gupte
> On Jan. 19, 2011, 2:44 p.m., Boroondas Gupte wrote: > > > validate_idx being used in a test later, it's not just for (validate_idx > > > == 0) > > > that the behavior will be different. I need to understand better what > > > that idx > > > is all about or you need to give a bit more explanati

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-19 Thread Boroondas Gupte
> On Jan. 18, 2011, 12:09 p.m., Merov Linden wrote: > > indra/newview/lltexturecache.cpp, line 1595 > > > > > > validate_idx being used in a test later, it's not just for > > (validate_idx == 0) that the behavior will b

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-19 Thread Twisted Laws
> On Jan. 18, 2011, 12:09 p.m., Merov Linden wrote: > > indra/newview/lltexturecache.cpp, line 1595 > > > > > > validate_idx being used in a test later, it's not just for > > (validate_idx == 0) that the behavior will b

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-18 Thread Cron Stardust
> On Jan. 18, 2011, 12:09 p.m., Merov Linden wrote: > > indra/newview/lltexturecache.cpp, line 1595 > > > > > > validate_idx being used in a test later, it's not just for > > (validate_idx == 0) that the behavior will b

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-18 Thread Aleric Inglewood
> On Jan. 18, 2011, 12:09 p.m., Merov Linden wrote: > > indra/newview/lltexturecache.cpp, line 1595 > > > > > > validate_idx being used in a test later, it's not just for > > (validate_idx == 0) that the behavior will b

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-18 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/90/#review191 --- indra/newview/lltexturecache.cpp

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-14 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/90/#review161 --- Ship it! Correct. - Boroondas On Jan. 14, 2011, 1:02 p.m., Aler

[opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/90/ --- Review request for Viewer. Summary --- Trivial patch, just removes stup