Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-20 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/#review223 --- Ship it! Seems good. Glad to see a "TODO" being dealt with :) - M

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-17 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/#review173 --- Ship it! - Boroondas On Jan. 17, 2011, 5:24 a.m., Aleric Inglewo

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-17 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/ --- (Updated Jan. 17, 2011, 5:24 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-16 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/#review167 --- Ship it! scripts/install.py

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-16 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/ --- (Updated Jan. 16, 2011, 5:35 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-15 Thread Boroondas Gupte
> On Jan. 14, 2011, 1:16 p.m., Boroondas Gupte wrote: > > scripts/install.py, lines 592-594 > > > > > > This can be written more pythonesque as > > > > (to_install, to_uninstall) = self._build_ifiles(plat

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-15 Thread Boroondas Gupte
> On Jan. 14, 2011, 1:16 p.m., Boroondas Gupte wrote: > > scripts/install.py, line 598 > > > > > > Does to_install need filtering at all? (Can it contain > > non-installables?) Reading the docstring of install() , I rea

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-14 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/#review152 --- scripts/install.py

[opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/ --- Review request for Viewer. Summary --- See https://jira.secondlife.com/