Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

2012-06-21 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/543/#review1235 --- This code is also missing the work I did to add a radio button to

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

2012-06-21 Thread Jonathan Yap
> On None, Tobias Roth wrote: > > Ship It! Please add the viewer version you are working from to the Branch field and STORM-468 to the Bugs field in this review request. In addition to the objections LL has posted I found two bugs when I worked on this code in January. Have both of these iss

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

2012-06-21 Thread Lance Corrimal
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/543/#review1233 --- Ship it! This patch has been used in more third party viewers th

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

2012-03-02 Thread Liny Odell
Yea, I noticed that as read more into the comments on that jira, but it may be useful for others to have a link in both directions (into and out of the code review) On Fri, Mar 2, 2012 at 10:48 AM, Lance Corrimal wrote: > You do know that that jira links to this CR request, right? > > > bye, > LC

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

2012-03-02 Thread Nicky Perian
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/543/#review1173 --- qtoolalign not qtools - Nicky Perian On March 2, 2012, 12:30 a

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

2012-03-02 Thread Tankmaster Finesmith
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/543/#review1172 --- I would suggest using "size *= 1.25;" instead of "size *= 2.0;" t

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

2012-03-02 Thread Lance Corrimal
You do know that that jira links to this CR request, right? bye, LC Am Freitag, 2. März 2012, 10:36:25 schrieb Liny Odell: > Please see https://jira.secondlife.com/browse/STORM-468 > > On Fri, Mar 2, 2012 at 1:45 AM, Lance Corrimal wrote: > >This is an automatically generated e-mail. To re

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

2012-03-02 Thread Nicky Perian
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/543/#review1171 --- Do qtoolsalign.cpp aand qtoolsalign.h need to added to /indra/ne

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

2012-03-02 Thread Liny Odell
Please see https://jira.secondlife.com/browse/STORM-468 On Fri, Mar 2, 2012 at 1:45 AM, Lance Corrimal wrote: >This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/543/ > > Ship it! > > Testing done: this tool has been in dolphin viewer for over a y

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

2012-03-02 Thread Lance Corrimal
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/543/#review1170 --- Ship it! Testing done: this tool has been in dolphin viewer for