[opensource-dev] Review Request: VWR-24519: Spawning of the 'spare' media plugin process makes debugging SLPlugin harder

2011-01-17 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/96/ --- Review request for Viewer. Summary --- This patch stops early spawns of

[opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

2011-01-17 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/99/ --- Review request for Viewer. Summary --- Please see http://jira.secondlif

[opensource-dev] Review Request: STORM-2 As a User, I want to set my own default views with specific UI layout so I can tailor my Viewer experience to the activities I'm most interested in.

2011-01-17 Thread Andrew ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/98/ --- Review request for Viewer. Summary --- First pass of saving of UI state

Re: [opensource-dev] Review Request: VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2

2011-01-17 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/97/#review179 --- Ship it! Perfect ;) - Aleric On Jan. 17, 2011, 10:03 a.m., Bor

[opensource-dev] AW Groupies meeting tomorrow on mesh asset interop format

2011-01-17 Thread Lawson English
The AW Groupies meeting tomorrow will be Aaron Walsh talking (in voice with questions taken in voice and text) about the iED OpenFile Format: http://mediagrid.org/news/2010-11_iED_Create_Once_Experience_Everywhere.html at http://maps.secondlife.com/secondlife/ThorneBridgeTown/156/130/22 at 9:30

[opensource-dev] Review Request: VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2

2011-01-17 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/97/ --- Review request for Viewer. Summary --- Only use QUIET in pkg_check_modu

Re: [opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express

2011-01-17 Thread Jonathan Yap
> On Jan. 17, 2011, 7:33 a.m., Oz Linden wrote: > > Given that we are in the process of moving to VS2010, I suggest that this > > is not worth doing Oz, I think it is worth doing, but doing it it a more general and forward-looking way, unless VS2010 Express will not have this issue. Please see

Re: [opensource-dev] Review Request: (STORM-383) Context menu cannot be open for Landmark that are located in the My inventory->Trash folder

2011-01-17 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/77/#review177 --- Ship it! Alright then. - Vadim On Jan. 17, 2011, 8:17 a.m., Set

Re: [opensource-dev] Review Request: (STORM-383) Context menu cannot be open for Landmark that are located in the My inventory->Trash folder

2011-01-17 Thread Seth ProductEngine
> On Jan. 16, 2011, 7:37 a.m., Vadim ProductEngine wrote: > > indra/newview/llpanellandmarks.cpp, lines 1127-1132 > > > > > > Why are the checks for are_all_items_in_trash and > > are_any_items_in_trash different? > >

Re: [opensource-dev] Review Request: (STORM-383) Context menu cannot be open for Landmark that are located in the My inventory->Trash folder

2011-01-17 Thread Seth ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/77/ --- (Updated Jan. 17, 2011, 8:17 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express

2011-01-17 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/68/#review175 --- Given that we are in the process of moving to VS2010, I suggest tha

Re: [opensource-dev] Review Request: VWR-24420: PNG images which specify "background color" lose alpha layer when imported.

2011-01-17 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/74/#review174 --- Ship it! - Oz On Jan. 9, 2011, 6:59 a.m., Thickbrick Sleaford wr

Re: [opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

2011-01-17 Thread Tateru Nino
I confess to not liking leaving in incorrectly spelled commented code. Just saying. On 17/01/2011 11:31 PM, Oz Linden wrote: This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/87/ indra/llui/llnotifications.cpp

Re: [opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

2011-01-17 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/87/ --- (Updated Jan. 17, 2011, 5:32 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-17 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/#review173 --- Ship it! - Boroondas On Jan. 17, 2011, 5:24 a.m., Aleric Inglewo

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-17 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/ --- (Updated Jan. 17, 2011, 5:24 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

2011-01-17 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/87/#review172 --- indra/llui/llnotifications.cpp

[opensource-dev] Linden holiday - Oz office hour cancelled

2011-01-17 Thread Oz Linden (Scott Lawrence)
Monday 17 January is a Linden Lab employee holiday. so I won't be holding my Office Hour. ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmodera