Re: [opensource-dev] Review Request: Storm-844 "More" should be "Less" when Media Control is open

2011-01-16 Thread Jonathan Yap
> On Jan. 13, 2011, 8:05 a.m., Twisted Laws wrote: > > To me, this is the wrong solution. label_selected used to work to allow a > > button to display different text when it was selected, so you could have a > > button that said More until it was pressed or selected and displayed more > > inf

Re: [opensource-dev] Link times

2011-01-16 Thread Aleric Inglewood
I'm afraid that VWR-24366 won't reduce link times significantly. On Fri, Jan 14, 2011 at 11:49 PM, Boroondas Gupte wrote: > On 01/14/2011 06:04 PM, Jonathan Welch wrote: > > I just did a quick study on link times for various viewers on my 2Gb XP > system > > Viewer 1st link 2nd link > CV 1.22

Re: [opensource-dev] Review Request: (STORM-383) Context menu cannot be open for Landmark that are located in the My inventory->Trash folder

2011-01-16 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/77/#review170 --- indra/newview/llpanellandmarks.cpp

Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory

2011-01-16 Thread Boroondas Gupte
> On Jan. 14, 2011, 1:47 p.m., Boroondas Gupte wrote: > > indra/newview/llappviewer.cpp, lines 3091-3094 > > > > > > what's the reason for moving the LL_INFOS around? > > Aleric Inglewood wrote: > The last two, in o

Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory

2011-01-16 Thread Aleric Inglewood
> On Jan. 14, 2011, 1:47 p.m., Boroondas Gupte wrote: > > indra/newview/llappviewer.cpp, lines 3091-3094 > > > > > > what's the reason for moving the LL_INFOS around? The last two, in order to print the correct value th

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-16 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/#review167 --- Ship it! scripts/install.py

Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: remove: Attempting to remove filename: /ramdisk/imprudence/cache/textures/*/*.texture

2011-01-16 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/84/ --- (Updated Jan. 16, 2011, 6:12 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-16 Thread Aleric Inglewood
> On Jan. 14, 2011, 1:31 p.m., Boroondas Gupte wrote: > > indra/llcommon/lllslconstants.h, line 184 > > > > > > Yay for having type modifiers after the core type name. Makes them much > > easier to understand, especially

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-16 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/ --- (Updated Jan. 16, 2011, 5:53 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-16 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/ --- (Updated Jan. 16, 2011, 5:35 a.m.) Review request for Viewer. Changes