Re: RFR: 8277122: SplitPane divider drag can hang the layout [v2]

On Wed, 26 Jan 2022 20:14:37 GMT, Marius Hanl wrote: > Hm, is this really needed? yes, IMO, we want the exact same cleanup for passing/failing tests. So either dispose is required always (then need to make sure it's called on failure) or not required always (then all its calls would be noise)

Re: RFR: 8251481: TableCell accessing row: NPE on auto-sizing

On Tue, 25 Jan 2022 12:00:11 GMT, Jeanette Winzenburg wrote: >> This PR will fix a simple NPE which may happens when using the `TableRow` >> inside a `TableCell` during the initial auto sizing. >> In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` >> will return null and

Re: RFR: 8251481: TableCell accessing row: NPE on auto-sizing [v2]

> This PR will fix a simple NPE which may happens when using the `TableRow` > inside a `TableCell` during the initial auto sizing. > In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` will > return null and it is not possible to e.g. access the row item. > > This is fixed b

AVIF ImageProvider registering

Hello everyone, as some of you already know I have created the project LibHeifFX (github.com/lanthaler/libheiffx) for adding HEIC (iPhone) and AVIF file format to the image class. Basically all is working with HEIC files, but as soons as I try to open a AVIF file OpenJFX gives me the error m

Re: RFR: 8277122: SplitPane divider drag can hang the layout [v2]

On Thu, 27 Jan 2022 10:18:31 GMT, Jeanette Winzenburg wrote: >> Hm, is this really needed? Not sure, are there any side effects by the >> `StageLoader` like this when a test failed? >> Just asking since the `StageLoader` is used a lot like this. >> And since the tests normally run green unless

Re: RFR: 8277122: SplitPane divider drag can hang the layout [v2]

On Thu, 27 Jan 2022 11:42:28 GMT, Marius Hanl wrote: >>> Hm, is this really needed? >> >> yes, IMO, we want the exact same cleanup for passing/failing tests. So >> either dispose is required always (then need to make sure it's called on >> failure) or not required always (then all its calls w

Integrated: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning

On Thu, 2 Dec 2021 10:12:50 GMT, meghanEmbrace wrote: > With a touch-enabled device, the scrollbar disappears a short while after > it's used. During the layout, updateHbar() checks the hbar visibility and > resets the clip, causing the user to be scrolled fully to the left when > trying to ac

Re: AVIF ImageProvider registering

The error message of the exception that is thrown by `ImageStorage` when attempting to load an unsupported image type is: "No loader for image data". If you're encountering a different exception, maybe it originates from somewhere else. That being said, you're right that OpenJFX doesn't care abou

Re: AVIF ImageProvider registering

That link should be https://github.com/lanthale/LibHeifFX > On Jan 27, 2022, at 6:02 AM, Clemens Lanthaler > wrote: > > Hello everyone, > > as some of you already know I have created the project LibHeifFX > (github.com/lanthaler/libheiffx) for adding

Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v5]

> After thinking about this issue for some time, I've now got a solution. > I know put the scene in the state it is, before is was shown, when the > dirtyNodes are unset, the whole scene is basically considered dirty. > This has the drawback of rerendering, whenever a window is "reshown", but it

Re: AVIF ImageProvider registering

>From a quick look at the code, two things come to mind: 1. The file signature is specified as "001C667479706176", which corresponds to "ftypav" followed by two null bytes. Maybe "av" ist not a valid `major_brand`. 2. The first four bytes of the file specify the size of the header, which

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

On Tue, 25 Jan 2022 06:21:37 GMT, Ambarish Rapte wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/AmbientLight.java line 37: >> >>> 35: * >>> 36: * {@code AmbientLight}s can represent strong light sources in an >>> enclosed area where the lights bounces from many >>> 37: * objec

Re: RFR: 8277122: SplitPane divider drag can hang the layout [v2]

On Thu, 27 Jan 2022 12:46:19 GMT, Jeanette Winzenburg wrote: >> ah okay. Was just confusing for me since I never read that and I think some >> recent PRs still had this pattern, e.g. also the touch table scrolling PR I >> had a look at yesterday. >> >> Maybe for future it makes sense to have

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

On Thu, 27 Jan 2022 15:07:26 GMT, Nir Lisker wrote: >> Ambient light is a light that comes from all directions, scattered from >> different surfaces and it does not cast shadow. So I think the example of >> strong light and moon light should be avoided. Moon light is more like the >> Sun light

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

On Tue, 25 Jan 2022 01:17:51 GMT, Kevin Rushforth wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v2]

> Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to `LightBase` since > different light types share characteristics

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v2]

On Thu, 27 Jan 2022 15:45:44 GMT, Michael Strauß wrote: >> What examples would you use? >> >> If a light in a room is strong it will barely cast shadows since its >> reflections from all directions eliminate them. >> >> Maybe I should mention that Ambient light can be used with a dark color to

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v2]

On Thu, 27 Jan 2022 17:14:51 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/LightBase.java line 119: >> >>> 117: *The transparency (alpha) component of a light is ignored. >>> 118: * >>> 119: * There are no guarantee that these behaviors will not change. >>

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v3]

> Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to `LightBase` since > different light types share characteristics

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v2]

On Thu, 27 Jan 2022 17:28:15 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to `Ligh

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v4]

> Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to `LightBase` since > different light types share characteristics

Re: RFR: 8251481: TableCell accessing row: NPE on auto-sizing [v3]

> This PR will fix a simple NPE which may happens when using the `TableRow` > inside a `TableCell` during the initial auto sizing. > In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` will > return null and it is not possible to e.g. access the row item. > > This is fixed b

Re: RFR: 8251481: TableCell accessing row: NPE on auto-sizing [v3]

On Tue, 25 Jan 2022 12:09:31 GMT, Jeanette Winzenburg wrote: >> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8251481: Using global stageLoader now > > modules/javafx.controls/src/test/java/test/javafx/scene/control/TableC

Re: RFR: 8277122: SplitPane divider drag can hang the layout [v4]

> When a divider is moved via drag or code it will call **requestLayout()** for > the **SplitPane**. > While this is fine, it is also called when the > **SplitPaneSkin#layoutChildren(..)** method is repositioning the divider. > > This makes no sense since we are currently layouting everything, s

Re: RFR: 8277122: SplitPane divider drag can hang the layout [v2]

On Thu, 27 Jan 2022 15:21:33 GMT, Marius Hanl wrote: >> just for reference - found the source of my [faintly >> remember](https://github.com/openjdk/jfx/pull/337/files/8a6fc1cf6cad2c453de17b71777ddd63fadb539e#r510975640) > > I see. Unfortunately though that was not done consistently during the p

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v5]

On Sun, 16 Jan 2022 12:25:13 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix grammar mistakes and did some small rephrases > > modules/javafx.base/src/main/java/javafx/beans/value/ObservableVal

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v6]

> This is an implementation of the proposal in > https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker > (@nlisker) have been working on. It's a complete implementation including > good test coverage. > > This was based on https://github.com/openjdk/jfx/pull/434 but with a

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v5]

On Thu, 20 Jan 2022 17:19:49 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix grammar mistakes and did some small rephrases > > modules/javafx.base/src/main/java/javafx/beans/value/LazyObjectBin

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v7]

> This is an implementation of the proposal in > https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker > (@nlisker) have been working on. It's a complete implementation including > good test coverage. > > This was based on https://github.com/openjdk/jfx/pull/434 but with a

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v5]

On Sun, 16 Jan 2022 22:01:33 GMT, Nir Lisker wrote: > * Most tests that I have seen in JavaFX use the assert overloads that include > a message that explains what the value should be or what it means if the > assertion failed. I don't know how much of a requirement it is. I can help > write th

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v8]

> This is an implementation of the proposal in > https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker > (@nlisker) have been working on. It's a complete implementation including > good test coverage. > > This was based on https://github.com/openjdk/jfx/pull/434 but with a

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler) t

Re: RFR: 8255940: localStorage is null after window.close()

On Mon, 27 Dec 2021 09:31:08 GMT, Jay Bhaskar wrote: > Issue: The current implementation of DOMWindow ::localStorage(..) returns > null pointer in case of page is being closed. > Fix: It should not return nullptr , as per the [w3c web storage > spec](https://www.w3.org/TR/2016/REC-webstorage-2