> This is an implementation of the proposal in
> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
> (@nlisker) have been working on. It's a complete implementation including
> good test coverage.
>
> This was based on https://github.com/openjdk/jfx/pull/434 but with a
On Sun, 2 Jan 2022 20:18:02 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Upgrade tests to JUnit 5
>
> modules/javafx.base/src/main/java/javafx/beans/binding/ObjectBinding.java
> line 193:
>
>>
On Wed, 5 Jan 2022 09:45:21 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/binding/ObjectBinding.java
>> line 193:
>>
>>> 191: *
>>> 192: * @return {@code true} when this binding currently has one or more
>>> 193: * listeners, otherwise {@code fal
On Wed, 5 Jan 2022 09:52:29 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/binding/ObjectBinding.java
>> line 204:
>>
>>> 202: *
>>> 203: * @return {@code true} if this binding is allowed to become
>>> valid, otherwise
>>> 204: * {@code false}
>>
On Wed, 5 Jan 2022 12:08:01 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java
>> line 188:
>>
>>> 186: * {@code ObservableValue} given by applying {@code mapper} on
>>> the value
>>> 187: * held by this {@code ObservableVal
On Tue, 4 Jan 2022 03:28:57 GMT, Nir Lisker wrote:
> Unrelated to the review, will it makes sense in the future to make all
> bindings lazily register listeners like `LazyObjectBinding`, perhaps when we
> introduce `Subscription`?
That would need to be very well tested. There are some noticeab
On Fri, 27 Aug 2021 13:39:13 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> com
> Making the initial listener of the ListProperty weak fixes the problem.
> The same is fixed for Set and Map.
> Due to a smart implementation, this is done without any performance drawback.
> (The trick is to have an object, which is both the WeakReference and the
> Changelistener)
> By implying
On Fri, 31 Dec 2021 12:53:54 GMT, Michael Strauß wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8277848
>> Added missing change
>
> Why are the new listener imlementations called `BaseChangeListener` and
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote:
>> This PR fixes an issue when building OpenJFX on Windows and command-line
>> arguments contain paths with spaces.
>>
>> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to
>> quotes being interpreted twice. This ca
On Wed, 5 Jan 2022 18:14:44 GMT, Florian Kirmaier wrote:
>> Making the initial listener of the ListProperty weak fixes the problem.
>> The same is fixed for Set and Map.
>> Due to a smart implementation, this is done without any performance drawback.
>> (The trick is to have an object, which is b
11 matches
Mail list logo
