Re: [Numpy-discussion] assert_allclose equal_nan default value.

2016-10-20 Thread Marten van Kerkwijk
Good, that means I can revert some changes to astropy, which made the tests less readable. -- Marten ___ NumPy-Discussion mailing list NumPy-Discussion@scipy.org https://mail.scipy.org/mailman/listinfo/numpy-discussion

Re: [Numpy-discussion] assert_allclose equal_nan default value.

2016-10-20 Thread Benjamin Root
+1. I was almost always setting it to True anyway. On Thu, Oct 20, 2016 at 1:18 PM, Nathan Goldbaum wrote: > Agreed, especially given the prevalence of using this function in > downstream test suites: > > https://github.com/search?utf8=%E2%9C%93&q=numpy+assert_ > allclose&type=Code&ref=searchres

Re: [Numpy-discussion] assert_allclose equal_nan default value.

2016-10-20 Thread Nathan Goldbaum
Agreed, especially given the prevalence of using this function in downstream test suites: https://github.com/search?utf8=%E2%9C%93&q=numpy+assert_allclose&type=Code&ref=searchresults On Thu, Oct 20, 2016 at 12:16 PM, Charles R Harris < charlesr.har...@gmail.com> wrote: > Hi All, > > Just a heads