Re: [Numpy-discussion] proposal: min, max of complex should give warning

2014-01-04 Thread Ralf Gommers
On Tue, Dec 31, 2013 at 5:45 PM, Neal Becker wrote: > Ralf Gommers wrote: > > > On Tue, Dec 31, 2013 at 4:52 PM, Neal Becker > wrote: > > > >> Cera, Tim wrote: > >> > >> > I don't work with complex numbers, but just sampling what others do: > >> > > >> > > >> > Python: no ordering, results in Ty

Re: [Numpy-discussion] proposal: min, max of complex should give warning (Ralf Gommers)

2013-12-31 Thread David Goldsmith
> > As for your proposal, it would be good to know if adding a warning would > actually catch any bugs. For the truncation warning it caught several in > scipy and other libs IIRC. > > Ralf > In light of this, perhaps the pertinent unit tests should be modified (even if the warning suggestion isn'

Re: [Numpy-discussion] proposal: min, max of complex should give warning

2013-12-31 Thread Neal Becker
Ralf Gommers wrote: > On Tue, Dec 31, 2013 at 4:52 PM, Neal Becker wrote: > >> Cera, Tim wrote: >> >> > I don't work with complex numbers, but just sampling what others do: >> > >> > >> > Python: no ordering, results in TypeError >> > >> > Matlab: sorts by magnitude >> > http://www.mathworks.com

Re: [Numpy-discussion] proposal: min, max of complex should give warning

2013-12-31 Thread Ralf Gommers
On Tue, Dec 31, 2013 at 4:52 PM, Neal Becker wrote: > Cera, Tim wrote: > > > I don't work with complex numbers, but just sampling what others do: > > > > > > Python: no ordering, results in TypeError > > > > Matlab: sorts by magnitude > > http://www.mathworks.com/help/matlab/ref/sort.html > > > >

Re: [Numpy-discussion] proposal: min, max of complex should give warning

2013-12-31 Thread Neal Becker
Cera, Tim wrote: > I don't work with complex numbers, but just sampling what others do: > > > Python: no ordering, results in TypeError > > Matlab: sorts by magnitude > http://www.mathworks.com/help/matlab/ref/sort.html > > R: sorts first by real, then by imaginary > http://stat.ethz.ch/R-manu

Re: [Numpy-discussion] proposal: min, max of complex should give warning

2013-12-31 Thread Cera, Tim
I don't work with complex numbers, but just sampling what others do: Python: no ordering, results in TypeError Matlab: sorts by magnitude http://www.mathworks.com/help/matlab/ref/sort.html R: sorts first by real, then by imaginary http://stat.ethz.ch/R-manual/R-patched/library/base/html/sort.ht

[Numpy-discussion] proposal: min, max of complex should give warning

2013-12-30 Thread Neal Becker
I propose the following change: min, max applied to complex should give a warning. The rationale is, when the user applies min or max to complex, it's probably a mistake. ___ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.or