Re: [Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-11 Thread Brian Granger
Thanks much! Brian On Wed, Feb 11, 2009 at 9:44 PM, Stéfan van der Walt wrote: > 2009/2/6 Brian Granger : >> Great, what is the best way of rolling this into numpy? > > I've committed your patch. > > Cheers > Stéfan > ___ > Numpy-discussion mailing lis

Re: [Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-11 Thread Stéfan van der Walt
2009/2/6 Brian Granger : > Great, what is the best way of rolling this into numpy? I've committed your patch. Cheers Stéfan ___ Numpy-discussion mailing list Numpy-discussion@scipy.org http://projects.scipy.org/mailman/listinfo/numpy-discussion

Re: [Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-05 Thread Brian Granger
Great, what is the best way of rolling this into numpy? Brian On Thu, Feb 5, 2009 at 8:13 PM, Robert Kern wrote: > On Thu, Feb 5, 2009 at 22:00, Brian Granger wrote: >> Robert, >> >> Can you have a look at the following fix and see if it is satisfactory? >> >> http://github.com/ellisonbg/numpy/

Re: [Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-05 Thread Robert Kern
On Thu, Feb 5, 2009 at 22:00, Brian Granger wrote: > Robert, > > Can you have a look at the following fix and see if it is satisfactory? > > http://github.com/ellisonbg/numpy/blob/81360e93968968dc9dcbafd7895da7cec5015a3c/numpy/distutils/fcompiler/gnu.py Looks good. -- Robert Kern "I have come

Re: [Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-05 Thread Brian Granger
Robert, Can you have a look at the following fix and see if it is satisfactory? http://github.com/ellisonbg/numpy/blob/81360e93968968dc9dcbafd7895da7cec5015a3c/numpy/distutils/fcompiler/gnu.py Brian On Tue, Feb 3, 2009 at 9:32 PM, Robert Kern wrote: > On Tue, Feb 3, 2009 at 23:22, Brian Grang

Re: [Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-03 Thread Robert Kern
On Tue, Feb 3, 2009 at 23:22, Brian Granger wrote: >> 1) Trust the environment variable if given and let distutils raise its >> error message (why not raise it ourselves? distutils' error message >> and explanation is already out in THE GOOGLE.) >> >> 2) Otherwise, use the value in the Makefile if

Re: [Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-03 Thread Brian Granger
> 1) Trust the environment variable if given and let distutils raise its > error message (why not raise it ourselves? distutils' error message > and explanation is already out in THE GOOGLE.) > > 2) Otherwise, use the value in the Makefile if it's there. > > 3) If it's not even in the Makefile for

Re: [Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-03 Thread Robert Kern
On Tue, Feb 3, 2009 at 18:53, Brian Granger wrote: >> Hmm, that's still going to break for any custom build that decides to >> build Python with a specific MACOSX_DEPLOYMENT_TARGET. If you're going >> to fix it at all, it should default to the value in the Makefile that >> sysconfig is going to ch

Re: [Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-03 Thread Brian Granger
> Hmm, that's still going to break for any custom build that decides to > build Python with a specific MACOSX_DEPLOYMENT_TARGET. If you're going > to fix it at all, it should default to the value in the Makefile that > sysconfig is going to check against. The relevant code to copy is in > sysconfig

Re: [Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-03 Thread Robert Kern
On Tue, Feb 3, 2009 at 18:34, Brian Granger wrote: >> What is the fix you are thinking of? > > This is how Cython currently handles this logic. This would have to > be modified to include the additional case of a user setting > MACOSX_DEPLOYMENT_TARGET in their environment, but that logic is > al

Re: [Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-03 Thread Brian Granger
> What is the fix you are thinking of? This is how Cython currently handles this logic. This would have to be modified to include the additional case of a user setting MACOSX_DEPLOYMENT_TARGET in their environment, but that logic is already in numpy.distutils.fcompiler.gnu.get_flags_linker_so Th

Re: [Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-03 Thread Robert Kern
On Tue, Feb 3, 2009 at 18:20, Brian Granger wrote: > Robert, > > Thanks. > > Yes, I just saw that this will work. When I fixed this in Cython a > while back this workaround wouldn't work. Would you still consider > this a bug? The logic to fix it is fairly simply. What is the fix you are think

Re: [Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-03 Thread Brian Granger
Robert, Thanks. Yes, I just saw that this will work. When I fixed this in Cython a while back this workaround wouldn't work. Would you still consider this a bug? The logic to fix it is fairly simply. Brian On Tue, Feb 3, 2009 at 4:17 PM, Robert Kern wrote: > On Tue, Feb 3, 2009 at 18:12, Br

Re: [Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-03 Thread Robert Kern
On Tue, Feb 3, 2009 at 18:12, Brian Granger wrote: > I am trying to use numscons to build a project and have run into a > show stopper. I am using: > > OS X 10.5 > The builtin Python 2.5.2 > > Here is what I see upon running python setup.py scons: > > scons: Reading SConscript files ... > Distuti

[Numpy-discussion] numscons/numpy.distutils bug related to MACOSX_DEPLOYMENT_TARGET

2009-02-03 Thread Brian Granger
I am trying to use numscons to build a project and have run into a show stopper. I am using: OS X 10.5 The builtin Python 2.5.2 Here is what I see upon running python setup.py scons: scons: Reading SConscript files ... DistutilsPlatformError: $MACOSX_DEPLOYMENT_TARGET mismatch: now "10.3" but "