Re: [Numpy-discussion] isnan and co: cleaning up

2008-09-15 Thread Andrew Dalke
On Sep 15, 2008, at 5:45 AM, David Cournapeau wrote: > It is not an error for the build, but an error at the configuration > stage. To get some informations about the platform, we do compile some > code snippets, and do our configuration depending on whether they fail > or not. We could log those i

Re: [Numpy-discussion] isnan and co: cleaning up

2008-09-14 Thread Andrew Dalke
The following seems relevant in this thread. On a Mac, OS X 10.4, I just rebuilt from SVN and got compile options: '-Inumpy/core/src -Inumpy/core/include -I/Library/ Frameworks/Python.framework/Versions/2.5/include/python2.5 -c' gcc: _configtest.c _configtest.c: In function 'main': _configtest.c

Re: [Numpy-discussion] isnan and co: cleaning up

2008-09-06 Thread David Cournapeau
On Sat, Sep 6, 2008 at 5:40 PM, David Cournapeau <[EMAIL PROTECTED]> wrote: > Charles R Harris wrote: >> >> >> This one >> Patch available here: http://scipy.org/scipy/numpy/ticket/907 Tested with gcc on mac os X, it also builds with VS 2003

Re: [Numpy-discussion] isnan and co: cleaning up

2008-09-06 Thread David Cournapeau
Charles R Harris wrote: > > > This one > > int main(int argc, char *argv[]) > > { > ... > while (x == y) { > something(); > > somethingelse(); > if (some_error) > do_correct(); > > else >

Re: [Numpy-discussion] isnan and co: cleaning up

2008-09-05 Thread Charles R Harris
On Fri, Sep 5, 2008 at 9:15 PM, David Cournapeau <[EMAIL PROTECTED]> wrote: > On Sat, Sep 6, 2008 at 8:38 AM, Charles R Harris > <[EMAIL PROTECTED]> wrote: > > > > +1, but (putting on pedant hat) I think the functions should be formatted > in > > the way revealed to us by K&R. > > By K&R, you mean

Re: [Numpy-discussion] isnan and co: cleaning up

2008-09-05 Thread David Cournapeau
On Sat, Sep 6, 2008 at 8:38 AM, Charles R Harris <[EMAIL PROTECTED]> wrote: > > +1, but (putting on pedant hat) I think the functions should be formatted in > the way revealed to us by K&R. By K&R, you mean the K&R style, right , not the K&R function declaration style ? :) cheers, David

Re: [Numpy-discussion] isnan and co: cleaning up

2008-09-05 Thread Charles R Harris
On Thu, Sep 4, 2008 at 11:06 PM, David Cournapeau < [EMAIL PROTECTED]> wrote: > Hi, > >While working on my branch to clean the math configuration, I > noticed that the code for isnan and co became quite convoluted. autoconf > info file has a mention of it, and suggests the following for > port

[Numpy-discussion] isnan and co: cleaning up

2008-09-04 Thread David Cournapeau
Hi, While working on my branch to clean the math configuration, I noticed that the code for isnan and co became quite convoluted. autoconf info file has a mention of it, and suggests the following for portability (section 5.5.1 of autoconf): The C99 standard says that `isinf' and `isnan'