Re: [Numpy-discussion] deprecations for 1.6; assert_almost_equal

2011-03-09 Thread Ralf Gommers
On Mon, Mar 7, 2011 at 7:53 PM, Pauli Virtanen wrote: > Mon, 07 Mar 2011 06:39:20 -0500, josef.pktd wrote: Doc update committed in f527b49a. >> Why does assert_allclose have atol=0, while np.allclose has rtol=1.e-5, >> atol=1.e-8 ? > > Probably no reason, it should be fixed. I'm guessing that w

Re: [Numpy-discussion] deprecations for 1.6; assert_almost_equal

2011-03-07 Thread josef . pktd
On Mon, Mar 7, 2011 at 8:37 AM, Pauli Virtanen wrote: > Mon, 07 Mar 2011 08:30:11 -0500, josef.pktd wrote: > [clip] >> assert_approx_equal  checks for signigicant digits in decimal system, >> which looks like it's easy to interpret. > > Ditto for tolerance=1e-7, which has the advantage that it's w

Re: [Numpy-discussion] deprecations for 1.6; assert_almost_equal

2011-03-07 Thread Pauli Virtanen
Mon, 07 Mar 2011 08:30:11 -0500, josef.pktd wrote: [clip] > assert_approx_equal checks for signigicant digits in decimal system, > which looks like it's easy to interpret. Ditto for tolerance=1e-7, which has the advantage that it's what "print abs(desired-actual)" prints. > I don't have much ide

Re: [Numpy-discussion] deprecations for 1.6; assert_almost_equal

2011-03-07 Thread josef . pktd
On Mon, Mar 7, 2011 at 6:53 AM, Pauli Virtanen wrote: > Mon, 07 Mar 2011 06:39:20 -0500, josef.pktd wrote: > [clip] >> Why does assert_allclose have atol=0, while np.allclose has rtol=1.e-5, >> atol=1.e-8 ? > > Probably no reason, it should be fixed. > >> What's the status on np.testing.assert_app

Re: [Numpy-discussion] deprecations for 1.6; assert_almost_equal

2011-03-07 Thread Pauli Virtanen
Mon, 07 Mar 2011 06:39:20 -0500, josef.pktd wrote: [clip] > Why does assert_allclose have atol=0, while np.allclose has rtol=1.e-5, > atol=1.e-8 ? Probably no reason, it should be fixed. > What's the status on np.testing.assert_approx_equal, I would have liked > to use it more often, except it do

Re: [Numpy-discussion] deprecations for 1.6; assert_almost_equal

2011-03-07 Thread josef . pktd
On Mon, Mar 7, 2011 at 4:10 AM, Pauli Virtanen wrote: > Mon, 07 Mar 2011 11:03:17 +0800, Ralf Gommers wrote: > [clip] >> If anyone has new deprecations they want to put in for 1.6, discussing >> them now would be good. I found one item in Trac, #1543. The proposal in >> the ticket is to deprecate

Re: [Numpy-discussion] deprecations for 1.6; assert_almost_equal

2011-03-07 Thread Pauli Virtanen
Mon, 07 Mar 2011 11:03:17 +0800, Ralf Gommers wrote: [clip] > If anyone has new deprecations they want to put in for 1.6, discussing > them now would be good. I found one item in Trac, #1543. The proposal in > the ticket is to deprecate assert_almost_equal because it is quite badly > behaved. This

[Numpy-discussion] deprecations for 1.6; assert_almost_equal

2011-03-06 Thread Ralf Gommers
Hi, I went through the current deprecations, and removed a number of things that have been deprecated for a long time, see https://github.com/rgommers/numpy/commits/deprecations-1.6. I'll commit that unless anyone objects. If anyone has new deprecations they want to put in for 1.6, discussing the