Re: [Numpy-discussion] code review for datetime arange

2011-06-12 Thread Ralf Gommers
On Fri, Jun 10, 2011 at 4:18 PM, Mark Wiebe wrote: > On Fri, Jun 10, 2011 at 12:56 AM, Ralf Gommers < > ralf.gomm...@googlemail.com> wrote: > >> >> Maybe I'm misunderstanding this, and once you make a function work for >> datetime it would also work for other new dtypes. But my impression is that

Re: [Numpy-discussion] code review for datetime arange

2011-06-10 Thread Pierre GM
On Jun 11, 2011, at 12:57 AM, Mark Wiebe wrote: > The other issue is how do you define the np.arange step argument since that > can be in different scales such as month, years, seconds? Can a user specific > days and get half-days (like 1.5 days) or must these be 'integer' days? > > The dateti

Re: [Numpy-discussion] code review for datetime arange

2011-06-10 Thread Mark Wiebe
On Fri, Jun 10, 2011 at 10:03 AM, Bruce Southey wrote: > ** > > > I have following the multiple date/time discussions with some interest as > it is clear there is not 'one way' (perhaps it's Dutch). But, I do keep > coming back to Chris's concepts of time as a strict unit of measure and time >

Re: [Numpy-discussion] code review for datetime arange

2011-06-10 Thread Bruce Southey
On 06/10/2011 09:18 AM, Mark Wiebe wrote: On Fri, Jun 10, 2011 at 12:56 AM, Ralf Gommers mailto:ralf.gomm...@googlemail.com>> wrote: On Fri, Jun 10, 2011 at 1:54 AM, Mark Wiebe mailto:mwwi...@gmail.com>> wrote: On Thu, Jun 9, 2011 at 5:21 PM, Ralf Gommers mailto:ralf.gomm

Re: [Numpy-discussion] code review for datetime arange

2011-06-10 Thread Mark Wiebe
On Fri, Jun 10, 2011 at 12:56 AM, Ralf Gommers wrote: > > > On Fri, Jun 10, 2011 at 1:54 AM, Mark Wiebe wrote: > >> On Thu, Jun 9, 2011 at 5:21 PM, Ralf Gommers > > wrote: >> >>> >>> >>> On Thu, Jun 9, 2011 at 11:54 PM, Mark Wiebe wrote: >>> On Thu, Jun 9, 2011 at 4:27 PM, Ralf Gommers < >>

Re: [Numpy-discussion] code review for datetime arange

2011-06-09 Thread Ralf Gommers
On Fri, Jun 10, 2011 at 1:54 AM, Mark Wiebe wrote: > On Thu, Jun 9, 2011 at 5:21 PM, Ralf Gommers > wrote: > >> >> >> On Thu, Jun 9, 2011 at 11:54 PM, Mark Wiebe wrote: >> >>> On Thu, Jun 9, 2011 at 4:27 PM, Ralf Gommers < >>> ralf.gomm...@googlemail.com> wrote: >>> On Thu, Jun 9

Re: [Numpy-discussion] code review for datetime arange

2011-06-09 Thread Mark Wiebe
On Thu, Jun 9, 2011 at 5:21 PM, Ralf Gommers wrote: > > > On Thu, Jun 9, 2011 at 11:54 PM, Mark Wiebe wrote: > >> On Thu, Jun 9, 2011 at 4:27 PM, Ralf Gommers > > wrote: >> >>> >>> >>> On Thu, Jun 9, 2011 at 10:58 PM, Mark Wiebe wrote: >>> On Thu, Jun 9, 2011 at 3:41 PM, Christopher Barker

Re: [Numpy-discussion] code review for datetime arange

2011-06-09 Thread Mark Wiebe
On Thu, Jun 9, 2011 at 6:28 PM, Robert Kern wrote: > On Thu, Jun 9, 2011 at 16:27, Robert Kern wrote: > > On Thu, Jun 9, 2011 at 15:01, Mark Wiebe wrote: > >> I've replaced the previous two pull requests with a single pull request > >> rolling up all the changes so far. The newest changes inclu

Re: [Numpy-discussion] code review for datetime arange

2011-06-09 Thread Robert Kern
On Thu, Jun 9, 2011 at 16:27, Robert Kern wrote: > On Thu, Jun 9, 2011 at 15:01, Mark Wiebe wrote: >> I've replaced the previous two pull requests with a single pull request >> rolling up all the changes so far. The newest changes include finishing the >> generic unit and np.arange function suppo

Re: [Numpy-discussion] code review for datetime arange

2011-06-09 Thread Ralf Gommers
On Thu, Jun 9, 2011 at 11:54 PM, Mark Wiebe wrote: > On Thu, Jun 9, 2011 at 4:27 PM, Ralf Gommers > wrote: > >> >> >> On Thu, Jun 9, 2011 at 10:58 PM, Mark Wiebe wrote: >> >>> On Thu, Jun 9, 2011 at 3:41 PM, Christopher Barker < >>> chris.bar...@noaa.gov> wrote: >>> >>> Your branch works fine f

Re: [Numpy-discussion] code review for datetime arange

2011-06-09 Thread Charles R Harris
On Thu, Jun 9, 2011 at 3:27 PM, Robert Kern wrote: > On Thu, Jun 9, 2011 at 15:01, Mark Wiebe wrote: > > I've replaced the previous two pull requests with a single pull request > > rolling up all the changes so far. The newest changes include finishing > the > > generic unit and np.arange functi

Re: [Numpy-discussion] code review for datetime arange

2011-06-09 Thread Mark Wiebe
On Thu, Jun 9, 2011 at 4:27 PM, Ralf Gommers wrote: > > > On Thu, Jun 9, 2011 at 10:58 PM, Mark Wiebe wrote: > >> On Thu, Jun 9, 2011 at 3:41 PM, Christopher Barker > > wrote: >> >> Your branch works fine for me (OS X, py2.6), no failures. Only a few > deprecation warnings like: > /Library/Framew

Re: [Numpy-discussion] code review for datetime arange

2011-06-09 Thread Robert Kern
On Thu, Jun 9, 2011 at 15:01, Mark Wiebe wrote: > I've replaced the previous two pull requests with a single pull request > rolling up all the changes so far. The newest changes include finishing the > generic unit and np.arange function support. > https://github.com/numpy/numpy/pull/87 > Because

Re: [Numpy-discussion] code review for datetime arange

2011-06-09 Thread Ralf Gommers
On Thu, Jun 9, 2011 at 10:58 PM, Mark Wiebe wrote: > On Thu, Jun 9, 2011 at 3:41 PM, Christopher Barker > wrote: > > Your branch works fine for me (OS X, py2.6), no failures. Only a few deprecation warnings like: /Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/unittest.py:336: D

Re: [Numpy-discussion] code review for datetime arange

2011-06-09 Thread Mark Wiebe
On Thu, Jun 9, 2011 at 3:41 PM, Christopher Barker wrote: > Mark Wiebe wrote: > > Because of the nature of datetime and timedelta, arange has to be > > slightly different than with all the other types. In particular, for > > datetime the primary signature is np.arange(datetime, datetime, > timed

Re: [Numpy-discussion] code review for datetime arange

2011-06-09 Thread Christopher Barker
Mark Wiebe wrote: > Because of the nature of datetime and timedelta, arange has to be > slightly different than with all the other types. In particular, for > datetime the primary signature is np.arange(datetime, datetime, timedelta). > > I've implemented a simple extension which allows for anot

[Numpy-discussion] code review for datetime arange

2011-06-09 Thread Mark Wiebe
I've replaced the previous two pull requests with a single pull request rolling up all the changes so far. The newest changes include finishing the generic unit and np.arange function support. https://github.com/numpy/numpy/pull/87 Because of the nature of datetime and timedelta, arange has to be