Re: [Numpy-discussion] Test framework changes

2008-06-21 Thread Alan McIntyre
These changes are now checked in, with the changes Robert suggested: numpy.test() returns a TextTestResult object again, and coverage (if enabled) is limited to the package from which test is called. The tests still fail because the buildbots don't have nose installed, though. On Fri, Jun 20, 200

Re: [Numpy-discussion] Test framework changes

2008-06-21 Thread Charles R Harris
On Fri, Jun 20, 2008 at 6:22 PM, Alan McIntyre <[EMAIL PROTECTED]> wrote: > On Fri, Jun 20, 2008 at 7:22 PM, Fernando Perez <[EMAIL PROTECTED]> > wrote: > > It may be worth bringing it up wtih the nose guys here: > > > > http://lists.idyll.org/listinfo/testing-in-python > > > > The nose author see

Re: [Numpy-discussion] Test framework changes

2008-06-20 Thread Alan McIntyre
On Fri, Jun 20, 2008 at 7:22 PM, Fernando Perez <[EMAIL PROTECTED]> wrote: > It may be worth bringing it up wtih the nose guys here: > > http://lists.idyll.org/listinfo/testing-in-python > > The nose author seems very responsive, and Titus Brown is on the list > and cares a lot about numpy/scipy, a

Re: [Numpy-discussion] Test framework changes

2008-06-20 Thread Fernando Perez
On Fri, Jun 20, 2008 at 3:04 PM, Alan McIntyre <[EMAIL PROTECTED]> wrote: > On Fri, Jun 20, 2008 at 5:35 PM, Robert Kern <[EMAIL PROTECTED]> wrote: >> So NoseTester.run() basically just calls nose.run(). That basically >> just instantiates nose.core.TestProgram and returns the .success >> attribute

Re: [Numpy-discussion] Test framework changes

2008-06-20 Thread Alan McIntyre
On Fri, Jun 20, 2008 at 5:35 PM, Robert Kern <[EMAIL PROTECTED]> wrote: > So NoseTester.run() basically just calls nose.run(). That basically > just instantiates nose.core.TestProgram and returns the .success > attribute of it. Unfortunately, the TextTestResults object (a nose > subclass of unittes

Re: [Numpy-discussion] Test framework changes

2008-06-20 Thread Robert Kern
On Fri, Jun 20, 2008 at 16:01, Alan McIntyre <[EMAIL PROTECTED]> wrote: > - numpy.test now returns an object with a wasSuccessful method; under > the old test framework it returned a unittest._TextTestResult, but > since nose.run only returns success/failure, I'm just wrapping this > result in a d

[Numpy-discussion] Test framework changes

2008-06-20 Thread Alan McIntyre
Hi all, Just wanted to get feedback about the following changes before I make them. Please speak up if any of this seems objectionable to you. - The old test framework classes will be restored, but will not be used anywhere in NumPy's tests. If your old tests still don't work with the restored