Re: [Numpy-discussion] Separating out the maskna code

2012-05-22 Thread Nathaniel Smith
On Tue, May 22, 2012 at 5:34 AM, Travis Oliphant wrote: > Just to be clear.   Are we waiting for the conclusion of the PyArray_Diagonal > PR before proceeding with this one? We can talk about this one and everyone's welcome to look at the patch, of course. (In fact it'd be useful if anyone catch

Re: [Numpy-discussion] Separating out the maskna code

2012-05-21 Thread Travis Oliphant
Just to be clear. Are we waiting for the conclusion of the PyArray_Diagonal PR before proceeding with this one? -Travis On May 20, 2012, at 1:06 PM, Nathaniel Smith wrote: > On Sun, May 20, 2012 at 6:59 PM, Nathaniel Smith wrote: >>> I have not reviewed it in detail, but in general I would

Re: [Numpy-discussion] Separating out the maskna code

2012-05-20 Thread Nathaniel Smith
On Sun, May 20, 2012 at 6:59 PM, Nathaniel Smith wrote: >> I have not reviewed it in detail, but in general I would be very supportive >> of your plan to commit this to master, make a 1.7 release (without the >> ReduceWrapper) function and then work on the masked array / ndarray >> separation p

Re: [Numpy-discussion] Separating out the maskna code

2012-05-20 Thread Nathaniel Smith
On Sun, May 20, 2012 at 11:35 AM, Ralf Gommers wrote: > > > On Sat, May 19, 2012 at 10:54 PM, Nathaniel Smith wrote: >> >> >> Ralf, IIUC merging this and my other outstanding PRs would leave the >> datetime issues on python3/win32 as the only outstanding blocker? > > > Yes. There are some more op

Re: [Numpy-discussion] Separating out the maskna code

2012-05-20 Thread Nathaniel Smith
On Sun, May 20, 2012 at 6:08 AM, Travis Oliphant wrote: > Wow, Nathaniel.   This looks like a nice piece of tedious work. Honestly, it only took a few hours -- M-x grep is awesome. Would still have been better if it'd been separated in the first place, but so it goes. > I have not reviewed it in

Re: [Numpy-discussion] Separating out the maskna code

2012-05-20 Thread Ralf Gommers
On Sat, May 19, 2012 at 10:54 PM, Nathaniel Smith wrote: > > Ralf, IIUC merging this and my other outstanding PRs would leave the > datetime issues on python3/win32 as the only outstanding blocker? > Yes. There are some more open tickets for 1.7 (see http://projects.scipy.org/numpy/report/3), bu

Re: [Numpy-discussion] Separating out the maskna code

2012-05-19 Thread Travis Oliphant
Wow, Nathaniel. This looks like a nice piece of tedious work. I have not reviewed it in detail, but in general I would be very supportive of your plan to commit this to master, make a 1.7 release (without the ReduceWrapper) function and then work on the masked array / ndarray separation pl

[Numpy-discussion] Separating out the maskna code

2012-05-19 Thread Nathaniel Smith
Hi all, Since Mark's original missingdata branch made so many changes, I figured it would be a useful exercise to figure out what code in master is actually related to masked arrays, and which isn't. The easiest way seemed to be to delete the new fields, then keep removing any code that depended o