Re: [Numpy-discussion] Review of issue 825

2008-06-26 Thread Neil Muller
On Thu, Jun 26, 2008 at 7:25 AM, Charles R Harris <[EMAIL PROTECTED]> wrote: > Etch has a problem with memmap.roundtrip > while Lenny does fine, but that looks to be some other problem. Indeed - I see this is already filed as #828. I'll look at this and add any comments to that ticket. -- Neil

Re: [Numpy-discussion] Review of issue 825

2008-06-26 Thread Travis E. Oliphant
Charles R Harris wrote: > > > On Wed, Jun 25, 2008 at 2:04 PM, Neil Muller > <[EMAIL PROTECTED] > wrote: > > On Wed, Jun 25, 2008 at 7:53 PM, Charles R Harris > <[EMAIL PROTECTED] > wrote: > > But I wonder if this case isn't supposed

Re: [Numpy-discussion] Review of issue 825

2008-06-25 Thread Charles R Harris
On Wed, Jun 25, 2008 at 9:13 PM, Charles R Harris <[EMAIL PROTECTED]> wrote: > > > On Wed, Jun 25, 2008 at 8:42 PM, Charles R Harris < > [EMAIL PROTECTED]> wrote: > >> Hi Neil, >> >> On Wed, Jun 25, 2008 at 2:26 PM, Neil Muller <[EMAIL PROTECTED]<[EMAIL >> PROTECTED]>> >> wrote: >> >>> On Wed, Ju

Re: [Numpy-discussion] Review of issue 825

2008-06-25 Thread Charles R Harris
On Wed, Jun 25, 2008 at 8:42 PM, Charles R Harris <[EMAIL PROTECTED]> wrote: > Hi Neil, > > On Wed, Jun 25, 2008 at 2:26 PM, Neil Muller <[EMAIL PROTECTED]<[EMAIL > PROTECTED]>> > wrote: > >> On Wed, Jun 25, 2008 at 8:46 PM, Charles R Harris >> <[EMAIL PROTECTED]> wrote: >> > >> > >> > Looks to m

Re: [Numpy-discussion] Review of issue 825

2008-06-25 Thread Charles R Harris
Hi Neil, On Wed, Jun 25, 2008 at 2:26 PM, Neil Muller <[EMAIL PROTECTED]<[EMAIL PROTECTED]>> wrote: > On Wed, Jun 25, 2008 at 8:46 PM, Charles R Harris > <[EMAIL PROTECTED]> wrote: > > > > > > Looks to me like the NPY_ALIGNED flag is incorrectly set. Can you check > > this by printing the result

Re: [Numpy-discussion] Review of issue 825

2008-06-25 Thread Charles R Harris
On Wed, Jun 25, 2008 at 2:04 PM, Neil Muller <[EMAIL PROTECTED]<[EMAIL PROTECTED]>> wrote: > On Wed, Jun 25, 2008 at 7:53 PM, Charles R Harris > <[EMAIL PROTECTED]> wrote: > > But I wonder if this case isn't supposed to be caught by this > > fragment: > > > > if (!PyArray_ISBEHAVED(ap)) { > >

Re: [Numpy-discussion] Review of issue 825

2008-06-25 Thread Charles R Harris
On Wed, Jun 25, 2008 at 10:49 AM, Neil Muller <[EMAIL PROTECTED]<[EMAIL PROTECTED]>> wrote: > On Wed, Jun 25, 2008 at 5:14 PM, Charles R Harris > <[EMAIL PROTECTED]> wrote: > > OK, the problem in the UNICODE_{get,set}item routines is converting > between > > ucs4 and the encoding python is using,

Re: [Numpy-discussion] Review of issue 825

2008-06-25 Thread Neil Muller
On Wed, Jun 25, 2008 at 8:46 PM, Charles R Harris <[EMAIL PROTECTED]> wrote: > > > Looks to me like the NPY_ALIGNED flag is incorrectly set. Can you check > this by printing the results of > > PyArray_CHKFLAGS(ap, NPY_ALIGNED) For the test listed in the ticket, the array isn't flagged as aligned

Re: [Numpy-discussion] Review of issue 825

2008-06-25 Thread Neil Muller
On Wed, Jun 25, 2008 at 7:53 PM, Charles R Harris <[EMAIL PROTECTED]> wrote: > But I wonder if this case isn't supposed to be caught by this > fragment: > > if (!PyArray_ISBEHAVED(ap)) { > buffer = _pya_malloc(mysize << 2); > if (buffer == NULL) > return PyErr_NoMemo

Re: [Numpy-discussion] Review of issue 825

2008-06-25 Thread Charles R Harris
On Wed, Jun 25, 2008 at 11:53 AM, Charles R Harris < [EMAIL PROTECTED]> wrote: > > > On Wed, Jun 25, 2008 at 10:49 AM, Neil Muller <[EMAIL PROTECTED]<[EMAIL > PROTECTED]>> > wrote: > >> On Wed, Jun 25, 2008 at 5:14 PM, Charles R Harris >> <[EMAIL PROTECTED]> wrote: >> > OK, the problem in the UNI

Re: [Numpy-discussion] Review of issue 825

2008-06-25 Thread Charles R Harris
On Wed, Jun 25, 2008 at 10:49 AM, Neil Muller <[EMAIL PROTECTED]<[EMAIL PROTECTED]>> wrote: > On Wed, Jun 25, 2008 at 5:14 PM, Charles R Harris > <[EMAIL PROTECTED]> wrote: > > OK, the problem in the UNICODE_{get,set}item routines is converting > between > > ucs4 and the encoding python is using,

Re: [Numpy-discussion] Review of issue 825

2008-06-25 Thread Neil Muller
On Wed, Jun 25, 2008 at 5:14 PM, Charles R Harris <[EMAIL PROTECTED]> wrote: > OK, the problem in the UNICODE_{get,set}item routines is converting between > ucs4 and the encoding python is using, which may be ucs2. But there is > something strange if sparc is using ucs4 (Py_UNICODE_WIDE) and the p

Re: [Numpy-discussion] Review of issue 825

2008-06-25 Thread Charles R Harris
On Wed, Jun 25, 2008 at 8:17 AM, Charles R Harris <[EMAIL PROTECTED]> wrote: > > > On Wed, Jun 25, 2008 at 8:12 AM, Charles R Harris < > [EMAIL PROTECTED]> wrote: > >> >> >> On Wed, Jun 25, 2008 at 12:44 AM, Neil Muller <[EMAIL PROTECTED]<[EMAIL >> PROTECTED]>> >> wrote: >> >>> Could someone revi

Re: [Numpy-discussion] Review of issue 825

2008-06-25 Thread Charles R Harris
On Wed, Jun 25, 2008 at 8:12 AM, Charles R Harris <[EMAIL PROTECTED]> wrote: > > > On Wed, Jun 25, 2008 at 12:44 AM, Neil Muller <[EMAIL PROTECTED]<[EMAIL > PROTECTED]>> > wrote: > >> Could someone review the patch at >> http://scipy.org/scipy/numpy/ticket/825, please? >> >> The issue prevents th

Re: [Numpy-discussion] Review of issue 825

2008-06-25 Thread Charles R Harris
On Wed, Jun 25, 2008 at 12:44 AM, Neil Muller <[EMAIL PROTECTED]<[EMAIL PROTECTED]>> wrote: > Could someone review the patch at > http://scipy.org/scipy/numpy/ticket/825, please? > > The issue prevents the test suite running successfully on Sparc, so > I'd like to see it fixed. > Looks like the c

[Numpy-discussion] Review of issue 825

2008-06-24 Thread Neil Muller
Could someone review the patch at http://scipy.org/scipy/numpy/ticket/825, please? The issue prevents the test suite running successfully on Sparc, so I'd like to see it fixed. -- Neil Muller [EMAIL PROTECTED] ___ Numpy-discussion mailing list Numpy-di