Re: [Numpy-discussion] Nanmean review

2013-08-11 Thread Arnaldo Russo
Congratulations!! I have been waiting for a long time to see a nanmean function inside numpy. I never looked inside this function, but I'm happy seeing this discussion on github! Cheers, Arnaldo. --- *Arnaldo D'Amaral Pereira Granja Russo* Lab. de Estudos dos Oceanos e Clima Instituto de Oc

Re: [Numpy-discussion] Nanmean review

2013-08-10 Thread Ralf Gommers
On Sat, Aug 10, 2013 at 12:48 AM, David Reed wrote: > > Hello, > > This is my first time contributing and I was hoping to get a review of a > change I made. Here is the comparison link. > > https://github.com/dvreed77/numpy/compare/nanmean > Hi David, your contribution looks good and adding nan

[Numpy-discussion] Nanmean review

2013-08-09 Thread David Reed
Hello, This is my first time contributing and I was hoping to get a review of a change I made. Here is the comparison link. https://github.com/dvreed77/numpy/compare/nanmean ___ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.s