Re: [Numpy-discussion] NEP for faster ufuncs

2011-01-06 Thread Francesc Alted
2011/1/5, Mark Wiebe : > On Wed, Jan 5, 2011 at 4:26 AM, Francesc Alted wrote: > >> Sorry for the naive question, but I use the numpy.fromiter() iterator >> quite a few in my projects. and I'm curious on whether this new >> iterator would allow numpy.fromiter() to go faster (I mean, in Python >> s

Re: [Numpy-discussion] NEP for faster ufuncs

2011-01-05 Thread Mark Wiebe
On Wed, Jan 5, 2011 at 4:26 AM, Francesc Alted wrote: > Sorry for the naive question, but I use the numpy.fromiter() iterator > quite a few in my projects. and I'm curious on whether this new > iterator would allow numpy.fromiter() to go faster (I mean, in Python > space). Any hint? > The new i

Re: [Numpy-discussion] NEP for faster ufuncs

2011-01-05 Thread Francesc Alted
2011/1/4, Mark Wiebe : >> To get a deeper understanding of the code, I am starting to implement >> several benchmarks to compare old and new iterator - do you already >> have some of them handy ? >> > > So far I've just done timing with the Python exposure, C-based benchmarking > is welcome. Where

Re: [Numpy-discussion] NEP for faster ufuncs

2011-01-04 Thread Mark Wiebe
On Tue, Jan 4, 2011 at 4:34 AM, David Cournapeau wrote: > > Ok, I took some time to look into it, but I am far from understanding > everything yet. I will need more time. > Yeah, it ended up being pretty large. I think the UFunc code will shrink substantially when it uses this iterator, which i

Re: [Numpy-discussion] NEP for faster ufuncs

2011-01-04 Thread David Cournapeau
On Wed, Dec 22, 2010 at 11:20 AM, Mark Wiebe wrote: > On Tue, Dec 21, 2010 at 6:06 PM, David wrote: >> >> >> >> This looks pretty cool. I hope to be able to take a look at it during >> the christmas holidays. > > Thanks! Ok, I took some time to look into it, but I am far from understanding ever

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-23 Thread Travis Oliphant
This is very cool! I would like to see this get into NumPy 2.0. Thanks for all the great work! -Travis On Dec 21, 2010, at 6:53 PM, Mark Wiebe wrote: > Hello NumPy-ers, > > After some performance analysis, I've designed and implemented a new iterator > designed to speed up ufuncs and a

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Francesc Alted
A Wednesday 22 December 2010 22:02:03 Mark Wiebe escrigué: > On Wed, Dec 22, 2010 at 12:42 PM, Mark Wiebe > wrote: > > > I think numexpr could get a nice boost from using the new iterator > > internally though > > There's actually a trivial way to do this with very minimal changes > to numexpr

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Mark Wiebe
On Wed, Dec 22, 2010 at 12:42 PM, Mark Wiebe wrote: > I think numexpr could get a nice boost from using the new iterator > internally though > There's actually a trivial way to do this with very minimal changes to numexpr - the 'itview' mechanism. Create the new iterator, call NpyIter_GetIterVi

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Mark Wiebe
On Wed, Dec 22, 2010 at 12:05 PM, Francesc Alted wrote: > > > Ah, things go well now: > > >>> timeit 3*a+b-(a/c) > 10 loops, best of 3: 67.7 ms per loop > >>> timeit luf(lambda a,b,c:3*a+b-(a/c), a, b, c) > 10 loops, best of 3: 27.8 ms per loop > >>> timeit ne.evaluate("3*a+b-(a/c)") > 10 loops,

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Francesc Alted
A Wednesday 22 December 2010 20:42:54 Mark Wiebe escrigué: > On Wed, Dec 22, 2010 at 11:16 AM, Francesc Alted wrote: > > A Wednesday 22 December 2010 19:52:45 Mark Wiebe escrigué: > > > On Wed, Dec 22, 2010 at 10:41 AM, Francesc Alted > > > > wrote: > > > > NumPy version 2.0.0.dev-147f817 > > >

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Mark Wiebe
On Wed, Dec 22, 2010 at 11:16 AM, Francesc Alted wrote: > A Wednesday 22 December 2010 19:52:45 Mark Wiebe escrigué: > > On Wed, Dec 22, 2010 at 10:41 AM, Francesc Alted > wrote: > > > NumPy version 2.0.0.dev-147f817 > > > > There's your problem, it looks like the PYTHONPATH isn't seeing your > >

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Francesc Alted
A Wednesday 22 December 2010 19:52:45 Mark Wiebe escrigué: > On Wed, Dec 22, 2010 at 10:41 AM, Francesc Alted wrote: > > NumPy version 2.0.0.dev-147f817 > > There's your problem, it looks like the PYTHONPATH isn't seeing your > new build for some reason. That build is off of this commit in the >

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Mark Wiebe
On Wed, Dec 22, 2010 at 10:41 AM, Francesc Alted wrote: > NumPy version 2.0.0.dev-147f817 > There's your problem, it looks like the PYTHONPATH isn't seeing your new build for some reason. That build is off of this commit in the NumPy master branch: https://github.com/numpy/numpy/commit/147f817e

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Francesc Alted
A Wednesday 22 December 2010 18:21:28 Mark Wiebe escrigué: > On Wed, Dec 22, 2010 at 9:07 AM, Francesc Alted wrote: > > A Wednesday 22 December 2010 17:25:13 Mark Wiebe escrigué: > > > Can you print out your np.__version__, and try running the tests? > > > If newiter didn't build for some reason

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Mark Wiebe
On Wed, Dec 22, 2010 at 9:07 AM, Francesc Alted wrote: > A Wednesday 22 December 2010 17:25:13 Mark Wiebe escrigué: > > Can you print out your np.__version__, and try running the tests? If > > newiter didn't build for some reason, its tests should be throwing a > > bunch of exceptions. > > I'm a

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Francesc Alted
A Wednesday 22 December 2010 17:25:13 Mark Wiebe escrigué: > Can you print out your np.__version__, and try running the tests? If > newiter didn't build for some reason, its tests should be throwing a > bunch of exceptions. I'm a bit swamped now. Let's see if I can do that later on. > > I see :

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Mark Wiebe
On Wed, Dec 22, 2010 at 12:54 AM, Francesc Alted wrote: > A Wednesday 22 December 2010 09:48:03 Mark Wiebe escrigué: > > On Wed, Dec 22, 2010 at 12:21 AM, Francesc Alted > wrote: > > > > > > new_iterator branch does not work for me; it gives me an error > > > like: AttributeError: 'module' objec

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Mark Wiebe
On Tue, Dec 21, 2010 at 10:05 PM, Charles R Harris < charlesr.har...@gmail.com> wrote: > > Wow, that's a really nice design and write up. Small typo: > > /* Only allow exactly equivalent types */ > NPY_NO_CASTING=0, > /* Allow casts between equivalent types of different by

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Francesc Alted
A Wednesday 22 December 2010 09:48:03 Mark Wiebe escrigué: > On Wed, Dec 22, 2010 at 12:21 AM, Francesc Alted wrote: > > > > Wow, really nice work! It would be great if that could make into > > NumPy > > > > :-) Regarding your comment on numexpr being faster, I'm not sure > > :(your > > > > n

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Mark Wiebe
On Wed, Dec 22, 2010 at 12:21 AM, Francesc Alted wrote: > > Wow, really nice work! It would be great if that could make into NumPy > :-) Regarding your comment on numexpr being faster, I'm not sure (your > new_iterator branch does not work for me; it gives me an error like: > AttributeError: 'm

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-22 Thread Francesc Alted
A Wednesday 22 December 2010 01:53:55 Mark Wiebe escrigué: > Hello NumPy-ers, > > After some performance analysis, I've designed and implemented a new > iterator designed to speed up ufuncs and allow for easier > multi-dimensional iteration. The new code is fairly large, but > works quite well al

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-21 Thread Charles R Harris
On Tue, Dec 21, 2010 at 5:53 PM, Mark Wiebe wrote: > Hello NumPy-ers, > > After some performance analysis, I've designed and implemented a new > iterator designed to speed up ufuncs and allow for easier multi-dimensional > iteration. The new code is fairly large, but works quite well already. I

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-21 Thread Mark Wiebe
On Tue, Dec 21, 2010 at 6:06 PM, David wrote: > > This looks pretty cool. I hope to be able to take a look at it during > the christmas holidays. > Thanks! > > I cannot comment in details yet, but it seems to address several issues > I encountered myself while implementing the neighborhood iter

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-21 Thread Mark Wiebe
That's a good suggestion - added. Unfortunately, it looks like the github rst converter doesn't make a table of contents with working links. Cheers, Mark On Tue, Dec 21, 2010 at 6:00 PM, John Salvatier wrote: > I applaud you on your vision. I only have one small suggestion: I suggest > you put

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-21 Thread David
Hi Mark, On 12/22/2010 09:53 AM, Mark Wiebe wrote: > Hello NumPy-ers, > > After some performance analysis, I've designed and implemented a new > iterator designed to speed up ufuncs and allow for easier > multi-dimensional iteration. The new code is fairly large, but works > quite well already.

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-21 Thread John Salvatier
I applaud you on your vision. I only have one small suggestion: I suggest you put a table of contents at the beginning of your NEP so people may skip to the part that most interests them. On Tue, Dec 21, 2010 at 4:59 PM, John Salvatier wrote: > That is an amazing christmas present. > > On Tue, De

Re: [Numpy-discussion] NEP for faster ufuncs

2010-12-21 Thread John Salvatier
That is an amazing christmas present. On Tue, Dec 21, 2010 at 4:53 PM, Mark Wiebe wrote: > Hello NumPy-ers, > > After some performance analysis, I've designed and implemented a new > iterator designed to speed up ufuncs and allow for easier multi-dimensional > iteration. The new code is fairly

[Numpy-discussion] NEP for faster ufuncs

2010-12-21 Thread Mark Wiebe
Hello NumPy-ers, After some performance analysis, I've designed and implemented a new iterator designed to speed up ufuncs and allow for easier multi-dimensional iteration. The new code is fairly large, but works quite well already. If some people could read the NEP and give some feedback, that