Re: [Numpy-discussion] Fixing #736 and possible memory leak

2008-04-25 Thread Charles R Harris
On Fri, Apr 25, 2008 at 8:27 AM, Travis E. Oliphant <[EMAIL PROTECTED]> wrote: > > > > > So on and so forth. The problem is this bit of code (among others) > > > > stop_at_string = ((type == PyArray_OBJECT) || > > (type == PyArray_STRING && > >type

Re: [Numpy-discussion] Fixing #736 and possible memory leak

2008-04-25 Thread Travis E. Oliphant
> > So on and so forth. The problem is this bit of code (among others) > > stop_at_string = ((type == PyArray_OBJECT) || > (type == PyArray_STRING && >typecode->type == PyArray_STRINGLTR) || > (type == PyArray_UNICODE) || >

Re: [Numpy-discussion] Fixing #736 and possible memory leak

2008-04-24 Thread Charles R Harris
On Thu, Apr 24, 2008 at 5:58 PM, Robert Kern <[EMAIL PROTECTED]> wrote: > On Thu, Apr 24, 2008 at 5:37 PM, Charles R Harris > <[EMAIL PROTECTED]> wrote: > > Hi, > > > > I've been looking into ticket #736 and playing with some things. In > > arrayobject.c starting at line 8534 I added a check for s

Re: [Numpy-discussion] Fixing #736 and possible memory leak

2008-04-24 Thread Charles R Harris
On Thu, Apr 24, 2008 at 7:11 PM, Charles R Harris <[EMAIL PROTECTED]> wrote: > > > On Thu, Apr 24, 2008 at 5:58 PM, Robert Kern <[EMAIL PROTECTED]> > wrote: > >> On Thu, Apr 24, 2008 at 5:37 PM, Charles R Harris >> <[EMAIL PROTECTED]> wrote: >> > Hi, >> > >> > I've been looking into ticket #736 an

Re: [Numpy-discussion] Fixing #736 and possible memory leak

2008-04-24 Thread Charles R Harris
On Thu, Apr 24, 2008 at 5:58 PM, Robert Kern <[EMAIL PROTECTED]> wrote: > On Thu, Apr 24, 2008 at 5:37 PM, Charles R Harris > <[EMAIL PROTECTED]> wrote: > > Hi, > > > > I've been looking into ticket #736 and playing with some things. In > > arrayobject.c starting at line 8534 I added a check for s

Re: [Numpy-discussion] Fixing #736 and possible memory leak

2008-04-24 Thread Robert Kern
On Thu, Apr 24, 2008 at 5:37 PM, Charles R Harris <[EMAIL PROTECTED]> wrote: > Hi, > > I've been looking into ticket #736 and playing with some things. In > arrayobject.c starting at line 8534 I added a check for strings. > > if (PyString_Check(op)) { > r = Array_FromPyScalar(op

[Numpy-discussion] Fixing #736 and possible memory leak

2008-04-24 Thread Charles R Harris
Hi, I've been looking into ticket #736 and playing with some things. In arrayobject.c starting at line 8534 I added a check for strings. if (PyString_Check(op)) { r = Array_FromPyScalar(op, newtype); } if (PySequence_Check(op)) { PyObject *thiserr =