Re: [Numpy-discussion] Doctest items

2008-07-02 Thread Alan McIntyre
On Wed, Jul 2, 2008 at 5:47 PM, Stéfan van der Walt <[EMAIL PROTECTED]> wrote: > How about a slight modification to Fernando's idea: a dummy function that > > a) Does nothing if matplotlib is not installed > b) Otherwise passes through calls to matplotlib, after setting the > backend to /dev/null.

Re: [Numpy-discussion] Doctest items

2008-07-02 Thread Stéfan van der Walt
2008/7/2 Ryan May <[EMAIL PROTECTED]>: >> To be clear, these aren't tests of the numpy code. The tests would be >> to make sure the examples still run. >> > Right. I just don't think effort should be put into making examples > using matplotlib run as doctests. If the behavior is important, numpy

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Ryan May
Robert Kern wrote: > On Tue, Jul 1, 2008 at 19:19, Ryan May <[EMAIL PROTECTED]> wrote: >> Robert Kern wrote: >>> On Tue, Jul 1, 2008 at 17:50, Fernando Perez <[EMAIL PROTECTED]> wrote: On Tue, Jul 1, 2008 at 1:41 PM, Pauli Virtanen <[EMAIL PROTECTED]> wrote: > But it's a custom tweak

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Robert Kern
On Tue, Jul 1, 2008 at 19:19, Ryan May <[EMAIL PROTECTED]> wrote: > Robert Kern wrote: >> On Tue, Jul 1, 2008 at 17:50, Fernando Perez <[EMAIL PROTECTED]> wrote: >>> On Tue, Jul 1, 2008 at 1:41 PM, Pauli Virtanen <[EMAIL PROTECTED]> wrote: >>> But it's a custom tweak to doctest, so it might br

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Alan McIntyre
On Tue, Jul 1, 2008 at 4:41 PM, Pauli Virtanen <[EMAIL PROTECTED]> wrote: > All in all, I'd estimate this to be ~100 lines, put in a suitable > location. > > If possible, I'd like other possibilities be considered first before > jumping this route. I think it would be nice to retain the ability to

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Ryan May
Robert Kern wrote: > On Tue, Jul 1, 2008 at 17:50, Fernando Perez <[EMAIL PROTECTED]> wrote: >> On Tue, Jul 1, 2008 at 1:41 PM, Pauli Virtanen <[EMAIL PROTECTED]> wrote: >> >>> But it's a custom tweak to doctest, so it might break at some point in >>> the future, and I don't love the monkeypatching

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Robert Kern
On Tue, Jul 1, 2008 at 17:50, Fernando Perez <[EMAIL PROTECTED]> wrote: > On Tue, Jul 1, 2008 at 1:41 PM, Pauli Virtanen <[EMAIL PROTECTED]> wrote: > >> But it's a custom tweak to doctest, so it might break at some point in >> the future, and I don't love the monkeypatching here... > > Welcome to t

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Fernando Perez
On Tue, Jul 1, 2008 at 4:03 PM, Charles R Harris <[EMAIL PROTECTED]> wrote: > That was my thought, but Robert didn't like it. Mmh, ok, sorry that I'd missed the original. Cheers, f ___ Numpy-discussion mailing list Numpy-discussion@scipy.org http://p

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Charles R Harris
On Tue, Jul 1, 2008 at 4:50 PM, Fernando Perez <[EMAIL PROTECTED]> wrote: > On Tue, Jul 1, 2008 at 1:41 PM, Pauli Virtanen <[EMAIL PROTECTED]> wrote: > > > But it's a custom tweak to doctest, so it might break at some point in > > the future, and I don't love the monkeypatching here... > > Welcome

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Fernando Perez
On Tue, Jul 1, 2008 at 1:41 PM, Pauli Virtanen <[EMAIL PROTECTED]> wrote: > But it's a custom tweak to doctest, so it might break at some point in > the future, and I don't love the monkeypatching here... Welcome to the joys of extending doctest/unittest. They hardcoded so much stuff in there th

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Pauli Virtanen
Tue, 01 Jul 2008 15:30:47 -0400, Alan McIntyre wrote: > On Tue, Jul 1, 2008 at 3:20 PM, Robert Kern <[EMAIL PROTECTED]> > wrote: >> Can it work on an entire section? If not, can we do something that >> works on a whole section? Everything after "Plot the window and its >> frequency response:" is n

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Robert Kern
On Tue, Jul 1, 2008 at 14:39, Charles R Harris <[EMAIL PROTECTED]> wrote: > > On Tue, Jul 1, 2008 at 1:30 PM, Alan McIntyre <[EMAIL PROTECTED]> > wrote: >> >> On Tue, Jul 1, 2008 at 3:20 PM, Robert Kern <[EMAIL PROTECTED]> wrote: >> > Can it work on an entire section? If not, can we do something th

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Alan McIntyre
On Tue, Jul 1, 2008 at 3:33 PM, Robert Kern <[EMAIL PROTECTED]> wrote: > That's not a bad idea. Coordinate with Stéfan about the details (if > any are left to be decided). Ok, will do. I'll also update all the test documentation I can find so that documenters have a chance of being aware of the d

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Alan McIntyre
On Tue, Jul 1, 2008 at 3:39 PM, Charles R Harris <[EMAIL PROTECTED]> wrote: >> We could always just make the plotting section one of those "it's just >> an example not a doctest" things and remove the ">>>" (since it >> doesn't appear to provide any useful test coverage or anything). > > Would it s

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Charles R Harris
On Tue, Jul 1, 2008 at 1:30 PM, Alan McIntyre <[EMAIL PROTECTED]> wrote: > On Tue, Jul 1, 2008 at 3:20 PM, Robert Kern <[EMAIL PROTECTED]> wrote: > > Can it work on an entire section? If not, can we do something that > > works on a whole section? Everything after "Plot the window and its > > frequ

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Robert Kern
On Tue, Jul 1, 2008 at 14:30, Alan McIntyre <[EMAIL PROTECTED]> wrote: > On Tue, Jul 1, 2008 at 3:20 PM, Robert Kern <[EMAIL PROTECTED]> wrote: >> Can it work on an entire section? If not, can we do something that >> works on a whole section? Everything after "Plot the window and its >> frequency r

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Alan McIntyre
On Tue, Jul 1, 2008 at 3:20 PM, Robert Kern <[EMAIL PROTECTED]> wrote: > Can it work on an entire section? If not, can we do something that > works on a whole section? Everything after "Plot the window and its > frequency response:" is not required for testing. It's on a per-line basis at the mome

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Robert Kern
On Tue, Jul 1, 2008 at 14:14, Alan McIntyre <[EMAIL PROTECTED]> wrote: > On Tue, Jul 1, 2008 at 2:45 PM, Robert Kern <[EMAIL PROTECTED]> wrote: >>> If the >>> auto-ignore capability is still needed after that, I'll work on it. >> >> It seems to me that the ellipsis mechanism just allows the output

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Alan McIntyre
On Tue, Jul 1, 2008 at 2:45 PM, Robert Kern <[EMAIL PROTECTED]> wrote: >> If the >> auto-ignore capability is still needed after that, I'll work on it. > > It seems to me that the ellipsis mechanism just allows the output to > differ. However, matplotlib would still be required because plt.plot() >

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Robert Kern
On Tue, Jul 1, 2008 at 12:56, Alan McIntyre <[EMAIL PROTECTED]> wrote: > Just a few questions/comments about doctests: > > 1. Should all doctests be written such that you could start Python, do > an "import numpy as np", and then type in the examples verbatim? There > are a number that currently wo

Re: [Numpy-discussion] Doctest items

2008-07-01 Thread Charles R Harris
On Tue, Jul 1, 2008 at 11:56 AM, Alan McIntyre <[EMAIL PROTECTED]> wrote: > Just a few questions/comments about doctests: > > 1. Should all doctests be written such that you could start Python, do > an "import numpy as np", and then type in the examples verbatim? There > are a number that currentl

[Numpy-discussion] Doctest items

2008-07-01 Thread Alan McIntyre
Just a few questions/comments about doctests: 1. Should all doctests be written such that you could start Python, do an "import numpy as np", and then type in the examples verbatim? There are a number that currently wouldn't work that way (they depend on the function under test being in the local