Re: [Numpy-discussion] [pydata] Re: [SciPy-Dev] 1.8.0rc1

2013-10-01 Thread Nathaniel Smith
On Tue, Oct 1, 2013 at 3:13 PM, Charles R Harris wrote: > > > > On Tue, Oct 1, 2013 at 7:58 AM, Nathaniel Smith wrote: >> >> I bet the difference is: >> >> In master, nansum ultimately calls arr.sum(...), which will be >> intercepted by Series.sum. >> >> In 1.8.x, nansum ultimately calls np.add.r

Re: [Numpy-discussion] [pydata] Re: [SciPy-Dev] 1.8.0rc1

2013-10-01 Thread Charles R Harris
On Tue, Oct 1, 2013 at 7:58 AM, Nathaniel Smith wrote: > I bet the difference is: > > In master, nansum ultimately calls arr.sum(...), which will be > intercepted by Series.sum. > > In 1.8.x, nansum ultimately calls np.add.reduce(...), which can't be > intercepted and will return the wrong thing.

Re: [Numpy-discussion] [pydata] Re: [SciPy-Dev] 1.8.0rc1

2013-10-01 Thread Nathaniel Smith
I bet the difference is: In master, nansum ultimately calls arr.sum(...), which will be intercepted by Series.sum. In 1.8.x, nansum ultimately calls np.add.reduce(...), which can't be intercepted and will return the wrong thing. AFAICT the np.add.reduce(a, ...) call could just be replaced with a

Re: [Numpy-discussion] [pydata] Re: [SciPy-Dev] 1.8.0rc1

2013-10-01 Thread Nathaniel Smith
On Tue, Oct 1, 2013 at 2:39 PM, Jeff wrote: > Just built from numpy master looks ok > > In [7]: pd.__version__ > Out[7]: '0.12.0' > > In [8]: np.__version__ > Out[8]: '1.9.0.dev-74abfa2' > > In [9]: s = pandas.Series([1.0, np.nan]) > > In [10]: np.nansum(s) > Out[10]: 1.0 > > In [11]: type(np.nans