[Numpy-discussion] Cross-correlation PR stuck in limbo

2016-05-03 Thread Honi Sanders
Hello all, I have completed a pull request to add a “maxlag” functionality to numpy.correlate. See here: https://github.com/numpy/numpy/pull/5978 . This pull request has passed all tests and has been ready to be merged for around six months. Several p

Re: [Numpy-discussion] Video meeting this week

2015-07-02 Thread Honi Sanders
I’m interested in listening in just to see what it’s like, but I have to leave after ~15 minutes because I have a meeting at 4:30. Is that too disruptive? > On Jul 2, 2015, at 3:59 PM, Nathaniel Smith wrote: > > Hi all, > > Meeting is starting in a few minutes! > > Hangouts link: > https://

Re: [Numpy-discussion] Video meeting this week

2015-06-30 Thread Honi Sanders
I’m pretty new to Numpy so I won’t be able to contribute much, but I would appreciate being able to sit in on this if possible. Honi > On Jun 30, 2015, at 12:58 AM, Nathaniel Smith wrote: > > On Fri, Jun 26, 2015 at 2:32 AM, Nathaniel Smith wrote: >> Hi all, >> >> In a week and a half, this

Re: [Numpy-discussion] Removal of Deprecated Keywords/functionality

2015-06-21 Thread Honi Sanders
OK. So I am in the midst of a pull request adding a “maxlag” mode to correlate (https://github.com/numpy/numpy/compare/master...bringingheavendown:maxlag). Am I to understand that I no longer need to preserve the old_behavior functionality? Is it possible that we could address my pull request

Re: [Numpy-discussion] How to limit cross correlation window width in Numpy?

2015-06-21 Thread Honi Sanders
Did you check out my implementation? I was able to modify the Numpy correlate function just fine. https://github.com/numpy/numpy/compare/master...bringingheavendown:maxlag > On Jun 21, 2015, at 1:53 PM, Mansour Moufid wrote: > > I just realized that NumPy uses the time domain algorithm for c

Re: [Numpy-discussion] How to limit cross correlation window width in Numpy?

2015-06-17 Thread Honi Sanders
ntion. Honi > On Jun 17, 2015, at 6:13 PM, Sturla Molden wrote: > > On 17/06/15 04:38, Honi Sanders wrote: > >> I have now implemented this functionality in numpy.correlate() and >> numpy.convolve(). https://github.com/bringingheavendown/numpy. The files >> that

Re: [Numpy-discussion] How to limit cross correlation window width in Numpy?

2015-06-16 Thread Honi Sanders
design decisions, and the unit tests I have written. This is my first time contributing, so I am not confident about any of these and welcome feedback. > On Jun 8, 2015, at 9:54 PM, Honi Sanders wrote: > > I am learning numpy/scipy, coming from a MATLAB background. The xcorr > functi

[Numpy-discussion] How to limit cross correlation window width in Numpy?

2015-06-08 Thread Honi Sanders
I am learning numpy/scipy, coming from a MATLAB background. The xcorr function in Matlab has an optional argument "maxlag" that limits the lag range from –maxlag to maxlag. This is very useful if you are looking at the cross-correlation between two very long time series but are only interested i