Re: [Numpy-discussion] code review request: masked dtype transfers

2011-07-09 Thread Nathaniel Smith
On Sat, Jul 9, 2011 at 7:24 PM, Mark Wiebe wrote: > On Sat, Jul 9, 2011 at 2:38 PM, Nathaniel Smith wrote: >> >> On Sat, Jul 9, 2011 at 11:29 AM, Mark Wiebe wrote: >> > typedef npy_uint8 npy_mask; >> > #define NPY_MASK NPY_UINT8 >> > #define NPY_MASK_ISEXPOSED(mask) (((mask)&0x01) != 0) >> > #de

Re: [Numpy-discussion] code review request: masked dtype transfers

2011-07-09 Thread Mark Wiebe
On Sat, Jul 9, 2011 at 2:38 PM, Nathaniel Smith wrote: > On Sat, Jul 9, 2011 at 11:29 AM, Mark Wiebe wrote: > > typedef npy_uint8 npy_mask; > > #define NPY_MASK NPY_UINT8 > > #define NPY_MASK_ISEXPOSED(mask) (((mask)&0x01) != 0) > > #define NPY_MASK_GETPAYLOAD(mask) (((npy_mask)mask) >> 1) > > #

Re: [Numpy-discussion] code review request: masked dtype transfers

2011-07-09 Thread Nathaniel Smith
On Sat, Jul 9, 2011 at 11:29 AM, Mark Wiebe wrote: > typedef npy_uint8 npy_mask; > #define NPY_MASK NPY_UINT8 > #define NPY_MASK_ISEXPOSED(mask) (((mask)&0x01) != 0) > #define NPY_MASK_GETPAYLOAD(mask) (((npy_mask)mask) >> 1) > #define NPY_MASK_MAKEMASK(exposed, payload) ((npy_mask)(exposed&0x01)

Re: [Numpy-discussion] code review request: masked dtype transfers

2011-07-09 Thread Mark Wiebe
On Sat, Jul 9, 2011 at 12:53 PM, Eric Firing wrote: > On 07/08/2011 01:31 PM, Mark Wiebe wrote: > > I've just made pull request 105: > > > > https://github.com/numpy/numpy/pull/105 > > > > It's merged, which is good, but I have a suggestion relevant to that > pull and I suspect to many others to

Re: [Numpy-discussion] code review request: masked dtype transfers

2011-07-09 Thread Eric Firing
On 07/08/2011 01:31 PM, Mark Wiebe wrote: > I've just made pull request 105: > > https://github.com/numpy/numpy/pull/105 > It's merged, which is good, but I have a suggestion relevant to that pull and I suspect to many others to come: use defines and macros to consolidate some of the implementat

Re: [Numpy-discussion] code review request: masked dtype transfers

2011-07-09 Thread Charles R Harris
On Fri, Jul 8, 2011 at 11:06 PM, Mark Wiebe wrote: > On Fri, Jul 8, 2011 at 10:04 PM, Eric Firing wrote: > >> On 07/08/2011 01:31 PM, Mark Wiebe wrote: >> > I've just made pull request 105: >> > >> > https://github.com/numpy/numpy/pull/105 >> > >> > This adds public API PyArray_MaskedCopyInto an

[Numpy-discussion] non-integer powers in scimath.power

2011-07-09 Thread Nathaniel Dosé
Is it true that numpy.lib.scimath.power() only accepts integer powers? >>> np.info(scimath.power) ... >>> Parameters >>> -- >>> x : array_like >>> The input value(s). >>> p : array_like of ints In any case, scimath.power() doesn't complain when you send in a non-int, and in fac