Re: [Numpy-discussion] let's use patch review

2008-05-15 Thread Stéfan van der Walt
2008/5/16 Anne Archibald <[EMAIL PROTECTED]>: > How frequently does numpy receive patches that warrant review? The > zillion little doc fixes don't, even moderate-sized patches from > experienced developers probably don't warrant review. Those moderately-sized patches are the ones that need review

Re: [Numpy-discussion] let's use patch review

2008-05-15 Thread David Cournapeau
Anne Archibald wrote: > I think here's the rub: when I hear "patch review system" it sounds to > me like an obstacle course for getting code into the software. Maybe > it's justified, but I think at the moment there are many many things > that are just awaiting a little bit of attention from someon

Re: [Numpy-discussion] let's use patch review

2008-05-15 Thread Anne Archibald
2008/5/15 Francesc Alted <[EMAIL PROTECTED]>: > I don't need to say that this procedure was not used for small or > trivial changes (that were fixed directly), but only when the issue was > important enough to deserve the attention of the mate. I think here's the rub: when I hear "patch review sy

Re: [Numpy-discussion] let's use patch review

2008-05-15 Thread David Cournapeau
David Huard wrote: > > There is about 5 commits/day, I don't think it's a good idea to wait > for a vote on each one of them. There is definitely a balance to find, and I am not convinced it would work well with subversion (it really makes sense to have those review with merge request, not per

Re: [Numpy-discussion] searchsorted() and memory cache

2008-05-15 Thread Charles R Harris
On Wed, May 14, 2008 at 8:50 PM, Andrew Straw <[EMAIL PROTECTED]> wrote: > Aha, I've found the problem -- my values were int64 and my keys were > uint64. Switching to the same data type immediately fixes the issue! > It's not a memory cache issue at all. > > Perhaps searchsorted() should emit a wa

Re: [Numpy-discussion] let's use patch review

2008-05-15 Thread Francesc Alted
A Wednesday 14 May 2008, Ondrej Certik escrigué: > Hi, > > I read the recent flamebate about unittests, formal procedures for a > commit etc. and it was amusing. :) > I think Stefan is right about the unit tests. I also think that > Travis is right that there is no formal procedure that can assure

Re: [Numpy-discussion] failure building numpy using icc

2008-05-15 Thread Glen W. Mabey
On Tue, Apr 29, 2008 at 04:43:09PM -0500, Glen W. Mabey wrote: > Isn't that cool? I can only assume that it is a compiler bug and I will > have to upgrade to a newer version of icc (I'm using 10.0.025, actually > it's cce). > > After I do that, I'll post again if I have trouble. Just to follow u

Re: [Numpy-discussion] let's use patch review

2008-05-15 Thread Pearu Peterson
On Thu, May 15, 2008 12:06 am, Ondrej Certik wrote: > Hi, > > I read the recent flamebate about unittests, formal procedures for a > commit etc. and it was amusing. :) > I think Stefan is right about the unit tests. I also think that Travis > is right that there is no formal procedure that can assu

Re: [Numpy-discussion] let's use patch review

2008-05-15 Thread Ondrej Certik
On Thu, May 15, 2008 at 3:08 PM, David Huard <[EMAIL PROTECTED]> wrote: > 2008/5/14 David Cournapeau <[EMAIL PROTECTED]>: >> >> On Wed, 2008-05-14 at 13:58 -1000, Eric Firing wrote: >> > >> > What does that mean? How does one know when there is a consensus? >> >> There can be a system to make this

Re: [Numpy-discussion] let's use patch review

2008-05-15 Thread David Huard
2008/5/14 David Cournapeau <[EMAIL PROTECTED]>: > On Wed, 2008-05-14 at 13:58 -1000, Eric Firing wrote: > > > > What does that mean? How does one know when there is a consensus? > > There can be a system to make this automatic. For example, the code is > never commited directly to svn, but to a g

Re: [Numpy-discussion] f2py and -D_FORTIFY_SOURCE=2 compilation flag

2008-05-15 Thread David Huard
Works for me, Thanks David 2008/5/15 Pearu Peterson <[EMAIL PROTECTED]>: > > > Robert Kern wrote: > > On Wed, May 14, 2008 at 3:20 PM, David Huard <[EMAIL PROTECTED]> > wrote: > >> I filed a patch that seems to do the trick in ticket #792. > > > > I don't think this is the right approach. The p

Re: [Numpy-discussion] f2py and -D_FORTIFY_SOURCE=2 compilation flag

2008-05-15 Thread Pearu Peterson
Robert Kern wrote: > On Wed, May 14, 2008 at 3:20 PM, David Huard <[EMAIL PROTECTED]> wrote: >> I filed a patch that seems to do the trick in ticket #792. > > I don't think this is the right approach. The problem isn't that > _FORTIFY_SOURCE is set to 2 but that f2py is doing (probably) bad > th