Re: [Numpy-discussion] `keepdims=True` for argmin/argmx and C-API `PyArray_ArgMaxWithKeepdims`

Hi Sebastian, On Wed, Jun 30, 2021, at 18:23, Sebastian Berg wrote: > The PR https://github.com/numpy/numpy/pull/19211 proposes to extend > argmin and argmax with a `keepdims=False` keyword-only argument. This seems consistent with existing APIs, so I'm not concerned. For those wondering, `keepd

Re: [Numpy-discussion] `keepdims=True` for argmin/argmx and C-API `PyArray_ArgMaxWithKeepdims`

On Thu, 2021-07-01 at 00:39 -0700, Stefan van der Walt wrote: > Hi Sebastian, > > On Wed, Jun 30, 2021, at 18:23, Sebastian Berg wrote: > > The PR https://github.com/numpy/numpy/pull/19211 proposes to extend > > argmin and argmax with a `keepdims=False` keyword-only argument. > > This seems consi

Re: [Numpy-discussion] `keepdims=True` for argmin/argmx and C-API `PyArray_ArgMaxWithKeepdims`

Hi, So should I remove these new functions from public C-API? Let me know. I will do that. On Thu, 1 Jul, 2021, 10:02 pm Sebastian Berg, wrote: > On Thu, 2021-07-01 at 00:39 -0700, Stefan van der Walt wrote: > > Hi Sebastian, > > > > On Wed, Jun 30, 2021, at 18:23, Sebastian Berg wrote: > > > T

Re: [Numpy-discussion] `keepdims=True` for argmin/argmx and C-API `PyArray_ArgMaxWithKeepdims`

On 1/7/21 7:49 pm, Gagandeep Singh wrote: Hi, So should I remove these new functions from public C-API? Let me know. I will do that. Yes please. If needed we can add them, but once in we cannot remove them. Matti ___ NumPy-Discussion mailing

Re: [Numpy-discussion] `keepdims=True` for argmin/argmx and C-API `PyArray_ArgMaxWithKeepdims`

Hi, I have removed the two new C functions from public C-API. Let me know if anything else is needed. Thanks. On Fri, Jul 2, 2021 at 2:10 AM Matti Picus wrote: > > On 1/7/21 7:49 pm, Gagandeep Singh wr