On Fri, 2020-01-24 at 10:57 -0700, Charles R Harris wrote:
>
>
> On Fri, Jan 24, 2020 at 10:42 AM Kevin Sheppard <
> kevin.k.shepp...@gmail.com> wrote:
> > I think some types of clean-ups, for example, imports, are pretty
> > low cost, low risk and don't have much bearing on and it might be
> > b
On Fri, Jan 24, 2020 at 10:42 AM Kevin Sheppard
wrote:
> I think some types of clean-ups, for example, imports, are pretty low
> cost, low risk and don't have much bearing on and it might be best to do
> them all at once.
>
> f-strings are also pretty simple but can be abused to the detriment of
I think some types of clean-ups, for example, imports, are pretty low cost,
low risk and don't have much bearing on and it might be best to do them all
at once.
f-strings are also pretty simple but can be abused to the detriment of code
around (for example, moving a string defined in a variable ou
On Fri, Jan 24, 2020 at 9:46 AM Ralf Gommers wrote:
> Hi all,
>
> It's great to see that people are jumping at the chance to clean up Python
> 2 support. I would however caution about overdoing it on other cleanups. As
> a reminder, we normally do not want pure style PRs (e.g. PEP8 cleanups),
> b
Hi all,
It's great to see that people are jumping at the chance to clean up Python
2 support. I would however caution about overdoing it on other cleanups. As
a reminder, we normally do not want pure style PRs (e.g. PEP8 cleanups),
because they make the code history (git blame, commits on particul
