Re: [Numpy-discussion] Removing undocumented __buffer__ attribute lookup

2019-02-28 Thread Charles R Harris
On Wed, Feb 27, 2019 at 1:37 AM Hameer Abbasi wrote: > Cc-ing in Travis, because he was the original author of the buffer > protocol, and this is most definitely related. > > Best Regards, > Hameer Abbasi > > On Wednesday, Feb 27, 2019 at 9:20 AM, Matti Picus > wrote: > In digging around the cod

Re: [Numpy-discussion] Removing undocumented __buffer__ attribute lookup

2019-02-27 Thread Hameer Abbasi
Cc-ing in Travis, because he was the original author of the buffer protocol, and this is most definitely related. Best Regards, Hameer Abbasi > On Wednesday, Feb 27, 2019 at 9:20 AM, Matti Picus (mailto:matti.pi...@gmail.com)> wrote: > In digging around the code, I found a gem in PyArray_FromBu

[Numpy-discussion] Removing undocumented __buffer__ attribute lookup

2019-02-27 Thread Matti Picus
In digging around the code, I found a gem in PyArray_FromBuffer (exposed to python as numpy.frombuffer). If a PyObject* does not have a tp_as_buffer->bf_getbuffer function, we check if the python object has a __buffer__ attribute. If so we use that as buf in PyObject_GetBuffer(buf, ...). Thi