Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-27 Thread Zimmermann Klaus
Hi Ralf, On 26/11/2020 15:17, Ralf Gommers wrote: > On Fri, Nov 6, 2020 at 4:03 PM Zimmermann Klaus > mailto:klaus.zimmerm...@smhi.se>> wrote: > I was just wondering if, of the top your head, an existing, better fit > comes to mind? > > > Not really. Outside of stride_tricks there's noth

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-26 Thread Ralf Gommers
On Fri, Nov 6, 2020 at 4:03 PM Zimmermann Klaus wrote: > Hi, > > On 06/11/2020 15:58, Ralf Gommers wrote: > > On Fri, Nov 6, 2020 at 9:51 AM Zimmermann Klaus > > mailto:klaus.zimmerm...@smhi.se>> wrote: > > I have absolutely no problem keeping this out of the main namespace. > > > > In fa

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-06 Thread Zimmermann Klaus
Hi, On 06/11/2020 15:58, Ralf Gommers wrote: > On Fri, Nov 6, 2020 at 9:51 AM Zimmermann Klaus > mailto:klaus.zimmerm...@smhi.se>> wrote: > I have absolutely no problem keeping this out of the main namespace. > > In fact I'd like to point out that it was not my idea. Rather, it was >

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-06 Thread Ralf Gommers
On Fri, Nov 6, 2020 at 9:51 AM Zimmermann Klaus wrote: > Hi all, > > > I have absolutely no problem keeping this out of the main namespace. > > In fact I'd like to point out that it was not my idea. Rather, it was > proposed by Bas van Beek in the comments [1,2] and received a little > more scrut

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-06 Thread Zimmermann Klaus
Hi all, I have absolutely no problem keeping this out of the main namespace. In fact I'd like to point out that it was not my idea. Rather, it was proposed by Bas van Beek in the comments [1,2] and received a little more scrutiny from Eric Wieser in [3]. The reason that it didn't receive the sc

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-05 Thread Sebastian Berg
On Thu, 2020-11-05 at 17:35 -0600, Sebastian Berg wrote: > On Thu, 2020-11-05 at 12:51 -0800, Stephan Hoyer wrote: > > On Thu, Nov 5, 2020 at 11:16 AM Ralf Gommers < > > ralf.gomm...@gmail.com> > > wrote: > > > > > On Thu, Nov 5, 2020 at 4:56 PM Sebastian Berg < > > > sebast...@sipsolutions.net> >

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-05 Thread Sebastian Berg
On Thu, 2020-11-05 at 12:51 -0800, Stephan Hoyer wrote: > On Thu, Nov 5, 2020 at 11:16 AM Ralf Gommers > wrote: > > > > > On Thu, Nov 5, 2020 at 4:56 PM Sebastian Berg < > > sebast...@sipsolutions.net> > > wrote: > > > > > Hi all, > > > > > > just a brief note that I merged this proposal: > >

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-05 Thread Stephan Hoyer
On Thu, Nov 5, 2020 at 11:16 AM Ralf Gommers wrote: > > > On Thu, Nov 5, 2020 at 4:56 PM Sebastian Berg > wrote: > >> Hi all, >> >> just a brief note that I merged this proposal: >> >> https://github.com/numpy/numpy/pull/17394 >> >> adding `np.sliding_window_view` into the 1.20 release of Nu

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-05 Thread Ralf Gommers
On Thu, Nov 5, 2020 at 4:56 PM Sebastian Berg wrote: > Hi all, > > just a brief note that I merged this proposal: > > https://github.com/numpy/numpy/pull/17394 > > adding `np.sliding_window_view` into the 1.20 release of NumPy. > > There was only one public API change, and that is that the `s

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-05 Thread Sebastian Berg
Hi all, just a brief note that I merged this proposal: https://github.com/numpy/numpy/pull/17394 adding `np.sliding_window_view` into the 1.20 release of NumPy. There was only one public API change, and that is that the `shape` argument is now called `window_shape`. This is still a good ti

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-10-13 Thread Zimmermann Klaus
Hi, thanks, Juan, you are very kind! Let's hope we can get this in soon :) Cheers Klaus On 13/10/2020 01:18, Juan Nunez-Iglesias wrote: > Looks gorgeous, thank you to all who worked on the implementation, API, > and review, and thank you Sebastian for saving me a click! 😂 > >> On 13 Oct 2020,

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-10-13 Thread Zimmermann Klaus
Hi, thanks, Sebastian! Since `sliding_window_view` is essentially a small function determining the parameters with which to call `as_strided`, it makes sense to me to keep the essential `as_strided` parameters, `subok` among them. But if somebody with a deeper insight into numpy is convinced this

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-10-12 Thread Juan Nunez-Iglesias
Looks gorgeous, thank you to all who worked on the implementation, API, and review, and thank you Sebastian for saving me a click! 😂 > On 13 Oct 2020, at 2:25 am, Sebastian Berg wrote: > > On Mon, 2020-10-12 at 08:39 +, Zimmermann Klaus wrote: >> Hello, >> >> I would like to draw the atten

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-10-12 Thread Sebastian Berg
On Mon, 2020-10-12 at 08:39 +, Zimmermann Klaus wrote: > Hello, > > I would like to draw the attention of this list to PR #17394 [1] that > adds the implementation of a sliding window view to numpy. > Hi, thanks for working on this and driving going forward. I like the choice of a minimal A

[Numpy-discussion] Add sliding_window_view method to numpy

2020-10-12 Thread Zimmermann Klaus
Hello, I would like to draw the attention of this list to PR #17394 [1] that adds the implementation of a sliding window view to numpy. Having a sliding window view in numpy is a longstanding open issue (cf #7753 [2] from 2016). A brief summary of the discussions surrounding it can be found in th