Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-05 Thread Sebastian Berg
On Thu, 2020-11-05 at 17:35 -0600, Sebastian Berg wrote: > On Thu, 2020-11-05 at 12:51 -0800, Stephan Hoyer wrote: > > On Thu, Nov 5, 2020 at 11:16 AM Ralf Gommers < > > ralf.gomm...@gmail.com> > > wrote: > > > > > On Thu, Nov 5, 2020 at 4:56 PM Sebastian Berg < > > > sebast...@sipsolutions.net> >

Re: [Numpy-discussion] datetime64: Remove deprecation warning when constructing with timezone

2020-11-05 Thread Stephan Hoyer
I can try to dig up the old discussions, but datetime64 used to implement both (1) and (3), and this was updated in a very intentional way. Datetime64 now works like Python's own time-zone naive datetime.datetime objects. The documentation referencing "Z" should be updated -- datetime64 can be in a

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-05 Thread Sebastian Berg
On Thu, 2020-11-05 at 12:51 -0800, Stephan Hoyer wrote: > On Thu, Nov 5, 2020 at 11:16 AM Ralf Gommers > wrote: > > > > > On Thu, Nov 5, 2020 at 4:56 PM Sebastian Berg < > > sebast...@sipsolutions.net> > > wrote: > > > > > Hi all, > > > > > > just a brief note that I merged this proposal: > >

Re: [Numpy-discussion] datetime64: Remove deprecation warning when constructing with timezone

2020-11-05 Thread Eric Wieser
Without weighing in yet on how I feel about the deprecation, you can see some discussion about why this was originally deprecated in the PR that introduced the warning: https://github.com/numpy/numpy/pull/6453 Eric On Thu, Nov 5, 2020, 20:13 Noam Yorav-Raphael wrote: > Hi, > > I suggest removi

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-05 Thread Stephan Hoyer
On Thu, Nov 5, 2020 at 11:16 AM Ralf Gommers wrote: > > > On Thu, Nov 5, 2020 at 4:56 PM Sebastian Berg > wrote: > >> Hi all, >> >> just a brief note that I merged this proposal: >> >> https://github.com/numpy/numpy/pull/17394 >> >> adding `np.sliding_window_view` into the 1.20 release of Nu

[Numpy-discussion] datetime64: Remove deprecation warning when constructing with timezone

2020-11-05 Thread Noam Yorav-Raphael
Hi, I suggest removing the deprecation warning when constructing a datetime64 with a timezone. For example, this is the current behavior: >>> np.datetime64('2020-11-05 16:00+0200') :1: DeprecationWarning: parsing timezone aware datetimes is deprecated; this will raise an error in the future numpy

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-05 Thread Ralf Gommers
On Thu, Nov 5, 2020 at 4:56 PM Sebastian Berg wrote: > Hi all, > > just a brief note that I merged this proposal: > > https://github.com/numpy/numpy/pull/17394 > > adding `np.sliding_window_view` into the 1.20 release of NumPy. > > There was only one public API change, and that is that the `s

Re: [Numpy-discussion] Add sliding_window_view method to numpy

2020-11-05 Thread Sebastian Berg
Hi all, just a brief note that I merged this proposal: https://github.com/numpy/numpy/pull/17394 adding `np.sliding_window_view` into the 1.20 release of NumPy. There was only one public API change, and that is that the `shape` argument is now called `window_shape`. This is still a good ti

[Numpy-discussion] Officially drop Python 3.6 from NumPy 1.20 (was: NumPy 1.20.x branch in two weeks)

2020-11-05 Thread Sebastian Berg
Hi all, just to note: We discussed this yesterday briefly and decided to drop official support for 3.6 in the 1.20 release. We never had ambition to support 1.20 and there seems advantage in dropping it, if mainly for clarity and consistency with many other projects. If you disagree with this de