Re: [Numpy-discussion] Adding `max_rows` to `loadtxt'

2018-09-16 Thread Stephan Hoyer
This seems like a minor and uncontroversial improvement. No objections from me! On Sun, Sep 16, 2018 at 2:01 PM Matti Picus wrote: > A new contributor submitted a PR[0] to add `max_rows`[1] to `loadtxt`, > like is done in 'genfromtxt', (which is used under the hood for > 'ndfromtxt', 'mafromtxt'

[Numpy-discussion] Adding `max_rows` to `loadtxt'

2018-09-16 Thread Matti Picus
A new contributor submitted a PR[0] to add `max_rows`[1] to `loadtxt`, like is done in 'genfromtxt', (which is used under the hood for 'ndfromtxt', 'mafromtxt', and 'recfromtxt`).  Any thoughts? [0] https://github.com/numpy/numpy/pull/11962 [1] Well, actually `maxlines`, but I asked to change i