[PR] Add scoped context support. Remove ThreadContextDataInjector. (logging-log4j2)

2024-04-21 Thread via GitHub
rgoers opened a new pull request, #2494: URL: https://github.com/apache/logging-log4j2/pull/2494 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[PR] Bump org.apache.maven.plugins:maven-toolchains-plugin from 3.1.0 to 3.2.0 [logging-log4j-scala]

2024-04-21 Thread via GitHub
dependabot[bot] opened a new pull request, #52: URL: https://github.com/apache/logging-log4j-scala/pull/52 Bumps [org.apache.maven.plugins:maven-toolchains-plugin](https://github.com/apache/maven-toolchains-plugin) from 3.1.0 to 3.2.0. Commits https://github.com/apache/maven-t

Re: [PR] Bump org.apache.maven.plugins:maven-toolchains-plugin from 3.1.0 to 3.2.0 [logging-log4j-scala]

2024-04-21 Thread via GitHub
github-actions[bot] closed pull request #52: Bump org.apache.maven.plugins:maven-toolchains-plugin from 3.1.0 to 3.2.0 URL: https://github.com/apache/logging-log4j-scala/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Bump org.apache.maven.plugins:maven-toolchains-plugin from 3.1.0 to 3.2.0 [logging-log4j-scala]

2024-04-21 Thread via GitHub
github-actions[bot] merged PR #52: URL: https://github.com/apache/logging-log4j-scala/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

Re: [PR] Add scoped context support. Remove ThreadContextDataInjector. (logging-log4j2)

2024-04-21 Thread via GitHub
rgoers merged PR #2494: URL: https://github.com/apache/logging-log4j2/pull/2494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

Re: [PR] Use Logging Services common pages #144 (logging-log4net)

2024-04-22 Thread via GitHub
vy commented on code in PR #145: URL: https://github.com/apache/logging-log4net/pull/145#discussion_r1574292042 ## src/site/site.xml: ## @@ -28,8 +28,8 @@ Review Comment: @FreeAndNil, how does this work at all? The root points to `logging.[staged.]apache.org

Re: [I] Use Logging Services common pages (logging-log4net)

2024-04-22 Thread via GitHub
vy commented on issue #144: URL: https://github.com/apache/logging-log4net/issues/144#issuecomment-2068751933 @FreeAndNil @LaurentDardenne Removed `README.html` and `KEYS` symlink from the https://dist.apache.org/repos/dist/dev/logging/log4net Subversion folder. https://archive.apach

Re: [PR] Use Logging Services common pages #144 (logging-log4net)

2024-04-22 Thread via GitHub
FreeAndNil commented on code in PR #145: URL: https://github.com/apache/logging-log4net/pull/145#discussion_r1574417000 ## src/site/site.xml: ## @@ -28,8 +28,8 @@ Review Comment: As I understand, the root points to `logging.[staged.]apache.org/log4net` --

Re: [PR] Use Logging Services common pages #144 (logging-log4net)

2024-04-22 Thread via GitHub
vy commented on code in PR #145: URL: https://github.com/apache/logging-log4net/pull/145#discussion_r1574480904 ## src/site/site.xml: ## @@ -28,8 +28,8 @@ - - + + Review Comment: ```suggestion https://logging.apache.org/downlo

Re: [PR] Use Logging Services common pages #144 (logging-log4net)

2024-04-22 Thread via GitHub
FreeAndNil merged PR #145: URL: https://github.com/apache/logging-log4net/pull/145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Use Logging Services common pages (logging-log4net)

2024-04-22 Thread via GitHub
FreeAndNil closed issue #144: Use Logging Services common pages URL: https://github.com/apache/logging-log4net/issues/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Use Logging Services common pages #144 (logging-log4net)

2024-04-22 Thread via GitHub
vy commented on PR #145: URL: https://github.com/apache/logging-log4net/pull/145#issuecomment-2068986300 @FreeAndNil, thanks so much! :heart_eyes: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Add compression option for JSON Template Layout (logging-log4j2)

2024-04-22 Thread via GitHub
vy commented on issue #2496: URL: https://github.com/apache/logging-log4j2/issues/2496#issuecomment-2068999593 Instead adding compression support to ``, we better create a wrapper layout that compresses the output of another layout. This issue has already been discussed in [LOG4J2-3023](h

[PR] Bump actions/checkout from 4.1.2 to 4.1.3 [logging-parent]

2024-04-22 Thread via GitHub
dependabot[bot] opened a new pull request, #163: URL: https://github.com/apache/logging-parent/pull/163 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.2 to 4.1.3. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's r

Re: [PR] Bump actions/checkout from 4.1.2 to 4.1.3 [logging-parent]

2024-04-22 Thread via GitHub
github-actions[bot] merged PR #163: URL: https://github.com/apache/logging-parent/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [I] Wrapper layout compressing the output of a delegate (LOG4J2-3023) (logging-log4j2)

2024-04-22 Thread via GitHub
der-eismann commented on issue #2496: URL: https://github.com/apache/logging-log4j2/issues/2496#issuecomment-2069078162 I'm kinda interested, but my Java knowledge is very basic and I'm not sure if my help is really useful here :see_no_evil: -- This is an automated message from the Apac

Re: [PR] Port new Download and Installation pages to `2.x` (logging-log4j2)

2024-04-22 Thread via GitHub
vy merged PR #2487: URL: https://github.com/apache/logging-log4j2/pull/2487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Bump actions/checkout from 4.1.2 to 4.1.3 (logging-log4j2)

2024-04-22 Thread via GitHub
github-actions[bot] merged PR #2497: URL: https://github.com/apache/logging-log4j2/pull/2497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [I] Wrapper layout compressing the output of a delegate (LOG4J2-3023) (logging-log4j2)

2024-04-22 Thread via GitHub
ppkarwasz commented on issue #2496: URL: https://github.com/apache/logging-log4j2/issues/2496#issuecomment-2069148758 I marked [LOG4J2-3023](https://issues.apache.org/jira/browse/LOG4J2-3023) as duplicate of this issue, so we don't need to use JIRA any more. -- This is an automated messa

[PR] Add trace context fields to GcpLayout.json (logging-log4j2)

2024-04-22 Thread via GitHub
aabmass opened a new pull request, #2498: URL: https://github.com/apache/logging-log4j2/pull/2498 This PR adds a few tracing related JSON fields to the included `GcpLayout.json` event template which are documented in the [Cloud Logging docs](https://cloud.google.com/logging/docs/structured-

Re: [PR] Add trace context fields to GcpLayout.json (logging-log4j2)

2024-04-22 Thread via GitHub
aabmass commented on PR #2498: URL: https://github.com/apache/logging-log4j2/pull/2498#issuecomment-2070784374 Thanks for the quick review! > A quick question just before merging it: If `trace_id` and/or `span_id` MDC values are missing, `logging.googleapis.com/trace_sampled` will sti

Re: [PR] Add trace context fields to GcpLayout.json (logging-log4j2)

2024-04-22 Thread via GitHub
aabmass commented on PR #2498: URL: https://github.com/apache/logging-log4j2/pull/2498#issuecomment-2070792509 > A quick question just before merging it: If `trace_id` and/or `span_id` MDC values are missing, `logging.googleapis.com/trace_sampled` will still be set to `true` without `loggin

Re: [PR] Add trace context fields to GcpLayout.json (logging-log4j2)

2024-04-22 Thread via GitHub
aabmass commented on PR #2498: URL: https://github.com/apache/logging-log4j2/pull/2498#issuecomment-2070891282 > I would also really appreciate it if you can create a `src/changelog/.2.x.x/add_GcpLayout_tracing_support.xml` changelog entry file. Added -- This is an automated messag

Re: [I] Use Logging Services common pages [logging-log4cxx]

2024-04-22 Thread via GitHub
swebb2066 commented on issue #370: URL: https://github.com/apache/logging-log4cxx/issues/370#issuecomment-2071282144 As far as I can see, those three pages do not seem to have anything that is relevant to a Log4cxx user. I notice the links to these pages are available from the [Apach

Re: [PR] Prefer std::lock_guard when std::unique_lock features are not required [logging-log4cxx]

2024-04-22 Thread via GitHub
swebb2066 merged PR #369: URL: https://github.com/apache/logging-log4cxx/pull/369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Add trace context fields to GcpLayout.json (logging-log4j2)

2024-04-23 Thread via GitHub
vy commented on code in PR #2498: URL: https://github.com/apache/logging-log4j2/pull/2498#discussion_r1575804018 ## src/changelog/.2.x.x/add_GcpLayout_tracing_support.xml: ## @@ -0,0 +1,8 @@ + +http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org

Re: [PR] Add trace context fields to GcpLayout.json (logging-log4j2)

2024-04-23 Thread via GitHub
vy commented on PR #2498: URL: https://github.com/apache/logging-log4j2/pull/2498#issuecomment-2071650563 @aabmass, thanks so much! I will merge this once CI passes and `cherry-pick` it to `main` too. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Use Logging Services common pages [logging-log4cxx]

2024-04-23 Thread via GitHub
vy commented on issue #370: URL: https://github.com/apache/logging-log4cxx/issues/370#issuecomment-2071664759 > As far as I can see, those three pages do not seem to have anything that is relevant to a Log4cxx user. Pages I cited are implemented in a project agnostic way. That is,

Re: [PR] Add trace context fields to GcpLayout.json (logging-log4j2)

2024-04-23 Thread via GitHub
vy merged PR #2498: URL: https://github.com/apache/logging-log4j2/pull/2498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [I] `LevelResolver` of `JsonTemplateLayout` wrongly assumes that `Level.values()` is constant (logging-log4j2)

2024-04-23 Thread via GitHub
vy commented on issue #2063: URL: https://github.com/apache/logging-log4j2/issues/2063#issuecomment-2071825194 Fixed in e0a2bcb4dc4c475ec79bb8b7b876f46062579eef (`2.x`) and 97e441dd9ee4236fd1ba31bc373bebee483a2ddc (`main`). -- This is an automated message from the Apache Git Service. To

Re: [I] `LevelResolver` of `JsonTemplateLayout` wrongly assumes that `Level.values()` is constant (logging-log4j2)

2024-04-23 Thread via GitHub
vy closed issue #2063: `LevelResolver` of `JsonTemplateLayout` wrongly assumes that `Level.values()` is constant URL: https://github.com/apache/logging-log4j2/issues/2063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [I] Java compatibility information is missing (logging-log4j2)

2024-04-23 Thread via GitHub
vy closed issue #2121: Java compatibility information is missing URL: https://github.com/apache/logging-log4j2/issues/2121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] Java compatibility information is missing (logging-log4j2)

2024-04-23 Thread via GitHub
vy commented on issue #2121: URL: https://github.com/apache/logging-log4j2/issues/2121#issuecomment-2071831349 Fixed in #2480 (`main`) and #2487 (`2.x`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Prefer std::lock_guard when std::unique_lock features are not required [logging-log4cxx]

2024-04-23 Thread via GitHub
vopl commented on code in PR #369: URL: https://github.com/apache/logging-log4cxx/pull/369#discussion_r1575988574 ## src/main/cpp/filewatchdog.cpp: ## @@ -74,11 +74,7 @@ void FileWatchdog::stop() { LogLog::debug(LOG4CXX_STR("Stopping file watchdog")); m_priv->in

Re: [PR] Bump actions/upload-artifact from 4.3.2 to 4.3.3 [logging-parent]

2024-04-23 Thread via GitHub
github-actions[bot] merged PR #164: URL: https://github.com/apache/logging-parent/pull/164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [I] Refresh CONTRIBUTING.md (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz closed issue #1216: Refresh CONTRIBUTING.md URL: https://github.com/apache/logging-log4j2/issues/1216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] log4j-api 2.20.0 causing : java.lang.NoClassDefFoundError: Could not initialize class org.apache.logging.log4j.util.PropertiesUtil (logging-log4j2)

2024-04-23 Thread via GitHub
vy commented on issue #2414: URL: https://github.com/apache/logging-log4j2/issues/2414#issuecomment-2072032310 @jolly28, pushed a small fix in f0bd87818d43efa8337f56526ced2020c308d9bf. Could you see if the most recent `2.24.0-SNAPSHOT` solves the problem, please? (Note that you need to [ad

[PR] Close stale issues (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz opened a new pull request, #2500: URL: https://github.com/apache/logging-log4j2/pull/2500 We add a GitHub action to automatically close GitHub issues that: - are marked as `waiting-for-user`, - have been inactive for more than 60 days. -- This is an automated messag

Re: [I] JMX should be disabled by default (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz closed issue #1229: JMX should be disabled by default URL: https://github.com/apache/logging-log4j2/issues/1229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [I] java.lang.NoClassDefFoundError: Failed resolution of: Lorg/apache/logging/log4j/core/lookup/StrLookup (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz commented on issue #1311: URL: https://github.com/apache/logging-log4j2/issues/1311#issuecomment-2072121185 @akash-queuebuster, This seems to be a simple classpath problem in your application, not a problem with Log4j. If you think otherwise, feel free to reopen this iss

Re: [I] java.lang.NoClassDefFoundError: Failed resolution of: Lorg/apache/logging/log4j/core/lookup/StrLookup (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz closed issue #1311: java.lang.NoClassDefFoundError: Failed resolution of: Lorg/apache/logging/log4j/core/lookup/StrLookup URL: https://github.com/apache/logging-log4j2/issues/1311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[PR] Keep mutex locked when changing the variable that change the condition [logging-log4cxx]

2024-04-23 Thread via GitHub
swebb2066 opened a new pull request, #371: URL: https://github.com/apache/logging-log4cxx/pull/371 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [I] SpringProfile arbiter fails without a Spring's environment (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz closed issue #1783: SpringProfile arbiter fails without a Spring's environment URL: https://github.com/apache/logging-log4j2/issues/1783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Issue with Log4J2 Compression/Decompression on the Mainframe (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz commented on issue #1795: URL: https://github.com/apache/logging-log4j2/issues/1795#issuecomment-2072168855 Hi @JamesChambers-E11074, Could you provide an excerpt of your Log4j configuration file? -- This is an automated message from the Apache Git Service. To respond to

Re: [I] RollingRandomAccessFile won't ZIP logs if there are 2 RRAF appenders (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz commented on issue #1804: URL: https://github.com/apache/logging-log4j2/issues/1804#issuecomment-2072176344 @JohnLussmyer, Sorry for the late answer. In your configuration file I see only one `RollingFileAppender`, could you provide the whole configuration file? -- This

Re: [I] log file overwritten and not correctly rolled (with log4j 2.20.0) (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz commented on issue #1958: URL: https://github.com/apache/logging-log4j2/issues/1958#issuecomment-2072190413 @castriottaa, Does your application run 24/7 or do you restart it every day? In the latter case you might be missing an [`OnStartupTriggeringPolicy`](https://loggi

Re: [I] Log4j2 starts again after LogManager.shutdown() (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz closed issue #2007: Log4j2 starts again after LogManager.shutdown() URL: https://github.com/apache/logging-log4j2/issues/2007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] Various tests abuse static state that no longer works (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz commented on issue #2022: URL: https://github.com/apache/logging-log4j2/issues/2022#issuecomment-2072204542 They seem to be fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] Various tests abuse static state that no longer works (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz closed issue #2022: Various tests abuse static state that no longer works URL: https://github.com/apache/logging-log4j2/issues/2022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] Add support for defining internal metrics (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz commented on issue #2027: URL: https://github.com/apache/logging-log4j2/issues/2027#issuecomment-2072210074 This should be fixed by #2469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [I] log file overwritten and not correctly rolled (with log4j 2.20.0) (logging-log4j2)

2024-04-23 Thread via GitHub
castriottaa commented on issue #1958: URL: https://github.com/apache/logging-log4j2/issues/1958#issuecomment-2072214067 @ppkarwasz My application is a batch that starts every day on event. Probably you are right: that configuration is missing. If you confirm that it manages the rollove

Re: [I] Issue with Log4J2 Compression/Decompression on the Mainframe (logging-log4j2)

2024-04-23 Thread via GitHub
JamesChambers-E11074 commented on issue #1795: URL: https://github.com/apache/logging-log4j2/issues/1795#issuecomment-2072241469 The mainframe uses a different character set (CP1047) when creating files. Creating a ZIP of those files puts them in a state where I cannot unzip them. I have

Re: [I] log4j2 record log to gz has gc lock error (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz commented on issue #2074: URL: https://github.com/apache/logging-log4j2/issues/2074#issuecomment-2072301269 @marinesky, The GC log you attached doesn't point to any error condition. What problems are you experiencing? -- This is an automated message from the Apache Git S

Re: [I] Document Log4j security model (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz closed issue #2100: Document Log4j security model URL: https://github.com/apache/logging-log4j2/issues/2100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [I] Consider moving recyclers to `log4j-core` (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz closed issue #2106: Consider moving recyclers to `log4j-core` URL: https://github.com/apache/logging-log4j2/issues/2106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] .NET8.0 XML Exception Problem (logging-log4net)

2024-04-23 Thread via GitHub
FreeAndNil commented on issue #142: URL: https://github.com/apache/logging-log4net/issues/142#issuecomment-2072310135 @SwEngine is this still relevant for you? Otherwise I will close this at the end of the week. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Split CLI commands from `log4j-1.2-api` and `log4j-core` (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz commented on issue #2131: URL: https://github.com/apache/logging-log4j2/issues/2131#issuecomment-2072312141 Closed in #2435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Split CLI commands from `log4j-1.2-api` and `log4j-core` (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz closed issue #2131: Split CLI commands from `log4j-1.2-api` and `log4j-core` URL: https://github.com/apache/logging-log4j2/issues/2131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] [Fatal Error] log4j2.yml:1:1: Content is not allowed in prolog. (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz closed issue #2318: [Fatal Error] log4j2.yml:1:1: Content is not allowed in prolog. URL: https://github.com/apache/logging-log4j2/issues/2318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [I] Provide a programmatic way to enable/disable log4j2 JMX beans creation (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz closed issue #2462: Provide a programmatic way to enable/disable log4j2 JMX beans creation URL: https://github.com/apache/logging-log4j2/issues/2462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Provide a programmatic way to enable/disable log4j2 JMX beans creation (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz commented on issue #2462: URL: https://github.com/apache/logging-log4j2/issues/2462#issuecomment-2072329175 Fixed by #2468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Issue with Log4J2 Compression/Decompression on the Mainframe (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz closed issue #1795: Issue with Log4J2 Compression/Decompression on the Mainframe URL: https://github.com/apache/logging-log4j2/issues/1795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] Issue with Log4J2 Compression/Decompression on the Mainframe (logging-log4j2)

2024-04-23 Thread via GitHub
ppkarwasz commented on issue #1795: URL: https://github.com/apache/logging-log4j2/issues/1795#issuecomment-2072333009 Thanks for the fast answer. I am closing this issue then, since we are unable to reproduce it. -- This is an automated message from the Apache Git Service. To respo

Re: [I] log4j-api 2.20.0 causing : java.lang.NoClassDefFoundError: Could not initialize class org.apache.logging.log4j.util.PropertiesUtil (logging-log4j2)

2024-04-23 Thread via GitHub
jolly28 commented on issue #2414: URL: https://github.com/apache/logging-log4j2/issues/2414#issuecomment-2072811890 @vy I have used the latest log4j-api and log4j-core jars (2.24.0-SNAPSHOT). seems the issue is solved. -- This is an automated message from the Apache Git Service. To r

Re: [I] Issue with Log4J2 Compression/Decompression on the Mainframe (logging-log4j2)

2024-04-23 Thread via GitHub
JamesChambers-E11074 commented on issue #1795: URL: https://github.com/apache/logging-log4j2/issues/1795#issuecomment-2072923267 That works. If you ever want to reproduce it, simply run the code on zOS add a compress step and then look at the final ZIP. From: Piotr P. Karwasz ***@**

Re: [PR] Bump org.apache.maven.plugins:maven-shade-plugin from 3.5.2 to 3.5.3 [logging-log4j-transform]

2024-04-23 Thread via GitHub
github-actions[bot] merged PR #101: URL: https://github.com/apache/logging-log4j-transform/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.13 to 1.14.14 [logging-log4j-samples]

2024-04-23 Thread via GitHub
github-actions[bot] merged PR #131: URL: https://github.com/apache/logging-log4j-samples/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Prefer std::lock_guard when std::unique_lock features are not required [logging-log4cxx]

2024-04-23 Thread via GitHub
swebb2066 commented on code in PR #369: URL: https://github.com/apache/logging-log4cxx/pull/369#discussion_r1577072840 ## src/main/cpp/filewatchdog.cpp: ## @@ -74,11 +74,7 @@ void FileWatchdog::stop() { LogLog::debug(LOG4CXX_STR("Stopping file watchdog")); m_pri

Re: [PR] Bump net.alchim31.maven:scala-maven-plugin from 4.8.1 to 4.9.0 [logging-log4j-scala]

2024-04-23 Thread via GitHub
github-actions[bot] merged PR #53: URL: https://github.com/apache/logging-log4j-scala/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[PR] Add links to Logging Services support, security and download pages [logging-log4cxx]

2024-04-23 Thread via GitHub
swebb2066 opened a new pull request, #372: URL: https://github.com/apache/logging-log4cxx/pull/372 This PR adds links as requested in #370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [I] Use Logging Services common pages [logging-log4cxx]

2024-04-23 Thread via GitHub
swebb2066 commented on issue #370: URL: https://github.com/apache/logging-log4cxx/issues/370#issuecomment-2074087961 > Pages I cited are implemented in a project agnostic way. They really do not read like that. They are heavily oriented towards Log4j. > The goal is to >

Re: [PR] Add links to Logging Services support, security and download pages [logging-log4cxx]

2024-04-23 Thread via GitHub
swebb2066 commented on PR #372: URL: https://github.com/apache/logging-log4cxx/pull/372#issuecomment-2074155378 The [1.3.0 staging web site](https://logging.staged.apache.org/log4cxx/1.3.0) is available for review. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Use Logging Services common pages [logging-log4cxx]

2024-04-24 Thread via GitHub
vy commented on issue #370: URL: https://github.com/apache/logging-log4cxx/issues/370#issuecomment-2074228484 > > Pages I cited are implemented in a project agnostic way. > > They really do not read like that. They are heavily oriented towards Log4j. Please feel free to make ch

Re: [I] `PropertiesUtil` fails due to blank key lookup (logging-log4j2)

2024-04-24 Thread via GitHub
vy closed issue #2414: `PropertiesUtil` fails due to blank key lookup URL: https://github.com/apache/logging-log4j2/issues/2414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Use Logging Services common pages [logging-log4cxx]

2024-04-24 Thread via GitHub
swebb2066 commented on issue #370: URL: https://github.com/apache/logging-log4cxx/issues/370#issuecomment-2074336080 > Please feel free to make changes as see fit I am not convinced generalised documentation is good documentation so I would not be able to help. > Log4cxx has o

Re: [I] Use Logging Services common pages [logging-log4cxx]

2024-04-24 Thread via GitHub
vy commented on issue #370: URL: https://github.com/apache/logging-log4cxx/issues/370#issuecomment-2074399373 @swebb2066, [I offered you to close this ticket if you think Log4cxx is doing fine](https://github.com/apache/logging-log4cxx/issues/370#issuecomment-2071664759): > If, as t

Re: [I] Use Logging Services common pages [logging-log4cxx]

2024-04-24 Thread via GitHub
vy commented on issue #370: URL: https://github.com/apache/logging-log4cxx/issues/370#issuecomment-2074403480 > Adding Log4cxx and Log4Net to the coverage makes it hard to write user specific text. For the record, this statement is not completely correct; Log4Net is already using th

Re: [PR] Bump org.apache.maven.plugins:maven-shade-plugin from 3.5.2 to 3.5.3 [logging-log4j-kotlin]

2024-04-24 Thread via GitHub
github-actions[bot] merged PR #72: URL: https://github.com/apache/logging-log4j-kotlin/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-2 to 1.5.6-3 (logging-log4j2)

2024-04-24 Thread via GitHub
github-actions[bot] merged PR #2504: URL: https://github.com/apache/logging-log4j2/pull/2504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Close stale issues (logging-log4j2)

2024-04-24 Thread via GitHub
ppkarwasz commented on PR #2500: URL: https://github.com/apache/logging-log4j2/pull/2500#issuecomment-2074727316 @vy, I added a second workflow that adds a `waiting-for-maintainer` label and removes `waiting-for-user` whenever: * an issue is created, * a user comments on an

Re: [PR] Fix handling of `log4j2.messageFactory` and `log4j2.flowMessageFactory` properties (logging-log4j2)

2024-04-24 Thread via GitHub
ppkarwasz commented on code in PR #2505: URL: https://github.com/apache/logging-log4j2/pull/2505#discussion_r1577750867 ## log4j-core/src/main/java/org/apache/logging/log4j/core/Logger.java: ## @@ -63,16 +77,82 @@ public class Logger extends AbstractLogger implements Supplier {

Re: [PR] Close stale issues (logging-log4j2)

2024-04-24 Thread via GitHub
vy commented on code in PR #2500: URL: https://github.com/apache/logging-log4j2/pull/2500#discussion_r1577748113 ## .github/workflows/close-stale.yaml: ## @@ -0,0 +1,39 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

Re: [I] Use Logging Services common pages [logging-log4cxx]

2024-04-24 Thread via GitHub
swebb2066 closed issue #370: Use Logging Services common pages URL: https://github.com/apache/logging-log4cxx/issues/370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Fix handling of `log4j2.messageFactory` and `log4j2.flowMessageFactory` properties (logging-log4j2)

2024-04-24 Thread via GitHub
vy commented on code in PR #2505: URL: https://github.com/apache/logging-log4j2/pull/2505#discussion_r1577848392 ## log4j-core/src/main/java/org/apache/logging/log4j/core/Logger.java: ## @@ -63,16 +77,82 @@ public class Logger extends AbstractLogger implements Supplier { p

Re: [PR] Bump org.apache.tomcat:tomcat-juli from 10.1.20 to 10.1.23 (logging-log4j2)

2024-04-24 Thread via GitHub
github-actions[bot] merged PR #2502: URL: https://github.com/apache/logging-log4j2/pull/2502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[I] Revamp the F.A.Q. page [2.x] (logging-log4j2)

2024-04-24 Thread via GitHub
vy opened a new issue, #2506: URL: https://github.com/apache/logging-log4j2/issues/2506 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), revamp `faq.adoc` with following goals in mind: - Rework the exist

[I] Create a _"Log4j in under 2 minutes!"_ page (logging-log4j2)

2024-04-24 Thread via GitHub
vy opened a new issue, #2507: URL: https://github.com/apache/logging-log4j2/issues/2507 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), create a _"Log4j in under 2 minutes!"_ page with following goals in mind:

[I] Create a `Concepts` page (logging-log4j2)

2024-04-24 Thread via GitHub
vy opened a new issue, #2508: URL: https://github.com/apache/logging-log4j2/issues/2508 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), create a `concepts.adoc` such that: - Title: _"Log4j, SLF4J, JUL,

Re: [PR] Close stale issues (logging-log4j2)

2024-04-24 Thread via GitHub
ppkarwasz merged PR #2500: URL: https://github.com/apache/logging-log4j2/pull/2500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-24 Thread via GitHub
michaelbraun opened a new pull request, #2515: URL: https://github.com/apache/logging-log4j2/pull/2515 In a few places in code, DateTimeFormatter.format(...) is called on an Instant, which creates a new String, when this is just appended to a StringBuilder. This can be improved by calling D

Re: [PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-24 Thread via GitHub
michaelbraun commented on PR #2515: URL: https://github.com/apache/logging-log4j2/pull/2515#issuecomment-2075884028 > @michaelbraun, > > Looks good to me. Thank you for your contribution. Does this change need a file in the changelog or additional tests before merging? -- T

[I] JsonTemplateLayout: java.lang.OutOfMemoryError: Java heap space java.lang.OutOfMemoryError: Java heap space (logging-log4j2)

2024-04-24 Thread via GitHub
PassiveIncomeMachine opened a new issue, #2516: URL: https://github.com/apache/logging-log4j2/issues/2516 ## Constructor ERROR Could not create plugin of type class org.apache.logging.log4j.layout.template.json.JsonTemplateLayout for element JsonTemplateLayout: java.lang.OutOfMemoryError: J

Re: [PR] Keep mutex locked when changing the variable that change the condition [logging-log4cxx]

2024-04-24 Thread via GitHub
swebb2066 merged PR #371: URL: https://github.com/apache/logging-log4cxx/pull/371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-24 Thread via GitHub
ppkarwasz commented on PR #2515: URL: https://github.com/apache/logging-log4j2/pull/2515#issuecomment-2076300336 I don't think additional tests are needed, since your changes should be covered by the current ones. Please add a changelog entry. -- This is an automated message from t

Re: [I] .NET8.0 XML Exception Problem (logging-log4net)

2024-04-24 Thread via GitHub
SwEngine commented on issue #142: URL: https://github.com/apache/logging-log4net/issues/142#issuecomment-2076426672 I am on vacation, but next week I will look at again, thank you so much! -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Bump dependabot/fetch-metadata from 2.0.0 to 2.1.0 [logging-parent]

2024-04-25 Thread via GitHub
github-actions[bot] merged PR #166: URL: https://github.com/apache/logging-parent/pull/166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[I] Add an `Installation` page and rework the `Download` page (logging-log4net)

2024-04-25 Thread via GitHub
vy opened a new issue, #146: URL: https://github.com/apache/logging-log4net/issues/146 _[**Disclaimer:** I am not a .NET developer. Apologies in advance if I say something nonsense.]_ Currently, in the Log4Net website, I am not able to quickly answer the following questions: *

[PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
ppkarwasz opened a new pull request, #2517: URL: https://github.com/apache/logging-log4j2/pull/2517 Currently, if `log4j2.isWebapp` is enabled, the effective values of the following system properties: * `log4j2.enableThreadlocals`, * `log4j2.garbagefreeThreadLocalMap`, * `log4j2

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
ppkarwasz commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579370783 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## @@ -326,12 +326,10 @@ public String getThreadContextMap() { return threa

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
ppkarwasz commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579370783 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## @@ -326,12 +326,10 @@ public String getThreadContextMap() { return threa

<    5   6   7   8   9   10   11   12   13   14   >