Re: [I] New Feature: Add stacktrace package-name filtering for JsonTemplateLayout like it exists for PatternLayout (logging-log4j2)

2024-04-10 Thread via GitHub
vy commented on issue #1941: URL: https://github.com/apache/logging-log4j2/issues/1941#issuecomment-2046733323 @abhijit911turbo, @takanuva15, sorry to break it to you, but if you need this feature from Log4j, which I presume is deployed at an organization helping you to pay your bills at t

[PR] Bump com.github.spotbugs:spotbugs-maven-plugin from 4.8.3.1 to 4.8.4.0 [logging-parent]

2024-04-10 Thread via GitHub
dependabot[bot] opened a new pull request, #156: URL: https://github.com/apache/logging-parent/pull/156 Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.8.3.1 to 4.8.4.0. Release notes Sourced from https://github.com/spotb

Re: [PR] Bump com.github.spotbugs:spotbugs-maven-plugin from 4.8.3.1 to 4.8.4.0 [logging-parent]

2024-04-10 Thread via GitHub
github-actions[bot] merged PR #156: URL: https://github.com/apache/logging-parent/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Raman Gupta: correct timezone (logging-log4j2)

2024-04-10 Thread via GitHub
rocketraman commented on PR #2463: URL: https://github.com/apache/logging-log4j2/pull/2463#issuecomment-2047373711 > @rocketraman, come on, we don't need a PR for these kind of changes. 😅 Just push it to `2.x`, `main`, etc. next time, please. Ok! :-) -- This is an automated message

[PR] Add 'persist-credentials: false' to all Github checkout actions [logging-log4cxx]

2024-04-10 Thread via GitHub
swebb2066 opened a new pull request, #367: URL: https://github.com/apache/logging-log4cxx/pull/367 This PR applies a [policy recommended by Apache InfraStructure](https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status#GitHubActionsstatus-Mitigations) -- This is an automa

Re: [PR] Add 'persist-credentials: false' to all Github checkout actions [logging-log4cxx]

2024-04-10 Thread via GitHub
swebb2066 commented on PR #367: URL: https://github.com/apache/logging-log4cxx/pull/367#issuecomment-2048943481 Not sure this is actually necessary. There seems to be a mismatch bewteen the [documentated default](https://github.com/actions/checkout/blob/cd7d8d697e10461458bc61a30d094dc601a8b

Re: [PR] Bump spring-framework.version from 6.1.5 to 6.1.6 (logging-log4j2)

2024-04-11 Thread via GitHub
github-actions[bot] merged PR #2465: URL: https://github.com/apache/logging-log4j2/pull/2465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] Bump org.springframework:spring-framework-bom from 5.3.33 to 5.3.34 [logging-log4j-audit-sample]

2024-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #44: URL: https://github.com/apache/logging-log4j-audit-sample/pull/44 Bumps [org.springframework:spring-framework-bom](https://github.com/spring-projects/spring-framework) from 5.3.33 to 5.3.34. Release notes Sourced from https://github.

Re: [PR] Bump org.springframework:spring-framework-bom from 5.3.33 to 5.3.34 [logging-log4j-audit-sample]

2024-04-11 Thread via GitHub
github-actions[bot] merged PR #44: URL: https://github.com/apache/logging-log4j-audit-sample/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

Re: [PR] Bump commons-io:commons-io from 2.16.0 to 2.16.1 (logging-log4j2)

2024-04-11 Thread via GitHub
github-actions[bot] merged PR #2456: URL: https://github.com/apache/logging-log4j2/pull/2456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.apache.activemq:activemq-broker from 6.1.0 to 6.1.1 (logging-log4j2)

2024-04-11 Thread via GitHub
github-actions[bot] merged PR #2452: URL: https://github.com/apache/logging-log4j2/pull/2452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump spring-framework.version from 5.3.33 to 5.3.34 (logging-log4j2)

2024-04-11 Thread via GitHub
github-actions[bot] merged PR #2464: URL: https://github.com/apache/logging-log4j2/pull/2464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.elasticsearch.client:elasticsearch-rest-high-level-client from 7.17.19 to 7.17.20 (logging-log4j2)

2024-04-11 Thread via GitHub
github-actions[bot] merged PR #2455: URL: https://github.com/apache/logging-log4j2/pull/2455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561370434 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561368718 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2050174486 I have done major refactoring to the PR based on some of your comments. So I am not sure how much of the comments above now apply. -- This is an automated message from the Apache

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561452144 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Backport part of #2062 to `2.x` branch. (logging-log4j2)

2024-04-11 Thread via GitHub
vy commented on code in PR #2454: URL: https://github.com/apache/logging-log4j2/pull/2454#discussion_r1561569850 ## log4j-api/src/main/java/org/apache/logging/log4j/util/PropertySource.java: ## @@ -101,10 +101,12 @@ class Comparator implements java.util.Comparator, Serializable

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
vy commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561600267 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561630657 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561634223 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561648835 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561650920 ## log4j-api-test/src/test/java/org/apache/logging/log4j/ScopedContextTest.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561657002 ## log4j-api/src/main/java/org/apache/logging/log4j/message/package-info.java: ## @@ -20,7 +20,7 @@ */ @Export /** - * Bumped to 2.22.0, since FormattedMessag

[I] Log4J in desktop application (logging-log4j2)

2024-04-11 Thread via GitHub
tmmlsBE opened a new issue, #2466: URL: https://github.com/apache/logging-log4j2/issues/2466 I'm having an issue with Log4J. It doesn't output my messages in a compiled application (compiled using jPackage). It does work when run the jar file. The issue is described at https://st

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561821021 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561821021 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561821021 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561821021 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561821021 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1561821021 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[PR] Bump org.springframework:spring-framework-bom from 5.3.33 to 5.3.34 [logging-log4j-samples]

2024-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #126: URL: https://github.com/apache/logging-log4j-samples/pull/126 Bumps [org.springframework:spring-framework-bom](https://github.com/spring-projects/spring-framework) from 5.3.33 to 5.3.34. Release notes Sourced from https://github.com

Re: [PR] Bump org.springframework:spring-framework-bom from 5.3.33 to 5.3.34 [logging-log4j-samples]

2024-04-11 Thread via GitHub
github-actions[bot] merged PR #126: URL: https://github.com/apache/logging-log4j-samples/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Add 'persist-credentials: false' to all Github checkout actions [logging-log4cxx]

2024-04-11 Thread via GitHub
swebb2066 merged PR #367: URL: https://github.com/apache/logging-log4cxx/pull/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1552486927 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Backport part of #2062 to `2.x` branch. (logging-log4j2)

2024-04-11 Thread via GitHub
rgoers commented on code in PR #2454: URL: https://github.com/apache/logging-log4j2/pull/2454#discussion_r1562074401 ## log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java: ## @@ -540,18 +552,18 @@ private synchronized void reload() { final

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-11 Thread via GitHub
ppkarwasz commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1562087991 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/DefaultThreadContextMap.java: ## @@ -231,4 +231,21 @@ public boolean equals(final Object obj) {

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-12 Thread via GitHub
ppkarwasz commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1562164031 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-12 Thread via GitHub
ppkarwasz commented on PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#issuecomment-2051291811 > Son of a gun, I forgot to hit submit so none of my comments have been viewable. It happens to me all the time or even I hit it, but a network problem prevents the commen

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-12 Thread via GitHub
ppkarwasz commented on PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#issuecomment-2051349123 I realized now that in this PR I assume that the `Object` returned by `saveMap` will be used **only** once in a `restoreMap` call. This assumption might be too restrictive for co

Re: [PR] Simplify `DefaultScopedContextProvider` (logging-log4j2)

2024-04-12 Thread via GitHub
ppkarwasz closed pull request #2450: Simplify `DefaultScopedContextProvider` URL: https://github.com/apache/logging-log4j2/pull/2450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Simplify `DefaultScopedContextProvider` (logging-log4j2)

2024-04-12 Thread via GitHub
ppkarwasz commented on PR #2450: URL: https://github.com/apache/logging-log4j2/pull/2450#issuecomment-2051463364 I closed it, since a similar solution appeared in #2438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [I] Use non-commercial host for SslConfigurationTest (logging-log4j2)

2024-04-12 Thread via GitHub
vy closed issue #2467: Use non-commercial host for SslConfigurationTest URL: https://github.com/apache/logging-log4j2/issues/2467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Use non-commercial host for SslConfigurationTest (logging-log4j2)

2024-04-12 Thread via GitHub
vy commented on issue #2467: URL: https://github.com/apache/logging-log4j2/issues/2467#issuecomment-2051581481 @sdavids, thanks for the heads up. Fixed in c88a546125f80ce840e96008ae6b96050ff24a7e and c79cc7519c42fed2cfc01c943803d200a66fddd7 for `2.x` and `main`, respectively. -- This is

[PR] Disable JMX bean creation by default (logging-log4j2)

2024-04-12 Thread via GitHub
sdavids opened a new pull request, #2468: URL: https://github.com/apache/logging-log4j2/pull/2468 https://github.com/apache/logging-log4j2/issues/2462#issuecomment-2045821938 ## Checklist * Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` otherwise

Re: [PR] Disable JMX bean creation by default (logging-log4j2)

2024-04-12 Thread via GitHub
sdavids commented on PR #2468: URL: https://github.com/apache/logging-log4j2/pull/2468#issuecomment-2052182025 There are currently no tests for the JMX support. `org.apache.logging.log4j.core.jmx.Server#isJmxDisabled` is `private` and `PropertiesUtil.getProperties()` lazily caches its

[PR] Add service to attach metrics to Log4j Core (logging-log4j2)

2024-04-12 Thread via GitHub
ppkarwasz opened a new pull request, #2469: URL: https://github.com/apache/logging-log4j2/pull/2469 This PR is an evolution of #1943, that adds an easy to use way to add metrics and other instrumentation to Log4j Core. It introduces an `InstrumentationService` class that is used each

Re: [PR] Disable JMX bean creation by default (logging-log4j2)

2024-04-12 Thread via GitHub
sdavids commented on PR #2468: URL: https://github.com/apache/logging-log4j2/pull/2468#issuecomment-2052243202 The double negative `log4j2.disableJmx=false` is unfortunate, but we would have to deprecate an existing system property and introduce a new one `log4j2.enableJmx` otherwise. --

[PR] Bump org.slf4j:slf4j-api from 2.0.12 to 2.0.13 [logging-log4j-transform]

2024-04-12 Thread via GitHub
dependabot[bot] opened a new pull request, #97: URL: https://github.com/apache/logging-log4j-transform/pull/97 Bumps org.slf4j:slf4j-api from 2.0.12 to 2.0.13. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org

Re: [PR] Bump org.slf4j:slf4j-api from 2.0.12 to 2.0.13 [logging-log4j-transform]

2024-04-12 Thread via GitHub
github-actions[bot] merged PR #97: URL: https://github.com/apache/logging-log4j-transform/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Scoped context (logging-log4j2)

2024-04-12 Thread via GitHub
jvz commented on PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2052603332 Would it be possible to key a scoped context on something besides `ThreadContext`? One idea I had was to use a span id (like from OpenTelemetry) as the key for the logical context asso

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-12 Thread via GitHub
jvz commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1563251355 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Add service to attach metrics to Log4j Core (logging-log4j2)

2024-04-12 Thread via GitHub
adamthom-amzn commented on PR #2469: URL: https://github.com/apache/logging-log4j2/pull/2469#issuecomment-2052616884 At first glance, I quite like this approach, and it would help with some other instrumentation I've hacked in - I observe configuration changes to modify all attached appende

Re: [PR] Scoped context (logging-log4j2)

2024-04-12 Thread via GitHub
rgoers commented on PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2053435531 @jvz I don't understand your comment Matt. While a ScopedContext performs a similar function as the ThreadContext (but in a much safer way) it shares no code with it at all. Did yo

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-12 Thread via GitHub
rgoers commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1563689177 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [I] JMX should be disabled by default (logging-log4j2)

2024-04-13 Thread via GitHub
sdavids commented on issue #1229: URL: https://github.com/apache/logging-log4j2/issues/1229#issuecomment-2053717504 https://github.com/apache/logging-log4j2/pull/2468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Scoped context (logging-log4j2)

2024-04-13 Thread via GitHub
ppkarwasz commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1564479010 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Scoped context (logging-log4j2)

2024-04-14 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1564812727 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Add service to attach metrics to Log4j Core (logging-log4j2)

2024-04-14 Thread via GitHub
rgoers commented on code in PR #2469: URL: https://github.com/apache/logging-log4j2/pull/2469#discussion_r1564869924 ## log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java: ## @@ -800,6 +802,12 @@ private void initApiModule() { // LOG4J2-151: changed

Re: [PR] Add service to attach metrics to Log4j Core (logging-log4j2)

2024-04-14 Thread via GitHub
rgoers commented on code in PR #2469: URL: https://github.com/apache/logging-log4j2/pull/2469#discussion_r1564872577 ## log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java: ## @@ -800,6 +802,12 @@ private void initApiModule() { // LOG4J2-151: changed

Re: [PR] Disable JMX bean creation by default (logging-log4j2)

2024-04-14 Thread via GitHub
vy commented on code in PR #2468: URL: https://github.com/apache/logging-log4j2/pull/2468#discussion_r1564897732 ## src/site/antora/modules/ROOT/pages/log4j-jmx-gui.adoc: ## @@ -18,3 +18,10 @@ Licensed to the Apache Software Foundation (ASF) under one or more https://github.

Re: [PR] Disable JMX bean creation by default (logging-log4j2)

2024-04-14 Thread via GitHub
vy commented on code in PR #2468: URL: https://github.com/apache/logging-log4j2/pull/2468#discussion_r1564897732 ## src/site/antora/modules/ROOT/pages/log4j-jmx-gui.adoc: ## @@ -18,3 +18,10 @@ Licensed to the Apache Software Foundation (ASF) under one or more https://github.

Re: [PR] Disable JMX bean creation by default (logging-log4j2)

2024-04-14 Thread via GitHub
vy commented on PR #2468: URL: https://github.com/apache/logging-log4j2/pull/2468#issuecomment-2054169637 > There are currently no tests for the JMX support. > ... > 1. keep the status quo, i.e. no tests I'd be in favor of this approach. I doubt if this feature has any significa

Re: [I] Log4J in desktop application (logging-log4j2)

2024-04-14 Thread via GitHub
vy commented on issue #2466: URL: https://github.com/apache/logging-log4j2/issues/2466#issuecomment-2054171871 @tmmlsBE, Log4j doesn't support native image compilation out-of-the-box currently, see [LOG4J2-2649](https://issues.apache.org/jira/browse/LOG4J2-2649). You need to manually prov

Re: [PR] Scoped context (logging-log4j2)

2024-04-14 Thread via GitHub
ppkarwasz commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1564907528 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [I] Log4J in desktop application (logging-log4j2)

2024-04-14 Thread via GitHub
ppkarwasz commented on issue #2466: URL: https://github.com/apache/logging-log4j2/issues/2466#issuecomment-2054175670 @vy, I never used `jpackage`, but as far as I understood it is just a thin wrapper that unpacks some JAR files and starts up the JVM. In this aspect it should more r

Re: [PR] Scoped context (logging-log4j2)

2024-04-14 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1564941333 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-04-14 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1564941333 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[PR] Bump io.fabric8:kubernetes-client-bom from 6.11.0 to 6.12.0 [logging-log4j-samples]

2024-04-14 Thread via GitHub
dependabot[bot] opened a new pull request, #127: URL: https://github.com/apache/logging-log4j-samples/pull/127 Bumps [io.fabric8:kubernetes-client-bom](https://github.com/fabric8io/kubernetes-client) from 6.11.0 to 6.12.0. Release notes Sourced from https://github.com/fabric8io/ku

[PR] Bump org.slf4j:slf4j-api from 2.0.12 to 2.0.13 [logging-log4j-samples]

2024-04-14 Thread via GitHub
dependabot[bot] opened a new pull request, #128: URL: https://github.com/apache/logging-log4j-samples/pull/128 Bumps org.slf4j:slf4j-api from 2.0.12 to 2.0.13. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org

Re: [PR] Bump io.fabric8:kubernetes-client-bom from 6.11.0 to 6.12.0 [logging-log4j-samples]

2024-04-14 Thread via GitHub
github-actions[bot] merged PR #127: URL: https://github.com/apache/logging-log4j-samples/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Bump org.slf4j:slf4j-api from 2.0.12 to 2.0.13 [logging-log4j-samples]

2024-04-14 Thread via GitHub
github-actions[bot] merged PR #128: URL: https://github.com/apache/logging-log4j-samples/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Scoped context (logging-log4j2)

2024-04-14 Thread via GitHub
rgoers merged PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

[PR] Bump com.h3xstream.findsecbugs:findsecbugs-plugin from 1.12.0 to 1.13.0 [logging-parent]

2024-04-15 Thread via GitHub
dependabot[bot] opened a new pull request, #157: URL: https://github.com/apache/logging-parent/pull/157 Bumps [com.h3xstream.findsecbugs:findsecbugs-plugin](https://github.com/find-sec-bugs/find-sec-bugs) from 1.12.0 to 1.13.0. Release notes Sourced from https://github.com/find-se

Re: [PR] Bump com.h3xstream.findsecbugs:findsecbugs-plugin from 1.12.0 to 1.13.0 [logging-parent]

2024-04-15 Thread via GitHub
github-actions[bot] merged PR #157: URL: https://github.com/apache/logging-parent/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Bump slf4j.version from 1.7.36 to 2.0.13 (logging-log4j2)

2024-04-15 Thread via GitHub
ppkarwasz commented on PR #2473: URL: https://github.com/apache/logging-log4j2/pull/2473#issuecomment-2056976779 Do not merge, see [comment on previous PR](https://github.com/apache/logging-log4j2/pull/2440#issuecomment-2042316912) -- This is an automated message from the Apache Git Servi

[PR] Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 [logging-log4j-audit]

2024-04-15 Thread via GitHub
dependabot[bot] opened a new pull request, #138: URL: https://github.com/apache/logging-log4j-audit/pull/138 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 4.0.0 to 4.0.1. Release notes Sourced from https://github.com/codehaus-plexus

Re: [PR] Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 [logging-log4j-audit]

2024-04-15 Thread via GitHub
github-actions[bot] merged PR #138: URL: https://github.com/apache/logging-log4j-audit/pull/138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [I] [MS11] Log4j API generalization #2 (logging-log4j2)

2024-04-15 Thread via GitHub
grobmeier commented on issue #2290: URL: https://github.com/apache/logging-log4j2/issues/2290#issuecomment-2057552775 Checked, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [I] [MS11] Log4j API generalization #2 (logging-log4j2)

2024-04-15 Thread via GitHub
grobmeier closed issue #2290: [MS11] Log4j API generalization #2 URL: https://github.com/apache/logging-log4j2/issues/2290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 [logging-log4j-transform]

2024-04-15 Thread via GitHub
dependabot[bot] opened a new pull request, #98: URL: https://github.com/apache/logging-log4j-transform/pull/98 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 4.0.0 to 4.0.1. Release notes Sourced from https://github.com/codehaus-plex

Re: [PR] Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 [logging-log4j-transform]

2024-04-15 Thread via GitHub
github-actions[bot] merged PR #98: URL: https://github.com/apache/logging-log4j-transform/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 [logging-log4j-transform]

2024-04-15 Thread via GitHub
github-actions[bot] merged PR #98: URL: https://github.com/apache/logging-log4j-transform/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-15 Thread via GitHub
vy commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1566341055 ## src/changelog/.2.x.x/add_extended_thread_context.xml: ## @@ -0,0 +1,7 @@ + +http://www.w3.org/2001/XMLSchema-instance"; + xmlns="http://logging.apache.org/lo

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-15 Thread via GitHub
vy commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1566341055 ## src/changelog/.2.x.x/add_extended_thread_context.xml: ## @@ -0,0 +1,7 @@ + +http://www.w3.org/2001/XMLSchema-instance"; + xmlns="http://logging.apache.org/lo

Re: [PR] Bump io.netty:netty-bom from 4.1.108.Final to 4.1.109.Final (logging-log4j2)

2024-04-15 Thread via GitHub
ppkarwasz commented on PR #2471: URL: https://github.com/apache/logging-log4j2/pull/2471#issuecomment-2057773475 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump org.apache.activemq:activemq-broker from 6.1.1 to 6.1.2 (logging-log4j2)

2024-04-15 Thread via GitHub
ppkarwasz commented on PR #2472: URL: https://github.com/apache/logging-log4j2/pull/2472#issuecomment-2057773758 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump io.netty:netty-bom from 4.1.108.Final to 4.1.109.Final (logging-log4j2)

2024-04-15 Thread via GitHub
ppkarwasz commented on PR #2474: URL: https://github.com/apache/logging-log4j2/pull/2474#issuecomment-2057774012 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-15 Thread via GitHub
rgoers commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1566715733 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[I] Draft: [MS13] Automate website deployment (logging-log4j2)

2024-04-16 Thread via GitHub
vy opened a new issue, #2476: URL: https://github.com/apache/logging-log4j2/issues/2476 **Abstract:** This PR completes the STF milestone 13 by implementing the infrastructure to auto-deploy the Log4j website from project sources. Due to reasons detailed below, the website support is migrat

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-16 Thread via GitHub
ppkarwasz commented on code in PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1566981486 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-16 Thread via GitHub
ppkarwasz commented on PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#issuecomment-2058655973 @remkop, Is there any usage for context propagation in the "garbage-free world"? My guess is that switching threads using Reactive streams or similar provides too much gar

[PR] Bump github/codeql-action from 3.24.10 to 3.25.0 [logging-parent]

2024-04-16 Thread via GitHub
dependabot[bot] opened a new pull request, #158: URL: https://github.com/apache/logging-parent/pull/158 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.10 to 3.25.0. Changelog Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.m

Re: [PR] Bump github/codeql-action from 3.24.10 to 3.25.0 [logging-parent]

2024-04-16 Thread via GitHub
github-actions[bot] merged PR #158: URL: https://github.com/apache/logging-parent/pull/158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-16 Thread via GitHub
remkop commented on PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#issuecomment-2058746052 > Is there any usage for context propagation in the "garbage-free world"? My guess is that switching threads using Reactive streams or similar provides too much garbage for it to be

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-16 Thread via GitHub
ppkarwasz closed pull request #2442: Add support for thread context map propagation URL: https://github.com/apache/logging-log4j2/pull/2442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Add support for thread context map propagation (logging-log4j2)

2024-04-16 Thread via GitHub
ppkarwasz commented on PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#issuecomment-2058762386 @remkop, > @ppkarwasz I don't think there is a garbage-free way to do Reactive streams. I would keep this simple and not worry about any garbage-free use cases. Tha

[PR] Bump com.h3xstream.findsecbugs:findsecbugs-plugin from 1.12.0 to 1.13.0 [logging-parent]

2024-04-16 Thread via GitHub
dependabot[bot] opened a new pull request, #159: URL: https://github.com/apache/logging-parent/pull/159 Bumps [com.h3xstream.findsecbugs:findsecbugs-plugin](https://github.com/find-sec-bugs/find-sec-bugs) from 1.12.0 to 1.13.0. Release notes Sourced from https://github.com/find-se

Re: [PR] Bump com.h3xstream.findsecbugs:findsecbugs-plugin from 1.12.0 to 1.13.0 [logging-parent]

2024-04-16 Thread via GitHub
github-actions[bot] merged PR #159: URL: https://github.com/apache/logging-parent/pull/159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Bump io.netty:netty-bom from 4.1.108.Final to 4.1.109.Final (logging-log4j2)

2024-04-16 Thread via GitHub
ppkarwasz commented on PR #2471: URL: https://github.com/apache/logging-log4j2/pull/2471#issuecomment-2059194654 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

<    3   4   5   6   7   8   9   10   11   12   >