ppkarwasz commented on code in PR #2438:
URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1554553444
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java:
##
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Apache Softwar
ppkarwasz commented on code in PR #2438:
URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1554553683
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java:
##
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Apache Softwar
rm5248 commented on PR #363:
URL: https://github.com/apache/logging-log4cxx/pull/363#issuecomment-2041068413
Note: the `APACHE_MAINTAINER` flag does this already:
https://github.com/apache/logging-log4cxx/blob/ac7eda0d371a2812a3973b817bba9b6f95c968db/CMakeLists.txt#L265
The one thing
swebb2066 commented on PR #363:
URL: https://github.com/apache/logging-log4cxx/pull/363#issuecomment-2041324707
> Note: the APACHE_MAINTAINER flag does this already:
Using CPack would be acceptable if it supported a white-list instead of an
ignore-list. At this time, packaging source
ritzow opened a new issue, #2449:
URL: https://github.com/apache/logging-log4j2/issues/2449
## Description
I believe that adding `extends java.util.function.Supplier` to
`log4j-api/src/main/java/org/apache/logging/log4j/util/Supplier.java` may have
caused binary or source code incomp
ritzow commented on issue #2449:
URL:
https://github.com/apache/logging-log4j2/issues/2449#issuecomment-2041349748
@ppkarwasz I think I may have found a sneaky bug with a change you made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
bharathchandrathakkallapally-cpi commented on issue #2447:
URL:
https://github.com/apache/logging-log4j2/issues/2447#issuecomment-2041354023
@tcmot according the thread dump analysis we did, there is no deadlock.
@jvz If it is related to the rollover, this issue should be only seen a
ritzow closed issue #2449: Lambda expressions compiled with a previous version
of `org.apache.logging.log4j.util.Supplier.java` or `MessageSupplier` fail to
generate
URL: https://github.com/apache/logging-log4j2/issues/2449
--
This is an automated message from the Apache Git Service.
To resp
tcmot commented on issue #2447:
URL:
https://github.com/apache/logging-log4j2/issues/2447#issuecomment-2041371880
Are all servers like this? Is there a problem with the hard drive? If there
is no deadlock, it is likely that data cannot be written to the hard drive.
@bharathchandrath
bharathchandrathakkallapally-cpi commented on issue #2447:
URL:
https://github.com/apache/logging-log4j2/issues/2447#issuecomment-2041407219
@tcmot yes, all the servers in the cluster are facing this issue. There is
no problem with the hard drive or IO, we had the AWS guy checked our quota
rm5248 commented on code in PR #364:
URL: https://github.com/apache/logging-log4cxx/pull/364#discussion_r1555094695
##
src/site/markdown/development/build-cmake.md:
##
@@ -22,28 +22,82 @@ Building with CMake {#build-cmake}
-->
[TOC]
-## Quick start:
+# Supported options
-
swebb2066 commented on code in PR #364:
URL: https://github.com/apache/logging-log4cxx/pull/364#discussion_r1555144938
##
src/site/markdown/4-build.md:
##
@@ -21,9 +21,17 @@ Build {#build}
limitations under the License.
-->
+As of version 0.11.0, the only supported build sy
swebb2066 commented on code in PR #364:
URL: https://github.com/apache/logging-log4cxx/pull/364#discussion_r1555146356
##
src/site/markdown/development/build-cmake.md:
##
@@ -22,28 +22,82 @@ Building with CMake {#build-cmake}
-->
[TOC]
-## Quick start:
+# Supported options
swebb2066 commented on code in PR #364:
URL: https://github.com/apache/logging-log4cxx/pull/364#discussion_r1555146356
##
src/site/markdown/development/build-cmake.md:
##
@@ -22,28 +22,82 @@ Building with CMake {#build-cmake}
-->
[TOC]
-## Quick start:
+# Supported options
swebb2066 merged PR #363:
URL: https://github.com/apache/logging-log4cxx/pull/363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr
swebb2066 merged PR #364:
URL: https://github.com/apache/logging-log4cxx/pull/364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr
swebb2066 opened a new pull request, #365:
URL: https://github.com/apache/logging-log4cxx/pull/365
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
swebb2066 commented on PR #365:
URL: https://github.com/apache/logging-log4cxx/pull/365#issuecomment-2041833640
Benchmark results on Ubuntu gcc 11.4 comparing v1.2.0.json to v1.3.0.json
|Benchmark |Time |CPU |Time Old |Time New |CPU Old |CPU New |
| | | -- | --- | ---
swebb2066 commented on PR #365:
URL: https://github.com/apache/logging-log4cxx/pull/365#issuecomment-2041863687
Benchmark results on Windows 11 VS2022 comparing v1.2.0.json to v1.3.0.json
| Benchmark | Time | CPU | Time Old | Time New | CPU Old | CPU New |
| --- | - | |
ppkarwasz commented on issue #2447:
URL:
https://github.com/apache/logging-log4j2/issues/2447#issuecomment-2042086722
I think that the crucial information that is missing here, is what is thread
`http-nio-8080-exec-123` waiting for. The lock on `RollingFileManager` should
be the last one r
ppkarwasz opened a new pull request, #2450:
URL: https://github.com/apache/logging-log4j2/pull/2450
This PR simplifies the logic of `DefaultScopedContextProvider`, by using two
kinds of `ScopedContext.Instance` implementations:
- `MapInstance` is a simple container for an immutable ma
ppkarwasz commented on code in PR #2438:
URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1555475924
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java:
##
@@ -0,0 +1,421 @@
+/*
+ * Licensed to the Apache Softwar
ppkarwasz commented on code in PR #2438:
URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1555476864
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java:
##
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Apache Softwar
ppkarwasz commented on PR #2435:
URL: https://github.com/apache/logging-log4j2/pull/2435#issuecomment-2042296049
@vy,
> Could you double-check that the `src/site` doesn't need to be updated,
please?
I migrated the documentation of the code generator to the
apache/logging-log4j
ppkarwasz commented on PR #2440:
URL: https://github.com/apache/logging-log4j2/pull/2440#issuecomment-2042316912
We already have a Dependabot rule that should prevent such proposals:
```yaml
# SLF4J 1.7.x should only upgrade to 1.7.x and
# SLF4J 2.x should only upgrade to
vy opened a new pull request, #150:
URL: https://github.com/apache/logging-parent/pull/150
This PR addresses #138.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
ppkarwasz commented on code in PR #150:
URL: https://github.com/apache/logging-parent/pull/150#discussion_r164230
##
src/site/_release-instructions-xml-schema.adoc:
##
@@ -0,0 +1,67 @@
+
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor lic
ppkarwasz merged PR #2435:
URL: https://github.com/apache/logging-log4j2/pull/2435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
dependabot[bot] opened a new pull request, #151:
URL: https://github.com/apache/logging-parent/pull/151
Bumps
[com.palantir.javaformat:palantir-java-format](https://github.com/palantir/palantir-java-format)
from 2.41.0 to 2.42.0.
Release notes
Sourced from https://github.com/palan
dependabot[bot] opened a new pull request, #152:
URL: https://github.com/apache/logging-parent/pull/152
Bumps
[com.github.spotbugs:spotbugs-annotations](https://github.com/spotbugs/spotbugs)
from 4.8.3 to 4.8.4.
Changelog
Sourced from https://github.com/spotbugs/spotbugs/blob/mast
github-actions[bot] merged PR #151:
URL: https://github.com/apache/logging-parent/pull/151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications
github-actions[bot] merged PR #151:
URL: https://github.com/apache/logging-parent/pull/151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications
github-actions[bot] merged PR #152:
URL: https://github.com/apache/logging-parent/pull/152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications
dependabot[bot] opened a new pull request, #153:
URL: https://github.com/apache/logging-parent/pull/153
Bumps [github/codeql-action](https://github.com/github/codeql-action) from
3.24.9 to 3.24.10.
Changelog
Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.m
github-actions[bot] merged PR #153:
URL: https://github.com/apache/logging-parent/pull/153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications
vy merged PR #150:
URL: https://github.com/apache/logging-parent/pull/150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logg
vy commented on code in PR #150:
URL: https://github.com/apache/logging-parent/pull/150#discussion_r1555634876
##
src/site/_release-instructions-xml-schema.adoc:
##
@@ -0,0 +1,67 @@
+
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license ag
github-actions[bot] merged PR #2451:
URL: https://github.com/apache/logging-log4j2/pull/2451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
bharathchandrathakkallapally-cpi commented on issue #2447:
URL:
https://github.com/apache/logging-log4j2/issues/2447#issuecomment-2042573768
@ppkarwasz here is the data your are asking
```
"http-nio-8080-exec-123" #2723 daemon prio=5 os_prio=0
tid=0x7f7e94095800 nid=0x34a8f waitin
ppkarwasz commented on issue #2447:
URL:
https://github.com/apache/logging-log4j2/issues/2447#issuecomment-2042579641
@bharathchandrathakkallapally-cpi,
Any idea what kind of object `0x7f7ea87c4000` might be? Does it appear
in the stacktraces of other threads?
--
This is an au
bharathchandrathakkallapally-cpi commented on issue #2447:
URL:
https://github.com/apache/logging-log4j2/issues/2447#issuecomment-2042613196
@ppkarwasz
It appeared in the stacktrace of another thread, that is trace is pointing
to a line in the code, but that line or method the thread is
bharathchandrathakkallapally-cpi commented on issue #2447:
URL:
https://github.com/apache/logging-log4j2/issues/2447#issuecomment-2042616999
sorry, the object `0x7f7ea87c4000` only appeared once in the dump, and
it is with the "http-nio-8080-exec-123" thread .
--
This is an automate
FreeAndNil merged PR #141:
URL: https://github.com/apache/logging-log4net/pull/141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
clobotorre opened a new issue, #366:
URL: https://github.com/apache/logging-log4cxx/issues/366
Based on the answer to this issue
https://github.com/apache/logging-log4cxx/issues/362 I have done following
steps on both Ubuntu 18.04 and Ubuntu 22.04.
Initial steps
```
# mkdi
rm5248 commented on issue #366:
URL:
https://github.com/apache/logging-log4cxx/issues/366#issuecomment-2043275966
If it's only the tests, you can just disable the tests(add
`-DBUILD_TESTING=OFF` when configuring with cmake). Or, add `-ldl` to your
linker flags.
Is there a particula
clobotorre commented on issue #366:
URL:
https://github.com/apache/logging-log4cxx/issues/366#issuecomment-2043324141
Thank you. I'll use `-DBUILD_TESTING=OFF`
I need APR libs statically linked because in the target machines there are
already another (needed) version of APR libs wich
vy closed issue #121: Retain `project.build.outputTimestamp` property while
trimming BOM
URL: https://github.com/apache/logging-parent/issues/121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vy commented on issue #121:
URL: https://github.com/apache/logging-parent/issues/121#issuecomment-2043511073
This turned out to be pretty difficult to implement – [fact checked this in
#maven](https://the-asf.slack.com/archives/C7Q9JB404/p1712563548050659). AFAIC,
we don't have a choice but
dependabot[bot] opened a new pull request, #96:
URL: https://github.com/apache/logging-log4j-transform/pull/96
Bumps commons-io:commons-io from 2.16.0 to 2.16.1.
[ fails
URL: https://github.com/apache/logging-log4j2/issues/2434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ppkarwasz commented on PR #2454:
URL: https://github.com/apache/logging-log4j2/pull/2454#issuecomment-2044511229
I also included a fix for
[`LOG4J2-3618`](https://issues.apache.org/jira/browse/LOG4J2-3618) in this PR,
which caused the original test case to fail.
If your prefer to spl
github-actions[bot] merged PR #2459:
URL: https://github.com/apache/logging-log4j2/pull/2459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
vy opened a new pull request, #155:
URL: https://github.com/apache/logging-parent/pull/155
apache/logging-log4j2#2427 migrated Log4j 2 to Antora.
apache/logging-log4j2#2443 cloned this work for Log4j 3. This PR clones the
very same work to `logging-parent` to streamline it for all projects
vy commented on code in PR #155:
URL: https://github.com/apache/logging-parent/pull/155#discussion_r1557452855
##
.github/workflows/build-reusable.yaml:
##
@@ -69,9 +69,34 @@ jobs:
-DinstallAtEnd=true \
clean install
+ # Node.js cache is needed f
github-actions[bot] merged PR #2458:
URL: https://github.com/apache/logging-log4j2/pull/2458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
vy commented on code in PR #155:
URL: https://github.com/apache/logging-parent/pull/155#discussion_r1557457799
##
.github/workflows/deploy-release-reusable.yaml:
##
@@ -28,10 +28,6 @@ on:
description: Identifier used in the distribution artifact and
Subversion reposito
dependabot[bot] opened a new pull request, #154:
URL: https://github.com/apache/logging-parent/pull/154
Bumps
[com.palantir.javaformat:palantir-java-format](https://github.com/palantir/palantir-java-format)
from 2.42.0 to 2.43.0.
Release notes
Sourced from https://github.com/palan
vy commented on code in PR #155:
URL: https://github.com/apache/logging-parent/pull/155#discussion_r1557457799
##
.github/workflows/deploy-release-reusable.yaml:
##
@@ -28,10 +28,6 @@ on:
description: Identifier used in the distribution artifact and
Subversion reposito
vy commented on code in PR #155:
URL: https://github.com/apache/logging-parent/pull/155#discussion_r1557460646
##
.github/workflows/deploy-release-reusable.yaml:
##
@@ -264,18 +280,16 @@ jobs:
# Checkout the SVN repository
export SVN_DIR="/tmp/svn-repo"
github-actions[bot] merged PR #154:
URL: https://github.com/apache/logging-parent/pull/154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications
github-actions[bot] merged PR #154:
URL: https://github.com/apache/logging-parent/pull/154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications
github-actions[bot] merged PR #2457:
URL: https://github.com/apache/logging-log4j2/pull/2457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
ppkarwasz commented on code in PR #155:
URL: https://github.com/apache/logging-parent/pull/155#discussion_r1557474903
##
src/site/antora/.antora.yml:
##
@@ -0,0 +1,54 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
ppkarwasz commented on code in PR #155:
URL: https://github.com/apache/logging-parent/pull/155#discussion_r1557475697
##
.github/workflows/build-reusable.yaml:
##
@@ -69,9 +69,34 @@ jobs:
-DinstallAtEnd=true \
clean install
+ # Node.js cache is n
ppkarwasz commented on code in PR #155:
URL: https://github.com/apache/logging-parent/pull/155#discussion_r1557476256
##
.github/workflows/deploy-release-reusable.yaml:
##
@@ -264,18 +280,16 @@ jobs:
# Checkout the SVN repository
export SVN_DIR="/tmp/svn-re
ppkarwasz commented on PR #155:
URL: https://github.com/apache/logging-parent/pull/155#issuecomment-2044825724
Since all this PR does is modifying Github Actions can you stage the website
after merging this PR to confirm that it works as required?
--
This is an automated message from the
ppkarwasz opened a new pull request, #2460:
URL: https://github.com/apache/logging-log4j2/pull/2460
We clean up `PropertyEnvironment` from all the unused public methods.
Since all the classes should only use `getProperty(Class)`, the other
converter methods are not necessary. We keep
ppkarwasz commented on issue #2449:
URL:
https://github.com/apache/logging-log4j2/issues/2449#issuecomment-2045090142
@ritzow,
Thank you for pointing out this problem. I was sure I left a comment two
days ago, but AJAX must have eaten it.
We did two apparently backward compati
ppkarwasz opened a new issue, #2461:
URL: https://github.com/apache/logging-log4j2/issues/2461
As discussed in [this `dev@logging`
thread](https://lists.apache.org/thread/dvmtok2wxfskw94d8pv0bq73yom8sq74) it
should be
safe to remove `log4j-1.2-api` from the 3.x release.
**Remark**
jvz commented on issue #2449:
URL:
https://github.com/apache/logging-log4j2/issues/2449#issuecomment-2045575558
BND might not have noticed because it's a strange edge case involving type
erasure and default methods.
I think we should revert the `MessageSupplier` changes since the API
abhijit911turbo commented on issue #1941:
URL:
https://github.com/apache/logging-log4j2/issues/1941#issuecomment-2045600664
Hello, Any ETA on this enhancement? Would really love to have this released
--
This is an automated message from the Apache Git Service.
To respond to the message, p
dependabot[bot] opened a new pull request, #137:
URL: https://github.com/apache/logging-log4j-audit/pull/137
Bumps commons-io:commons-io from 2.16.0 to 2.16.1.
[
[Spring Boot - Do not create log4j2 JMX beans if
spring.jmx.enabl
ppkarwasz closed issue #2449: Lambda expressions compiled with a previous
version of `org.apache.logging.log4j.util.Supplier.java` or `MessageSupplier`
fail to generate
URL: https://github.com/apache/logging-log4j2/issues/2449
--
This is an automated message from the Apache Git Service.
To r
ppkarwasz commented on issue #2449:
URL:
https://github.com/apache/logging-log4j2/issues/2449#issuecomment-2045801954
I did some more testing and what happened is that in `3.0.0-beta2` we
redefined `MessageSupplier` as:
```java
public interface MessageSupplier extends Supplier {}
ppkarwasz commented on issue #2462:
URL:
https://github.com/apache/logging-log4j2/issues/2462#issuecomment-2045821938
@sdavids,
Would disabling JMX by default work for you (cf. #1229)? We are open to PRs
in that direction.
--
This is an automated message from the Apache Git Servic
sdavids commented on issue #2462:
URL:
https://github.com/apache/logging-log4j2/issues/2462#issuecomment-2045832021
Yeah, it would be a good idea from a security standpoint also.
I am not sure about backward compatibility though …
--
This is an automated message from the Apache Git
ppkarwasz commented on issue #2462:
URL:
https://github.com/apache/logging-log4j2/issues/2462#issuecomment-2045848752
We accept such behavioral changes in minor releases. Users can always revert
it through a system property.
--
This is an automated message from the Apache Git Service.
To
vy commented on code in PR #155:
URL: https://github.com/apache/logging-parent/pull/155#discussion_r1558139173
##
src/site/antora/.antora.yml:
##
@@ -0,0 +1,54 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the
vy commented on PR #155:
URL: https://github.com/apache/logging-parent/pull/155#issuecomment-2045868015
> Since all this PR does is modifying Github Actions can you stage the
website after merging this PR to confirm that it works as required?
I will do that in my follow up PR, where I
vy merged PR #155:
URL: https://github.com/apache/logging-parent/pull/155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logg
vy commented on issue #2449:
URL:
https://github.com/apache/logging-log4j2/issues/2449#issuecomment-2045930917
@jvz, @ppkarwasz, as I understand from Piotr's explanation, the rationale
behind this change is to allow several `MessageSupplier` usages in `log4j-core`
to switch to `Supplier` i
ppkarwasz commented on issue #2449:
URL:
https://github.com/apache/logging-log4j2/issues/2449#issuecomment-2045959561
> * I could have bought this plan as a twilight state until we get rid
off `MessageSupplier`, but we all know that removing stuff from `log4j-api` is
a _"pipe dream"_.
takanuva15 commented on issue #1941:
URL:
https://github.com/apache/logging-log4j2/issues/1941#issuecomment-2046107677
@abhijit911turbo It's still under development on my fork; been distracted
with other things that life has thrown on me lol. No definite ETA I can give
you at this point
rocketraman opened a new pull request, #2463:
URL: https://github.com/apache/logging-log4j2/pull/2463
Correct my time zone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
vy commented on issue #2449:
URL:
https://github.com/apache/logging-log4j2/issues/2449#issuecomment-2046702649
I am not strongly opinionated, but I suggest reverting the `MessageSupplier`
change and only keeping the `@FunctionalInterface`. It increases complexity,
brings marginal benefit,
vy merged PR #2463:
URL: https://github.com/apache/logging-log4j2/pull/2463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@lo
601 - 700 of 13987 matches
Mail list logo
