[PR] Move configuration format converter from `log4j-1.2-api` [logging-log4j-transform]

2024-04-01 Thread via GitHub
ppkarwasz opened a new pull request, #93: URL: https://github.com/apache/logging-log4j-transform/pull/93 This moves the converter between `log4j.properties` and `log4j2.xml` from `log4j-1.2-api` to a new `log4j-config-converter` artifact. -- This is an automated message from the Apache Gi

[PR] Remove CLI tools from `log4j-core` and `log4j-1.2-api` (logging-log4j2)

2024-04-01 Thread via GitHub
ppkarwasz opened a new pull request, #2435: URL: https://github.com/apache/logging-log4j2/pull/2435 We remove the command line tools to generate logger wrappers and convert Log4j 1.x configuration. The tools have been submitted to Log4j Transform: * apache/logging-log4j-transf

Re: [PR] Remove CLI tools from `log4j-core` and `log4j-1.2-api` (logging-log4j2)

2024-04-01 Thread via GitHub
ppkarwasz commented on PR #2435: URL: https://github.com/apache/logging-log4j2/pull/2435#issuecomment-2029895505 The build failure is an April's Fool I played on myself: the failing test was disabled until `2024-04-01`. I'll fix it in `main`. -- This is an automated message from the Apach

[PR] Bump org.apache.maven.plugins:maven-invoker-plugin from 3.6.0 to 3.6.1 [logging-log4j-transform]

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #94: URL: https://github.com/apache/logging-log4j-transform/pull/94 Bumps [org.apache.maven.plugins:maven-invoker-plugin](https://github.com/apache/maven-invoker-plugin) from 3.6.0 to 3.6.1. Commits https://github.com/apache/maven-inv

Re: [PR] Bump org.apache.maven.plugins:maven-invoker-plugin from 3.6.0 to 3.6.1 [logging-log4j-transform]

2024-04-01 Thread via GitHub
github-actions[bot] merged PR #94: URL: https://github.com/apache/logging-log4j-transform/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[PR] Bump org.apache.maven.plugin-tools:maven-plugin-annotations from 3.11.0 to 3.12.0 [logging-log4j-audit]

2024-04-02 Thread via GitHub
dependabot[bot] opened a new pull request, #136: URL: https://github.com/apache/logging-log4j-audit/pull/136 Bumps org.apache.maven.plugin-tools:maven-plugin-annotations from 3.11.0 to 3.12.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compa

[PR] Bump org.apache.maven.plugin-tools:maven-plugin-tools-api from 3.11.0 to 3.12.0 [logging-log4j-audit]

2024-04-02 Thread via GitHub
dependabot[bot] opened a new pull request, #135: URL: https://github.com/apache/logging-log4j-audit/pull/135 Bumps org.apache.maven.plugin-tools:maven-plugin-tools-api from 3.11.0 to 3.12.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compati

[PR] Bump org.jacoco:jacoco-maven-plugin from 0.8.11 to 0.8.12 [logging-log4j-transform]

2024-04-02 Thread via GitHub
dependabot[bot] opened a new pull request, #95: URL: https://github.com/apache/logging-log4j-transform/pull/95 Bumps [org.jacoco:jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.11 to 0.8.12. Release notes Sourced from https://github.com/jacoco/jacoco/releases";>org.

Re: [PR] Bump org.jacoco:jacoco-maven-plugin from 0.8.11 to 0.8.12 [logging-log4j-transform]

2024-04-02 Thread via GitHub
github-actions[bot] merged PR #95: URL: https://github.com/apache/logging-log4j-transform/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Migrate `2.x` website to Antora (logging-log4j2)

2024-04-02 Thread via GitHub
ppkarwasz commented on code in PR #2427: URL: https://github.com/apache/logging-log4j2/pull/2427#discussion_r1543289763 ## pom.xml: ## @@ -652,34 +664,86 @@ + + +org.apache.logging.log4j +log4j-changelog-maven-plugin + +

Re: [PR] Migrate `2.x` website to Antora (logging-log4j2)

2024-04-03 Thread via GitHub
vy commented on code in PR #2427: URL: https://github.com/apache/logging-log4j2/pull/2427#discussion_r1549020140 ## pom.xml: ## @@ -652,34 +664,86 @@ + + +org.apache.logging.log4j +log4j-changelog-maven-plugin + +

Re: [PR] Migrate `2.x` website to Antora (logging-log4j2)

2024-04-03 Thread via GitHub
vy commented on PR #2427: URL: https://github.com/apache/logging-log4j2/pull/2427#issuecomment-2033861605 @garydgregory shared [some remarks in Slack](https://the-asf.slack.com/archives/C4TQW0M5L/p1712094446443179). I will address them here. > I get a 404 for the API and Implementati

Re: [PR] Scoped context (logging-log4j2)

2024-04-03 Thread via GitHub
vy commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2034076685 **Disclaimer:** I did not completely read all the earlier discussions in this PR. ### On using `ThreadLocal`s I am against implementing `ScopedContext` using `ThreadLocal`s

[PR] Restore support for legacy 2.x property names (logging-log4j2)

2024-04-03 Thread via GitHub
ppkarwasz opened a new pull request, #2436: URL: https://github.com/apache/logging-log4j2/pull/2436 This PR restores the support for legacy 2.x property names by introducing a `META-INF/log4j/propertyMapping.json` file that contains a map between 3.x property names and one or more 2.x prope

[PR] Bump org.jacoco:jacoco-maven-plugin from 0.8.11 to 0.8.12 [logging-parent]

2024-04-03 Thread via GitHub
dependabot[bot] opened a new pull request, #148: URL: https://github.com/apache/logging-parent/pull/148 Bumps [org.jacoco:jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.11 to 0.8.12. Release notes Sourced from https://github.com/jacoco/jacoco/releases";>org.jacoco:

Re: [PR] Bump org.jacoco:jacoco-maven-plugin from 0.8.11 to 0.8.12 [logging-parent]

2024-04-03 Thread via GitHub
github-actions[bot] merged PR #148: URL: https://github.com/apache/logging-parent/pull/148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Bump co.elastic.clients:elasticsearch-java from 8.13.0 to 8.13.1 (logging-log4j2)

2024-04-03 Thread via GitHub
ppkarwasz commented on PR #2437: URL: https://github.com/apache/logging-log4j2/pull/2437#issuecomment-2034424438 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add logging to `PropertiesUtil` and fix `Duration` parser (logging-log4j2)

2024-04-03 Thread via GitHub
ppkarwasz merged PR #2424: URL: https://github.com/apache/logging-log4j2/pull/2424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Issue with Duration Parsing (logging-log4j2)

2024-04-03 Thread via GitHub
ppkarwasz closed issue #1963: Issue with Duration Parsing URL: https://github.com/apache/logging-log4j2/issues/1963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] Bump co.elastic.clients:elasticsearch-java from 8.13.0 to 8.13.1 (logging-log4j2)

2024-04-03 Thread via GitHub
ppkarwasz commented on PR #2437: URL: https://github.com/apache/logging-log4j2/pull/2437#issuecomment-2034561121 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] Remove deprecated code for 3.0 (logging-log4net)

2024-04-03 Thread via GitHub
FreeAndNil commented on issue #125: URL: https://github.com/apache/logging-log4net/issues/125#issuecomment-2034645504 Deleted obsolete API: - obsolete since 1.2.14 - 2015 - `log4net.Appender.BufferingAppenderSkeleton.OnlyFixPartialEventData` - `log4net.Appender.ColoredConsol

Re: [PR] Bump co.elastic.clients:elasticsearch-java from 8.13.0 to 8.13.1 (logging-log4j2)

2024-04-03 Thread via GitHub
github-actions[bot] merged PR #2437: URL: https://github.com/apache/logging-log4j2/pull/2437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Remove obsolete properties, methods, and classes for 3.0 (logging-log4net)

2024-04-03 Thread via GitHub
FreeAndNil commented on code in PR #138: URL: https://github.com/apache/logging-log4net/pull/138#discussion_r1549785447 ## src/log4net/Config/RepositoryAttribute.cs: ## @@ -43,12 +43,8 @@ namespace log4net.Config /// Gert Driesen [AttributeUsage(AttributeTargets.Assembly)]

Re: [PR] Scoped context (logging-log4j2)

2024-04-03 Thread via GitHub
rgoers commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2035006189 I have updated the branch with some significant changes: 1. ContextDataProvider is now moved to the API. This allows all ContextDataProviders to be used in Lookups, Filters, e

Re: [PR] Scoped context (logging-log4j2)

2024-04-03 Thread via GitHub
rgoers commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2035025220 Rats. I can't reopen the PR. Guess I have to create a new one again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] Scoped context (logging-log4j2)

2024-04-03 Thread via GitHub
rgoers opened a new pull request, #2438: URL: https://github.com/apache/logging-log4j2/pull/2438 This adds support for a ScopedContext and a ResourceLogger as requested in https://github.com/apache/logging-log4j-kotlin/issues/71 and similar to https://github.com/apache/logging-log4j2/discus

Re: [I] ContextDataInjector ignores custom ContextDataProvider (logging-log4j2)

2024-04-03 Thread via GitHub
rgoers commented on issue #2331: URL: https://github.com/apache/logging-log4j2/issues/2331#issuecomment-2035462644 Well, I am going to reopen this as PR https://github.com/apache/logging-log4j2/pull/2438 actually fixes this. -- This is an automated message from the Apache Git Service. To

Re: [PR] Remove obsolete properties, methods, and classes for 3.0 (logging-log4net)

2024-04-03 Thread via GitHub
erikmav commented on code in PR #138: URL: https://github.com/apache/logging-log4net/pull/138#discussion_r1550566077 ## src/log4net/Config/RepositoryAttribute.cs: ## @@ -43,12 +43,8 @@ namespace log4net.Config /// Gert Driesen [AttributeUsage(AttributeTargets.Assembly)]

Re: [PR] Remove obsolete properties, methods, and classes for 3.0 (logging-log4net)

2024-04-03 Thread via GitHub
FreeAndNil merged PR #138: URL: https://github.com/apache/logging-log4net/pull/138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Scoped context (logging-log4j2)

2024-04-03 Thread via GitHub
ppkarwasz commented on PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2036237507 For completeness' sake, there is a related OpenTelemetry proposal: open-telemetry/oteps#207. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Migrate `2.x` website to Antora (logging-log4j2)

2024-04-04 Thread via GitHub
vy merged PR #2427: URL: https://github.com/apache/logging-log4j2/pull/2427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

[PR] Bump org.apache.maven.plugin-tools:maven-plugin-annotations from 3.11.0 to 3.12.0 [logging-log4j-tools]

2024-04-04 Thread via GitHub
dependabot[bot] opened a new pull request, #113: URL: https://github.com/apache/logging-log4j-tools/pull/113 Bumps [org.apache.maven.plugin-tools:maven-plugin-annotations](https://github.com/apache/maven-plugin-tools) from 3.11.0 to 3.12.0. Release notes Sourced from https://githu

Re: [PR] Bump org.apache.maven.plugin-tools:maven-plugin-annotations from 3.11.0 to 3.12.0 [logging-log4j-tools]

2024-04-04 Thread via GitHub
github-actions[bot] merged PR #113: URL: https://github.com/apache/logging-log4j-tools/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [I] ContextDataInjector ignores custom ContextDataProvider (logging-log4j2)

2024-04-04 Thread via GitHub
lukasalexanderweber commented on issue #2331: URL: https://github.com/apache/logging-log4j2/issues/2331#issuecomment-2036387491 great! Till now we used [ContextDataInjector](https://logging.apache.org/log4j/2.x/javadoc/log4j-core/org/apache/logging/log4j/core/ContextDataInjector.html) to c

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-04-04 Thread via GitHub
9you commented on issue #2384: URL: https://github.com/apache/logging-log4j2/issues/2384#issuecomment-2036388621 Spring Boot should remove log4j-spring-boot from their declaration. It will cause errors to be reported immediately when upgrading the Spring Boot version from 2.x to 3.x. --

Re: [PR] #124 LoggingEvent.Level not nullable (logging-log4net)

2024-04-04 Thread via GitHub
FreeAndNil closed pull request #137: #124 LoggingEvent.Level not nullable URL: https://github.com/apache/logging-log4net/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-04-04 Thread via GitHub
ppkarwasz commented on issue #2384: URL: https://github.com/apache/logging-log4j2/issues/2384#issuecomment-2036565176 @9you, Does any Spring Boot 3.x artifact or starter depend on `log4j-spring-boot`? If you know such an example, you should probably [submit an issue report](https://

Re: [I] 3.0.0-preview.1 (logging-log4net)

2024-04-04 Thread via GitHub
FreeAndNil commented on issue #139: URL: https://github.com/apache/logging-log4net/issues/139#issuecomment-2036658286 ## Breaking Changes ### Framework Support **Attention:** Starting with 3.0.0 we only support the following target frameworks - net462 - netstandard2.0 The

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-04-04 Thread via GitHub
9you commented on issue #2384: URL: https://github.com/apache/logging-log4j2/issues/2384#issuecomment-2036700488 In Spring 2.x, we use the following declaration (without specifying the version): ` org.apache.logging.log4j log4j-spring-boot ` So, I believe Spring Boo

[PR] Add support for thread context map propagation (logging-log4j2)

2024-04-04 Thread via GitHub
ppkarwasz opened a new pull request, #2442: URL: https://github.com/apache/logging-log4j2/pull/2442 Adds a new `ExtendedThreadContext` SPI class to help external libraries with an efficient propagation of the `ThreadContextMap`. Currently integrators can retrieve and set the context m

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-04-04 Thread via GitHub
ppkarwasz commented on issue #2384: URL: https://github.com/apache/logging-log4j2/issues/2384#issuecomment-2036850995 > So, I believe Spring Boot has defined it in their `` section. And if they remove it in version 3.x, Maven will raise an error when it tries to resolve dependencies. >

Re: [PR] Scoped context (logging-log4j2)

2024-04-04 Thread via GitHub
ppkarwasz commented on PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2036848158 @rgoers, Can you look at #2442? I think that your `ScopedContext#runWhere` implementation could be replaced by calls to the new `ThreadContextMap#restore` and `ThreadConte

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-1 to 1.5.6-2 (logging-log4j2)

2024-04-04 Thread via GitHub
github-actions[bot] merged PR #2441: URL: https://github.com/apache/logging-log4j2/pull/2441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] Migrate `3.x` website to Antora (logging-log4j2)

2024-04-04 Thread via GitHub
vy opened a new pull request, #2443: URL: https://github.com/apache/logging-log4j2/pull/2443 This work ports #2427 to `main`, i.e., Log4j 3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Migrate `3.x` website to Antora (logging-log4j2)

2024-04-04 Thread via GitHub
ppkarwasz commented on code in PR #2443: URL: https://github.com/apache/logging-log4j2/pull/2443#discussion_r1551736197 ## src/site/resources/.htaccess: ## @@ -8,13 +7,16 @@ # "License"); you may not use this file except in compliance # with the License. You may obtain a copy

Re: [PR] Bump mongodb.version from 5.0.0 to 5.0.1 (logging-log4j2)

2024-04-04 Thread via GitHub
github-actions[bot] merged PR #2439: URL: https://github.com/apache/logging-log4j2/pull/2439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[I] Error building log4cxx with cmake and APR_STATIC option [logging-log4cxx]

2024-04-04 Thread via GitHub
clobotorre opened a new issue, #362: URL: https://github.com/apache/logging-log4cxx/issues/362 Steps to reproduce: ``` # curl -L -O https://dlcdn.apache.org/logging/log4cxx/1.2.0/apache-log4cxx-1.2.0.tar.gz # tar xzvf apache-log4cxx-1.2.0.tar.gz # a

Re: [PR] Scoped context (logging-log4j2)

2024-04-04 Thread via GitHub
rgoers commented on PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2037862545 @ppkarwasz I looked at the Open Telemetry proposal. While the naming might give the impression it is similar to ScopedContext they are really unrelated. The Open Telemetry propo

[PR] Delegate `ScopedContext` functionality to interface (logging-log4j2)

2024-04-04 Thread via GitHub
ppkarwasz opened a new pull request, #2445: URL: https://github.com/apache/logging-log4j2/pull/2445 To provide more configurability for the `ScopedContext` service, this PR moves its implementation details to `log4j-core` and replaces it with a `ScopedContextProvider` interface. In L

Re: [PR] Scoped context (logging-log4j2)

2024-04-04 Thread via GitHub
ppkarwasz commented on PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2038331405 Would you consider merging #2445 into this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Bump rewrite-maven-plugin and recipes (logging-log4j2)

2024-04-04 Thread via GitHub
ppkarwasz closed pull request #2444: Bump rewrite-maven-plugin and recipes URL: https://github.com/apache/logging-log4j2/pull/2444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Bump rewrite-maven-plugin and recipes (logging-log4j2)

2024-04-04 Thread via GitHub
ppkarwasz commented on PR #2444: URL: https://github.com/apache/logging-log4j2/pull/2444#issuecomment-2038343517 OpenRewrite is **very** active project and the `rewrite` Maven profile is **not** part of our standard build. That is why we disabled Dependabot updates on these plugins. I

Re: [I] Error building log4cxx with cmake and APR_STATIC option [logging-log4cxx]

2024-04-04 Thread via GitHub
swebb2066 commented on issue #362: URL: https://github.com/apache/logging-log4cxx/issues/362#issuecomment-2038443183 The distro provied apr and apr-util static libraries are built without -fPIC (probably assuming everthing will be statically linked if anything is statically linked).

Re: [PR] Scoped context (logging-log4j2)

2024-04-04 Thread via GitHub
rgoers commented on PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2038446381 @ppkarwasz > Would you consider merging https://github.com/apache/logging-log4j2/pull/2445 into this PR? No, for two reasons: 1. As I showed above it isn't necessar

Re: [PR] Delegate `ScopedContext` functionality to interface (logging-log4j2)

2024-04-04 Thread via GitHub
rgoers commented on PR #2445: URL: https://github.com/apache/logging-log4j2/pull/2445#issuecomment-2038461264 I might buy this if I could envision multiple implementations. But why would I need more than this? For example, lets pretend SLF4J provided an equivalent API. Because I have access

Re: [PR] Scoped context (logging-log4j2)

2024-04-04 Thread via GitHub
rgoers commented on PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2038466681 @ppkarwasz No. See my comments there. Unless you can demonstrate a valid reason why I would want another implementation I don't see the point of uglifying the usage. -- This

Re: [PR] Delegate `ScopedContext` functionality to interface (logging-log4j2)

2024-04-04 Thread via GitHub
rgoers commented on PR #2445: URL: https://github.com/apache/logging-log4j2/pull/2445#issuecomment-2038564972 AFter thinking about this a bit more I think you are on to something but this implementation isn't it. I will work on my PR tonight to see what I can do. -- This is an automated m

Re: [PR] Delegate `ScopedContext` functionality to interface (logging-log4j2)

2024-04-04 Thread via GitHub
ppkarwasz commented on PR #2445: URL: https://github.com/apache/logging-log4j2/pull/2445#issuecomment-203842 > I took a look at this again. I missed some things the first time through it. I like most of this but will want to change it a bit. Feel free to directly modify this branc

Re: [PR] Scoped context (logging-log4j2)

2024-04-04 Thread via GitHub
ppkarwasz commented on PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2038901414 > Looking a second time at your example I now see what you are attempting to do but I don't think you even need to modify ThreadContextMap to do that. I could just do: > >

Re: [PR] Delegate `ScopedContext` functionality to interface (logging-log4j2)

2024-04-04 Thread via GitHub
rgoers merged PR #2445: URL: https://github.com/apache/logging-log4j2/pull/2445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

Re: [PR] Delegate `ScopedContext` functionality to interface (logging-log4j2)

2024-04-04 Thread via GitHub
rgoers commented on PR #2445: URL: https://github.com/apache/logging-log4j2/pull/2445#issuecomment-2039035897 Rats. I didn't mean to but I merged my changes to this branch by mistake. They are now in the ScopedContext branch as well. -- This is an automated message from the Apache Git Ser

Re: [PR] Delegate `ScopedContext` functionality to interface (logging-log4j2)

2024-04-05 Thread via GitHub
ppkarwasz commented on PR #2445: URL: https://github.com/apache/logging-log4j2/pull/2445#issuecomment-2039157328 > I have a question though. I just noticed that you made the default ThreadContext provider a no-op. How did that manage to pass unit tests? Why does it need to be a no-op. For o

Re: [PR] Migrate `3.x` website to Antora (logging-log4j2)

2024-04-05 Thread via GitHub
vy commented on code in PR #2443: URL: https://github.com/apache/logging-log4j2/pull/2443#discussion_r1553169012 ## src/site/resources/.htaccess: ## @@ -8,13 +7,16 @@ # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the

Re: [PR] Migrate `3.x` website to Antora (logging-log4j2)

2024-04-05 Thread via GitHub
vy commented on code in PR #2443: URL: https://github.com/apache/logging-log4j2/pull/2443#discussion_r1553190265 ## src/site/resources/.htaccess: ## @@ -1,5 +1,4 @@ -#!/bin/sh -# +# Review Comment:

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
ppkarwasz commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553097482 ## log4j-api/src/main/java/org/apache/logging/log4j/message/package-info.java: ## @@ -20,7 +20,7 @@ */ @Export /** - * Bumped to 2.22.0, since FormattedMes

[PR] Bump org.apache.maven.plugins:maven-artifact-plugin from 3.5.0 to 3.5.1 [logging-parent]

2024-04-05 Thread via GitHub
dependabot[bot] opened a new pull request, #149: URL: https://github.com/apache/logging-parent/pull/149 Bumps [org.apache.maven.plugins:maven-artifact-plugin](https://github.com/apache/maven-artifact-plugin) from 3.5.0 to 3.5.1. Commits https://github.com/apache/maven-artifact

Re: [PR] Bump org.apache.maven.plugins:maven-artifact-plugin from 3.5.0 to 3.5.1 [logging-parent]

2024-04-05 Thread via GitHub
github-actions[bot] merged PR #149: URL: https://github.com/apache/logging-parent/pull/149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[I] Threads contention because of OutputStreamManager.writeBytes (logging-log4j2)

2024-04-05 Thread via GitHub
bharathchandrathakkallapally-cpi opened a new issue, #2447: URL: https://github.com/apache/logging-log4j2/issues/2447 ## Description We are using the RollingFileAppender with below configuration ``` appender.file.type=RollingFile appender.file.name=LOGFILE appender.file.fileNa

Re: [PR] Create metrics API proof of concept (logging-log4j2)

2024-04-05 Thread via GitHub
ppkarwasz commented on PR #1943: URL: https://github.com/apache/logging-log4j2/pull/1943#issuecomment-2039486315 @jvz, I think we could choose an approach similar to [`RxJavaHooks`](https://github.com/ReactiveX/RxJava/wiki/Plugins) to provide instrumentation hooks **without** affecti

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-1 to 1.5.6-2 (logging-log4j2)

2024-04-05 Thread via GitHub
github-actions[bot] merged PR #2446: URL: https://github.com/apache/logging-log4j2/pull/2446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [I] Error building log4cxx with cmake and APR_STATIC option [logging-log4cxx]

2024-04-05 Thread via GitHub
clobotorre commented on issue #362: URL: https://github.com/apache/logging-log4cxx/issues/362#issuecomment-2039568083 Thank you so much. Solved!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] 3.0.0 preview.1 (logging-log4net)

2024-04-05 Thread via GitHub
FreeAndNil opened a new pull request, #140: URL: https://github.com/apache/logging-log4net/pull/140 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[PR] #124 fixed more nullable Warnings when targeting net8.0 (logging-log4net)

2024-04-05 Thread via GitHub
FreeAndNil opened a new pull request, #141: URL: https://github.com/apache/logging-log4net/pull/141 - fixed LoggingEventTest for execution in CE(S)T or SAST - added missing nullable attributes from net6-8 - added Log4NetAssert - fixed more nullable Warnings when targeting net8.0

Re: [PR] #124 fixed more nullable Warnings when targeting net8.0 (logging-log4net)

2024-04-05 Thread via GitHub
FreeAndNil commented on PR #141: URL: https://github.com/apache/logging-log4net/pull/141#issuecomment-2039604820 @erikmav can you take a look? - LoggingEventTest wasn't successful in CEST - fixed more nullable Warnings when targeting net8.0 api -- This is an automated message from th

Re: [I] Threads contention because of OutputStreamManager.writeBytes (logging-log4j2)

2024-04-05 Thread via GitHub
tcmot commented on issue #2447: URL: https://github.com/apache/logging-log4j2/issues/2447#issuecomment-2039705734 I think this is a deadlock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Delegate `ScopedContext` functionality to interface (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on PR #2445: URL: https://github.com/apache/logging-log4j2/pull/2445#issuecomment-2039916880 I disagree with your premise. SimpleLogger has always supported logging the ThreadContext. Including the ScopedContext as well makes sense since they can be interchangeably used. Yo

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553739209 ## log4j-api/src/main/java/org/apache/logging/log4j/message/package-info.java: ## @@ -20,7 +20,7 @@ */ @Export /** - * Bumped to 2.22.0, since FormattedMessag

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553740141 ## log4j-api-test/src/test/java/org/apache/logging/log4j/ResourceLoggerTest.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553746082 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553745339 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553754256 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553757235 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553771392 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553773527 ## log4j-api/src/main/java/org/apache/logging/log4j/message/package-info.java: ## @@ -20,7 +20,7 @@ */ @Export /** - * Bumped to 2.22.0, since FormattedMessag

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
ppkarwasz commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1554003929 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] #124 fixed more nullable Warnings when targeting net8.0 (logging-log4net)

2024-04-05 Thread via GitHub
erikmav commented on PR #141: URL: https://github.com/apache/logging-log4net/pull/141#issuecomment-2040286940 To aid understanding - are you considering adding net8.0 as a target for the 3.0 package? I kind of like it as there are perf optimizations that can be added like avoiding `params o

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
ppkarwasz commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r155402 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] #124 fixed more nullable Warnings when targeting net8.0 (logging-log4net)

2024-04-05 Thread via GitHub
erikmav commented on code in PR #141: URL: https://github.com/apache/logging-log4net/pull/141#discussion_r1554000115 ## src/log4net/Core/DefaultRepositorySelector.cs: ## @@ -755,17 +712,12 @@ private void LoadPlugins(Assembly assembly, ILoggerRepository repository) ///

Re: [I] Threads contention because of OutputStreamManager.writeBytes (logging-log4j2)

2024-04-05 Thread via GitHub
jvz commented on issue #2447: URL: https://github.com/apache/logging-log4j2/issues/2447#issuecomment-2040314637 Does this deadlock coincide with the hourly log file rollover you configured? I wonder if there's a race condition here between incoming log events and the rollover process. --

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
ppkarwasz commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1554047173 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Migrate `3.x` website to Antora (logging-log4j2)

2024-04-05 Thread via GitHub
vy merged PR #2443: URL: https://github.com/apache/logging-log4j2/pull/2443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Create metrics API proof of concept (logging-log4j2)

2024-04-05 Thread via GitHub
jvz closed pull request #1943: Create metrics API proof of concept URL: https://github.com/apache/logging-log4j2/pull/1943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Create metrics API proof of concept (logging-log4j2)

2024-04-05 Thread via GitHub
jvz commented on PR #1943: URL: https://github.com/apache/logging-log4j2/pull/1943#issuecomment-2040478427 I think that's a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Enable parallel releases in reusable workflows [logging-parent]

2024-04-05 Thread via GitHub
vy closed issue #139: Enable parallel releases in reusable workflows URL: https://github.com/apache/logging-parent/issues/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] #124 fixed more nullable Warnings when targeting net8.0 (logging-log4net)

2024-04-05 Thread via GitHub
FreeAndNil commented on PR #141: URL: https://github.com/apache/logging-log4net/pull/141#issuecomment-2040632651 @erikmav thanks for your feedback. I adjusted the files. I'm definitely thinking about adding .net8 as target. I had the same idea for interpolated strings (especially for th

[PR] Improve release process repeatability [logging-log4cxx]

2024-04-05 Thread via GitHub
swebb2066 opened a new pull request, #363: URL: https://github.com/apache/logging-log4cxx/pull/363 This PR aims to make the release process more repeatable by using a scripted job run by CI to generate the release files . -- This is an automated message from the Apache Git Service

Re: [PR] Scoped context (logging-log4j2)

2024-04-06 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1554539914 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Scoped context (logging-log4j2)

2024-04-06 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1554540229 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Scoped context (logging-log4j2)

2024-04-06 Thread via GitHub
rgoers commented on PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2041000281 At this point I am very happy with where this is and am prepared to merge. If you have technical reasons as to why you would veto the commit please let me know. -- This is an a

Re: [PR] Scoped context (logging-log4j2)

2024-04-06 Thread via GitHub
ppkarwasz commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1554551301 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Softwar

<    1   2   3   4   5   6   7   8   9   10   >