Re: [PR] Document a way to avoid SIOF when extending log4cxx [logging-log4cxx]

2024-07-24 Thread via GitHub
swebb2066 commented on PR #395: URL: https://github.com/apache/logging-log4cxx/pull/395#issuecomment-2249110548 The [1.3.0 staging web site](https://logging.staged.apache.org/log4cxx/1.3.0) is available for review. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Use latest version of Github actions for CI [logging-log4cxx]

2024-07-24 Thread via GitHub
rm5248 commented on PR #399: URL: https://github.com/apache/logging-log4cxx/pull/399#issuecomment-2249132996 > > The -V flag I find is important, because if a test fails there will generally be some output that is useful. > > Doesn't the --output-on-failure do exactly that? It'

Re: [PR] Use latest version of Github actions for CI [logging-log4cxx]

2024-07-24 Thread via GitHub
swebb2066 commented on PR #399: URL: https://github.com/apache/logging-log4cxx/pull/399#issuecomment-2249255482 > it's one of those sub-tests that fails. I improved that diagnostic somewhat in 7ae2e640f. Would defining LOG4CXX_DUBUG=true in the CI workflows be helpful? -- This is a

[PR] Prevent undefined behaviour when an appender is deleted without being closed [logging-log4cxx]

2024-07-24 Thread via GitHub
swebb2066 opened a new pull request, #400: URL: https://github.com/apache/logging-log4cxx/pull/400 This PR addresses the underlying problem that caused the TelnetAppenderTestCase failure seen with Msys2. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] 3.0.0 preview.1 (logging-log4net)

2024-07-25 Thread via GitHub
fluffynuts commented on code in PR #140: URL: https://github.com/apache/logging-log4net/pull/140#discussion_r1690915191 ## src/log4net/log4net.csproj: ## @@ -63,10 +62,10 @@ TRACE;DEBUG;$(DefineConstants) +$(GeneratePackages) Review Comment: why auto-generat

Re: [PR] 3.0.0 preview.1 (logging-log4net)

2024-07-25 Thread via GitHub
FreeAndNil commented on code in PR #140: URL: https://github.com/apache/logging-log4net/pull/140#discussion_r1690938084 ## src/log4net/log4net.csproj: ## @@ -63,10 +62,10 @@ TRACE;DEBUG;$(DefineConstants) +$(GeneratePackages) Review Comment: Please see line

[PR] Add ClassCastException to lmax-4 failure (logging-log4j2)

2024-07-25 Thread via GitHub
jackshirazi opened a new pull request, #2768: URL: https://github.com/apache/logging-log4j2/pull/2768 During startup with an agent, the resulting object can be in the wrong classloader leading to a ClassCastException. Catching that falls back to the old behaviour which works fine The

Re: [PR] Bump github/codeql-action from 3.25.13 to 3.25.14 [logging-parent]

2024-07-25 Thread via GitHub
github-actions[bot] merged PR #211: URL: https://github.com/apache/logging-parent/pull/211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[I] All plugin builder attributes should have setters (logging-log4j2)

2024-07-25 Thread via GitHub
ppkarwasz opened a new issue, #2769: URL: https://github.com/apache/logging-log4j2/issues/2769 As issue #2766 shows, there are still some Log4j plugin builders that don't have setters for all their configuration attributes. Since field injection becomes more problematic in newer Java

[PR] Bump org.modelmapper.extensions:modelmapper-spring from 3.2.0 to 3.2.1 [logging-log4j-audit-sample]

2024-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #52: URL: https://github.com/apache/logging-log4j-audit-sample/pull/52 Bumps org.modelmapper.extensions:modelmapper-spring from 3.2.0 to 3.2.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibilit

[PR] Bump org.modelmapper.extensions:modelmapper-jackson from 3.2.0 to 3.2.1 [logging-log4j-audit-sample]

2024-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #53: URL: https://github.com/apache/logging-log4j-audit-sample/pull/53 Bumps org.modelmapper.extensions:modelmapper-jackson from 3.2.0 to 3.2.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibili

[PR] Bump org.modelmapper:modelmapper from 3.2.0 to 3.2.1 [logging-log4j-audit-sample]

2024-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #54: URL: https://github.com/apache/logging-log4j-audit-sample/pull/54 Bumps [org.modelmapper:modelmapper](https://github.com/modelmapper/modelmapper) from 3.2.0 to 3.2.1. Commits https://github.com/modelmapper/modelmapper/commit/8b43

Re: [PR] Bump org.modelmapper:modelmapper from 3.2.0 to 3.2.1 [logging-log4j-audit-sample]

2024-07-25 Thread via GitHub
github-actions[bot] closed pull request #54: Bump org.modelmapper:modelmapper from 3.2.0 to 3.2.1 URL: https://github.com/apache/logging-log4j-audit-sample/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [I] Add support for event context lookup evaluation in the `NoSql` appender (logging-log4j2)

2024-07-25 Thread via GitHub
ppkarwasz commented on issue #2766: URL: https://github.com/apache/logging-log4j2/issues/2766#issuecomment-2250069982 [FYI: You are not using `ConfigurationBuilder`, which always returns a complete configuration. You are modifying the existing configuration using the internal builders of L

Re: [PR] Add ClassCastException to lmax-4 failure (logging-log4j2)

2024-07-25 Thread via GitHub
jackshirazi commented on PR #2768: URL: https://github.com/apache/logging-log4j2/pull/2768#issuecomment-2250132082 We don't use LoaderUtil. The linked issue is [this](https://github.com/elastic/apm-agent-java/issues/3691). The full sequence is pretty convoluted 1. Elastic agent opens a u

Re: [PR] Add ClassCastException to lmax-4 failure (logging-log4j2)

2024-07-25 Thread via GitHub
ppkarwasz commented on PR #2768: URL: https://github.com/apache/logging-log4j2/pull/2768#issuecomment-2250148217 Did you try replacing `LoaderUtil.newInstanceOf` with: ```java return (EventHandler) Class.forName("org.apache.logging.log4j.core.async.RingBufferLogEventHand

Re: [PR] Add ClassCastException to lmax-4 failure (logging-log4j2)

2024-07-25 Thread via GitHub
jackshirazi commented on PR #2768: URL: https://github.com/apache/logging-log4j2/pull/2768#issuecomment-2250191420 Again, we're not using LoaderUtil. This is also not in Graal (Graal doesn't yet support agents, and when it does it won't have this kind of issue because it flattens classloadi

Re: [PR] Add ClassCastException to lmax-4 failure (logging-log4j2)

2024-07-25 Thread via GitHub
github-actions[bot] commented on PR #2768: URL: https://github.com/apache/logging-log4j2/pull/2768#issuecomment-2250203846 Job Requested goals Build Tool Version Build Outcome Build Scan® build-

Re: [PR] Add ClassCastException to lmax-4 failure (logging-log4j2)

2024-07-25 Thread via GitHub
ppkarwasz commented on PR #2768: URL: https://github.com/apache/logging-log4j2/pull/2768#issuecomment-2250452028 > Again, we're not using LoaderUtil. This is also not in Graal (Graal doesn't yet support agents, and when it does it won't have this kind of issue because it flattens classloadi

Re: [PR] Add ClassCastException to lmax-4 failure (logging-log4j2)

2024-07-25 Thread via GitHub
jackshirazi commented on PR #2768: URL: https://github.com/apache/logging-log4j2/pull/2768#issuecomment-2250687556 Thanks, I'll test that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Allow selected test cases to be executed [logging-log4cxx]

2024-07-25 Thread via GitHub
swebb2066 merged PR #401: URL: https://github.com/apache/logging-log4cxx/pull/401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Prevent undefined behaviour when an appender is deleted without being closed [logging-log4cxx]

2024-07-25 Thread via GitHub
swebb2066 merged PR #400: URL: https://github.com/apache/logging-log4cxx/pull/400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

[PR] Improve asyncappender robustness [logging-log4cxx]

2024-07-25 Thread via GitHub
swebb2066 opened a new pull request, #403: URL: https://github.com/apache/logging-log4cxx/pull/403 This PR aims to prevent #402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Use latest version of Github actions for CI [logging-log4cxx]

2024-07-25 Thread via GitHub
rm5248 commented on PR #399: URL: https://github.com/apache/logging-log4cxx/pull/399#issuecomment-2251837228 > > it's one of those sub-tests that fails. > > I improved that diagnostic somewhat in [7ae2e64](https://github.com/apache/logging-log4cxx/commit/7ae2e640f933ced35f8c3839692b17

Re: [PR] Improve asyncappender robustness [logging-log4cxx]

2024-07-25 Thread via GitHub
swebb2066 merged PR #403: URL: https://github.com/apache/logging-log4cxx/pull/403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Use latest version of Github actions for CI [logging-log4cxx]

2024-07-25 Thread via GitHub
swebb2066 merged PR #399: URL: https://github.com/apache/logging-log4cxx/pull/399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Document a way to avoid SIOF when extending log4cxx [logging-log4cxx]

2024-07-25 Thread via GitHub
swebb2066 merged PR #395: URL: https://github.com/apache/logging-log4cxx/pull/395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [I] Async appender in msys2 ucrt-x86_64-g++ occasionally blocks [logging-log4cxx]

2024-07-25 Thread via GitHub
swebb2066 closed issue #402: Async appender in msys2 ucrt-x86_64-g++ occasionally blocks URL: https://github.com/apache/logging-log4cxx/issues/402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Async appender in msys2 ucrt-x86_64-g++ occasionally blocks [logging-log4cxx]

2024-07-25 Thread via GitHub
swebb2066 commented on issue #402: URL: https://github.com/apache/logging-log4cxx/issues/402#issuecomment-2251898523 The cause was a failure to lock the mutex before calling notify_all(), which seems to be a problem in newer compilers (gcc 14, MSVC 2022 Release builds). No re-occuran

[PR] #154 RemotingAppender removed (logging-log4net)

2024-07-25 Thread via GitHub
FreeAndNil opened a new pull request, #155: URL: https://github.com/apache/logging-log4net/pull/155 #154 RemotingAppender removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] #154 RemotingAppender removed (logging-log4net)

2024-07-25 Thread via GitHub
FreeAndNil merged PR #155: URL: https://github.com/apache/logging-log4net/pull/155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[I] Regression: Creating nested loggers in reverse order fails in 3.0.0-preview.1 (logging-log4net)

2024-07-26 Thread via GitHub
FreeAndNil opened a new issue, #156: URL: https://github.com/apache/logging-log4net/issues/156 When creating nested loggers in reverse order `var child = LogManager.GetLogger("A.B.C");` `var parent = LogManager.GetLogger("A.B")` you get ` Message: ` `System.Inv

[PR] #156 fixed Regression when creating nested loggers in reverse order (logging-log4net)

2024-07-26 Thread via GitHub
FreeAndNil opened a new pull request, #157: URL: https://github.com/apache/logging-log4net/pull/157 #156 fixed Regression when creating nested loggers in reverse order -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] #156 fixed Regression when creating nested loggers in reverse order (logging-log4net)

2024-07-26 Thread via GitHub
fluffynuts commented on code in PR #157: URL: https://github.com/apache/logging-log4net/pull/157#discussion_r1692730299 ## src/log4net/Repository/Hierarchy/Hierarchy.cs: ## @@ -660,43 +660,62 @@ public Logger GetLogger(string name, ILoggerFactory factory) var key = new

Re: [I] Remove RemotingAppender (logging-log4net)

2024-07-26 Thread via GitHub
FreeAndNil closed issue #154: Remove RemotingAppender URL: https://github.com/apache/logging-log4net/issues/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] #156 fixed Regression when creating nested loggers in reverse order (logging-log4net)

2024-07-26 Thread via GitHub
FreeAndNil commented on code in PR #157: URL: https://github.com/apache/logging-log4net/pull/157#discussion_r1692760606 ## src/log4net/Repository/Hierarchy/Hierarchy.cs: ## @@ -660,43 +660,62 @@ public Logger GetLogger(string name, ILoggerFactory factory) var key = new

Re: [PR] Bump de.flapdoodle.reverse:de.flapdoodle.reverse from 1.7.2 to 1.7.3 (logging-log4j2)

2024-07-26 Thread via GitHub
github-actions[bot] closed pull request #2771: Bump de.flapdoodle.reverse:de.flapdoodle.reverse from 1.7.2 to 1.7.3 URL: https://github.com/apache/logging-log4j2/pull/2771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] #156 fixed Regression when creating nested loggers in reverse order (logging-log4net)

2024-07-26 Thread via GitHub
fluffynuts commented on code in PR #157: URL: https://github.com/apache/logging-log4net/pull/157#discussion_r1693003946 ## src/log4net/Repository/Hierarchy/Hierarchy.cs: ## @@ -203,22 +203,22 @@ public Logger Root { get { -if (m_root is null) +

[PR] Revamp file and delegating appenders (logging-log4j2)

2024-07-26 Thread via GitHub
ppkarwasz opened a new pull request, #2772: URL: https://github.com/apache/logging-log4j2/pull/2772 This PR splits the documentation of file appenders and the `Async`, `Failover`, `Rewrite` and `Routing` appenders into their own files. As in the previous PRs we: * check and ref

Re: [PR] Revamp rolling file appender documentation (logging-log4j2)

2024-07-26 Thread via GitHub
vy commented on code in PR #2764: URL: https://github.com/apache/logging-log4j2/pull/2764#discussion_r1693073331 ## src/site/antora/modules/ROOT/examples/manual/rolling-file/script-condition.groovy: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Revamp rolling file appender documentation (logging-log4j2)

2024-07-26 Thread via GitHub
ppkarwasz commented on code in PR #2764: URL: https://github.com/apache/logging-log4j2/pull/2764#discussion_r1693085316 ## src/site/antora/modules/ROOT/examples/manual/rolling-file/script-condition.groovy: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [I] Add support for event context lookup evaluation in the `NoSql` appender (logging-log4j2)

2024-07-26 Thread via GitHub
vy commented on issue #2766: URL: https://github.com/apache/logging-log4j2/issues/2766#issuecomment-2252813059 @SnobbyVirus1973, first of all, (as @ppkarwasz indicated) **you are not using `ConfigurationBuilder`**, but instead programmatically creating components using their builders. This

Re: [PR] #156 fixed Regression when creating nested loggers in reverse order (logging-log4net)

2024-07-26 Thread via GitHub
michal-ciechan commented on code in PR #157: URL: https://github.com/apache/logging-log4net/pull/157#discussion_r1693121907 ## src/log4net/Repository/Hierarchy/Hierarchy.cs: ## @@ -252,12 +249,7 @@ public ILoggerFactory LoggerFactory /// public override ILogger? Exist

Re: [PR] #156 fixed Regression when creating nested loggers in reverse order (logging-log4net)

2024-07-26 Thread via GitHub
FreeAndNil commented on code in PR #157: URL: https://github.com/apache/logging-log4net/pull/157#discussion_r1693140777 ## src/log4net/Repository/Hierarchy/Hierarchy.cs: ## @@ -252,12 +249,7 @@ public ILoggerFactory LoggerFactory /// public override ILogger? Exists(st

Re: [PR] #156 fixed Regression when creating nested loggers in reverse order (logging-log4net)

2024-07-26 Thread via GitHub
FreeAndNil commented on code in PR #157: URL: https://github.com/apache/logging-log4net/pull/157#discussion_r1693141944 ## src/log4net/Repository/Hierarchy/Hierarchy.cs: ## @@ -203,22 +203,22 @@ public Logger Root { get { -if (m_root is null) +

Re: [I] log4net in MAUI application (logging-log4net)

2024-07-26 Thread via GitHub
FreeAndNil commented on issue #153: URL: https://github.com/apache/logging-log4net/issues/153#issuecomment-2252852381 @TheSundayDev feel free to reopen when you have more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [I] log4net in MAUI application (logging-log4net)

2024-07-26 Thread via GitHub
FreeAndNil closed issue #153: log4net in MAUI application URL: https://github.com/apache/logging-log4net/issues/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [I] Add support for event context lookup evaluation in the `NoSql` appender (logging-log4j2)

2024-07-26 Thread via GitHub
ppkarwasz commented on issue #2766: URL: https://github.com/apache/logging-log4j2/issues/2766#issuecomment-2252901689 > @SnobbyVirus1973, `NoSqlAppender` doesn't support lookups in the additional fields. Hence, what you want is not really possible at this stage _"out of the box"_ – that is

Re: [PR] Revamp rolling file appender documentation (logging-log4j2)

2024-07-26 Thread via GitHub
ppkarwasz merged PR #2764: URL: https://github.com/apache/logging-log4j2/pull/2764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Add ClassCastException to lmax-4 failure (logging-log4j2)

2024-07-26 Thread via GitHub
jackshirazi commented on PR #2768: URL: https://github.com/apache/logging-log4j2/pull/2768#issuecomment-2253027779 that works, sorry took me a while to get what you were suggesting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Revamp file and delegating appenders (logging-log4j2)

2024-07-26 Thread via GitHub
vy commented on code in PR #2772: URL: https://github.com/apache/logging-log4j2/pull/2772#discussion_r1693285423 ## src/site/antora/modules/ROOT/nav.adoc: ## @@ -43,7 +43,9 @@ ** xref:manual/systemproperties.adoc[] ** xref:manual/customconfig.adoc[] ** xref:manual/appenders.a

Re: [PR] #158 NetSendAdapter removed - last supporting OS was Windows 2000 (logging-log4net)

2024-07-26 Thread via GitHub
FreeAndNil merged PR #158: URL: https://github.com/apache/logging-log4net/pull/158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Add support for event context lookup evaluation in the `NoSql` appender (logging-log4j2)

2024-07-26 Thread via GitHub
vy commented on issue #2766: URL: https://github.com/apache/logging-log4j2/issues/2766#issuecomment-2253103272 > Yes it does support runtime lookups (see [Runtime evaluation of attributes](https://logging.staged.apache.org/log4j/2.x/manual/appenders.html#runtime-evaluation) I recently reva

Re: [PR] Add ClassCastException to lmax-4 failure (logging-log4j2)

2024-07-26 Thread via GitHub
vy commented on PR #2768: URL: https://github.com/apache/logging-log4j2/pull/2768#issuecomment-2253141995 @ppkarwasz, I cannot think of an easy way to test this. The rest LGTM. How shall we proceed? -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-26 Thread via GitHub
jvz commented on PR #2716: URL: https://github.com/apache/logging-log4j2/pull/2716#issuecomment-2253150283 So far, I've mostly updated the plugins page, but I still have some things to add about order annotations, probably some info about conditional annotations, and a link to the DI page.

Re: [PR] Fix `ClassCastException` in LMAX Disruptor 3 initialization (logging-log4j2)

2024-07-26 Thread via GitHub
ppkarwasz commented on PR #2768: URL: https://github.com/apache/logging-log4j2/pull/2768#issuecomment-2253155897 > @ppkarwasz, I cannot think of an easy way to test this. The rest LGTM. How shall we proceed? We should at least add a code comment "Don't use `LoaderUtil`", otherwise we

Re: [PR] Reload key and certs in SockerAppender reconnector (logging-log4j2)

2024-07-26 Thread via GitHub
vy commented on PR #2767: URL: https://github.com/apache/logging-log4j2/pull/2767#issuecomment-2253178899 I'm not in favor of repurposing `monitorInterval` to periodically reload SSL key and trust stores, because * This convolutes the meaning of `monitorInterval` * Polling interval

Re: [PR] Reload key and certs in SockerAppender reconnector (logging-log4j2)

2024-07-26 Thread via GitHub
ppkarwasz commented on PR #2767: URL: https://github.com/apache/logging-log4j2/pull/2767#issuecomment-2253286295 Reloading the cryptographic material alone does not solve the problem in [LOG4J2-2988](https://issues.apache.org/jira/browse/LOG4J2-2988): `SocketAppender` will not close a TLS s

[PR] Deprecate `Message#getFormat()` (logging-log4j2)

2024-07-26 Thread via GitHub
vy opened a new pull request, #2773: URL: https://github.com/apache/logging-log4j2/pull/2773 `Message#getFormat()` doesn't only have unclear semantics, it is also implemented very inconsistently. One might think it should return `JSON` by messages that want to format themselves in JSON, yet

Re: [PR] Fix `ClassCastException` in LMAX Disruptor 3 initialization (logging-log4j2)

2024-07-26 Thread via GitHub
vy merged PR #2768: URL: https://github.com/apache/logging-log4j2/pull/2768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

[PR] Added video interview from CoC [logging-site]

2024-07-26 Thread via GitHub
grobmeier opened a new pull request, #3: URL: https://github.com/apache/logging-site/pull/3 - includes a plugin for embedding videos in privacy conform way - added blog post on video interview with piotr and matt -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Added video interview from CoC [logging-site]

2024-07-26 Thread via GitHub
grobmeier merged PR #3: URL: https://github.com/apache/logging-site/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@log

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-26 Thread via GitHub
jvz commented on code in PR #2716: URL: https://github.com/apache/logging-log4j2/pull/2716#discussion_r1693591068 ## src/site/antora/modules/ROOT/pages/manual/architecture.adoc: ## @@ -16,467 +16,848 @@ = Architecture -== Main Components - -Log4j uses the classes shown

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-26 Thread via GitHub
jvz commented on code in PR #2716: URL: https://github.com/apache/logging-log4j2/pull/2716#discussion_r1693591417 ## src/site/antora/modules/ROOT/pages/manual/layouts.adoc: ## @@ -557,6 +557,11 @@ include::partial$manual/plugin-preliminaries.adoc[] Layouts are xref:manual/plu

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-26 Thread via GitHub
jvz commented on PR #2716: URL: https://github.com/apache/logging-log4j2/pull/2716#issuecomment-2253492850 Remaining tasks: - [ ] Update existing configuration factory plugin classes to use `@Ordered` instead of `@Order`. - [ ] Would be nice if there were a way to still support `@O

Re: [PR] Deprecate `Message#getFormat()` (logging-log4j2)

2024-07-27 Thread via GitHub
vy commented on PR #2773: URL: https://github.com/apache/logging-log4j2/pull/2773#issuecomment-2254144407 > the `useRawMessage` attribute of `RegexFilter` does not make much sense, since it uses `getFormat()`. This is a difficult one. That is, I can understand the rationale behind `u

Re: [PR] Reload key and certs in SockerAppender reconnector (logging-log4j2)

2024-07-27 Thread via GitHub
vy commented on PR #2767: URL: https://github.com/apache/logging-log4j2/pull/2767#issuecomment-2254161981 For one, I don't think it is correct to keep the state (i.e., `SSLContext`) in configuration DTOs. I think the state should have rather been implemented as a part of `SslSocketManager`.

[I] log4j2.disableJmx and/or log4j2.disable.jmx seems not to work (logging-log4j2)

2024-07-27 Thread via GitHub
autumoswitzerland opened a new issue, #2774: URL: https://github.com/apache/logging-log4j2/issues/2774 ## Description System property switches "log4j2.disableJmx" and/or "log4j2.disable.jmx" seem not to work! ## Configuration **Version:** 2.23.1 with slf4j 1.7.36

Re: [I] JsonTemplateLayout: java.lang.OutOfMemoryError: Java heap space java.lang.OutOfMemoryError: Java heap space (logging-log4j2)

2024-07-27 Thread via GitHub
github-actions[bot] closed issue #2516: JsonTemplateLayout: java.lang.OutOfMemoryError: Java heap space java.lang.OutOfMemoryError: Java heap space URL: https://github.com/apache/logging-log4j2/issues/2516 -- This is an automated message from the Apache Git Service. To respond to the message

Re: [I] log4j2.disableJmx and/or log4j2.disable.jmx seems not to work (logging-log4j2)

2024-07-28 Thread via GitHub
vy commented on issue #2774: URL: https://github.com/apache/logging-log4j2/issues/2774#issuecomment-2254390183 @autumoswitzerland, thanks for your report, much appreciated. The described behaviour is indeed unexpected. I will create a custom Java runtime and try to reproduce the error – wh

[PR] Avoid `java.management` dependency when JMX is disabled (logging-log4j2)

2024-07-28 Thread via GitHub
vy opened a new pull request, #2775: URL: https://github.com/apache/logging-log4j2/pull/2775 Fixes #2774 by placing code depending on `java.management` behind a `java.management`-free check. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] log4j2.disableJmx and/or log4j2.disable.jmx seems not to work (logging-log4j2)

2024-07-28 Thread via GitHub
ppkarwasz commented on issue #2774: URL: https://github.com/apache/logging-log4j2/issues/2774#issuecomment-2254414225 The code seems to work as expected, the only problem I see is the severity of the status logger call, which should not be `ERROR` but `INFO` or `DEBUG`: https://gith

Re: [I] log4j2.disableJmx and/or log4j2.disable.jmx seems not to work (logging-log4j2)

2024-07-28 Thread via GitHub
vy commented on issue #2774: URL: https://github.com/apache/logging-log4j2/issues/2774#issuecomment-2254418643 @autumoswitzerland, I have verified that `log4j-core` still requires the `java.management` module even when JMX is disabled. I have fixed this issue in #2775, which will be releas

[PR] adhere to jpms (module-info.java added) [logging-log4j-kotlin]

2024-07-28 Thread via GitHub
aanno opened a new pull request, #80: URL: https://github.com/apache/logging-log4j-kotlin/pull/80 Currently, logging-log4j-kotlin does not adhere to jpms but the rest of log4j does (e.g. org.apache.logging.log4j:log4j-api:2.23.1 _does_ contain a `module-info.java`. This makes it _ver

Re: [PR] adhere to jpms (module-info.java added) [logging-log4j-kotlin]

2024-07-28 Thread via GitHub
vy commented on PR #80: URL: https://github.com/apache/logging-log4j-kotlin/pull/80#issuecomment-2254465301 Log4j Kotlin, just like all Maven-based Apache Logging Services projects (e.g., Log4j), uses [logging-parent](/apache/logging-parent), which takes care of the JPMS descriptor generat

Re: [PR] adhere to jpms (module-info.java added) [logging-log4j-kotlin]

2024-07-28 Thread via GitHub
aanno closed pull request #80: adhere to jpms (module-info.java added) URL: https://github.com/apache/logging-log4j-kotlin/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] adhere to jpms (module-info.java added) [logging-log4j-kotlin]

2024-07-28 Thread via GitHub
aanno commented on PR #80: URL: https://github.com/apache/logging-log4j-kotlin/pull/80#issuecomment-2254474542 Yes, you are right. JPMS support was added in 1.3.0 (but I looked at 1.2.0 by mistake). Sorry for the noise. -- This is an automated message from the Apache Git Service.

Re: [I] Is the version 2.0.15 still supported? (logging-log4net)

2024-07-28 Thread via GitHub
ppkarwasz closed issue #159: Is the version 2.0.15 still supported? URL: https://github.com/apache/logging-log4net/issues/159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] log4j2.disableJmx and/or log4j2.disable.jmx seem not to work (logging-log4j2)

2024-07-28 Thread via GitHub
autumoswitzerland commented on issue #2774: URL: https://github.com/apache/logging-log4j2/issues/2774#issuecomment-2254655797 Thanks for the quick response and checking of the issue! It is not really critical, it was more a surprising behaviour on Linux. Do you still need any of the arte

Re: [I] log4j2.disableJmx and/or log4j2.disable.jmx seem not to work (logging-log4j2)

2024-07-28 Thread via GitHub
autumoswitzerland commented on issue #2774: URL: https://github.com/apache/logging-log4j2/issues/2774#issuecomment-2254665217 Addendum, request No. 2. See attached image. ![Bildschirmfoto 2024-07-29 um 00 07 06](https://github.com/user-attachments/assets/2d0f41f8-9544-4b45-8280-82281a04a

Re: [PR] Avoid `java.management` dependency when JMX is disabled (logging-log4j2)

2024-07-29 Thread via GitHub
vy merged PR #2775: URL: https://github.com/apache/logging-log4j2/pull/2775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [I] log4j2.disableJmx and/or log4j2.disable.jmx seem not to work (logging-log4j2)

2024-07-29 Thread via GitHub
vy closed issue #2774: log4j2.disableJmx and/or log4j2.disable.jmx seem not to work URL: https://github.com/apache/logging-log4j2/issues/2774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] log4j2.disableJmx and/or log4j2.disable.jmx seem not to work (logging-log4j2)

2024-07-29 Thread via GitHub
vy commented on issue #2774: URL: https://github.com/apache/logging-log4j2/issues/2774#issuecomment-2255245618 > Still wondering why the switch is not in the log4j2 component properties, because that is imho the real issue; The system property is not copied into the component properties.

Re: [PR] #156 fixed Regression when creating nested loggers in reverse order (logging-log4net)

2024-07-29 Thread via GitHub
FreeAndNil merged PR #157: URL: https://github.com/apache/logging-log4net/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Regression: Creating nested loggers in reverse order fails in 3.0.0-preview.1 (logging-log4net)

2024-07-29 Thread via GitHub
FreeAndNil closed issue #156: Regression: Creating nested loggers in reverse order fails in 3.0.0-preview.1 URL: https://github.com/apache/logging-log4net/issues/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] Regression: Creating nested loggers in reverse order fails in 3.0.0-preview.1 (logging-log4net)

2024-07-29 Thread via GitHub
FreeAndNil commented on issue #156: URL: https://github.com/apache/logging-log4net/issues/156#issuecomment-2255256875 Fixed in 3.0.0-preview.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] 3.0.0-preview.2 (logging-log4net)

2024-07-29 Thread via GitHub
FreeAndNil commented on issue #139: URL: https://github.com/apache/logging-log4net/issues/139#issuecomment-2255400834 @erikmav Can you test 3.0.0-preview.2 on your side? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Bump ossf/scorecard-action from 2.3.3 to 2.4.0 [logging-parent]

2024-07-29 Thread via GitHub
github-actions[bot] closed pull request #212: Bump ossf/scorecard-action from 2.3.3 to 2.4.0 URL: https://github.com/apache/logging-parent/pull/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Bump org.apache.kafka:kafka-clients from 3.7.1 to 3.8.0 (logging-log4j2)

2024-07-29 Thread via GitHub
github-actions[bot] closed pull request #2777: Bump org.apache.kafka:kafka-clients from 3.7.1 to 3.8.0 URL: https://github.com/apache/logging-log4j2/pull/2777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] log4j2.disableJmx and/or log4j2.disable.jmx seem not to work (logging-log4j2)

2024-07-29 Thread via GitHub
ppkarwasz commented on issue #2774: URL: https://github.com/apache/logging-log4j2/issues/2774#issuecomment-2255869892 > As a temporary workaround, you need to add `java.management` module to your runtime. IMHO as a temporary workaround the status logger `ERROR` messages can be ignor

Re: [PR] Avoid `java.management` dependency when JMX is disabled (logging-log4j2)

2024-07-29 Thread via GitHub
ppkarwasz commented on PR #2775: URL: https://github.com/apache/logging-log4j2/pull/2775#issuecomment-2255891611 I ran a couple of tests on a simple JLink project to find out that: * the HotSpot JVM always loads `java.management` if it is present (the module provides an implementation

Re: [I] log4j2.disableJmx and/or log4j2.disable.jmx seem not to work (logging-log4j2)

2024-07-29 Thread via GitHub
autumoswitzerland commented on issue #2774: URL: https://github.com/apache/logging-log4j2/issues/2774#issuecomment-2256412955 Yes, adding the module "java.management" prevents the output above. No log information is put out. -- This is an automated message from the Apache Git Service. To

Re: [PR] Deprecate `Message#getFormat()` (logging-log4j2)

2024-07-29 Thread via GitHub
ppkarwasz commented on PR #2773: URL: https://github.com/apache/logging-log4j2/pull/2773#issuecomment-2256605972 > In short, `useRawMessage` has value, but it is implemented incorrectly, IMO. Instead, I think, we should have introduced a `RegexFilterableMessage` contract and implement it in

Re: [PR] Reload key and certs in SockerAppender reconnector (logging-log4j2)

2024-07-29 Thread via GitHub
ppkarwasz commented on PR #2767: URL: https://github.com/apache/logging-log4j2/pull/2767#issuecomment-2256772362 > @ppkarwasz, in the light of your feedback, I revised my proposal as follows: > > 1. Introduce `getId()` to `SslConfiguration` and use it in the `name` provided to `g

Re: [I] 3.0.0-preview.2 (logging-log4net)

2024-07-29 Thread via GitHub
erikmav commented on issue #139: URL: https://github.com/apache/logging-log4net/issues/139#issuecomment-2257261609 Preview.1 and preview.2 both checked out on 2 services I run. Thanks for publishing - looking forward to the final release. From: Jan Fri

Re: [PR] Deprecate `Message#getFormat()` (logging-log4j2)

2024-07-30 Thread via GitHub
vy merged PR #2773: URL: https://github.com/apache/logging-log4j2/pull/2773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

[I] Disable programmatic configuration if `log4j1.compatibility` is `false` (LOG4J2-3467) (logging-log4j2)

2024-07-30 Thread via GitHub
ppkarwasz opened a new issue, #2778: URL: https://github.com/apache/logging-log4j2/issues/2778 This issue is moved from the [LOG4J2-3467](https://issues.apache.org/jira/browse/LOG4J2-3467) JIRA issue. The `log4j-1.2-api` artifact is a bridge, whose main purpose is to forward Log4j 1

Re: [PR] Reload key and certs in SockerAppender reconnector (logging-log4j2)

2024-07-30 Thread via GitHub
vy commented on PR #2767: URL: https://github.com/apache/logging-log4j2/pull/2767#issuecomment-2257799411 > LOG4J2-2988 only asks to reload the keystores after a reconfiguration @ppkarwasz, you've have a point. Given this, aren't we practically done after introducing `SslConfiguration

Re: [PR] Reload key and certs in SockerAppender reconnector (logging-log4j2)

2024-07-30 Thread via GitHub
ppkarwasz commented on PR #2767: URL: https://github.com/apache/logging-log4j2/pull/2767#issuecomment-2257814797 > > LOG4J2-2988 only asks to reload the keystores after a reconfiguration > > @ppkarwasz, you've have a point. Given this, aren't we practically done after introducing `Ssl

Re: [PR] Reload key and certs in SockerAppender reconnector (logging-log4j2)

2024-07-30 Thread via GitHub
vy commented on PR #2767: URL: https://github.com/apache/logging-log4j2/pull/2767#issuecomment-2257831780 @MichaelMorrisEst, would you be interested in updating your PR with the following changes? 1. Introduce the new `SslConfiguration#getId()` method returning an identifier `String`

<    18   19   20   21   22   23   24   25   26   27   >