Re: [PR] Bump commons-logging:commons-logging from 1.3.2 to 1.3.3 [logging-log4j-jakarta]

2024-07-04 Thread via GitHub
github-actions[bot] merged PR #37: URL: https://github.com/apache/logging-log4j-jakarta/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-04 Thread via GitHub
alan0428a commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2209669545 @vy Thanks for your feedback! Actually I am happy we have this careful reveiw process, so that we have high standard codes. Back to the topic, I also agree that this re

Re: [I] `StrSubstitutor` cannot parse nested braces (logging-log4j2)

2024-07-05 Thread via GitHub
ppkarwasz commented on issue #2679: URL: https://github.com/apache/logging-log4j2/issues/2679#issuecomment-2210407353 To be more precise, the `StrLookup` parses the string `${env:TZ:-%d{-MM-dd HH:mm:ss}{GMT+00}}` as: 1. A lookup expression (`${env:TZ:-%d{-MM-dd HH:mm:ss}`), w

Re: [PR] Bump dependabot/fetch-metadata from 2.1.0 to 2.2.0 [logging-parent]

2024-07-05 Thread via GitHub
github-actions[bot] closed pull request #200: Bump dependabot/fetch-metadata from 2.1.0 to 2.2.0 URL: https://github.com/apache/logging-parent/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[PR] Revamp the explanation on creating loggers [logging-log4j-kotlin]

2024-07-05 Thread via GitHub
vy opened a new pull request, #79: URL: https://github.com/apache/logging-log4j-kotlin/pull/79 Tipped by @breun, users find it confusing which logger creation mechanism to choose from. This PR is improves the documentation in that direction. -- This is an automated message from the Apache

Re: [PR] Bump commons-logging:commons-logging from 1.3.2 to 1.3.3 (logging-log4j2)

2024-07-05 Thread via GitHub
github-actions[bot] closed pull request #2713: Bump commons-logging:commons-logging from 1.3.2 to 1.3.3 URL: https://github.com/apache/logging-log4j2/pull/2713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-05 Thread via GitHub
vy commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2210702563 > I saw at `xxxThrowablePatternConverter#format()` we do conditions checking whether `event.getThrownProxy() is null`. But when will it be null? I presume, since `ThrowableProxy`

[PR] Revamp `cloud.adoc` for service-oriented architectures (logging-log4j2)

2024-07-05 Thread via GitHub
vy opened a new pull request, #2715: URL: https://github.com/apache/logging-log4j2/pull/2715 Closes #2510. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [I] `StrSubstitutor` cannot parse nested braces (logging-log4j2)

2024-07-05 Thread via GitHub
ngocnhan-tran1996 commented on issue #2679: URL: https://github.com/apache/logging-log4j2/issues/2679#issuecomment-2210918728 Hi @vy , @ppkarwasz I have a PR but I think this has more edge case. Please take a look and tell me if I miss something https://github.com/apache/logg

Re: [PR] StrSubstitutor cannot parse nested braces (logging-log4j2)

2024-07-05 Thread via GitHub
ppkarwasz commented on PR #2712: URL: https://github.com/apache/logging-log4j2/pull/2712#issuecomment-2210973106 @ngocnhan-tran1996, Thank you for the PR. Unfortunately this does not solve #2679, but just your particular problem with the `%d{...}` pattern converter as default value

[PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-05 Thread via GitHub
vy opened a new pull request, #2716: URL: https://github.com/apache/logging-log4j2/pull/2716 This *incomplete* work ports #2696 to `main`. The following tasks still need to be done: - [ ] Adapt `plugins.adoc` for Log4j 3 - Artifact has changed - Package paths have changed

[PR] Revamp the `Filters` page (logging-log4j2)

2024-07-05 Thread via GitHub
ppkarwasz opened a new pull request, #2717: URL: https://github.com/apache/logging-log4j2/pull/2717 In this PR we: - add a section about the filtering process, that explains in detail all the places, where a filter can be configured. - add the description of 3 filters, - improve

Re: [PR] Consolidate stack trace rendering in Pattern Layout (logging-log4j2)

2024-07-05 Thread via GitHub
alan0428a commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2211071869 @vy Just want to make sure we are on the same page. So for `xxxThrowablePatternConverter#format()`, the existing implementation is that when `event.getThrownProxy()` i

Re: [PR] Revamp `cloud.adoc` for service-oriented architectures (logging-log4j2)

2024-07-05 Thread via GitHub
ppkarwasz commented on code in PR #2715: URL: https://github.com/apache/logging-log4j2/pull/2715#discussion_r1667084479 ## src/site/antora/modules/ROOT/pages/manual/cloud.adoc: ## @@ -15,549 +15,267 @@ limitations under the License. -= Using Log4j in Cloud Enabled Appl

Re: [PR] Bump org.apache.groovy:groovy-bom from 4.0.21 to 4.0.22 (logging-log4j2)

2024-07-05 Thread via GitHub
ppkarwasz commented on PR #2699: URL: https://github.com/apache/logging-log4j2/pull/2699#issuecomment-2211654253 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump net.javacrumbs.json-unit:json-unit from 2.38.0 to 2.40.0 (logging-log4j2)

2024-07-05 Thread via GitHub
ppkarwasz commented on PR #2705: URL: https://github.com/apache/logging-log4j2/pull/2705#issuecomment-2211655535 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump org.apache.groovy:groovy-bom from 4.0.21 to 4.0.22 (logging-log4j2)

2024-07-05 Thread via GitHub
github-actions[bot] closed pull request #2699: Bump org.apache.groovy:groovy-bom from 4.0.21 to 4.0.22 URL: https://github.com/apache/logging-log4j2/pull/2699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Bump net.javacrumbs.json-unit:json-unit from 2.38.0 to 2.40.0 (logging-log4j2)

2024-07-05 Thread via GitHub
github-actions[bot] closed pull request #2705: Bump net.javacrumbs.json-unit:json-unit from 2.38.0 to 2.40.0 URL: https://github.com/apache/logging-log4j2/pull/2705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Bump flapdoodle-embed.version from 4.11.0 to 4.12.0 (logging-log4j2)

2024-07-05 Thread via GitHub
ppkarwasz commented on PR #2707: URL: https://github.com/apache/logging-log4j2/pull/2707#issuecomment-2211679784 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] `StrSubstitutor` cannot parse nested braces (logging-log4j2)

2024-07-05 Thread via GitHub
ppkarwasz commented on issue #2679: URL: https://github.com/apache/logging-log4j2/issues/2679#issuecomment-2211679687 Looking at [bash parameter expansion](https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html), I would propose to just introduce a simple escape

Re: [PR] Bump net.javacrumbs.json-unit:json-unit from 2.39.0 to 2.40.0 (logging-log4j2)

2024-07-05 Thread via GitHub
ppkarwasz commented on PR #2708: URL: https://github.com/apache/logging-log4j2/pull/2708#issuecomment-2211679853 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump commons-logging:commons-logging from 1.3.2 to 1.3.3 (logging-log4j2)

2024-07-05 Thread via GitHub
ppkarwasz commented on PR #2714: URL: https://github.com/apache/logging-log4j2/pull/2714#issuecomment-2211680113 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump co.elastic.clients:elasticsearch-java from 8.14.1 to 8.14.2 (logging-log4j2)

2024-07-05 Thread via GitHub
ppkarwasz commented on PR #2711: URL: https://github.com/apache/logging-log4j2/pull/2711#issuecomment-2211680179 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump commons-logging:commons-logging from 1.3.2 to 1.3.3 (logging-log4j2)

2024-07-05 Thread via GitHub
github-actions[bot] closed pull request #2714: Bump commons-logging:commons-logging from 1.3.2 to 1.3.3 URL: https://github.com/apache/logging-log4j2/pull/2714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Bump co.elastic.clients:elasticsearch-java from 8.14.1 to 8.14.2 (logging-log4j2)

2024-07-06 Thread via GitHub
github-actions[bot] closed pull request #2711: Bump co.elastic.clients:elasticsearch-java from 8.14.1 to 8.14.2 URL: https://github.com/apache/logging-log4j2/pull/2711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Bump org.eclipse.jetty:jetty-bom from 9.4.54.v20240208 to 9.4.55.v20240627 (logging-log4j2)

2024-07-06 Thread via GitHub
ppkarwasz commented on PR #2706: URL: https://github.com/apache/logging-log4j2/pull/2706#issuecomment-2211695578 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] StrSubstitutor cannot parse nested braces (logging-log4j2)

2024-07-06 Thread via GitHub
ngocnhan-tran1996 commented on PR #2712: URL: https://github.com/apache/logging-log4j2/pull/2712#issuecomment-2211724941 @ppkarwasz I try to create class `ConverterKeysSubstitutor` for pattern specifiers ` %{...}`. Please take a look and give me more test or some advice. -- This i

Re: [PR] Consolidate stack trace rendering in Pattern Layout (logging-log4j2)

2024-07-06 Thread via GitHub
rgoers commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2211795872 As I recall ThrowableProxy was introduced so that LogEvents could be remotely shipped to remove systems. We no longer support doing that kind of thing using Java Serialization. So I

Re: [PR] Bump net.javacrumbs.json-unit:json-unit from 2.39.0 to 2.40.0 (logging-log4j2)

2024-07-06 Thread via GitHub
github-actions[bot] closed pull request #2708: Bump net.javacrumbs.json-unit:json-unit from 2.39.0 to 2.40.0 URL: https://github.com/apache/logging-log4j2/pull/2708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Bump org.eclipse.jetty:jetty-bom from 9.4.54.v20240208 to 9.4.55.v20240627 (logging-log4j2)

2024-07-06 Thread via GitHub
ppkarwasz commented on PR #2706: URL: https://github.com/apache/logging-log4j2/pull/2706#issuecomment-2211967930 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-07 Thread via GitHub
MehdiChinoune opened a new issue, #388: URL: https://github.com/apache/logging-log4cxx/issues/388 ``` [133/160] Building CXX object src/main/cpp/CMakeFiles/log4cxx.dir/threadutility.cpp.obj FAILED: src/main/cpp/CMakeFiles/log4cxx.dir/threadutility.cpp.obj D:\Programs\msys64_test\ucr

Re: [PR] Revamp the explanation on creating loggers [logging-log4j-kotlin]

2024-07-07 Thread via GitHub
vy merged PR #79: URL: https://github.com/apache/logging-log4j-kotlin/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] Revamp `cloud.adoc` for service-oriented architectures (logging-log4j2)

2024-07-07 Thread via GitHub
vy commented on code in PR #2715: URL: https://github.com/apache/logging-log4j2/pull/2715#discussion_r1667749244 ## src/site/antora/modules/ROOT/pages/manual/cloud.adoc: ## @@ -15,549 +15,267 @@ limitations under the License. -= Using Log4j in Cloud Enabled Application

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.17.1 to 2.17.2 [logging-log4j-samples]

2024-07-07 Thread via GitHub
github-actions[bot] merged PR #153: URL: https://github.com/apache/logging-log4j-samples/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-07 Thread via GitHub
swebb2066 commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2213096971 @MehdiChinoune Please post the version of mingw-w64 and g++ that you are using. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-07 Thread via GitHub
MehdiChinoune commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2213105746 mingw-w64: master (12.0.0+r81) g++: 14.1.0 I installed them (with apr and apr-util) from MSYS2/UCRT64 environment -- This is an automated message from the Apa

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668109357 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log eve

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
vy commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668112344 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log events at

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668159863 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log eve

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668160252 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log eve

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-08 Thread via GitHub
swebb2066 commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2213291857 @MehdiChinoune I was unable to reproduce the error using gcc 13.2.0 I have not managed to upgrade gcc to 14.1.0. Using the command ```pacman -U /c/users/steph/Downl

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668209963 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log eve

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668211811 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log eve

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-08 Thread via GitHub
MehdiChinoune commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2213431394 ``` pacman -Syu ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-08 Thread via GitHub
MehdiChinoune commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2213445591 I have managed to build it with mingw-w64-gcc https://github.com/msys2/MINGW-packages/commit/59ce40c8db but the patch breaks building with mingw-w64-clang. To make

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668270521 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log eve

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668298843 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log eve

Re: [PR] Consolidate stack trace rendering in Pattern Layout (logging-log4j2)

2024-07-08 Thread via GitHub
vy commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2213522269 @rgoers, I very much liked the idea of retiring `ThrowableProxy`. I analyzed the possibility of this. I will share my findings below. ### What does Logback do? AFAIK, Log4j

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668329599 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log eve

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668330374 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log eve

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668330651 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log eve

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668332031 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log eve

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668336523 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log eve

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668338950 ## src/site/antora/modules/ROOT/examples/manual/filters/ContextMapFilter.json: ## @@ -0,0 +1,38 @@ +{ + "Configuration": { +"monitorInterval": 10, Review

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
vy commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668389359 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log events at

Re: [PR] Consolidate stack trace rendering in Pattern Layout (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2213652711 @vy, > 1. Create a new _internal_ (package-private, etc.) `ThrowableRenderer` class taking care of `Throwable` (not `ThrowableProxy`!) rendering such that: I wo

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668401162 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log eve

Re: [PR] Bump com.github.spotbugs:spotbugs-maven-plugin from 4.8.6.1 to 4.8.6.2 [logging-parent]

2024-07-08 Thread via GitHub
github-actions[bot] merged PR #201: URL: https://github.com/apache/logging-parent/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
vy commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668407817 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -18,1036 +18,1448 @@ [id=filters] = Filters -Log4j supports filtering of log events at each level

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
vy commented on code in PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717#discussion_r1668408550 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -17,1038 +17,1407 @@ [id=filters] = Filters +:stem: -Log4j supports filtering of log events at

Re: [PR] Consolidate stack trace rendering in Pattern Layout (logging-log4j2)

2024-07-08 Thread via GitHub
vy commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2213682324 > I would rather retrofit `PatternConverter` with a generic parameter `T` to indicate the type of object supported by the converter. @ppkarwasz, agreed, but that would be a breaki

Re: [PR] Revamp `cloud.adoc` for service-oriented architectures (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2715: URL: https://github.com/apache/logging-log4j2/pull/2715#discussion_r1668418867 ## src/site/antora/modules/ROOT/pages/manual/cloud.adoc: ## @@ -15,549 +15,267 @@ limitations under the License. -= Using Log4j in Cloud Enabled Appl

Re: [PR] Revamp `cloud.adoc` for service-oriented architectures (logging-log4j2)

2024-07-08 Thread via GitHub
vy commented on code in PR #2715: URL: https://github.com/apache/logging-log4j2/pull/2715#discussion_r1668424434 ## src/site/antora/modules/ROOT/pages/manual/cloud.adoc: ## @@ -15,549 +15,267 @@ limitations under the License. -= Using Log4j in Cloud Enabled Application

Re: [PR] Bump actions/upload-artifact from 4.3.3 to 4.3.4 [logging-parent]

2024-07-08 Thread via GitHub
github-actions[bot] merged PR #202: URL: https://github.com/apache/logging-parent/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Revamp `cloud.adoc` for service-oriented architectures (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on code in PR #2715: URL: https://github.com/apache/logging-log4j2/pull/2715#discussion_r1668429751 ## src/site/antora/modules/ROOT/pages/manual/cloud.adoc: ## @@ -15,549 +15,267 @@ limitations under the License. -= Using Log4j in Cloud Enabled Appl

Re: [PR] Revamp `cloud.adoc` for service-oriented architectures (logging-log4j2)

2024-07-08 Thread via GitHub
vy merged PR #2715: URL: https://github.com/apache/logging-log4j2/pull/2715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [I] Create a `Logging against ELK-stack` guide (logging-log4j2)

2024-07-08 Thread via GitHub
vy closed issue #2510: Create a `Logging against ELK-stack` guide URL: https://github.com/apache/logging-log4j2/issues/2510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[PR] Bump com.fasterxml.jackson:jackson-bom from 2.17.1 to 2.17.2 [logging-log4j-audit-sample]

2024-07-08 Thread via GitHub
dependabot[bot] opened a new pull request, #51: URL: https://github.com/apache/logging-log4j-audit-sample/pull/51 Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.17.1 to 2.17.2. Commits https://github.com/FasterXML/jackson-bom/commit/

Re: [PR] Consolidate stack trace rendering in Pattern Layout (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2213746303 > @ppkarwasz, agreed, but that would be a breaking change, right? IMHO, it stretches the focus of this PR far too much. Let's just start with consolidating the existing `Throwabl

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.17.1 to 2.17.2 [logging-log4j-audit-sample]

2024-07-08 Thread via GitHub
github-actions[bot] merged PR #51: URL: https://github.com/apache/logging-log4j-audit-sample/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

Re: [I] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz closed issue #2529: Revamp the `Filters` page URL: https://github.com/apache/logging-log4j2/issues/2529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Revamp the `Filters` page (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz merged PR #2717: URL: https://github.com/apache/logging-log4j2/pull/2717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Bump org.eclipse.jetty:jetty-bom from 9.4.54.v20240208 to 9.4.55.v20240627 (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on PR #2706: URL: https://github.com/apache/logging-log4j2/pull/2706#issuecomment-2213930022 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.17.1 to 2.17.2 (logging-log4j2)

2024-07-08 Thread via GitHub
github-actions[bot] closed pull request #2719: Bump com.fasterxml.jackson:jackson-bom from 2.17.1 to 2.17.2 URL: https://github.com/apache/logging-log4j2/pull/2719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-08 Thread via GitHub
rm5248 commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2214036240 >To make it work on both, It should detect whether the threading library is posix (default for g++/libstdc++ through winpthreads) or win32 (default for clang++/libc++).

Re: [PR] Consolidate stack trace rendering in Pattern Layout (logging-log4j2)

2024-07-08 Thread via GitHub
alan0428a commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2214111273 I don't have feedback on deprecating `ThrowableProxy`, as you are more familiar with the historical background than I am. > // You need `StackLocatorUtil.getCurrentStackTrace(

[I] Cache LoggerContext in log4j-slf4j-impl (logging-log4j2)

2024-07-08 Thread via GitHub
blaghed opened a new issue, #2720: URL: https://github.com/apache/logging-log4j2/issues/2720 When integrating Slf4J with Log4J, I make use of the `log4j-slf4j-impl` library. Then, typically, when logging something this will be the classical approach used: ```java public class M

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-08 Thread via GitHub
MehdiChinoune commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2214226181 > > To make it work on both, It should detect whether the threading library is posix (default for g++/libstdc++ through winpthreads) or win32 (default for clang++/libc++

[I] CronTrigerringPolicy date (logging-log4j2)

2024-07-08 Thread via GitHub
Nef91 opened a new issue, #2721: URL: https://github.com/apache/logging-log4j2/issues/2721 Hello, below is my login configuration file, the main assumptions are: - maximum 5 logs per day, 20 MB each - deleting logs older than 21 days - log backup every day at midnight `

Re: [I] Cache LoggerContext in log4j-slf4j-impl (logging-log4j2)

2024-07-08 Thread via GitHub
blaghed commented on issue #2720: URL: https://github.com/apache/logging-log4j2/issues/2720#issuecomment-2214291396 Is it alright if I create a suggested PR for this? I would really rather avoid the Apache "mailing list" stuff, though... Worth noting that some of the other integrations o

[I] SimpleLayout in log4j-1.2-api does not log anything (logging-log4j2)

2024-07-08 Thread via GitHub
kojinoguchi opened a new issue, #2722: URL: https://github.com/apache/logging-log4j2/issues/2722 ## Description When using SimpleLayout provided in log4j-1.2-api, it doesn't log anything. Is this by design? In log4j1, it used to log with ā€œ%level - %m%nā€ pattern ? ## Repro

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-08 Thread via GitHub
jvz commented on code in PR #2716: URL: https://github.com/apache/logging-log4j2/pull/2716#discussion_r1668960552 ## src/site/antora/modules/ROOT/pages/manual/architecture.adoc: ## @@ -16,467 +16,848 @@ = Architecture -== Main Components - -Log4j uses the classes shown

Re: [PR] Consolidate stack trace rendering in Pattern Layout (logging-log4j2)

2024-07-08 Thread via GitHub
vy commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2215038458 > It seems to me this PR is more complicated then I thought and is more like refactoring now. But I will try my best to understand it. @alan0428a, thanks so much for your patience

Re: [I] Cache LoggerContext in log4j-slf4j-impl (logging-log4j2)

2024-07-08 Thread via GitHub
vy commented on issue #2720: URL: https://github.com/apache/logging-log4j2/issues/2720#issuecomment-221564 @blaghed, good news is, you don't need to deal with _the mailing list stuff_. We would be more than happy to assist you here. Can you explain what kind of a cache you see ot

Re: [I] Cache LoggerContext in log4j-slf4j-impl (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on issue #2720: URL: https://github.com/apache/logging-log4j2/issues/2720#issuecomment-2215258488 The idea behind instance loggers is a nice one: if an application server shares your library between applications, instance loggers should allow you to log messages to the

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.17 to 1.14.18 [logging-log4j-samples]

2024-07-08 Thread via GitHub
github-actions[bot] closed pull request #154: Bump net.bytebuddy:byte-buddy from 1.14.17 to 1.14.18 URL: https://github.com/apache/logging-log4j-samples/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] Replace `synchronized` blocks with locks for performance in virtual threads (logging-log4j2)

2024-07-08 Thread via GitHub
zekronium commented on issue #1532: URL: https://github.com/apache/logging-log4j2/issues/1532#issuecomment-2215776357 Any possibility of backporting this to 2.x? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-08 Thread via GitHub
swebb2066 commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2215961338 > To make it work on both, It should detect whether the threading library is posix (default for g++/libstdc++ through winpthreads) or win32 (default for clang++/libc++).

Re: [I] Issue with logs being stopped getting generated at midnight while using date based rollover strategy in log4j2 (logging-log4j2)

2024-07-08 Thread via GitHub
github-actions[bot] commented on issue #2010: URL: https://github.com/apache/logging-log4j2/issues/2010#issuecomment-2216157969 This issue is stale because it has been waiting for your feedback for more than 60 days. The Apache Logging Services community values every submitted issue, but w

Re: [I] RollingRandomAccessFile won't ZIP logs if there are 2 RRAF appenders (logging-log4j2)

2024-07-08 Thread via GitHub
github-actions[bot] commented on issue #1804: URL: https://github.com/apache/logging-log4j2/issues/1804#issuecomment-2216158105 This issue is stale because it has been waiting for your feedback for more than 60 days. The Apache Logging Services community values every submitted issue, but w

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-08 Thread via GitHub
MehdiChinoune commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2216333693 - It detects pthread only for UNIX. - It searches for pthread but doesn't search for the threading backend of C++ threading. Winpthread exists for mingw-w64-clang but

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-08 Thread via GitHub
swebb2066 commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2216506215 > It detects pthread only for UNIX mingw64 cmake seems to set UNIX to true When I build log4cxx using /mingw64/bin/clang++.exe version 18.1.8, the macro LOG4CXX

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-08 Thread via GitHub
MehdiChinoune commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2216530940 > > It detects pthread only for UNIX > > mingw64 cmake seems to set UNIX to true No, It does not > When I build log4cxx using /mingw64/bin/clang++.ex

Re: [PR] Bump org.eclipse.jetty:jetty-bom from 9.4.54.v20240208 to 9.4.55.v20240627 (logging-log4j2)

2024-07-08 Thread via GitHub
github-actions[bot] closed pull request #2706: Bump org.eclipse.jetty:jetty-bom from 9.4.54.v20240208 to 9.4.55.v20240627 URL: https://github.com/apache/logging-log4j2/pull/2706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.17.1 to 2.17.2 (logging-log4j2)

2024-07-08 Thread via GitHub
ppkarwasz commented on PR #2718: URL: https://github.com/apache/logging-log4j2/pull/2718#issuecomment-2216605019 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-08 Thread via GitHub
swebb2066 commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2216697333 Yes, I see that UNIX is not true using mingw-w64-x86_64-cmake. Using the information in [this stack overflow post](https://stackoverflow.com/questions/60794524/how-to-detect

Re: [PR] StrSubstitutor cannot parse nested braces (logging-log4j2)

2024-07-09 Thread via GitHub
ppkarwasz commented on PR #2712: URL: https://github.com/apache/logging-log4j2/pull/2712#issuecomment-2216804216 > IMHO `StrLookup` should be aware of the existence and syntax of pattern specifiers `%{...}`, it should just count the number of `{` and `}`. We also need to have a mechanism to

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.17.1 to 2.17.2 (logging-log4j2)

2024-07-09 Thread via GitHub
github-actions[bot] closed pull request #2718: Bump com.fasterxml.jackson:jackson-bom from 2.17.1 to 2.17.2 URL: https://github.com/apache/logging-log4j2/pull/2718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-09 Thread via GitHub
MehdiChinoune commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2216843317 > > The issue is about detecting the C++ threading backend on MinGW. > > It seems pthread and Win32 threading are available. We need to pick one. No, that's

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-09 Thread via GitHub
swebb2066 commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2216901619 > If you try to use one with the other It won't work. Using the following code ``` #include #include int main(){ pthread_t tid = pthread_self(

<    15   16   17   18   19   20   21   22   23   24   >