Re: [PR] Update XmlLayoutSchemaLog4j.cs to set writer.Namespaces = true for NETSTANDARD (logging-log4net)

2024-06-14 Thread via GitHub
FreeAndNil commented on PR #151: URL: https://github.com/apache/logging-log4net/pull/151#issuecomment-2168667973 Hi Marc, thanks for your contribution. Can you please - rebase your branch onto [Feature/111-Dropping-support-for-older-runtimes](https://github.com/apache/lo

Re: [PR] Bump io.netty:netty-bom from 4.1.110.Final to 4.1.111.Final (logging-log4j2)

2024-06-15 Thread via GitHub
ppkarwasz commented on PR #2652: URL: https://github.com/apache/logging-log4j2/pull/2652#issuecomment-2169837545 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump io.netty:netty-bom from 4.1.110.Final to 4.1.111.Final (logging-log4j2)

2024-06-15 Thread via GitHub
github-actions[bot] merged PR #2652: URL: https://github.com/apache/logging-log4j2/pull/2652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Split "Configuration" page (`main` branch) (logging-log4j2)

2024-06-17 Thread via GitHub
ppkarwasz merged PR #2659: URL: https://github.com/apache/logging-log4j2/pull/2659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] `PatternResolver` does not support substitution (logging-log4j2)

2024-06-17 Thread via GitHub
vy commented on issue #2666: URL: https://github.com/apache/logging-log4j2/issues/2666#issuecomment-2172733263 @ngocnhan-tran1996, thanks for the report, I've submitted #2667 fixing the issue. I would really appreciate it if you can 1. Checkout the `fix/2.x/JTL-prop-subs` branch 2

Re: [PR] Improve documentation on structured logging (logging-log4j2)

2024-06-17 Thread via GitHub
vy commented on code in PR #2665: URL: https://github.com/apache/logging-log4j2/pull/2665#discussion_r1642482876 ## src/site/antora/modules/ROOT/pages/manual/eventlogging.adoc: ## @@ -17,236 +17,35 @@ = Event Logger -The `EventLogger` class provides a mechanism for logging

Re: [PR] Improve documentation on structured logging (logging-log4j2)

2024-06-17 Thread via GitHub
vy commented on code in PR #2665: URL: https://github.com/apache/logging-log4j2/pull/2665#discussion_r1642496185 ## src/site/antora/modules/ROOT/pages/manual/eventlogging.adoc: ## @@ -17,236 +17,35 @@ = Event Logger -The `EventLogger` class provides a mechanism for logging

Re: [PR] Fix property substitution for `PatternResolver` (logging-log4j2)

2024-06-17 Thread via GitHub
ppkarwasz commented on PR #2667: URL: https://github.com/apache/logging-log4j2/pull/2667#issuecomment-2172962463 Using the features currently provided by `PluginBuilder` a possible alternative approach to introduce lookups in event templates would be: 1. Replace the `@PluginAttribute(

Re: [PR] Improve documentation on structured logging (logging-log4j2)

2024-06-17 Thread via GitHub
vy commented on code in PR #2665: URL: https://github.com/apache/logging-log4j2/pull/2665#discussion_r1642637395 ## src/site/antora/modules/ROOT/pages/manual/messages.adoc: ## @@ -217,7 +266,7 @@ In such a scenario, if you also have custom message types, consider implementing

Re: [PR] Improve documentation on structured logging (logging-log4j2)

2024-06-17 Thread via GitHub
vy merged PR #2665: URL: https://github.com/apache/logging-log4j2/pull/2665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [I] `PatternResolver` does not support substitution (logging-log4j2)

2024-06-17 Thread via GitHub
ngocnhan-tran1996 commented on issue #2666: URL: https://github.com/apache/logging-log4j2/issues/2666#issuecomment-2173652696 > @ngocnhan-tran1996, thanks for the report, I've submitted #2667 fixing the issue. I would really appreciate it if you can > > 1. Checkout the `fix/2.x/JTL-p

Re: [I] log4j is supporting the Openjdk21? (logging-log4j2)

2024-06-17 Thread via GitHub
ppkarwasz closed issue #2672: log4j is supporting the Openjdk21? URL: https://github.com/apache/logging-log4j2/issues/2672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-06-17 Thread via GitHub
rgoers commented on PR #2374: URL: https://github.com/apache/logging-log4j2/pull/2374#issuecomment-2173785816 I apologize for taking so long to look at this but while working on moving context related stuff to log4j-context-data I ran into this and it makes things much more difficult as it

Re: [PR] Bump maven.version from 3.9.7 to 3.9.8 [logging-log4j-transform]

2024-06-17 Thread via GitHub
github-actions[bot] closed pull request #109: Bump maven.version from 3.9.7 to 3.9.8 URL: https://github.com/apache/logging-log4j-transform/pull/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-06-17 Thread via GitHub
ppkarwasz commented on PR #2374: URL: https://github.com/apache/logging-log4j2/pull/2374#issuecomment-2174304317 Those internal/private classes are hardwired in `Provider`, since implementations of `Provider` have no way to access those classes. Once I'll promote the `StringArrayThrea

Re: [PR] Fix property substitution for `PatternResolver` (logging-log4j2)

2024-06-18 Thread via GitHub
vy commented on PR #2667: URL: https://github.com/apache/logging-log4j2/pull/2667#issuecomment-2175449983 @ppkarwasz, as discussed and agreed on, 1. Added `substitute` flag to `@Plugin[Builder]Attribute` 2. Disabled [configuration file] property substitution for `eventTemplate`, `s

Re: [PR] Bump com.github.spotbugs:spotbugs-annotations from 4.8.5 to 4.8.6 [logging-parent]

2024-06-18 Thread via GitHub
github-actions[bot] closed pull request #194: Bump com.github.spotbugs:spotbugs-annotations from 4.8.5 to 4.8.6 URL: https://github.com/apache/logging-parent/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Fix property substitution for `PatternResolver` (logging-log4j2)

2024-06-18 Thread via GitHub
ppkarwasz commented on code in PR #2667: URL: https://github.com/apache/logging-log4j2/pull/2667#discussion_r1644103084 ## log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/PatternResolver.java: ## @@ -71,6 +70,16 @@ public final cla

Re: [PR] Bump com.palantir.javaformat:palantir-java-format from 2.46.0 to 2.47.0 [logging-parent]

2024-06-18 Thread via GitHub
github-actions[bot] merged PR #186: URL: https://github.com/apache/logging-parent/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Fix property substitution for `PatternResolver` (logging-log4j2)

2024-06-18 Thread via GitHub
vy commented on code in PR #2667: URL: https://github.com/apache/logging-log4j2/pull/2667#discussion_r1644292997 ## log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/PatternResolver.java: ## @@ -71,6 +70,16 @@ public final class Patt

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-06-18 Thread via GitHub
ppkarwasz commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2175890695 I am converting this to a draft, since I'll use a slightly different approach: - I'll move `StringArrayThreadContextMap` to be the `DefaultThreadContextMap`, - I'll rem

[PR] Expand "Levels" page (logging-log4j2)

2024-06-18 Thread via GitHub
ppkarwasz opened a new pull request, #2674: URL: https://github.com/apache/logging-log4j2/pull/2674 We extend the "Levels" documentation page by providing information on how custom log levels appear in alternative Log4j API implementations (Logback and JUL). We also restore the `log4

Re: [PR] Add Logback example to "Markers" page (logging-log4j2)

2024-06-18 Thread via GitHub
ppkarwasz merged PR #2660: URL: https://github.com/apache/logging-log4j2/pull/2660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-06-18 Thread via GitHub
rgoers commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2176731969 @ppkarwasz Have you reconciled the problems I was seeing with StringArrayThreadContextMap in the perf tests? -- This is an automated message from the Apache Git Service. To re

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-06-18 Thread via GitHub
ppkarwasz commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2176759915 @rgoers, No, I didn't have time to look at it yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] `PatternResolver` does not support substitution (logging-log4j2)

2024-06-18 Thread via GitHub
vy commented on issue #2666: URL: https://github.com/apache/logging-log4j2/issues/2666#issuecomment-2176884248 @ngocnhan-tran1996, I collaborated on this issue with @ppkarwasz, and I decided to not update JTL (JSON Template Layout) to perform property substitution on resolver configuration

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-02 Thread via GitHub
vy commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1654740592 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java: ## @@ -295,12 +295,35 @@ public String getCauseStackTraceAsString( fi

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1654743393 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java: ## @@ -401,15 +423,17 @@ public String getExtendedStackTraceAsString(

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-02 Thread via GitHub
alan0428a commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1654818565 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java: ## @@ -295,12 +295,35 @@ public String getCauseStackTraceAsString(

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-02 Thread via GitHub
vy commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2194600314 @alan0428a, could you also create a `src/changelog/.2.x.x/fix_throwable_converter_issues.xml`, please? See other `fix_*.xml` files in the folder for the file structure. Please keep the

Re: [PR] Bump spring-boot.version from 3.3.0 to 3.3.1 (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on PR #2687: URL: https://github.com/apache/logging-log4j2/pull/2687#issuecomment-2194630021 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump org.apache.tomcat:tomcat-juli from 10.1.24 to 10.1.25 (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on PR #2680: URL: https://github.com/apache/logging-log4j2/pull/2680#issuecomment-2194621046 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-02 Thread via GitHub
vy commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1657060422 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/StringBuildersTest.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-02 Thread via GitHub
alan0428a commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1657071726 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/pattern/ThrowableFilterTest.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Bump spring-framework.version from 6.1.9 to 6.1.10 (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on PR #2682: URL: https://github.com/apache/logging-log4j2/pull/2682#issuecomment-2194622622 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.5.0 to 3.6.0 (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on PR #2684: URL: https://github.com/apache/logging-log4j2/pull/2684#issuecomment-2194624360 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump spring-framework.version from 6.1.9 to 6.1.10 (logging-log4j2)

2024-07-02 Thread via GitHub
github-actions[bot] closed pull request #2682: Bump spring-framework.version from 6.1.9 to 6.1.10 URL: https://github.com/apache/logging-log4j2/pull/2682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-02 Thread via GitHub
alan0428a commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1657159441 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/StringBuildersTest.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Bump spring-boot.version from 3.3.0 to 3.3.1 (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on PR #2687: URL: https://github.com/apache/logging-log4j2/pull/2687#issuecomment-2197895712 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2197939455 Note about the test failures: unfortunately we have about a dozen of flaky tests in our project (see the [Develocity statistics](https://ge.apache.org/scans/tests?search.rootProj

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-02 Thread via GitHub
vy commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1662515820 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/StringBuildersTest.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Bump net.javacrumbs.json-unit:json-unit from 2.38.0 to 2.39.0 (logging-log4j2)

2024-07-02 Thread via GitHub
github-actions[bot] closed pull request #2701: Bump net.javacrumbs.json-unit:json-unit from 2.38.0 to 2.39.0 URL: https://github.com/apache/logging-log4j2/pull/2701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on code in PR #2696: URL: https://github.com/apache/logging-log4j2/pull/2696#discussion_r1662608253 ## src/site/antora/modules/ROOT/pages/manual/customconfig.adoc: ## @@ -14,372 +14,232 @@ See the License for the specific language governing permissions a

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-02 Thread via GitHub
vy commented on code in PR #2696: URL: https://github.com/apache/logging-log4j2/pull/2696#discussion_r1661479919 ## src/site/antora/modules/ROOT/pages/manual/customconfig.adoc: ## @@ -14,372 +14,232 @@ See the License for the specific language governing permissions and

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on code in PR #2696: URL: https://github.com/apache/logging-log4j2/pull/2696#discussion_r1662526780 ## src/site/antora/modules/ROOT/pages/manual/customconfig.adoc: ## @@ -14,372 +14,232 @@ See the License for the specific language governing permissions a

Re: [PR] Revamp the `Web Applications` page (logging-log4j2)

2024-07-02 Thread via GitHub
vy commented on code in PR #2692: URL: https://github.com/apache/logging-log4j2/pull/2692#discussion_r1662529371 ## src/site/antora/modules/ROOT/examples/manual/webapp/log4j2-single.xml: ## @@ -0,0 +1,49 @@ + + +https://logging.apache.org/xml/ns"; + xmlns:xsi="http

Re: [PR] Bump org.codehaus.groovy:groovy-bom from 3.0.21 to 3.0.22 (logging-log4j2)

2024-07-02 Thread via GitHub
github-actions[bot] closed pull request #2698: Bump org.codehaus.groovy:groovy-bom from 3.0.21 to 3.0.22 URL: https://github.com/apache/logging-log4j2/pull/2698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1662595293 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverter.java: ## @@ -188,23 +188,24 @@ private void formatOption(final Thro

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-02 Thread via GitHub
alan0428a commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1662567553 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/StringBuildersTest.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Add Logback's throwable-consuming semantics as an option (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on code in PR #2381: URL: https://github.com/apache/logging-log4j2/pull/2381#discussion_r1662583010 ## src/changelog/.2.x.x/2363_add_logback_throwable_consuming_semantics.xml: ## @@ -1,8 +1,8 @@ http://www.w3.org/2001/XMLSchema-instance"; - xmlns="ht

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-02 Thread via GitHub
vy commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2204076668 > Just checked it's because before the PR, `ThrowablePatternRender#formatOption` serialize excpetion using [Throwable#printStackTrace](https://github.com/apache/logging-log4j2/blob/400c

Re: [PR] Add Logback's throwable-consuming semantics as an option (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz merged PR #2381: URL: https://github.com/apache/logging-log4j2/pull/2381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Add Logback's throwable-consuming semantics as an option (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz closed issue #2363: Add Logback's throwable-consuming semantics as an option URL: https://github.com/apache/logging-log4j2/issues/2363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-02 Thread via GitHub
vy commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1663019941 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverter.java: ## @@ -188,23 +188,24 @@ private void formatOption(final Throwable t

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-02 Thread via GitHub
vy commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1663019941 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverter.java: ## @@ -188,23 +188,24 @@ private void formatOption(final Throwable t

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-02 Thread via GitHub
vy commented on code in PR #2696: URL: https://github.com/apache/logging-log4j2/pull/2696#discussion_r1663063123 ## src/site/antora/modules/ROOT/pages/manual/customconfig.adoc: ## @@ -14,372 +14,232 @@ See the License for the specific language governing permissions and

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-02 Thread via GitHub
vy commented on code in PR #2696: URL: https://github.com/apache/logging-log4j2/pull/2696#discussion_r1663082428 ## src/site/antora/modules/ROOT/pages/manual/customconfig.adoc: ## @@ -14,372 +14,232 @@ See the License for the specific language governing permissions and

Re: [PR] Backport part of #2062 to `2.x` branch. (logging-log4j2)

2024-07-02 Thread via GitHub
vy commented on code in PR #2454: URL: https://github.com/apache/logging-log4j2/pull/2454#discussion_r1663089137 ## log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java: ## @@ -517,45 +532,64 @@ private Environment(final PropertySource propertySource) {

Re: [PR] Provide alternatives to config modifications (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on PR #2702: URL: https://github.com/apache/logging-log4j2/pull/2702#issuecomment-2204281617 > 1. `Your code relies on Log4j Core internals, which have lesser compatibility guarantees` statement is not correct. We don't have any guarantees on internals. We don't want

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on code in PR #2696: URL: https://github.com/apache/logging-log4j2/pull/2696#discussion_r1663094657 ## src/site/antora/modules/ROOT/pages/manual/extending.adoc: ## @@ -14,491 +14,132 @@ See the License for the specific language governing permissions and

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-02 Thread via GitHub
vy commented on code in PR #2696: URL: https://github.com/apache/logging-log4j2/pull/2696#discussion_r1663148071 ## src/site/antora/modules/ROOT/pages/manual/extending.adoc: ## @@ -14,491 +14,132 @@ See the License for the specific language governing permissions and li

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on code in PR #2696: URL: https://github.com/apache/logging-log4j2/pull/2696#discussion_r1663106641 ## src/site/antora/modules/ROOT/pages/manual/plugins.adoc: ## @@ -14,88 +14,274 @@ See the License for the specific language governing permissions and

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-02 Thread via GitHub
vy commented on code in PR #2696: URL: https://github.com/apache/logging-log4j2/pull/2696#discussion_r1663162070 ## src/site/antora/modules/ROOT/pages/manual/extending.adoc: ## @@ -14,491 +14,132 @@ See the License for the specific language governing permissions and li

Re: [PR] Bump io.fabric8:kubernetes-client-bom from 6.13.0 to 6.13.1 [logging-log4j-samples]

2024-07-02 Thread via GitHub
github-actions[bot] merged PR #151: URL: https://github.com/apache/logging-log4j-samples/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Provide alternatives to config modifications (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz closed pull request #2702: Provide alternatives to config modifications URL: https://github.com/apache/logging-log4j2/pull/2702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Provide alternatives to config modifications (logging-log4j2)

2024-07-02 Thread via GitHub
ppkarwasz commented on PR #2702: URL: https://github.com/apache/logging-log4j2/pull/2702#issuecomment-2205174177 After discussing it in a video call with Volkan, I am closing this for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-03 Thread via GitHub
vy commented on code in PR #2696: URL: https://github.com/apache/logging-log4j2/pull/2696#discussion_r1663673821 ## src/site/antora/modules/ROOT/pages/manual/plugins.adoc: ## @@ -14,88 +14,274 @@ See the License for the specific language governing permissions and limit

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-03 Thread via GitHub
vy commented on code in PR #2696: URL: https://github.com/apache/logging-log4j2/pull/2696#discussion_r1663711244 ## src/site/antora/modules/ROOT/pages/manual/plugins.adoc: ## @@ -14,88 +14,274 @@ See the License for the specific language governing permissions and limit

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-03 Thread via GitHub
vy commented on code in PR #2696: URL: https://github.com/apache/logging-log4j2/pull/2696#discussion_r1663730329 ## src/site/antora/modules/ROOT/pages/manual/plugins.adoc: ## @@ -14,88 +14,274 @@ See the License for the specific language governing permissions and limit

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-03 Thread via GitHub
vy commented on code in PR #2696: URL: https://github.com/apache/logging-log4j2/pull/2696#discussion_r1663731124 ## src/site/antora/modules/ROOT/pages/manual/plugins.adoc: ## @@ -14,88 +14,274 @@ See the License for the specific language governing permissions and limit

Re: [PR] Revamp the `Extending`, `Plugins`, `Architecture`, and `Programmatic configuration` pages (logging-log4j2)

2024-07-03 Thread via GitHub
vy merged PR #2696: URL: https://github.com/apache/logging-log4j2/pull/2696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Revamp the `Web Applications` page (logging-log4j2)

2024-07-03 Thread via GitHub
vy merged PR #2692: URL: https://github.com/apache/logging-log4j2/pull/2692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [I] Revamp the `Web Applications` page (logging-log4j2)

2024-07-03 Thread via GitHub
vy closed issue #2547: Revamp the `Web Applications` page URL: https://github.com/apache/logging-log4j2/issues/2547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [I] Revamp the `Extending` page (logging-log4j2)

2024-07-03 Thread via GitHub
vy closed issue #2530: Revamp the `Extending` page URL: https://github.com/apache/logging-log4j2/issues/2530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [I] Revamp the `Plugins` page (logging-log4j2)

2024-07-03 Thread via GitHub
vy closed issue #2531: Revamp the `Plugins` page URL: https://github.com/apache/logging-log4j2/issues/2531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [I] Revamp the `Extending` page (logging-log4j2)

2024-07-03 Thread via GitHub
vy commented on issue #2530: URL: https://github.com/apache/logging-log4j2/issues/2530#issuecomment-2205406779 Fixed by #2696. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] Revamp the `Plugins` page (logging-log4j2)

2024-07-03 Thread via GitHub
vy commented on issue #2531: URL: https://github.com/apache/logging-log4j2/issues/2531#issuecomment-2205407287 Fixed by #2696. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-03 Thread via GitHub
alan0428a commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1664283248 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/StringBuildersTest.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-03 Thread via GitHub
alan0428a commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1664284313 ## log4j-core/src/main/java/org/apache/logging/log4j/core/package-info.java: ## @@ -18,7 +18,7 @@ * Implementation of Log4j 2. */ @Export -@Version("2.24.

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-03 Thread via GitHub
alan0428a commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1664282749 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/StringBuildersTest.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-03 Thread via GitHub
alan0428a commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1664285290 ## log4j-core/src/main/java/org/apache/logging/log4j/core/util/internal/StringBuilders.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-03 Thread via GitHub
alan0428a commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1664286333 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/StringBuildersTest.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-03 Thread via GitHub
alan0428a commented on code in PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#discussion_r1664285750 ## src/changelog/.2.x.x/fix_throwable_converter_issues.xml: ## @@ -0,0 +1,10 @@ + +http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.a

[I] Unwanted `TRACE` output in v2.23.1 with `-Dlog4j.debug=false` (logging-log4j2)

2024-07-03 Thread via GitHub
vkolomeyko opened a new issue, #2703: URL: https://github.com/apache/logging-log4j2/issues/2703 ## Description The effect of `-Dlog4j.debug=false` has changed in v2.23.1 ## Configuration **Version:** 2.23.1 **Operating system:** Windows **JDK:** zulu17.46.19

[PR] Explicitly checking for `-Dlog4j.debug=false` (logging-log4j2)

2024-07-03 Thread via GitHub
vkolomeyko opened a new pull request, #2704: URL: https://github.com/apache/logging-log4j2/pull/2704 As reported in: https://github.com/apache/logging-log4j2/issues/2703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-03 Thread via GitHub
alan0428a commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2206446614 @vy Actually `%rEx` and `%xEx` both operate on a `ThrowableProxy` in existing implementation. So only `%ex` needs to rely on `Throwable#printStackTrace()`. However, the outp

Re: [PR] Bump org.eclipse.jetty:jetty-maven-plugin from 10.0.21 to 10.0.22 [logging-log4j-samples]

2024-07-03 Thread via GitHub
github-actions[bot] merged PR #152: URL: https://github.com/apache/logging-log4j-samples/pull/152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Explicitly checking for `-Dlog4j.debug=false` (logging-log4j2)

2024-07-03 Thread via GitHub
ppkarwasz merged PR #2704: URL: https://github.com/apache/logging-log4j2/pull/2704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Unwanted `TRACE` output in v2.23.1 with `-Dlog4j.debug=false` (logging-log4j2)

2024-07-03 Thread via GitHub
ppkarwasz commented on issue #2703: URL: https://github.com/apache/logging-log4j2/issues/2703#issuecomment-2208225457 Thank you for your report and the patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] Unwanted `TRACE` output in v2.23.1 with `-Dlog4j.debug=false` (logging-log4j2)

2024-07-03 Thread via GitHub
ppkarwasz closed issue #2703: Unwanted `TRACE` output in v2.23.1 with `-Dlog4j.debug=false` URL: https://github.com/apache/logging-log4j2/issues/2703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Merge `build` and `merge-dependabot` workflows (logging-log4j2)

2024-07-04 Thread via GitHub
ppkarwasz closed pull request #2686: Merge `build` and `merge-dependabot` workflows URL: https://github.com/apache/logging-log4j2/pull/2686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Merge `build` and `merge-dependabot` workflows (logging-log4j2)

2024-07-04 Thread via GitHub
ppkarwasz commented on PR #2686: URL: https://github.com/apache/logging-log4j2/pull/2686#issuecomment-2208265018 Closing this to comply with [INFRA policy](https://infra.apache.org/github-actions-policy.html). -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Bump org.apache.groovy:groovy-bom from 4.0.21 to 4.0.22 (logging-log4j2)

2024-07-04 Thread via GitHub
ppkarwasz commented on PR #2699: URL: https://github.com/apache/logging-log4j2/pull/2699#issuecomment-2208350822 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump net.javacrumbs.json-unit:json-unit from 2.38.0 to 2.39.0 (logging-log4j2)

2024-07-04 Thread via GitHub
ppkarwasz commented on PR #2700: URL: https://github.com/apache/logging-log4j2/pull/2700#issuecomment-2208351283 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump org.eclipse.jetty:jetty-bom from 9.4.54.v20240208 to 9.4.55.v20240627 (logging-log4j2)

2024-07-04 Thread via GitHub
github-actions[bot] closed pull request #2709: Bump org.eclipse.jetty:jetty-bom from 9.4.54.v20240208 to 9.4.55.v20240627 URL: https://github.com/apache/logging-log4j2/pull/2709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Bump flapdoodle-embed.version from 4.11.0 to 4.12.0 (logging-log4j2)

2024-07-04 Thread via GitHub
github-actions[bot] closed pull request #2710: Bump flapdoodle-embed.version from 4.11.0 to 4.12.0 URL: https://github.com/apache/logging-log4j2/pull/2710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-04 Thread via GitHub
vy commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2208951635 > @vy Actually `%rEx` and `%xEx` both operate on a `ThrowableProxy` in existing implementation. I think this is a ~feature~ bug. `%rEx` should operate on the `Throwable`, just li

Re: [PR] fix: LOG4J2-3627 and gh issue 1729 (logging-log4j2)

2024-07-04 Thread via GitHub
ppkarwasz commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2208995534 > @alan0428a, before starting to implement this, I really would like to hear your thoughts too. In the meantime, I will ask this to some other PMC members too. Looks good

[PR] StrSubstitutor cannot parse nested braces (logging-log4j2)

2024-07-04 Thread via GitHub
ngocnhan-tran1996 opened a new pull request, #2712: URL: https://github.com/apache/logging-log4j2/pull/2712 As reported in: [2679](https://github.com/apache/logging-log4j2/issues/2679) -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Bump commons-logging:commons-logging from 1.3.2 to 1.3.3 [logging-log4j-transform]

2024-07-04 Thread via GitHub
github-actions[bot] closed pull request #111: Bump commons-logging:commons-logging from 1.3.2 to 1.3.3 URL: https://github.com/apache/logging-log4j-transform/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

<    14   15   16   17   18   19   20   21   22   23   >