[I] PatternLayout unsuitable for production purposes (logging-log4j2)

2024-04-25 Thread via GitHub
marcelhoelscher opened a new issue, #2518: URL: https://github.com/apache/logging-log4j2/issues/2518 Hello, I came across the following statement on the Log4J security page (https://logging.apache.org/security.html#reporting): ![image](https://github.com/apache/logging-log4j2/

Re: [I] PatternLayout unsuitable for production purposes (logging-log4j2)

2024-04-25 Thread via GitHub
ppkarwasz commented on issue #2518: URL: https://github.com/apache/logging-log4j2/issues/2518#issuecomment-2077155374 Hi @marcelhoelscher, Sure, we should probably change the wording on the security page: * `PatternLayout` **can** be use in production, * but `PatternLayout`

Re: [I] JsonTemplateLayout: java.lang.OutOfMemoryError: Java heap space java.lang.OutOfMemoryError: Java heap space (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on issue #2516: URL: https://github.com/apache/logging-log4j2/issues/2516#issuecomment-2077170486 @PassiveIncomeMachine, could you share the following information too, please? 1. A complete stack trace (pointing to some line numbers in the `org.apache.logging.log4j` pack

Re: [PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on code in PR #2515: URL: https://github.com/apache/logging-log4j2/pull/2515#discussion_r1579473335 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusData.java: ## @@ -167,9 +167,9 @@ public Throwable getThrowable() { @SuppressWarnings("DefaultCh

Re: [PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on code in PR #2515: URL: https://github.com/apache/logging-log4j2/pull/2515#discussion_r1579473335 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusData.java: ## @@ -167,9 +167,9 @@ public Throwable getThrowable() { @SuppressWarnings("DefaultCh

Re: [PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on code in PR #2515: URL: https://github.com/apache/logging-log4j2/pull/2515#discussion_r1579481610 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusData.java: ## @@ -167,9 +167,9 @@ public Throwable getThrowable() { @SuppressWarnings("DefaultCh

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579538084 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## Review Comment: Can you explain how the thread-local toggling property is taken into ac

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
ppkarwasz commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579566800 ## src/site/antora/modules/ROOT/pages/manual/json-template-layout.adoc: ## @@ -1085,7 +1085,7 @@ Resolves `logEvent.getMessage().getParameters()`. Regarding g

Re: [PR] Fix handling of `log4j2.messageFactory` and `log4j2.flowMessageFactory` properties (logging-log4j2)

2024-04-25 Thread via GitHub
vy merged PR #2505: URL: https://github.com/apache/logging-log4j2/pull/2505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [I] The `log4j2.messageFactory` property is ignored since 2.23.0 (logging-log4j2)

2024-04-25 Thread via GitHub
vy closed issue #2379: The `log4j2.messageFactory` property is ignored since 2.23.0 URL: https://github.com/apache/logging-log4j2/issues/2379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[I] Create a `Development` page (logging-log4j2)

2024-04-25 Thread via GitHub
vy opened a new issue, #2520: URL: https://github.com/apache/logging-log4j2/issues/2520 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), create a _"Development"_ page such that - Outline: - Source r

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579657933 ## src/site/antora/modules/ROOT/pages/manual/json-template-layout.adoc: ## @@ -1085,7 +1085,7 @@ Resolves `logEvent.getMessage().getParameters()`. Regarding garbage

[I] Revamp the `Architecture` page (logging-log4j2)

2024-04-25 Thread via GitHub
vy opened a new issue, #2521: URL: https://github.com/apache/logging-log4j2/issues/2521 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), revamp the `Development` page such that - Improve content, formatt

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
ppkarwasz commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579671128 ## log4j-api/src/main/java/org/apache/logging/log4j/util/Constants.java: ## @@ -16,31 +16,56 @@ */ package org.apache.logging.log4j.util; +import org.apac

Re: [I] log4j-slf4j[2]-impl: Misleading and unclear names/descriptions (logging-log4j2)

2024-04-25 Thread via GitHub
vy closed issue #1462: log4j-slf4j[2]-impl: Misleading and unclear names/descriptions URL: https://github.com/apache/logging-log4j2/issues/1462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] log4j-slf4j[2]-impl: Misleading and unclear names/descriptions (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on issue #1462: URL: https://github.com/apache/logging-log4j2/issues/1462#issuecomment-2077584998 Fixed in f37af11c0f5bab4264665230f0d9a7e2d46b8bdc (`2.x`) and 935231cdbd79c59de9b1e63b256c2c3786c646cb (`main`). -- This is an automated message from the Apache Git Service. To

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
ppkarwasz commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579825873 ## src/site/antora/modules/ROOT/pages/manual/json-template-layout.adoc: ## @@ -1085,7 +1085,7 @@ Resolves `logEvent.getMessage().getParameters()`. Regarding g

[I] Logger precision formats in PatternLayout do not match documentation (logging-log4j2)

2024-04-25 Thread via GitHub
jvz opened a new issue, #2522: URL: https://github.com/apache/logging-log4j2/issues/2522 ## Description In the docs at https://logging.apache.org/log4j/2.x/manual/layouts.html#patterns it gives an example pattern `%c{1.2.*}` that should transform something like `org.apache.commons.t

[I] Delay/pause/crash in LogManager::shutdown() [logging-log4cxx]

2024-04-25 Thread via GitHub
hordi opened a new issue, #373: URL: https://github.com/apache/logging-log4cxx/issues/373 Can't provide any simple app to reproduce the issue, but getting it frequently enough in production multi-thread code during LogManager::shutdown() call before main.cpp exit (nothing is running at thi

Re: [I] Consider removing accessors from `MDC <-> ThreadContext` bridges (logging-log4j2)

2024-04-25 Thread via GitHub
jvz commented on issue #2499: URL: https://github.com/apache/logging-log4j2/issues/2499#issuecomment-2078002975 This is a solid proposal I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Delay/pause/crash in LogManager::shutdown() [logging-log4cxx]

2024-04-25 Thread via GitHub
rm5248 commented on issue #373: URL: https://github.com/apache/logging-log4cxx/issues/373#issuecomment-2078328839 It sounds like your other threads are not being shutdown before the main thread is exiting. That does lead to undefined behavior. The only safe way to exit is to stop al

Re: [PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on code in PR #2515: URL: https://github.com/apache/logging-log4j2/pull/2515#discussion_r1580526446 ## src/changelog/.2.x.x/2515_datetimeformatter_formatto.xml: ## @@ -0,0 +1,8 @@ + +http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.o

Re: [PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-25 Thread via GitHub
vy merged PR #2515: URL: https://github.com/apache/logging-log4j2/pull/2515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on PR #2515: URL: https://github.com/apache/logging-log4j2/pull/2515#issuecomment-2078705571 @michaelbraun, thanks so much! :bow: Please keep these contributions coming! :pray: -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[PR] Make statistics on the AsyncAppender's queue length available [logging-log4cxx]

2024-04-25 Thread via GitHub
swebb2066 opened a new pull request, #374: URL: https://github.com/apache/logging-log4cxx/pull/374 This PR addresses the user's problem of determining whether the application produces logging events faster than the background thread is able to process. -- This is an automated message from

Re: [I] Consider removing accessors from `MDC <-> ThreadContext` bridges (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on issue #2499: URL: https://github.com/apache/logging-log4j2/issues/2499#issuecomment-2078730673 _[I am not much familiar with the part of the code base you are talking about, hence apologies in advance if I say something stupid.]_ > will prevent the propagation of `MDC

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-26 Thread via GitHub
vy commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1580556072 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## Review Comment: Giving it a second thought, I think I pointed you in the wrong directio

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1580844634 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## Review Comment: On the contrary: you pointed out a valid concern. After l

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-26 Thread via GitHub
vy commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1580860904 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## Review Comment: > https://github.com/apache/logging-log4j2/blob/cc876ae7c629b698b92414

Re: [PR] Bump github/codeql-action from 3.25.1 to 3.25.3 [logging-parent]

2024-04-26 Thread via GitHub
github-actions[bot] merged PR #168: URL: https://github.com/apache/logging-parent/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Bump actions/checkout from 4.1.3 to 4.1.4 [logging-parent]

2024-04-26 Thread via GitHub
github-actions[bot] merged PR #167: URL: https://github.com/apache/logging-parent/pull/167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Temporary MacOS fixup [logging-parent]

2024-04-26 Thread via GitHub
ppkarwasz opened a new pull request, #169: URL: https://github.com/apache/logging-parent/pull/169 This branch contains temporary fix-ups for MacOS runners and is used by the `logging-log4j2` builds. We should follow actions/setup-java#625 to see what the definitive solution will be.

[I] Revamp the `Configuration` page (logging-log4j2)

2024-04-26 Thread via GitHub
vy opened a new issue, #2525: URL: https://github.com/apache/logging-log4j2/issues/2525 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), revamp the _"Configuration"_ page such that - Outline: - Supp

[I] Revamp the `Lookups` page (logging-log4j2)

2024-04-26 Thread via GitHub
vy opened a new issue, #2526: URL: https://github.com/apache/logging-log4j2/issues/2526 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), revampt the _"Development"_ page such that - Outline: - What

[I] Revamp the `Layouts` page (logging-log4j2)

2024-04-26 Thread via GitHub
vy opened a new issue, #2527: URL: https://github.com/apache/logging-log4j2/issues/2527 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), create a _"Layouts"_ page such that - Outline: - What is a la

Re: [PR] Temporary MacOS fixup [logging-parent]

2024-04-26 Thread via GitHub
ppkarwasz commented on PR #169: URL: https://github.com/apache/logging-parent/pull/169#issuecomment-2079295172 It seems that switching from Temurin to Zulu is enough for now. Zulu is not cached on the runners, so let us wait to see how the environment of macOS 14 runners will evolve.

[I] Revamp the `Appenders` page (logging-log4j2)

2024-04-26 Thread via GitHub
vy opened a new issue, #2528: URL: https://github.com/apache/logging-log4j2/issues/2528 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), revamp the `Appenders` page such that - Outline: - What is an

[I] Revamp the `Filters` page (logging-log4j2)

2024-04-26 Thread via GitHub
vy opened a new issue, #2529: URL: https://github.com/apache/logging-log4j2/issues/2529 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), revamp the `Filters` page such that - Outline: - What is a fi

[I] Create a `Troubleshooting` page (logging-log4j2)

2024-04-26 Thread via GitHub
vy opened a new issue, #2532: URL: https://github.com/apache/logging-log4j2/issues/2532 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), create a `Troubleshooting` page such that - Outline: - Common

Re: [I] Consider removing accessors from `MDC <-> ThreadContext` bridges (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on issue #2499: URL: https://github.com/apache/logging-log4j2/issues/2499#issuecomment-2079311501 > @ppkarwasz, this is the core problem this problem is attacking to, right? That is, avoiding redundant propagation when a particular bridge is in play. Yes, my main

Re: [I] log4j-api: Incomplete/unclear description (simple implementation) (logging-log4j2)

2024-04-26 Thread via GitHub
vy closed issue #1474: log4j-api: Incomplete/unclear description (simple implementation) URL: https://github.com/apache/logging-log4j2/issues/1474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-26 Thread via GitHub
vy closed issue #1475: log4j-core: Name/description not so clear URL: https://github.com/apache/logging-log4j2/issues/1475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-26 Thread via GitHub
vy commented on issue #1475: URL: https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2079463963 Thanks for the heads up @Chealer! :bow: Please keep these feedback coming! :100: I have improved the artifact description in f4da84f8004519bbe43a8ecf7655d735a13fcbe1. We will furt

Re: [PR] Fix MacOS build (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz merged PR #2524: URL: https://github.com/apache/logging-log4j2/pull/2524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-2 to 1.5.6-3 (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on PR #2501: URL: https://github.com/apache/logging-log4j2/pull/2501#issuecomment-2079495197 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.13 to 1.14.14 (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on PR #2503: URL: https://github.com/apache/logging-log4j2/pull/2503#issuecomment-2079495522 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.13 to 1.14.14 (logging-log4j2)

2024-04-26 Thread via GitHub
github-actions[bot] merged PR #2503: URL: https://github.com/apache/logging-log4j2/pull/2503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-2 to 1.5.6-3 (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on PR #2501: URL: https://github.com/apache/logging-log4j2/pull/2501#issuecomment-2079682423 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-2 to 1.5.6-3 (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on PR #2501: URL: https://github.com/apache/logging-log4j2/pull/2501#issuecomment-2079689715 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Consider removing accessors from `MDC <-> ThreadContext` bridges (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on issue #2499: URL: https://github.com/apache/logging-log4j2/issues/2499#issuecomment-2079800141 @rgoers, The problem this tries to solve is to prevent context propagators from copying both `MDC#getCopyOfContextMap()` and `ThreadContext#getImmutableMapOrNull()`

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-2 to 1.5.6-3 (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on PR #2501: URL: https://github.com/apache/logging-log4j2/pull/2501#issuecomment-2079972323 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Deprecate `log4j2.defaultStatusLevel` property (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz merged PR #2481: URL: https://github.com/apache/logging-log4j2/pull/2481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz merged PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] log4j-api: Incomplete/unclear description (simple implementation) (logging-log4j2)

2024-04-26 Thread via GitHub
Chealer commented on issue #1474: URL: https://github.com/apache/logging-log4j2/issues/1474#issuecomment-2080305252 Thanks to you @vy I commented the change and would suggest a small tuning: > This package contains 2 components of the Apache Log4j project's API, through which app

Re: [PR] Add links to Logging Services support, security and download pages [logging-log4cxx]

2024-04-26 Thread via GitHub
swebb2066 merged PR #372: URL: https://github.com/apache/logging-log4cxx/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [I] (doc) Clarify the usage of parameterized logging in `Log4j 2 API` page (logging-log4j2)

2024-04-26 Thread via GitHub
Chealer commented on issue #1918: URL: https://github.com/apache/logging-log4j2/issues/1918#issuecomment-2080326340 > * parameterized logging and string concatenation should **not** be mixed, e.g.: > // This is discouraged, but fine: > logger.info("Hello " + name + "!"

Re: [PR] Make statistics on the AsyncAppender's queue length available [logging-log4cxx]

2024-04-26 Thread via GitHub
swebb2066 merged PR #374: URL: https://github.com/apache/logging-log4cxx/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-27 Thread via GitHub
Chealer commented on issue #1475: URL: https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2080597175 @rgoers this was not just about the name, but you are right about the name. My suggestion was wrong. The name should either be left alone or removed. I suggest to seriously c

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-27 Thread via GitHub
Chealer commented on issue #1475: URL: https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2080655652 My pleasure @vy, thank you very much for this great improvement. Here is a suggestion based on your version: > This package contains the core of the Log4j API's referen

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-27 Thread via GitHub
Chealer commented on issue #1475: URL: https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2080701907 @rgoers I am sorry for replying so late. Thank you for your reply. > As such, I don't really see anything wrong with its name. Calling it the "implementation core" is m

Re: [I] Delay/pause/crash in LogManager::shutdown() [logging-log4cxx]

2024-04-27 Thread via GitHub
hordi commented on issue #373: URL: https://github.com/apache/logging-log4cxx/issues/373#issuecomment-2080848928 Yes, I have one more running thread which I can't turn off, that is intel-TBB thread that I can't control (no API provided to completely shutdown TBB, but no active work there d

Re: [I] log4j-slf4j[2]-impl: Misleading and unclear names/descriptions (logging-log4j2)

2024-04-27 Thread via GitHub
Chealer commented on issue #1462: URL: https://github.com/apache/logging-log4j2/issues/1462#issuecomment-2080890583 Thank you @ppkarwasz and @vy The revised names and descriptions and much less misleading and clearer. I suggested tweakings to descriptions via comments in d7917eb.

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-27 Thread via GitHub
ppkarwasz commented on issue #1475: URL: https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2081116610 > I cannot make sense of the name "core" if it isn't for these extensions. I guess the fundamental problem here is that the meaning of "core" is not documented anywhere.

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-27 Thread via GitHub
Chealer commented on issue #1475: URL: https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2081189175 Thank you very much for all this information as well as for starting that most interesting, albeit unfortunate thread @ppkarwasz . It's a shame if renaming the artifact ident

[PR] Add a simple termination test using AsyncAppender [logging-log4cxx]

2024-04-27 Thread via GitHub
swebb2066 opened a new pull request, #375: URL: https://github.com/apache/logging-log4cxx/pull/375 This PR adds a test (initially failing on Windows) that uses AsyncAppender -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] AsyncAppender's queue length not being output on Windows [logging-log4cxx]

2024-04-27 Thread via GitHub
swebb2066 opened a new pull request, #376: URL: https://github.com/apache/logging-log4cxx/pull/376 This PR ensures AsyncAppender::close is called before Windows terminates the AsyncAppender::dispatch thread -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] Improve AsyncAppender throughput [logging-log4cxx]

2024-04-27 Thread via GitHub
swebb2066 opened a new pull request, #377: URL: https://github.com/apache/logging-log4cxx/pull/377 This PR enables a higher rate at which logging events to be sent through AsyncAppender by avoiding some lock contention inside the `bufferNotEmpty` [std::condition_variable](https://en.cpprefe

Re: [I] Consider removing accessors from `MDC <-> ThreadContext` bridges (logging-log4j2)

2024-04-28 Thread via GitHub
rgoers commented on issue #2499: URL: https://github.com/apache/logging-log4j2/issues/2499#issuecomment-2081687573 @ppkarwasz Thanks for that. That definitely sounds like something should be done to address it. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Add a simple termination test using AsyncAppender [logging-log4cxx]

2024-04-28 Thread via GitHub
swebb2066 merged PR #375: URL: https://github.com/apache/logging-log4cxx/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] AsyncAppender's queue length not being output on Windows [logging-log4cxx]

2024-04-28 Thread via GitHub
swebb2066 merged PR #376: URL: https://github.com/apache/logging-log4cxx/pull/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-29 Thread via GitHub
vy commented on issue #1475: URL: https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2082010667 `pom.xml` description is not intended to be a fully-fledged documentation, but a high-level overview. I think we strike a good balance in being-short-yet-still-informative, thanks

Re: [I] log4j-api: Incomplete/unclear description (simple implementation) (logging-log4j2)

2024-04-29 Thread via GitHub
vy commented on issue #1474: URL: https://github.com/apache/logging-log4j2/issues/1474#issuecomment-2082011970 [I think the current state is good enough. We better spend our effort elsewhere.](https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2082010667) -- This is an aut

Re: [I] Uniform handling of location and URIs (logging-log4j2)

2024-04-29 Thread via GitHub
vy commented on issue #2537: URL: https://github.com/apache/logging-log4j2/issues/2537#issuecomment-2082022824 I wrote JTLs `Uris` class you mentioned before JTL became a part of the Log4j. Hence, I can totally relate to the absence of this resource loading mechanism and I fully support th

Re: [PR] Bump org.xmlunit:xmlunit-assertj3 from 2.9.1 to 2.10.0 [logging-log4j-tools]

2024-04-29 Thread via GitHub
github-actions[bot] merged PR #116: URL: https://github.com/apache/logging-log4j-tools/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-2 to 1.5.6-3 (logging-log4j2)

2024-04-29 Thread via GitHub
ppkarwasz commented on PR #2501: URL: https://github.com/apache/logging-log4j2/pull/2501#issuecomment-2082303908 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-2 to 1.5.6-3 (logging-log4j2)

2024-04-29 Thread via GitHub
ppkarwasz commented on PR #2501: URL: https://github.com/apache/logging-log4j2/pull/2501#issuecomment-2082322971 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 (logging-log4j2)

2024-04-29 Thread via GitHub
ppkarwasz commented on PR #2543: URL: https://github.com/apache/logging-log4j2/pull/2543#issuecomment-2082326019 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump xmlunit.version from 2.9.1 to 2.10.0 (logging-log4j2)

2024-04-29 Thread via GitHub
ppkarwasz commented on PR #2546: URL: https://github.com/apache/logging-log4j2/pull/2546#issuecomment-2082328096 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump com.google.errorprone:error_prone_core from 2.26.1 to 2.27.0 [logging-parent]

2024-04-29 Thread via GitHub
github-actions[bot] merged PR #170: URL: https://github.com/apache/logging-parent/pull/170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Bump com.palantir.javaformat:palantir-java-format from 2.43.0 to 2.44.0 [logging-parent]

2024-04-29 Thread via GitHub
github-actions[bot] merged PR #171: URL: https://github.com/apache/logging-parent/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-2 to 1.5.6-3 (logging-log4j2)

2024-04-29 Thread via GitHub
github-actions[bot] merged PR #2501: URL: https://github.com/apache/logging-log4j2/pull/2501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump xmlunit.version from 2.9.1 to 2.10.0 (logging-log4j2)

2024-04-29 Thread via GitHub
ppkarwasz commented on PR #2546: URL: https://github.com/apache/logging-log4j2/pull/2546#issuecomment-2082413918 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-29 Thread via GitHub
Chealer commented on issue #1475: URL: https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2082450700 Of course @vy The above was not saying that documentation should be in `pom.xml`. It can be documented in there, but for sure it is more important to document on the webs

Re: [PR] Bump xmlunit.version from 2.9.1 to 2.10.0 (logging-log4j2)

2024-04-29 Thread via GitHub
github-actions[bot] merged PR #2546: URL: https://github.com/apache/logging-log4j2/pull/2546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Improve APRInitiializer interface in next ABI version [logging-log4cxx]

2024-04-29 Thread via GitHub
rm5248 commented on code in PR #378: URL: https://github.com/apache/logging-log4cxx/pull/378#discussion_r1582969318 ## src/main/include/log4cxx/helpers/aprinitializer.h: ## @@ -44,7 +44,11 @@ class FileWatchdog; class APRInitializer { public: +#if LOG4CXX_ABI_VERSION <

[I] Revamp the `Web Applications` page (logging-log4j2)

2024-04-29 Thread via GitHub
vy opened a new issue, #2547: URL: https://github.com/apache/logging-log4j2/issues/2547 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), revamp `webapp.adoc` such that - Link to the Log4j Jakarta project

Re: [PR] Bump xmlunit.version from 2.9.1 to 2.10.0 (logging-log4j2)

2024-04-29 Thread via GitHub
github-actions[bot] merged PR #2545: URL: https://github.com/apache/logging-log4j2/pull/2545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 [logging-log4j-audit]

2024-04-29 Thread via GitHub
dependabot[bot] opened a new pull request, #141: URL: https://github.com/apache/logging-log4j-audit/pull/141 Bumps [commons-codec:commons-codec](https://github.com/apache/commons-codec) from 1.16.1 to 1.17.0. Changelog Sourced from https://github.com/apache/commons-codec/blob/maste

Re: [PR] Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 (logging-log4j2)

2024-04-29 Thread via GitHub
github-actions[bot] merged PR #2544: URL: https://github.com/apache/logging-log4j2/pull/2544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 (logging-log4j2)

2024-04-29 Thread via GitHub
github-actions[bot] merged PR #2543: URL: https://github.com/apache/logging-log4j2/pull/2543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Improve APRInitiializer interface in next ABI version [logging-log4cxx]

2024-04-29 Thread via GitHub
swebb2066 commented on code in PR #378: URL: https://github.com/apache/logging-log4cxx/pull/378#discussion_r1583995009 ## src/main/include/log4cxx/helpers/aprinitializer.h: ## @@ -44,7 +44,11 @@ class FileWatchdog; class APRInitializer { public: +#if LOG4CXX_ABI_VERSIO

Re: [PR] Improve AsyncAppender throughput [logging-log4cxx]

2024-04-29 Thread via GitHub
swebb2066 merged PR #377: URL: https://github.com/apache/logging-log4cxx/pull/377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

[PR] Remove duplicated and outdated information from README [logging-log4cxx]

2024-04-29 Thread via GitHub
swebb2066 opened a new pull request, #379: URL: https://github.com/apache/logging-log4cxx/pull/379 This PR aims to make the Log4cxx README similar to the Log4j2 readme. Note: The mailing list link was broken. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Revamp the F.A.Q. page (logging-log4j2)

2024-04-30 Thread via GitHub
vy commented on code in PR #2549: URL: https://github.com/apache/logging-log4j2/pull/2549#discussion_r1584368021 ## src/site/antora/modules/ROOT/pages/faq.adoc: ## @@ -17,404 +17,196 @@ Licensed to the Apache Software Foundation (ASF) under one or more = F.A.Q. -[#missing_

Re: [PR] Revamp the F.A.Q. page (logging-log4j2)

2024-04-30 Thread via GitHub
vy commented on code in PR #2549: URL: https://github.com/apache/logging-log4j2/pull/2549#discussion_r1584370858 ## src/site/antora/modules/ROOT/pages/faq.adoc: ## @@ -17,404 +17,196 @@ Licensed to the Apache Software Foundation (ASF) under one or more = F.A.Q. -[#missing_

Re: [PR] Revamp the F.A.Q. page (logging-log4j2)

2024-04-30 Thread via GitHub
vy commented on code in PR #2549: URL: https://github.com/apache/logging-log4j2/pull/2549#discussion_r1584375958 ## src/site/antora/modules/ROOT/pages/faq.adoc: ## @@ -17,404 +17,196 @@ Licensed to the Apache Software Foundation (ASF) under one or more = F.A.Q. -[#missing_

Re: [PR] Revamp the F.A.Q. page (logging-log4j2)

2024-04-30 Thread via GitHub
ppkarwasz commented on code in PR #2549: URL: https://github.com/apache/logging-log4j2/pull/2549#discussion_r1584392817 ## src/site/antora/modules/ROOT/pages/faq.adoc: ## @@ -17,404 +17,196 @@ Licensed to the Apache Software Foundation (ASF) under one or more = F.A.Q. -[#m

Re: [PR] Revamp the F.A.Q. page (logging-log4j2)

2024-04-30 Thread via GitHub
ppkarwasz commented on code in PR #2549: URL: https://github.com/apache/logging-log4j2/pull/2549#discussion_r1584397221 ## src/site/antora/modules/ROOT/pages/faq.adoc: ## @@ -17,404 +17,196 @@ Licensed to the Apache Software Foundation (ASF) under one or more = F.A.Q. -[#m

Re: [PR] Revamp the F.A.Q. page (logging-log4j2)

2024-04-30 Thread via GitHub
vy commented on code in PR #2549: URL: https://github.com/apache/logging-log4j2/pull/2549#discussion_r1584415137 ## src/site/antora/modules/ROOT/pages/faq.adoc: ## @@ -17,404 +17,196 @@ Licensed to the Apache Software Foundation (ASF) under one or more = F.A.Q. -[#missing_

Re: [PR] Revamp the F.A.Q. page (logging-log4j2)

2024-04-30 Thread via GitHub
vy commented on code in PR #2549: URL: https://github.com/apache/logging-log4j2/pull/2549#discussion_r1584427357 ## src/site/antora/modules/ROOT/pages/faq.adoc: ## @@ -17,404 +17,196 @@ Licensed to the Apache Software Foundation (ASF) under one or more = F.A.Q. -[#missing_

<    6   7   8   9   10   11   12   13   14   15   >